From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9C2645CF3; Tue, 12 Nov 2024 10:36:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99FCF402C3; Tue, 12 Nov 2024 10:36:01 +0100 (CET) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8E80040298 for ; Tue, 12 Nov 2024 10:35:59 +0100 (CET) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AC8PBoL006755; Tue, 12 Nov 2024 01:35:54 -0800 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2172.outbound.protection.outlook.com [104.47.73.172]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 42uh2ta1eb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Nov 2024 01:35:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w/3J21JxW/KubZgVL3MX2b3kj3aPDmYXHHatduu1D0NEy+CgbZYQHTlnt5Zx5FRkwyuKi6p3mM8aIBv3yIaQ/TIpEaa7/18q9TrLX6D0mSPueXpTe0gwzLqVr2HdFrcCr27sSl1GTZiq8CQuttby8EHAIyCi3CrOr1O8CZUCF4A1nItNPC1f0cY6zM7mrUalqQGjhCm9PpM8LXzUC1M34vri+L18jQMbs5Ux2ak6FtZHqzMWMlqqFV42qdKDxLzQb2M0bDkANgTzGPiojQ8f2QKPQpVezXdd5r9R5D3OO4qWMAOKJqOE6NBQTyc+5M7mOf8NLakmjh1ac7ObSyS5DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OI8Mppr8UiGHZIb/KwxAXHZbQ8t758HEcP4JYWeceU0=; b=pxSc9NH+duy1SpVxRed5EbEIU4Ehr7Pu7pf8wXpSE80Fmf/q+9J13r5Zczjy1iiIH79zdc1tlmmi53fPwrYgdFYaSa/Pv40LBvNHZu1hHx3GvhoUHjI9Ur3HBdrlC8+MgXxSK67eTzXy8q3eoSeVcRQ3TFvEm0SXgY58zjNAFd8wZvlZTbFVtBZ2ItlKM5rAH6nKWBnf0VoGKL15O3DvYjg81BZJ/HPVQpaMMdF1sFjMmVt52wBJ/fY/Ejq1FHKov+OPwejX0pdAGE5lpHekum2EI1gMK7DsMkQyJySLlKSH2W4Hi7m9m7zBQ6VI3OUvJQFi/Ooc8K7ngt8fSo9TVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OI8Mppr8UiGHZIb/KwxAXHZbQ8t758HEcP4JYWeceU0=; b=SXvJN5Kk4MokHOcQauB+KQHnV2iQ3K18KwN3AsNMKi0V2j7trHCfC+7GJDd6jaYQkhWk68I5OlFUJGDWrDWmJf/RGHTsEUKM8lD/anct5bl2M79U3b5twToPw1T4sbjVUXuOKxOWfcWic8tKZGfIV/GUcNhCD20PX8F/xrLjQYs= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by LV8PR18MB6177.namprd18.prod.outlook.com (2603:10b6:408:262::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 09:35:52 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.013; Tue, 12 Nov 2024 09:35:52 +0000 From: Jerin Jacob To: David Marchand , Huichao Cai CC: Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" , "dev@dpdk.org" , Thomas Monjalon , Robin Jarry Subject: RE: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes Thread-Topic: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes Thread-Index: AQHbMOvAG7PZCWtVIUGc8aK0tW06jLKrjYzAgAEOywCAAH+NYIAASTcAgAQwm6CAAch3AIAACuug Date: Tue, 12 Nov 2024 09:35:52 +0000 Message-ID: References: <1730966682-2632-1-git-send-email-chcchc88@163.com> <44cd588c.1867.193096d6e2b.Coremail.chcchc88@163.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-Mentions: chcchc88@163.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|LV8PR18MB6177:EE_ x-ms-office365-filtering-correlation-id: a8bb2a8d-c9ae-40e4-afe9-08dd02fd6634 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?NlROMXVsL3cwamFraDZGazdzK0xmSWpscEV2TG1uRnFYKys0NGxKVjNxL3k3?= =?utf-8?B?ZytXL2NRT2VHOVB6aXJYeXRGQytSakhHd2F3clIvQmZFT2Ixck9TRHFFdnQr?= =?utf-8?B?SWZSTnFmb2FmK3BGVFd2YnNnbXhJTFMydytKUHlCcytmQms4N0wvM0dXVXp0?= =?utf-8?B?Q2RFanhFS2pJUGJRdWtIc3ZjTVluZlY4M003NkMzMWNKZmgxTm82cGlhY3l1?= =?utf-8?B?SkQ0YlB6aGNaNWpCVVRzWW8vcFlETm1MeXVvVEliY2JwWW0rM1FRZHlrRWJo?= =?utf-8?B?c2JMamw1aGhFbnYwbXY3VTZxREdQYlZBcWpiZ3ovLzVzMlZmMkkvQ1hIQ2U1?= =?utf-8?B?VnhKcjZOTUpvQm9YSzAvMTVPQTg4Yk1pVWJqYkR6elRWdHQrL256b2dKd3N6?= =?utf-8?B?RXFJRWtUYjd1Y0V3cklLQ0N5emx2OC9IbldPRTFkVVA1Zi9SSzdyZkQzTi9E?= =?utf-8?B?bmNaWWY0dU5OVDRUUTBPSU9XRDROUkZFaW44NkdLamQ0aFZGSm5YMHVnNkNI?= =?utf-8?B?OHQrdkViOUpqOW9RdlB6ODI2WS9PK0N0amlWaHd0QWhJZlJSZmtCVUpGYUNJ?= =?utf-8?B?RjB1RmhsOWlmY2xqOWdMQzMrSHRBZjA4TEpta3A0QkpyYitHc0Jrak9RTEVt?= =?utf-8?B?ekpaTEgrRGJzcERrczJHZG9kZW92NEcyamw0dDQ3UnpHQUZhM3lUV2Z0UEZn?= =?utf-8?B?V2dUK1JpaUg2bDN6M25tUzNFcnpUKytwR3pLU0E0QmVrWWdiZG5nanlMRDkv?= =?utf-8?B?V1hHS2ozMWErUFYxa0IxZldwV3ZtcEZTMjRGNmF1cVdoS0w3dkZEa1NOVVZ4?= =?utf-8?B?WnRjUCtpVzJaWHlyYzN6TnVmWU5ERkU1OVRvYVhCcGZXSGtLVHdZb1QxRDJx?= =?utf-8?B?VDU5c25kWmFyVis2d21SWmtTNVc4MUJZdDY5YjdBMTJueXJzM00xU3NZQWRo?= =?utf-8?B?QWsybGNveG52K1Nwb1ZrY1B0b2lTMXlQMFI5N09pSFhubVNnRTZlWTJLbWFh?= =?utf-8?B?ZkdFMnQvMUlGRzhNMTBkOS9jZ3BydzN5NDg2Y2RTMFVqTlMwWC9kc0Q5bldi?= =?utf-8?B?d2wwVjJheWRBaGoxVnNVT25ycEF1YnZFTEE4aHNaajJCV0dFNldORnJuTlRL?= =?utf-8?B?ZmV5WmZEYXlmTW92TnpRK3VMUDE4SDFjbHhqT1R4b3hlRXV0VGxQU0REN252?= =?utf-8?B?ZnFmbjRsMG4yN3pqa3RGL1hCbkovS0p2SlNDNGptdXJxM2RWazN2NHZjaUlP?= =?utf-8?B?SFZPaWR0elhXeFVwWTBPUld4eWpsWTB1WEdWNFNldkxiaDFvS3k2aGlpaHpP?= =?utf-8?B?ZURrR3NaSEFEa2U0ZG52M05BVUMzSXFjTXA0ZndxckFsRHdiZVNZS1BCckRV?= =?utf-8?B?dkQyblRpZkEwVDNobzBqTkhDSUVOZmRBMm5HSU1LRzNKb2puTmJIYW1CdmZ1?= =?utf-8?B?RU05dVpGa2F1ZStJSkM5NFFzYnBYM2pZaExNdTBBQUpPRG1VdFlIRWNaMzhS?= =?utf-8?B?aUtFYnEvOUxHNGNJRzg2empJYjBnbDNyZTJwNjFwMFVqS0dqQnNtblE3aUlh?= =?utf-8?B?WXFtQ1l4QTUrK2QrMXVGLzBWLzBUNnMvUmFYSW94blhqTGRBZDZWRGpIaUtt?= =?utf-8?B?QzcwMmdJWUh3blRKVm93MDhXTmFFWWJhV2JUYlEyd2xkQjI3TjV6N0ZNS3di?= =?utf-8?B?N1FremNzRG5SVVVwOXVSM05naEkzKzdDc0RZdTRVMkNXNUIzWmhkVmVBcGRk?= =?utf-8?Q?/L8NPPzIJR+dM9uZIPRMwMZqE4LH0BVch+zxyNm?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TG03M05rdklsOEluaHdSYS9kdUhHWWtxby9aYXhMK3R6ZEpSeTl3ZExoc1hZ?= =?utf-8?B?UXRpV05nZEpwT1dEVjU2c21WTVlXYjhPMENERG5CNmZVbFRKcUkwMmRTTWVi?= =?utf-8?B?NmZWUVhVNjZBcjd5YXArQVdxMHB1M29TYWlVNjZVYmdqa21DNW1jejJVbFUv?= =?utf-8?B?a3N4NWJrVk1scU1oL05DUUN4NHlhR0Yzd0R1c2VhdjhhaWJXaDgzYVdqUXBG?= =?utf-8?B?algvZnpURG4zRDArck1ZM0tYdEg5bkVXQkJVYzZ6aXBTWjJydWJneTlRbHdo?= =?utf-8?B?TVowdnM0MVR0bHpWZXFhRmZwWklTL2NKckt4b2wxeXNkd0NHV2tmMitndDNV?= =?utf-8?B?N1BsdE9jbGh0TE9sM0dSOXJCMUJHVitEem5CYVF6bXV5S2xSY3AzS2EyWXNp?= =?utf-8?B?WnJSOU5TWXpYZ2NQTjVZdVpweWtVcjJ4QTc5enV0YjhGNUlwTEdGWmt4d09k?= =?utf-8?B?Z3RMNS9EUHQ1RHYxYjdZeDlDY2xVT1RaVVJ0WkY0VHdRWWJyQnQ3TEZ1L1BK?= =?utf-8?B?TFU2NmdUYzc5TUpuTlZqTkhjZU9UdEFKSmxMUlN1aDErRlBEbGxNZENEaGZr?= =?utf-8?B?KzZyb3FzRDAyZTNxMXF6RUdPRnBLSG5KRmxRRlpwSUZHdU5SYXhndTh2VWxT?= =?utf-8?B?aUhsQWtoYVMrcnRsZFlhMGlkWklFeHcxY2F6elV5TzFYZ0tCQkxsWktYdXdu?= =?utf-8?B?ZXBMSzA3ZWt0Ym9FUEVLZWxMaVl0VXA3MWIxblU0QWdsNU05VGhud2JuR1J4?= =?utf-8?B?RjA2bnIyRkl5ajNHRUZqcUlvYlNqZTZvTldmaWJtQ00xSUQ5QU9oTkg3SGJP?= =?utf-8?B?V2s5L0VrRmRBcVVSTlBoMTVBUy9PMnl2Vm02S2dwanozZXhMVjQyTjBJUlJx?= =?utf-8?B?VkpwTEZCYnVNampwMVAzQ0hvSVpoT2xIYS9ST0l3d2w4UG9Fbk9BNm9YZ1Vv?= =?utf-8?B?VitSaDlXZkE3Mi9vY3B4Z3RzVlJpazFiTFR2OFBwZ3V0SWJWeEMzbEFNNU90?= =?utf-8?B?c05PcGMvMDEzWTU4eEx1WnBBVkdXcTdteHlxUnM0aTNpdE44UVpRWmltRzJy?= =?utf-8?B?MjR2L01laWx1VFpZc2gzUVg2VWRrbDNXSnBTUlcrOWxVek85L1I3WGlxd0lq?= =?utf-8?B?SUJYVmpEU2R2MzhqeVFvcTJPTGd2dXlTTGxBMmZRdk1xOHRXSzVBTENOd014?= =?utf-8?B?OXg4cUdibWk3Qk54bStsK3JTSUhKdWU4Sk9lWm9EN2dXTFpCNEtpb3VPOVBa?= =?utf-8?B?aE02bTZNOWtyMXRLZ21hNFZiWDNiNmZvTVBtdDdIUkRuMk9JUlRNU09CazRQ?= =?utf-8?B?N1ZPVDNodE0yL3Y0NmNyOU5EeWo3Qm1XSEJVWFZYWUN6MC9XZkJyMzhNSXpR?= =?utf-8?B?QUREOFVHM3VqelJjT0czWTg3SFdBbElzMnIyV3RNZ29wZkw0blJtcmFTTlZS?= =?utf-8?B?MWxFSndtaGpyMllKazIxcjIrNjUyVFgybWJIdkhQZTdTTkNMKzVSOVlKL2pw?= =?utf-8?B?OWVGR1czYWhZZTZPZEFPQzR0aTBJNUFhMHdKUGRxTjhTNk9HMkFSbDQxUTFL?= =?utf-8?B?Ritwd2FrR0x2TklncE1UVkNzcUF1NEVWUzhpTG5LM29LUklIaSthYjI4bzg4?= =?utf-8?B?NXZtWDFycVlQMEdnN2ROTXlJU20rckgzaW5JTE5Ock5veU56azROUGdBVGo4?= =?utf-8?B?SHhaQmhtSHhLSW5wSXhEVkVIKy84VFlyN2V4OVpTK29vWktxbHIzNG9WdDNP?= =?utf-8?B?MTlOcmVuWUlxYmd2WlZCNUI3WmRsU1VqK0krRWlpQjhiU3lIbkwxWTJab3JT?= =?utf-8?B?Um14VGg4cnZhcUk0UE5QTS9LdFZuOU9PYlZkUmNxT3U4QTVVTk5NbnBTRzJI?= =?utf-8?B?WnFmaDlvY3NtVTNZNDZPcFhma1JSOS9ESGVYV1RFeWJZSXlOOHBjY2c0bEFB?= =?utf-8?B?RWJOQlpYTHFaRnoyZlN3QmovVWNYa3ZjUmRtTEtmdWg5M3lDcmRubUtHRy94?= =?utf-8?B?UVVzdEJDSWZNeWE3QWJrd3BLTGxqTFpKS3RGSWZJSmJtN2hZK1JJbXJLdm5Q?= =?utf-8?B?Z29VRnFZS1NybDFUSk45UWEyUWkrU2xBdmc5LzBnUjgxU0FPYkxHUURlRUJE?= =?utf-8?Q?Opq9blWnP2wqh+urvXXrScrsH?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8bb2a8d-c9ae-40e4-afe9-08dd02fd6634 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2024 09:35:52.0911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mk98XrzNGNJOlMFeS1j3+E1BwP+l0O45hT/yxCLPi8RYLsLgoOGcaV2Z1W6I5LqhSBbzF3IpYXNhtHL3dQ5N0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB6177 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: et1lbvapcRzSOK1R0BiDlXKzH7gD3h2c X-Proofpoint-ORIG-GUID: et1lbvapcRzSOK1R0BiDlXKzH7gD3h2c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Tuesday, November 12, 2024 2:21 PM > To: Jerin Jacob > Cc: Huichao Cai ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_163@163.com; dev@dpdk.org; > Thomas Monjalon ; Robin Jarry > Subject: Re: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when > scheduling nodes >=20 > On Mon, Nov 11, 2024 at 6:=E2=80=8A39 AM Jerin Jacob wrote: > > > > > > -----Original Message----- > > From: David Marchand > > > Sent: Friday, = November 8, 2024 7:=E2=80=8A08 >=20 > On Mon, Nov 11, 2024 at 6:39=E2=80=AFAM Jerin Jacob = wrote: > > > > > > > > > -----Original Message----- > > > From: David Marchand > > > Sent: Friday, November 8, 2024 7:08 PM > > > To: Jerin Jacob > > > Cc: Huichao Cai ; Kiran Kumar Kokkilagadda > > > ; Nithin Kumar Dabilpuram > > > ; yanzhirun_163@163.com; dev@dpdk.org; > > > Thomas Monjalon ; Robin Jarry > > > > > > Subject: Re: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search > > > when scheduling nodes > > > > > > Hello Jerin, On Fri, Nov 8, 2024 at 1:=E2=80=8A22 PM Jerin Jacob > > marvell.=E2=80=8Acom> > > > wrote: > > > Is n't breaking the ABI? > > > > So can't we modify the > > > ABI, or is there any special operation required to modify > > Hello > > > Jerin, > > > > Hello David, > > > > > > > > On Fri, Nov 8, 2024 at 1:22=E2=80=AFPM Jerin Jacob wrote: > > > > > > Is n't breaking the ABI? > > > > > > > > > > So can't we modify the ABI, or is there any special operation > > > > > required to modify the ABI? > > > > > > > > Only LTS release (xx.11) can change the ABI after sending deprecati= on > notice. > > > > Looking at the pahole output, one option will be making dispatch > > > > and new semi fastpath Additions like xstat_off can be min cache > > > > aligned to make room for future expansion and to make sure have > > > > better > > > performance. > > > > > > Adding holes may be a short term solution, but in my opinion, the > > > slow path part should be entirely hidden and we only expose the fp pa= rt. > > > > The new cache line alignment items are proposed are fastpath items only. >=20 > I had only noticed the second comment: >=20 > + alignas(RTE_CACHE_LINE_MIN_SIZE) > rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > /* Fast path area */ > ^^^^^^^^^^^^ >=20 > And I assumed the part in the struct before was slow path. > (it may be worth enhancing these comments, with a single limit of slow/fa= st > path areas) Yes. Xstat_off was new addition as a fastpath item in this release and ther= e was no space in original Fastpath area. And, Yes, the comment needs to be updated. >=20 >=20 > > > > > Reminder, those holes must be in a "known state" as we release > > > v24.11 so that the presence of future additions can be safely detecte= d. >=20 > If the rte_node objects are allocated by the graph library and zero'd, th= en we > are good. > It seems to be the case in graph_nodes_populate(), and the rte_node objec= ts > are embedded in the rte_graph object. >=20 > Is there another location in the graph library where a rte_node object is > allocated? No >=20 > If not, and an application can not create a rte_node object, your proposa= l looks > good to me. OK. @Huichao Cai Please send two patches (a) new proposal and (b) your impr= ovement as series. Update ABI Changes section in doc/guides/rel_notes/release_24_11.rst =20 >=20 >=20 > -- > David Marchand