RE: [EXTERNAL] [PATCH v2 2/3] examples/l2fwd-event: fix spinlock handling

[Jerin Jacob <jerinj@marvell.com>]

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Thursday, November 14, 2024 1:15 PM
> To: thomas@monjalon.net; dev@dpdk.org; david.marchand@redhat.com
> Cc: stephen@networkplumber.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; stable@dpdk.org
> Subject: [EXTERNAL] [PATCH v2 2/3] examples/l2fwd-event: fix spinlock
> handling
> 
> Detected by pvs-studio Bug 89-93: very suspicious synchronization The analyzer
> issued a pack of V1020 warnings that a resource might remain blocked. Fixes:
> 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Cc:
> pbhagavatula@ marvell. com 
> Detected by pvs-studio
> Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020
> warnings that a resource might remain blocked.
> 
> Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop")
> Cc: pbhagavatula@marvell.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>


1/3 and 3/3 are  NOT eventdev patches. So I Applied 2/3 to dpdk-next-eventdev/for-main and delegated 1/3 and 3/3 to Thomas.

> ---
>  examples/l2fwd-event/l2fwd_event.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-
> event/l2fwd_event.c
> index 22472027b9..416957384b 100644
> --- a/examples/l2fwd-event/l2fwd_event.c
> +++ b/examples/l2fwd-event/l2fwd_event.c
> @@ -141,6 +141,7 @@ l2fwd_get_free_event_port(struct
> l2fwd_event_resources *evt_rsrc)
>  	rte_spinlock_lock(&evt_rsrc->evp.lock);
>  	if (index >= evt_rsrc->evp.nb_ports) {
>  		printf("No free event port is available\n");
> +		rte_spinlock_unlock(&evt_rsrc->evp.lock);
>  		return -1;
>  	}
> 
> --
> 2.25.1