From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0619E45D35; Mon, 18 Nov 2024 10:32:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FE3940279; Mon, 18 Nov 2024 10:32:43 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E185940263; Mon, 18 Nov 2024 10:32:41 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI0paqJ025651; Mon, 18 Nov 2024 01:32:41 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42xuspjhe0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 01:32:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JWGoxCraaRinsfUycd6x3Bd9ZJxrWcBoDvSM/FMsz38GQfSp/0sg5nuEHBSgKwYzhJC0wU0FKW31ggFoHl2Infl3SUtA7LXQjXL6J4kJ8MhP9icDUcxq7tXHZiGostj1+TS2ZmGFMzL4yw++DiZM6gdKncMuZMcU4Pzo0kpxhhfGmc+hYgHPXlKtOscQS3K9gAevC8sbjVyAhkRSqgSTg+3va/W/Rcd7BCprLvApCqm7AKvHo2BPot7TrN/RhLMJrfWmvMW5XIVHfi6h+gnMF4p4IjdO0c4Bqmtl9VYFuYKocYkWM3ODDs5c9mN+oL9F1zRTxrjVSQXU63bPaYF9LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zDVp3hbSVFxAwKUQTkniX5qxRPJkuGG1CMAwQPB4W2s=; b=fu7tWwVlqNmoCvtfAlfRyYP9byHLLiGj6kpoOwhifKgQrbBLIFMR5JhD/+sDPb8NdlqMQZdcBWG3O2/LmfR0a7Kgi0pjwZcUZbZTf93/0HqsBri/YoRi6OaEpt80ZEPxVnGnhviWlnZUKT2cSMuBragn3Se32S7lVK+ptoFMrydSEEU8LvAPQ3t2Ydgh1uS/8nGIDPFoauKC9rRR3gxrEwlDQEi+kkghwwb18b7QvMX0yveu6DI2ORfgYg2uybyE6MjzKYspHeJAQL+9E5QUyIYcbLGFcimaJHmcWP/DaQgEueC7u2OW15dWSSTxPRmfUv1bRCC1s0jCJUAcPmyYoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zDVp3hbSVFxAwKUQTkniX5qxRPJkuGG1CMAwQPB4W2s=; b=pzKtYW8CGLfykvL3WfFvIgcCcUOWg6I5oaB1cMnbthGxO4m0vJiNWAF7cP+ct7xno+KInXIGBJWOQ5x4HkljLYeVPINVCJwdnm+DIZVcXF7mvP+6hm+p08/iPTpNVs+oXP7VLuU8UsAYZvLglqvF+W8IDl7v6tJePEbVQ9Uenb8= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by DS0PR18MB5429.namprd18.prod.outlook.com (2603:10b6:8:159::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.20; Mon, 18 Nov 2024 09:32:37 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.023; Mon, 18 Nov 2024 09:32:36 +0000 From: Jerin Jacob To: Hemant Agrawal , "thomas@monjalon.net" , "dev@dpdk.org" , "david.marchand@redhat.com" CC: "stephen@networkplumber.org" , Pavan Nikhilesh Bhagavatula , "stable@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v2 2/3] examples/l2fwd-event: fix spinlock handling Thread-Topic: [EXTERNAL] [PATCH v2 2/3] examples/l2fwd-event: fix spinlock handling Thread-Index: AQHbNmkheyKddjrQXk6vEfmZDEZhfLK8xw3g Date: Mon, 18 Nov 2024 09:32:36 +0000 Message-ID: References: <20241113161455.2649551-1-hemant.agrawal@nxp.com> <20241114074437.2943885-1-hemant.agrawal@nxp.com> <20241114074437.2943885-2-hemant.agrawal@nxp.com> In-Reply-To: <20241114074437.2943885-2-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|DS0PR18MB5429:EE_ x-ms-office365-filtering-correlation-id: cdffc88a-c6c6-4b5d-803e-08dd07b3f048 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?dGtvMzZqa1lmUlhsTGJNVm1RRThCaVR6SWxDRTlTQjd2UmwxcW9QbXB1NW5t?= =?utf-8?B?SVQyT1FMOFlyTEIxM0lYaUFraE9ncFNDMlJwRngyc3JnQjBZVUwwdTk0SWNi?= =?utf-8?B?RFhtSTZ3dUc3SjFIbzBUY2dNZ3NuaFcvN00rQjFtL2J4Q3Y0VU9yOU5zUTlt?= =?utf-8?B?RTVnY3VKRGlnY1ZpamtSeW54QUpXM0F3KzkxNGxsdmFKN05JenA4SUdIbU9P?= =?utf-8?B?d3FFU3kyRTJYZnYvSGo0cmxZSjVYbzlxa056eHc5QUx4ZThYNTVBMHJxMnlh?= =?utf-8?B?eEVETTdmLzZRODVjUDR3bGFFbXlwNzRYd3czREQ3YXQ0VGFMU0ZVSjVyblRN?= =?utf-8?B?d3ZBQzJXdUV5R3l1NlphWUJrQWxWN0IyUjRGK2dUb0Ntelh5YkRYQ25NQytz?= =?utf-8?B?RUZ1elhaRy9EWDE2TlNjQ0E0eWVVNitVZUlXeG8rZkpFQVpUY2JWb3BrazNR?= =?utf-8?B?UUF1Z2NWUUYvbVlQaER2K2JxZkZDVHpDbFhZNk5YZmFNNENrMjJqdFdwZVNU?= =?utf-8?B?aVcxT1dycmkrWVlQNS9rTCtUN3dmVll3S3ZYdk5rU29kcUxiTmQ2YWdpSzlr?= =?utf-8?B?Q2JZQ05vTmtnVm1oN0JET0JobzZVMFhXYzlEaG1tbGIxWXpJZTMzN3dxRTdp?= =?utf-8?B?VEhhQWdXVUtzNklLcExGaFdHMnFkUVRYRG9aNmZQeWJTNFBoSjdpejU5VW0v?= =?utf-8?B?WTFnVzRFV1hSS2RuVFdNZkR6ZndSdWErUExyZldnUXNKZ3BCM0lDN1U3ZjJ1?= =?utf-8?B?YXRPUUo1WkgwT2hFSXpqVk5JUlFTZjdvUU5aZXRJbGY3RnBGbmpjOFNyRmE0?= =?utf-8?B?dzFyWWhJTjRKdnlXZzliT0hoeXpOOVBaS2xoY2drcXloY0dsZ0xGSDZJbm8r?= =?utf-8?B?QzhBNndRZzRISUZQMktmS2NOUlMzSjRYV0ROZWprZkMwNTJ1MDUwRENXaFhq?= =?utf-8?B?c2YwbnlZUTNOY3VvRGxmRUpLbGdGUHNJaTM0QzI3eG9uSEtUZGZlcFdCM0hS?= =?utf-8?B?cXpsRk9JR0xHMjhVNE5pRERrOXN6WEVkUUZkUVJrN1EwWVhMQStPa2dXeHlE?= =?utf-8?B?dFJOMGZRcnZ3SFFUa3d3TzNxZ2RjYUtTd1h2Z01lQis2aTZxWG1vLzRHYjYr?= =?utf-8?B?TS80S21kN2gxSC9YUWsycHUyRkJYNm1vZGVFbnlybDN1UGFHMjBFS1BoT0xZ?= =?utf-8?B?V2kxUStlRFZoelJvSWl1VkYwQ2EvOG54SnRYdHpMWS9zSUhHTVVjOGovS3hV?= =?utf-8?B?d292Rmx1TU5jZjhENHhhSmw4SHB4SVZzTGdJbWg0cmdjUkRSU2dLeWhJUkV2?= =?utf-8?B?NzhIaHBPSUhYRHZUR1djUlU5UzJNbXZ5b21ZUmd0M21NQ3RyVWEzMmlwRGkw?= =?utf-8?B?UW9qS2JnNC9hOEkvRE9FcUV3SlVuYnhhRjlJazg5ZGRBSDloNWN1eHdEUUU0?= =?utf-8?B?U2YyWXg4QWZWaEtnekVjRy9vRitpQ0VUblhlZGtJT29UOCt3MTNIYVNlNmZs?= =?utf-8?B?dkZPWTFVYU85bWJYZmpmQlVaeG5yT0VpWUM0OUZ2NEVVU2hVaTV5bUxVcnBJ?= =?utf-8?B?V1drYWk1OE1jVzZBTjBkWHE4NjRtVGlaTTA4aXpMWU1oZFlRdDk0VGo1S0I4?= =?utf-8?B?WEoybWZYMnJmdWZzRWVYV0tGd2JsdmhHdUkxQ3NsWjV3N1g5MjhNOC9aOGZT?= =?utf-8?B?cnBwcFJjeFB3VVcvVGY0M3pnRDFXaG1OMGVubU9FeEhaWWdiaG5GQTJ1cDFC?= =?utf-8?Q?S6wo0J7OeRbCP2XSKcIPLydmXleLCOVCWf/4JsP?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eENIR2R0WDZkSUxTTERWVHhiRlp1Q244RjYrdElWS2FObUc0V3NGbnNBT2s3?= =?utf-8?B?OUp2RHFkMGdHc1o1QmoweitUTDZTOFlnVGN0cTZiWXQxUEFab2prUE15dXRN?= =?utf-8?B?czRsRlVzUFkzNlhsVFBlSTVKdFlVY2FxcmNGTUVwbDlNajlCK0NxQkZGZk9i?= =?utf-8?B?R1U5bTJNcGcyVE1KNGFiN1Y0Mnpid0VLa0N2ZlFZNWw4Y21VRTh5dHdEWjlR?= =?utf-8?B?V2YvNkVLcTRLa0kxamFkNithNU92NDUwMDZIemZ1Z1B1RWxHWGJEUnFJbmV5?= =?utf-8?B?c1dtZytQV0Y0SUkyejkwV0R3M3ptYnBxaDZaRk5Pbk9OMFBtMmdrWlFtMkkz?= =?utf-8?B?R3dteXZsR1NETlNVZmhGWUNES0QrTnBpY3k1MTNzdXlaRDNOdEtFekhvUDRK?= =?utf-8?B?WnZlL21oaGhmdzNVNlA3Mm1ZaXZLWE5DMFdFU1QvdCtKTHJObHUvd1JjOWVw?= =?utf-8?B?allUaGl6U0RJbUxnL0VoMnFzdS80bWFXaU9xUmV3MksvMDB0WkwvYUJtQlV0?= =?utf-8?B?cm8xMWJPVGl1TE5mOVE1WUpUbVRZd1dlUG4wTXQ3Z0ErREtMei9Oa0xlY2RH?= =?utf-8?B?eExrZGNyQTljTlplUGlOc0lwMkc1VUwyVWUrR3NjVi8raUZJWlpKYjZ1aXh3?= =?utf-8?B?enlNdXNDa0VYbG8wWmM2ekJUL0FkVWZ3ZFg1WmJWZjVDc1g2emxOYUgzUlRp?= =?utf-8?B?MkRRMEZxRWJUZmlRWndUYzZhWUFCTkZyV2QzOG5HbmRrU0ZpS0FDN3dwWmpt?= =?utf-8?B?ejhKRysreEZHSnIybFJMaDRWTnE2NHdpMU1VVk5yMjBETG1TUStIdC9hbVZQ?= =?utf-8?B?LzUxSWcwRWV3Ti8vY3VMb0VRNksveEFkTWphRVJ0a3J5UDAyU3luT2ljZHVt?= =?utf-8?B?ZjRpTzZpbkpGZzFsWnNJeGhXQUdIeit5bFR6UTkySWZQa1VoR0poM2k5aHIw?= =?utf-8?B?VXFlTVFxYXUvWGYyTndlamhpUFFwK2YyYjJDRDBaNkEwR280SzBWd3NjcTRS?= =?utf-8?B?RXBGZE03eE4zSUdMUCt6RFBkcmhTMjhQODNITjRqb080TWhvc0Y2cDJUTEI4?= =?utf-8?B?Uy9lRWQrenZmck1URERjcmlPU3dLRm5Nc2VocWJTR2RZTkp2TENpOHBISXRG?= =?utf-8?B?MGg5UjVjMEpnUGMrYmx5WFBOVnlQT1pQMEhFbUV6K1kwd2JnL1dPQXg5SUpD?= =?utf-8?B?SHFiQWRIYXhkVFEwRkJYMm9NTERCVlFHRWVZVVBTZlhJT2owMmhVY0wxWjVQ?= =?utf-8?B?NW5LbWpSS21tckk5RHlicEV3Wms0UEEyb0l2YkQ1K2NlUVQrS1MrL2JoL1R4?= =?utf-8?B?THNTZ3VJOHZRdXBvNVNJOHRnYlQ4YXY3YTYrais5QVJJTzNBamVPSEJEQk5Y?= =?utf-8?B?dHVHaDRaS0xMWGZXQVJRRyttb0JOVzI2SUJERHVxNkFIMFM0QUY0M0pOcnVk?= =?utf-8?B?eXd0MjdYSTYvNzBLQy90SzdoWXNpUEFQT1BOcWhUa2xFRERXVVQrdTFEbGxB?= =?utf-8?B?UHNnQm5Fdlp3UnJqSHZQY1FQQkJzb1VpTDFyS3F4U0tEYlpPL0tsekw4dWRs?= =?utf-8?B?c0ZZakwzcFlQbUNUYUlCcFBINmZDVWEzcE1aa0xuWUkzUlNaYkNycW51bUxL?= =?utf-8?B?U0JPT0gwNUI1N2ZpczRnZjRJeE8zRnhyWjlmTzJzaVQ4OTZZaGpoeHNOeGRE?= =?utf-8?B?Q01HYzdEbS80SXZrbzBpL0hjS3lFWk1vbmwvTGZNUVM5eFZieHNRNlcweE5C?= =?utf-8?B?M0I5OTVqMjhCV1BwQy9OMkNScE44L3RlOEVZNUxiaGZyQVNyRDM0RkZFUGZM?= =?utf-8?B?cFA2SEJxaEw3VjNDcnhqQmlVYU8rSkRYSWpqWmgveDAxNm5KMGJJSk0vQXhq?= =?utf-8?B?M21XQi9LNVZkTkRRdEhac1lKVi9DbmpjQTM0eDZrMnBUVXYyV1RJSXZycGs5?= =?utf-8?B?T1AxVllsQldvTkNSdVJjdzd3NjR2Y0txbXYvTXhKTGJaUlpabHNiYWR6RGNT?= =?utf-8?B?ZFN5Q2lrUklkVjJyMEZzd1N0bWdnK3lSZHQxamx0NWZFakJ6L2lKTC9oQi9K?= =?utf-8?B?dVFISEY2K0NDbFJGems4Qll1aDRaRnY5eEJhMGhrZWFYa3JtcHB0SE1pNHFq?= =?utf-8?Q?g9m4=3D?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdffc88a-c6c6-4b5d-803e-08dd07b3f048 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2024 09:32:36.8249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WHR7E16BRQpIxKlrF5aDzVlm6ZMOP0Pga8HBQ8bjN9Su5KeuH6jao7uTVMELjKa+cYMCL2CobwhLd/XsV80Umw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR18MB5429 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: YxaOvej9FJc-s-sIKsHVLCh0Iiqjs3tW X-Proofpoint-ORIG-GUID: YxaOvej9FJc-s-sIKsHVLCh0Iiqjs3tW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Hemant Agrawal > Sent: Thursday, November 14, 2024 1:15 PM > To: thomas@monjalon.net; dev@dpdk.org; david.marchand@redhat.com > Cc: stephen@networkplumber.org; Pavan Nikhilesh Bhagavatula > ; stable@dpdk.org > Subject: [EXTERNAL] [PATCH v2 2/3] examples/l2fwd-event: fix spinlock > handling >=20 > Detected by pvs-studio Bug 89-93: very suspicious synchronization The ana= lyzer > issued a pack of V1020 warnings that a resource might remain blocked. Fix= es: > 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Cc: > pbhagavatula@=E2=80=8Amarvell.=E2=80=8Acom=20 > Detected by pvs-studio > Bug 89-93: very suspicious synchronization The analyzer issued a pack of = V1020 > warnings that a resource might remain blocked. >=20 > Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") > Cc: pbhagavatula@marvell.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Hemant Agrawal 1/3 and 3/3 are NOT eventdev patches. So I Applied 2/3 to dpdk-next-eventd= ev/for-main and delegated 1/3 and 3/3 to Thomas. > --- > examples/l2fwd-event/l2fwd_event.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd- > event/l2fwd_event.c > index 22472027b9..416957384b 100644 > --- a/examples/l2fwd-event/l2fwd_event.c > +++ b/examples/l2fwd-event/l2fwd_event.c > @@ -141,6 +141,7 @@ l2fwd_get_free_event_port(struct > l2fwd_event_resources *evt_rsrc) > rte_spinlock_lock(&evt_rsrc->evp.lock); > if (index >=3D evt_rsrc->evp.nb_ports) { > printf("No free event port is available\n"); > + rte_spinlock_unlock(&evt_rsrc->evp.lock); > return -1; > } >=20 > -- > 2.25.1