From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E48B545D05; Thu, 14 Nov 2024 14:04:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B215D4028A; Thu, 14 Nov 2024 14:04:40 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DCE4B4025D for ; Thu, 14 Nov 2024 14:04:38 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AE9GiVN031126; Thu, 14 Nov 2024 05:04:30 -0800 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2045.outbound.protection.outlook.com [104.47.74.45]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42weearbp8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2024 05:04:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IRvEZQV0t0BvH40i+u1OBodHRsTSGQst4dYJ/s1dr7Q7Ae96GdkzZgTsdJlvPeorJVGbAT8RDne4shxj2UZTtMiRZz5UaSdmAEvzNeZEjHJSSzvJJZy1nvy7mcXKXWPf3MHGXOwp/ZwZ0OSYaHXxwvwHSpRykd5hrZ12QgEum3YMqsLdqRqw6vfYGpg5LD26HLfO5a4xN6nNEWf+71kUFDb1DLEiygM+VMOTL9KPr2wVrmQWM2hP60r6lZs5bTe5OK7pcVnKGJAFDYa1ZWwjUZ2gNz2Ogi+ejTbq1ohmuSsVdPsu+AOlz/c0GRqEZs1OyQ33kLa4jpk0/HrGRgEK8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9WHaEc8uvQm7Pmc81DZdxxmgTygJ+o70dzzHSURNqFQ=; b=VrkMZo5+AvGkcWka0GAxBlVH3xMPZdrAwL5bjw+zoJuxcVI+yFXofySHbUPzRSXW2I3WMXUXxoeyaZEiwl1Tp08Nr/ioUHFhXenn6rPP1CIfZylpS4OFJy3o3EvUjShTYeLQe7TaD/rYWfozWWPls1yg0cbsEo0RCBfOR9eUcDm5lKNkjsngr34Vrn0iNp+N645wHQDf4CHPp8Gebavq/xDIXZgakj1Yj2mKBTEN4quNPtNL/QDgC7XsBZSAZfsM2bkl/lyvYZWB4q65mliNDPnMGQOxzAV6U/RrCDF2lN5FKbUbQmUnAuMGoI8cZh01+P//6z9wRu5bM+5AIIDvlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9WHaEc8uvQm7Pmc81DZdxxmgTygJ+o70dzzHSURNqFQ=; b=pbzR+93unIbuVICOc+G9AK0vdYhRSrack+dZT6R3yK/0saREvgF/rliN6QMaPGKOr7LSDDo79y5hMdkEUCswRj/BGfLb6ZoslCivDqUClTXcqiDDSSgQhvDQMSHd0jKRL4kcSmFEb1mffRJH/046eONHjnox3ees4ftdhKCMcEQ= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by IA2PR18MB5980.namprd18.prod.outlook.com (2603:10b6:208:4ad::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 13:04:27 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.013; Thu, 14 Nov 2024 13:04:27 +0000 From: Jerin Jacob To: Huichao Cai CC: Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" , "david.marchand@redhat.com" , "dev@dpdk.org" Subject: RE: Re:RE: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of rte_node Thread-Topic: Re:RE: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of rte_node Thread-Index: AQHbNnGYX5reFApDa0K5J3pLV/7yrrK2ipiAgAAj5ICAAA/f0A== Date: Thu, 14 Nov 2024 13:04:27 +0000 Message-ID: References: <20241113073553.6125-1-chcchc88@163.com> <20241114084519.5128-1-chcchc88@163.com> <20241114084519.5128-2-chcchc88@163.com> <470e043d.ab5e.1932a91b2f3.Coremail.chcchc88@163.com> In-Reply-To: <470e043d.ab5e.1932a91b2f3.Coremail.chcchc88@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|IA2PR18MB5980:EE_ x-ms-office365-filtering-correlation-id: f141c863-82b1-4dbe-08a8-08dd04acdee8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?WnNsNG9oSmdMWVRQb1NGN0FVem5vbk5vQ1ZaT3VuSFhqWXBtTTFOeGhGSDVa?= =?utf-8?B?VWlZMUtlZ3J6T0x1WWRBaDYzS2RoTk9LV0xHNDBreHJuMnhQNXBna3Jrc1Ft?= =?utf-8?B?d3k5YjFydngrSmpkMjhnZnFQMFRvYzZ6MlRFekYyMEMzYmdVbUVHWEp2Z3BI?= =?utf-8?B?bUp3OVVCMDhPMnZiUnJoNHFhK2JhNWdOM3Z5R04zRHdWSzN3S2VEWFBKWi9n?= =?utf-8?B?bk1HLzh5RVBvMm9WbnExaFdVR1ZXRjNUZGs0M2FCQ1RqKzhtckpUdnUvZFJE?= =?utf-8?B?MFpLd2svYXJ2YU8zQnYxT0dwSHkwb3RCVE5oTmdQbEppSmZhdnRXTnRhcVJO?= =?utf-8?B?eG1SZGpSaFVxem5pNERyVExyOSszODZlRXdhbTIrNnd5ZEU4RUoyNy9KVjlw?= =?utf-8?B?YTVhSGlUdWpZM0lGcW9sRi8vOHZaNE4wdlNoYlZ4Q1Z0WTdtNWN0akNabDhj?= =?utf-8?B?azAvMHRoYmRPZlZ6OHdqVStDTzV4NENIV3ZkSyt2RFJiNWcwc2xtUy9IUWRz?= =?utf-8?B?Y3M5cVFYNlZ2Z1QzMXBvY1JDaDFEZnhlNEJBMUVpNXhxNFRFalZMeGdGbFRz?= =?utf-8?B?UmZxQmhvT1JOWDlwMzlOVzlQNVNHTUpDZXkzODdTd3p6UXZSNjBZVDFKWUc2?= =?utf-8?B?TjJybnJDRnZ3bnkxQ04xZ0NMZ3JCWlpNVUwrb3VCWDFFejRXT3MyMk1ON1Fv?= =?utf-8?B?bE1vTzM3Zisyc0JuZDdsYktDRlFhY0J4Q2tscElGV2tlLzVMRzlraWt1d0s4?= =?utf-8?B?RzFWNEJobGdJa1VLcnhsRGtFYVdXYWtXZFVrOUZoWnN3RlQxL2p3OVZmc1pH?= =?utf-8?B?N0FGUnh2U2JwVUM3V1EyL2UrcHMyQ0hZeTJxRDVYTS91VWVQZ1l5eHF3U1RQ?= =?utf-8?B?VGQ4TFBtNVBDanNTb0N2dTR3OWpjcUh0MW9jcFZub1hUTXpaem92RDBlNkFY?= =?utf-8?B?WVI4NmRXWGVrZXVybzgrakRqRE1rT3dOQ1BsbHVCSlRSZGdUYUJSV1l2aE40?= =?utf-8?B?ZnltMTRRWFBRQzRKRzNUbXB5RjRIRFhPYnAvNDBDRzJSWXNZOGJ1UGp4bEJP?= =?utf-8?B?YTF1U2g2c3krdUZ2TXBESDdackpUbHRvakd5V3A5amxVQ244MGoyL1kyYytY?= =?utf-8?B?bTkyUmswaDRoelVsZmhlQXM3TWZ2eis4V2Z0Mm40VDRLTUZrSlZIeUZLYUdi?= =?utf-8?B?OTdVTFpsdWJHSmE4bFZZRzlxYWNnd3gzSlRLUTlzclJxZDBBMEJXajUzZUxz?= =?utf-8?B?VFF1NHlGZi9aYmk5SzJRODJzeG5kYXBPY0c5M2hOL0M2YThheldIbUxCM0Fq?= =?utf-8?B?WXNxNDdPRkF1ck9ZUEo5cUxiNWxhVGFmMVFiK0x5UDZGcnYyelZPS0NIRmpX?= =?utf-8?B?UXI3bEVxN01PU2NqVk5mb0s2Q01rcHUyWGtWY1BOVmZRTm1aSXZmeFljQXlJ?= =?utf-8?B?eHFaZkdPY1pYaGNXRDd0SVFHbjlNUURmaEY3WlFmb1VvODRzdFcvSk5NT0Jz?= =?utf-8?B?aFNWbmlWY2drT2FybGo4YXp1UDl5aHJvczZxMG43OXFIdmhxWWdNZ3lKd0F4?= =?utf-8?B?bUoxb2dON2VZUkdZK3ZUdnppRTV6L0NqcE5UclRPVUdQTEt3S1kwQWJyTjVY?= =?utf-8?B?UWpmZGVmTmJDL0Z4VDZoa1ZLV2FXbFZSQTYvQVJ6TnFaMmpTMWVBelgzVkMz?= =?utf-8?B?cGV1Y3BJekFaNjYvTlhBeDlURitNamRPRklVaElCWC84aXZ5ejQ0Vk9YcEcz?= =?utf-8?Q?Ua3+lFZ2z/yK/xlkKaD7EYguNIsvSecNlGCLqgK?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Yjd3YUNTa0JCNk1Fa0hSc09OQkxPM2RnMnY5ZVdGUXJ0SHkrbHhzTFI3b3pw?= =?utf-8?B?MXROYVQ2TG1JT1djcDExeEFZRzFKdU5RVlVOTktib3VLVG5TM2QrQUJ4VzJS?= =?utf-8?B?ckZTMXRUUk1qKzgyRDJydHNFQmYyNDFRNXZUdWhSL1JGcEJWekd6c0Jxbzc2?= =?utf-8?B?NmVoTVhONGV5UmdoOHVRTVNtc0k5b0ZiRE55NVdqdCtyQVhmUHlPamdaNDdj?= =?utf-8?B?cWVMSCtPSzdTdWkxUTh0eU52L1RJSkR2QWpIK1NyRzFpZ1gyTzJIYzJnblZL?= =?utf-8?B?K09Tejd3WVQrZnhKTU10aERTOGMxMXNRR21SczdRanltb1lyL2JINmZaYzhS?= =?utf-8?B?bHFBbi8wUVVMdVV0YkVpWGVWQ0hkUkcrRHlQQXVkTjFrUDhMRlI2V2Fwc2F6?= =?utf-8?B?S25vTWUzK01adG93YjhZZjlBZ2pJMFhJQ3RCcGJ6M0x0d2g2Qnk2R2duRDVC?= =?utf-8?B?OXlwTmZ4NSsrUmtEZlJ6bkV1U201ZmlSc01MelNhUmdYaGNYM0w4bENxOXR2?= =?utf-8?B?Zy9nc0xsenlhMllGTlBpQnQzZEJNRGRpVmtSSnpQUkJkYzFSS3JIRXFURENz?= =?utf-8?B?VjFwelQ2VTREUzRzRTlQZmFwZ29PdmF0NnpIOXZWNCtlamtYVURtTmdHZ2RD?= =?utf-8?B?QkJuQ054NUhQanp0OU1zN3REblJlSTk0VE4zTml3dVUvMktjTVdGQ2VmNWRZ?= =?utf-8?B?MmdpekMwY2JhQ2NBMXhRSjhITS9sc3l6WDF5cE11bE5iNnBwZit5V2NyZjB5?= =?utf-8?B?M1pYVTRJczN3QUNNR3NoU3g5Z1BKd3FzNDExakdXS0RCek1RSmJZRFRzN3E5?= =?utf-8?B?NkVNNCs4ZFhHYXlqay8wY0VyWENtQkc0amR3TWVmdFpFSWkwNStBdkkyZlg0?= =?utf-8?B?aC9IeUU3enREQUNIcExYY0paTk5wQ1YwZi9UY3B5eDY0NUp2Y244dEdjSzhm?= =?utf-8?B?NURUSytoUm9hTXN4Z08rUGV3OGZVUG5zN0Vjd0JIM0lSb0s3dnhZc3FWVVlU?= =?utf-8?B?S2V6STJjU3BMcERGa3E3UUpNMHlmZXFYWHhUVXFQU1N2TDZUdmVRUUs2K1Z5?= =?utf-8?B?M1E3YWRxRnMxeXdyeDh0NzNWUmpHVnBLVmtsKzJyUE1yNEpKVE81YTNNOTVF?= =?utf-8?B?Z3pUd2pWY05DRk5FamhCNzZUS0NYSGRBSVBKNTNac2czVFA3NzF2T2pma1RJ?= =?utf-8?B?OFdQUEx1aEZGWnU2YzZ6VXkvbUlrdHdrd1cveU1COW5OUmVqa1IxOWRiSWxu?= =?utf-8?B?dVVVSTExeEpBaVNZY3RiSFRHaE9GWHA5aTh0NzdSK2t4dmVKb1BNb0lucU5D?= =?utf-8?B?K09RdWs2TE4weXBvRGhJN2RlUmJJdTU0a290cFVGcTZaSGthZzBMOWVmMjFU?= =?utf-8?B?SFZUeWEyTG5Zb3NOMjFhQ3lRK2Zod0VnWkxPNEVwQkNQUzMxa24yL0lZWmg0?= =?utf-8?B?Y25MY1hiU0tEekhERjg0QUJpbUtxSVFaelJzYlNKUzh3djEzbHlYbTQ3UUda?= =?utf-8?B?NFAwZURxaUxrYkpYd2dJL2hzNm9VNEQyVG4xVTRldTY4WDd4bHFlN3JtMWZp?= =?utf-8?B?UE9YaHhLYjdtSEVqenJXWWxLaTJMbzNTR2hOeE1KNWhneXl3TGJsMnNWZFgr?= =?utf-8?B?RG5MdGdVdlovajBqRnIvbmczTjU1dWt3RXVYVDJQR0J6bzJRRFZneFQ5QTNV?= =?utf-8?B?Y0VIaTVodTJrMlgxbEZhYkpXM1drcll0TW5CZ2tyUHdDVnFZamhEamRzcEw2?= =?utf-8?B?ZU1kK1hieThZQ2g2YWtJWlNzRkVBSTlvU0I1aFNMUHhENlorWUNCUEgyOWJC?= =?utf-8?B?ZmcwR3l3MWhwTmlOS1JOUEJSM3ZGeWpCa0hLSUw5TG5TUHVLWDVSSWppTUFx?= =?utf-8?B?Z2NYaHgyaGFrYnZUME9RN3F0UzBrRzZDT2o5aHpUT2ZZRXRsV0ZpZGQ1VUVz?= =?utf-8?B?WVBqaGllMHZpNlJPM0tYQVRmQWZSRzlqMEcveXlRQW1BVFFEKzRwaGoxUzBR?= =?utf-8?B?OW1mTWdhc3FZRWk0alhCTEttQUJHMXBmQmpkYlA3WjhEOXAreWdvbklMN2xs?= =?utf-8?B?bWJtQk5jWjNYdFNkWXJXQzRWZzlnVzJsOU5ZUGFDRklaMlhQOG5jZFhZN3cx?= =?utf-8?Q?/3bU=3D?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f141c863-82b1-4dbe-08a8-08dd04acdee8 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2024 13:04:27.6998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EplcCP/wtvqMzOm1HDWYQYzp8fWjIf86T320u+XaIbuZr5Dp/LIuVr9DrYKqizwjB4TAmyJj4/e1k7ObDKVvtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2PR18MB5980 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: rmyuAKQRVsRB3ttBfm6WLXZPMXQFuiGT X-Proofpoint-ORIG-GUID: rmyuAKQRVsRB3ttBfm6WLXZPMXQFuiGT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huichao Cai > Sent: Thursday, November 14, 2024 5:37 PM > To: Jerin Jacob > Cc: Kiran Kumar Kokkilagadda ; Nithin Kumar > Dabilpuram ; yanzhirun_163@163.com; > david.marchand@redhat.com; dev@dpdk.org > Subject: Re:RE: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the > member of rte_node >=20 > Hi, Jerin. Like this? diff --git a/lib/graph/rte_graph_worker_common.=E2= =80=8Ah > b/lib/graph/rte_graph_worker_common.=E2=80=8Ah index a518af2b2a.=E2=80=8A= .=E2=80=8Af9ff7dd8c9 > 100644 --- a/lib/graph/rte_graph_worker_common.=E2=80=8Ah +++ > b/lib/graph/rte_graph_worker_common.=E2=80=8Ah @@ -104,15 +104,19 >=20 >=20 > Hi, Jerin. Like this? >=20 >=20 >=20 >=20 > diff --git a/lib/graph/rte_graph_worker_common.h > b/lib/graph/rte_graph_worker_common.h >=20 > index a518af2b2a..f9ff7dd8c9 100644 >=20 > --- a/lib/graph/rte_graph_worker_common.h >=20 > +++ b/lib/graph/rte_graph_worker_common.h >=20 > @@ -104,15 +104,19 @@ struct __rte_cache_aligned rte_node { >=20 > /** Original process function when pcap is enabled. */ >=20 > rte_node_process_t original_process; >=20 >=20 >=20 > + /** Fast schedule area for mcore dispatch model. */ >=20 > union { >=20 > - /* Fast schedule area for mcore dispatch model */ >=20 > - struct { >=20 > + alignas(RTE_CACHE_LINE_MIN_SIZE) struct { >=20 > unsigned int lcore_id; /**< Node running lcore. = */ >=20 > uint64_t total_sched_objs; /**< Number of objects= scheduled. */ >=20 > uint64_t total_sched_fail; /**< Number of schedul= ed failure. */ >=20 > } dispatch; >=20 > }; >=20 > + >=20 > + /** Fast path area cache line 1. */ >=20 > + alignas(RTE_CACHE_LINE_MIN_SIZE) >=20 > rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ >=20 > + >=20 > /* Fast path area */ Fast path area cache line 2 Rest looks good to me. >=20 > __extension__ struct __rte_cache_aligned { >=20 > #define RTE_NODE_CTX_SZ 16 >=20