From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8983E45D13; Fri, 15 Nov 2024 16:57:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49B0042FEB; Fri, 15 Nov 2024 16:57:46 +0100 (CET) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5499D42F95 for ; Fri, 15 Nov 2024 16:57:44 +0100 (CET) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AFAFkrD021527; Fri, 15 Nov 2024 07:57:35 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2048.outbound.protection.outlook.com [104.47.70.48]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 42x4cgrgc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2024 07:57:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HO7KSmlGZ6WYS5ma4tLIL7cp2XxpxECb9ogWudOl2qSuyeq4lbbu7VzUZn4XLZf0z2ANklD0CKi+YbgZ+RbUjCEMSAhC8d9QSoGSy+qrOzTMvITeVVTmABTqypCiaezLUeMhoTPKYVuCab4xKRk6ulWMVIVLdN9G2kWicKOBXpuBQIDzfaSHRP5++toE2Px074Wxk1djj21vRBH0vUDzeMO1g+mrJpN8KH4XV2RUhFgpzBFSf8WINDIVm7wHwAiOFbOa3LLoGsykRoBT5NGewwSvQrujplg0P3r4YLlUPzOydgTg4bi/HsMQ99ebH3MzFqJlE8vW7llmjUIVwg58Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJUVk+3o+hwtYikEcjcjEj9roOMLq/sJZKgAjYMfdy0=; b=fQq9TWHPQ529lhzv6XMoSjCkTWaWPvAFPXcmAKTSxs+dzj3z0RhUstZHkyaZZfYrjPi+JscBSJPTQmEAP/UhoTqHEeAIj4wpsFXjf9NMlgcZea0lzz/z7BoTGF/bIUn8doP1XN/R5FAplpjWk8ozmiBPJdIGLuqQhY3gbW0hv8nd9qT67gH3sJIOEWyutZFxkDjp+vgrr3jly9DiwZjvUTqOfklbBtEKKESpLSULgFflUIn2QbGAiTjCs3e5jRLMx4jSKqZPuuZ/nRAJ5D3jFLoySs8s+yzTOgLb5bO3ELDSdv6ovpNx1/6UMlt3JG4km58KVa1ja2NSfrlRzGTNuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KJUVk+3o+hwtYikEcjcjEj9roOMLq/sJZKgAjYMfdy0=; b=SUOw+syz7ExXjkDWDGlMXsnxqgNGWC7cuag+ANKTiRmbieG02IANwM7YZDODElPA/YhODjUIFt4+1pn5uhHLLvuyGhuswT2hPX61ieZML/9+ujvJPWmDGxJIEQ06tGRRGao1oDhsFGUuxlysozV7089DSJsIUD5DdNEDIhxUilI= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by SJ0PR18MB4464.namprd18.prod.outlook.com (2603:10b6:a03:3bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 15:57:31 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.013; Fri, 15 Nov 2024 15:57:31 +0000 From: Jerin Jacob To: Thomas Monjalon , Nithin Kumar Dabilpuram CC: Kiran Kumar Kokkilagadda , "yanzhirun_163@163.com" , "dev@dpdk.org" , Huichao Cai Subject: RE: [EXTERNAL] Re: [PATCH v5 1/1] graph: improve node layout Thread-Topic: [EXTERNAL] Re: [PATCH v5 1/1] graph: improve node layout Thread-Index: AQHbN2n+cHv22I4fnkOUeYrVV0JckLK4fyjQ Date: Fri, 15 Nov 2024 15:57:31 +0000 Message-ID: References: <20241114084519.5128-2-chcchc88@163.com> <20241115015558.3080-1-chcchc88@163.com> <3517551.QJadu78ljV@thomas> In-Reply-To: <3517551.QJadu78ljV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|SJ0PR18MB4464:EE_ x-ms-office365-filtering-correlation-id: 47dbaaa9-0e84-40f1-de5c-08dd058e3657 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?OU9yUm9lN25vcmYraHloQmt2TG80YzNpOXVqb2FrdHJLZUxrSWNURi9ZMWdl?= =?utf-8?B?NUJaOWUxNHFnRU9uYnVteFY3MDByc0VRUmNNWWJGakZiYTByWXY3Y2liaVNU?= =?utf-8?B?c3lPRlJ5WnBJdXZ3MmVBTmN5NnZWRWgzRjFpYjhuUjdnKytCUFZTZHNLeWV6?= =?utf-8?B?WHNzK1JTUGdNNFFLRDA1YngwMlVmOCtEbmwrZ1RIQ0RaNmFYQ25KamgrcFVv?= =?utf-8?B?NlpQUytYR3FtdjdUR1hYU2o3UHNjV3cvUHovNEx6cGpwSG5LUVBzRHVibXVJ?= =?utf-8?B?UDhsQ0tqNWczNklDdXh1aGRaNWxQTGZ3Y1dMMHNadzlleUpURDBCMnZtS0Vp?= =?utf-8?B?ZTkxMVM1YUlxaXZDM1crb2dRUGJSTEcwRkRUenV6eFVhRVJsN0tJenZHMWYz?= =?utf-8?B?RWJLd09yRHdpQml2SlpkclJjZG9sbFBIRmRVK2NzS3hYNEVxVEtEZGhoQUkx?= =?utf-8?B?eDZNNmxCaTBGVVYvNHRtU3VFY2p3dWpJaG4zQitxeDBMMVFLMEdBRmJrQk90?= =?utf-8?B?WFkwM3pma0ZKMFI1Y1lkRGZXcnFEQlBqamk4TEhrVi8vWEtBeG02RnhSaVNW?= =?utf-8?B?OURNMWZXNmJ5RjFHRHJ2SFNxelNyM3RFTFJUVW1mQjZncldicGhLcjVPeHNK?= =?utf-8?B?RGZmenBjN2NsK2p3a3piNXB5ME5EY09KWDBWeGx6NDY0OXRxcjY3R3Q5b2pz?= =?utf-8?B?UTkycDc3aWhVMWpLNWplZ0wwYjJQd2VGNFcwOENOb1dDa0dZZmUxMXVuek1Z?= =?utf-8?B?N0VtS3NpWDhSY3pzaVJaUm5KK0NpMHhpRGJJanNsYW9mYW90WHg0eVFLSTBt?= =?utf-8?B?QTBIUFB6YmR5aVBRMjAvZVVLaFBEL3UycStpNkhUTWtTV1Q5bkc2TjI4RytL?= =?utf-8?B?SzBpTFd3ZERNRS9rcVAwWnpSbURhbnltVkV6MmVHUm5Odk5EWHZORTFDUHdE?= =?utf-8?B?UWlpUUE2cmQ3czh5Q2YrbUg0UTFnWHhYV1NKcjd0dlQwdkM5MURwMlBHdW45?= =?utf-8?B?VTlNcjl1VEdIcXA5M0xRMnZVSkhkZjk2ZEJLTUk1QUNSRC9WRUhIb0RpQkxq?= =?utf-8?B?M2oyVDNNOVFXWDV1TlZ4L2tTM3gxMFRHSmdjK29kQzAxalRHYkZWdkw4aElW?= =?utf-8?B?ek9oakJONmNkK1JQczkvMG41RWNPenNIN3AwZWZUclFZUnQvQ1ZNcHViNEJQ?= =?utf-8?B?WGxHaGlkMk1sV3NNQzZjZ2ZETzdrUE1ZUzF6RDk2NHJKZFY1dzdmdThQWFdU?= =?utf-8?B?VHBBdUdJaXp4TnE5ZHZEOXVaWEc2ZGZyRkljMWlnZzBoVDhzTEV2RXFuKzVI?= =?utf-8?B?Wk4zdnoyakgrOU9tY2RtY0tLZWtRaTQ2TUsvM3VPbEk3N1NRSWozaDc1SXl6?= =?utf-8?B?NXdqMzlvemFpblh6TkVrVjErRFNZOXZ1RjAvdVVveHFBWURCdTJjT1dOTFMx?= =?utf-8?B?MVloRWlzL2M4aXRkbFhORW9QT3MvWERJVmpaQkw4RFVVRThoSno5dS9wTk4y?= =?utf-8?B?ZjhhR1ZaUUZxTXE2TkIwSUY4dE0yNWNRSXJrSGtrdFpCTzVwbU9kd1dUME9u?= =?utf-8?B?ODcvbm9ibytselJPejlIUkNGTEF0VStpZVF6Q0g5RlY1MnlPQkxsdmRBMTcr?= =?utf-8?B?cDBuVUE1TERkS05DTVpYanNMdzhTQXNvcS9pVi8vMDBTWkplUllrMzFxMC84?= =?utf-8?B?M1l5eGEzTmNtK2t5UEZiOG1XN0dtWjBabGNEY3hzVjhLS3dhV2hVZ3pNODJm?= =?utf-8?Q?hLPLpatwW6baZvXLT4QUvqupKxabthMV6+Xz0zc?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YzhRN3B6YUMxK1piWVdjeDJSejNtWjVUcVBPbzlZVkNJOWtzMHdGTXFwamht?= =?utf-8?B?ZDFSNXhYK1ZGZkIyOXVFb3ZUbFlvWGcrZjFmcW82VlBoSEdYNDEvbXVxeS9i?= =?utf-8?B?RjlHQjRoN3ZyWDcvN3Y2TkJTK0FwbXlzbGk0djlvR1dVZ0JzMFFYSVJDd1ox?= =?utf-8?B?c3hjSUpvaUFLeWU3dTZJZ0s5dFVHem9PZGtmNUFSaVM2SHJiRktCeHk4MmdZ?= =?utf-8?B?ZmVjcG5JY0UxZHQ4c1E0amJRc25Gc2JRUmtYZHFYckNBTTFNSldMbkJjczRp?= =?utf-8?B?VWwxLzFmZE1SVDloU0E1OFhzTitYdjZpSW1nOTVYVk95ZTBDV3NLeXRJRW9l?= =?utf-8?B?YmoxUHZGUUZPSmFVS0I0Rm45SmIrV000RVZmQ2xRVGdsQ3FmeFYxL3ZjeUli?= =?utf-8?B?bzJ3dlRSKzc2ZjZKVCtsd2JTaDh0Y0tKNFNLcjVKNjFFQitIMEVJWWx1ZENE?= =?utf-8?B?bVBVT09TZTJ1dnl0UXhVYlkxWVpIRGZMN21KQW9jbDZOeWxlMGFLeVlrb0N2?= =?utf-8?B?dVgvZWR1eGk0YnpMNE5KZGpuaXJJZmFFWlZsd01NTnRwOENyaFpGNnhDd21H?= =?utf-8?B?SWptc2ZELzdTamlWclI1eXNKd2xnOE13ZEJCc2FzYXZYSzRVVWQ0eFFRdHFU?= =?utf-8?B?OTRuTzBnbkpaZ2pPSFhnajlNZTFnOE8vRWQ2MjR1Ti9WN2J4SHFWdkZOaTNM?= =?utf-8?B?b2RTajFZUWVEY3QzRm5UNEc0ZnhYMnNsdStZRnhPUThYM2pLSVpJVmhrTHRo?= =?utf-8?B?MHR4dmc0OUFJYzA5N2hvYUNLK0RXWXdUSGlEam5vTUdoQTd5Vms1QVEwczJN?= =?utf-8?B?UVB6MGpYM1pnZUFUbGVGVHgvVG14cTRxVTN3TTBmS0kweVhUc0VCa2grSlhm?= =?utf-8?B?UGsrS2NrMFpYMVMwNXNySHNwSy9Kb1N0OWFKK3dHWlZoMEJOR1VucGE2b0Q1?= =?utf-8?B?aXBjOXpYRzBrYS9adWJKVSt6azNNL2N1T3B6UkIwUDJwV3FLcHcvSnI0NEdk?= =?utf-8?B?THFMQXZWcHIzQ1JtQVJRbW9COTM5OHBYajhBMGNmalZ6ZDRLdCtURnJzbUJ4?= =?utf-8?B?NU55Z3dncFJlSlFyRkYzTXpJUTduUHNPeWt3SGdhYVU0MHk3M01vWEVnbm1E?= =?utf-8?B?Z1R2SDVDaWNvL2pEY0xYTVE0WlV1dU93dVhObTZGZEptUVJRNEJ3TUpwejlQ?= =?utf-8?B?U3QwVm1jMnBoSlhsQUFXdWNCNmNYSHNJa1pkZVJMWjNscEM1Qkc1YnEzYlp0?= =?utf-8?B?RXhnY3JGQS9JdkJ5VTFyaytxSXRtWHFEQTNiUEVvMnYwRmdwOGx2MDJlN1lQ?= =?utf-8?B?azBvWWNiSUV6cm5BY0FhTUFzNGRBSWtpOHJKOHg4SFNOWllQQUs2bjBSTjE5?= =?utf-8?B?VjdlRzZGU0dVRDZkTmFWTEZlWmlXK0hsNnNMZ0laMU1OMW0vaEZiM0lJUTl4?= =?utf-8?B?ODY4eXpwdUtrZllOOWRtY0FJVG8vVmFoa0EvWkNjenEwUS9jVGRyWFpybmhm?= =?utf-8?B?TnFLUnJzZTM2UWVyUTlEZGtCY0V3dkVKcDJIMTV4QzhuMkVKbEtIbE9DY01v?= =?utf-8?B?NGN0UmJoWEF1Z1o1amJkSUZzWnFIQ1F6TkEwTXdZdkN2NzNXWTZTVGdyS2RI?= =?utf-8?B?N0pFd1NzcURma0M3SEVmbXlXQTRPOFMxSWdCTGQ3eGs5UDR2UHd0aFFiWG5x?= =?utf-8?B?R2R3N3ZrN0MvN1haeUxFK0VvK1k4OGR5U0w3UGUwS0FWUmxWcnZLTlh3dVRM?= =?utf-8?B?b2FnTlZIUzhpR2ZvOHFkK05lOUNaYzdscStjSlJwL1lxQlY0NlcwYTg1SmtC?= =?utf-8?B?T1JXV1VnN3l1eXZKM2wrazJ6dVErT3hNNUJHR0ZmRGxRaVU4Tk1QaStGZ3E1?= =?utf-8?B?aEdPN3JZUXJBcHlqcmdQa3JzMzc0b0s4Yk1HL2hMSU80NCtqWktSVTlIeG1l?= =?utf-8?B?UW1IRmphSlRja09VRG9rcWwxZ3Ayd00xaHgrODZmeXFaMGpWeXVqRXUreUhs?= =?utf-8?B?eDZiejdHRUROVVdYR3pDakpNTHVZaWZMMHBQeHJ0dTBpMTA4VkdGOWZ4dDAy?= =?utf-8?B?VkY5Y1dDeWN4eDRPUy9yVHF3clk3czcwcUxvcEp1c3VVeHdtWXlSUTFwOGVS?= =?utf-8?Q?xpHM=3D?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47dbaaa9-0e84-40f1-de5c-08dd058e3657 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2024 15:57:31.1131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QjKkcCoTo31ZjkOuhmNappzvVaejBPf67IiezSbW7RfzOOf305i76tCQPTekbewmbkezCeo7qm5WF26uB4pR5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4464 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: PuFwQUdmWZWBPnofwk9yhgiKSGqN1ukq X-Proofpoint-ORIG-GUID: PuFwQUdmWZWBPnofwk9yhgiKSGqN1ukq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, November 15, 2024 7:54 PM > To: Jerin Jacob ; Nithin Kumar Dabilpuram > > Cc: Kiran Kumar Kokkilagadda ; > yanzhirun_163@163.com; dev@dpdk.org; Huichao Cai > Subject: [EXTERNAL] Re: [PATCH v5 1/1] graph: improve node layout >=20 > Is it good to go? 15/11/2024 02:=E2=80=8A55, Huichao Cai: > The members "= dispatch" > and "xstat_off" of the structure "rte_node" > can be min cache aligned to= make > room for future expansion and to > make sure have better performance. Add > corresponding=20 > Is it good to go? >=20 >=20 > 15/11/2024 02:55, Huichao Cai: > > The members "dispatch" and "xstat_off" of the structure "rte_node" > > can be min cache aligned to make room for future expansion and to make > > sure have better performance. Add corresponding comments. > > > > Signed-off-by: Huichao Cai ] Acked-by: Jerin Jacob > > --- > > doc/guides/rel_notes/release_24_11.rst | 2 ++ > > lib/graph/rte_graph_worker_common.h | 10 +++++++--- > > 2 files changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_24_11.rst > > b/doc/guides/rel_notes/release_24_11.rst > > index 5063badf39..32800e8cb0 100644 > > --- a/doc/guides/rel_notes/release_24_11.rst > > +++ b/doc/guides/rel_notes/release_24_11.rst > > @@ -491,6 +491,8 @@ ABI Changes > > added new structure ``rte_node_xstats`` to ``rte_node_register`` and > > added ``xstat_off`` to ``rte_node``. > > > > +* graph: The members ``dispatch`` and ``xstat_off`` of the structure > > +``rte_node`` have been > > + marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned. > > > > Known Issues > > ------------ > > diff --git a/lib/graph/rte_graph_worker_common.h > > b/lib/graph/rte_graph_worker_common.h > > index a518af2b2a..d3ec88519d 100644 > > --- a/lib/graph/rte_graph_worker_common.h > > +++ b/lib/graph/rte_graph_worker_common.h > > @@ -104,16 +104,20 @@ struct __rte_cache_aligned rte_node { > > /** Original process function when pcap is enabled. */ > > rte_node_process_t original_process; > > > > + /** Fast schedule area for mcore dispatch model. */ > > union { > > - /* Fast schedule area for mcore dispatch model */ > > - struct { > > + alignas(RTE_CACHE_LINE_MIN_SIZE) struct { > > unsigned int lcore_id; /**< Node running lcore. */ > > uint64_t total_sched_objs; /**< Number of objects > scheduled. */ > > uint64_t total_sched_fail; /**< Number of scheduled > failure. */ > > } dispatch; > > }; > > + > > + /** Fast path area cache line 1. */ > > + alignas(RTE_CACHE_LINE_MIN_SIZE) > > rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > > - /* Fast path area */ > > + > > + /** Fast path area cache line 2. */ > > __extension__ struct __rte_cache_aligned { #define RTE_NODE_CTX_SZ > > 16 > > union { > > >=20 >=20 >=20 >=20