From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC446460EC; Wed, 22 Jan 2025 18:01:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F0A402D5; Wed, 22 Jan 2025 18:01:02 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9722F402BC for ; Wed, 22 Jan 2025 18:01:00 +0100 (CET) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50MGISBK008207 for ; Wed, 22 Jan 2025 09:00:59 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 44b43402wu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Jan 2025 09:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AtKDzbG8qgs3DuxlJegDoCKIIHvBtK/R2XNHXXkfielGiAW2Dpm7nNw/ksv0Cy2/SAqzH1DzTQ3ZNxZ2eLN9mcORak/fnZuZc4y2Kq/MoMEo1kWGqF1uQgEhfjdNJGYDVUpKSp4glGMBXOukEyF8n9Ob2MMExO1lllkTjndnZ83cY4N79uT7JRFS5dq8NO7kxDnesjHNALGQ8G/XZ6eGaOWE4tBz87wbyckBCM4ILkHBkJKQYt9DxeJO+1rn6PI+lfcs30f0unb3VQHTo6BenBQdHsu58HlI1fdj0oUh2d6JgI+3nfukCx2hJY5Y7lceUG4k9KOOJOm+B8ps3gEG2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tv+28zMolj7oAu3tI8mLHxGPOv3UWNCSP+TeDHyp8I4=; b=ngHQG9t3IXvzKsLz4Jg8jlSqzaVEyQ0xMxD70B8kflYwR0rgaG7IACbiXU3PytajFwZkXWBmqvM4/s3AZce3Q7+j8JuBQyDo6TMUYtgygZGGP41RqYwG6G1Mj7MFkmfsheo4XnmHdGafgFgQsydt9cGicGOJ5UajUFEwr8BlqIJcOk86xSGjw8ldiKCD/NKUUEYPBhc7B8owgiCMwqySgQ4SKhNjk36i7RvX73RnLSIRXqskwXb64LzZa/SCh8ZZCHVg5BQM8QfGYUfprBrfoNV1tHT128PUB5OuvA+fN50xCT+EAcCujA8Pwg/qGmAfYbUORj0BfV0VBYMeYWvlLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tv+28zMolj7oAu3tI8mLHxGPOv3UWNCSP+TeDHyp8I4=; b=u/MWFnhHq/66oMRokMW+WOENDvmRDcGp4BL1BlqCEj+bzjQyz4ItctJx6/4Gb4KVmDLBOE70U+qK99qx7n4lzkW/yBJHXXPfjeGxyn+zgrjVDCkE7oO7yqTHLbQvEDBHCLKGLvpwqn5g2kcOHyzMXzFaBanQda0F9RPP2MVNWKA= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by BN9PR18MB4187.namprd18.prod.outlook.com (2603:10b6:408:118::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Wed, 22 Jan 2025 17:00:57 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8356.020; Wed, 22 Jan 2025 17:00:57 +0000 From: Jerin Jacob To: Nawal Kishor , "dev@dpdk.org" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Harman Kalra , Ashwin Sekhar T K CC: Nawal Kishor Subject: RE: [PATCH v2] common/cnxk: fix atomic load in batch ops Thread-Topic: [PATCH v2] common/cnxk: fix atomic load in batch ops Thread-Index: AQHbRNtdNhYJqsDAR0qRktT+3+3lO7MjVFpw Date: Wed, 22 Jan 2025 17:00:57 +0000 Message-ID: References: <20240823065104.2254919-1-nkishor@marvell.com> <20241202165739.1896876-1-nkishor@marvell.com> In-Reply-To: <20241202165739.1896876-1-nkishor@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|BN9PR18MB4187:EE_ x-ms-office365-filtering-correlation-id: 4fd730f8-0c31-4485-a2e7-08dd3b06570f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018|7053199007; x-microsoft-antispam-message-info: =?us-ascii?Q?DHTKgV3/bkNbva7NrUEwe4+sOeng3ourCCb0HYKlduumF8wwnHX1rysMEvV+?= =?us-ascii?Q?p9GoRtZMtXvqXWi74o6IhXBhIXo6CgxE0hZXgunHggF+j2S2Ge/nD0Xt+vpW?= =?us-ascii?Q?eA+lblkBeKqbMqR9YHQSfnD1JCl/0rfNxXfxg3l84SK1gwQEL3wXXnFVSQhM?= =?us-ascii?Q?XotiiPGgN35zMQ/cNkaNJoVuVIZdEefXHrXy2PGoUP42abhE8bLBfFCPmCj+?= =?us-ascii?Q?sV1R1BeGOQZ006dj2xO70B5mndkzNDlOC4NGYnEIKNa9T3BaA0oPz8NJsG7A?= =?us-ascii?Q?/fiP4EzFI7Z4TAumIeIaVZgNIsslstJe4s/MRKHsa38PNC76B4goeBxkILMh?= =?us-ascii?Q?w4/773dC8S/TEpmjG/F68rgXmPS5NLLphfmWgjkVMMhoqTBt5Pj9SB5t5baJ?= =?us-ascii?Q?ZujOCbXc1Iziki9fIKRSnm9RooHHH3A/NZohTtCf9/XuZ3nCLmWMK2DqTs4H?= =?us-ascii?Q?pB1jLvvnddGvys4KqbyMoD9Kyzt9dNZh5kjFAx97Gqw5E2fCDcpWVpUmdJTp?= =?us-ascii?Q?p3zMTXkG6gMbUGsePdGJbWcrwNXockogyjyen02zndt3VknLD0JaB6fElK4D?= =?us-ascii?Q?dalTSqCeVQESXYyPDgjWy1ywM+i4F9oKo5DguBDw6u8P+7jkCPPFBREAVQdu?= =?us-ascii?Q?ctpP6mxCjA4dgMT0uyhL64xdn98xFwWb5R3BgAHAR1qul46+8pQ3dh+JRcbM?= =?us-ascii?Q?vMlNWmbn6kN0ZZdj016RJ5uQNQlelYr53ovkMLK7cFi+qoOo/UY2St8Cp/OF?= =?us-ascii?Q?JSUrmzn+W1B4LCr4o1RZ5oJySVJawsFh1wt2eGABJrYnHtzVUaC3rhpbOcv3?= =?us-ascii?Q?OTQ7BO/jzDsUhxEkzKFYWal3GYCvNS4nXcEyx/q30b8lVOSDcP4XhC7qmvP7?= =?us-ascii?Q?X6AaMF6GOuPo8qaaxNXRa1Yfk9z4uriMnVduL985e246rd/XqjpwqEbECHi7?= =?us-ascii?Q?npdYq5yksDc5Bk98IAs3M3O+Vfhzai6zTqf3yVbrmt0ECNr+5q8ZQp7Rj4EP?= =?us-ascii?Q?9RR52KLgvAQfyPZQXvwEhlB1g/VtRtChYkMPDvFvY7kjkcnchDsEcS7Y0C+5?= =?us-ascii?Q?ctsxJVgxK3bV4JOwqnjJHcVeffCbp70CWGGbsYfEPetWd2zSpD2i3ZsweEhI?= =?us-ascii?Q?TeNHJLeECt8uUuqCWl05DBrVnV5tInHr4SyUz5j2yQeB4p7cT1zhryfS1RqJ?= =?us-ascii?Q?xgPtnG0NUpDpy8rBJ7di2yRag6ok6DPARIpe7HpjIYJTLFwgV+yIHsnfkfwA?= =?us-ascii?Q?vsfoSuTSw0sSyMTzAiweS8ZRntX72qmvIQd2FY4ZudWwUStzNfKsiwK5NFCh?= =?us-ascii?Q?QA2TWja11lzyoYnUC8HFlDlJsExZakdYN2HOG/ol6rBJAtG5D01sUdAESVtS?= =?us-ascii?Q?wej77WnSbtu+rkJyzwPCf6r9nFN9gcwBL6X736Aqdz5xg6IfYDBgQ2IDLZfn?= =?us-ascii?Q?jh5THd/+NonhDCWVrmXti61j6U50FruI?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018)(7053199007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VdNOGAkDPQSDbE06xExQhGI29Wa6m+UjwuSDjEvPAjyRVIC+aCDcpPDu9IJo?= =?us-ascii?Q?W2CjQUxcBu+ng7daDaK9i9qHfaajmenDf3ECaS7oaKosiOHeZ6heXL+87Tb9?= =?us-ascii?Q?ZATsP5WOvkquiQGOVsT87itxEjee0yNMuHhGSZhdK173y3xkPxwjL7b1w6aa?= =?us-ascii?Q?TtIwg2XEBe7ZM+y0xb3C75FG35cyk4DPnRjSRlQTet4IINXiQsz52HoQmA+h?= =?us-ascii?Q?Si7Vdqz3YiJt62e6qLd5AymhybEJjxcxYwiom1puj3fuUCrZPb4HFLPyX6BY?= =?us-ascii?Q?0NSv7ueQKy1qTGsDtEVlSVzfocj3RlJXbhyaiK/b67UHqxpBf5tJz8Au1q1z?= =?us-ascii?Q?KXnyRUM3djdGxg9FMR28HzWhgDDRM71B5k6Iy20tbyf/XNEc/jFLxKYooJN7?= =?us-ascii?Q?xAiKy6P8d/SeEL7HoliovfPZMeanYeu1RvguJzZewDVkDzIRWX81gm4EQX8a?= =?us-ascii?Q?skR1FvrcSXJ0b5fW6FsaxFK+cTyCh+ZWPiqZzChylB22sn2hMMkPPF3ezDyd?= =?us-ascii?Q?ilZYTMDi2/jz7KIaCif8hAOpodX9iFAvbn+XwIKq41chXEO5CVri8fRSsCuY?= =?us-ascii?Q?j9feyUxf8Gel+S+fAiLuNZHc4r9T8rL62p+btJh1Md/wezxLgiKqKw47r37z?= =?us-ascii?Q?M+RL59kqZF3mdAof9b+U+V0A5h6L2srj6LbShnRX3uS4sCAp5DZhO4R07YFx?= =?us-ascii?Q?4WvrdKrWsrnCaXySi7q4plZfyGXSzRcA2WtYbeoJP/0u1qclDCBI5sVYXLbN?= =?us-ascii?Q?lnm3vOodE8Uvn3z2DSw9IHZQp8mgs1RaTfBhrw4Rdu7rSEUmKD1mMgItIOl4?= =?us-ascii?Q?fV7I44N2CNLf4hqXUfu4TwrBU1nhZmwzTOkyVHldi3NJPeghcUuWMmyggRa6?= =?us-ascii?Q?FoeVuQgHhOcNo8Z6xqu8rbKJkwOcgvARKffnBuyTnvJ2xZb8FKmV24PGEgjs?= =?us-ascii?Q?bHJ4jj3uVe/i/II8o+l6vwIPWo4ihPl18fc1cYNmSTpfdVf05g0wMVlbTGch?= =?us-ascii?Q?DWukA4635V2h0s40V/sNSnDC/4Enzt22rv1C7ShuQF3ZdmB9pbsNO4nB0y9o?= =?us-ascii?Q?dcIA5RqhsrRP6avLyHoDce4felUkp4Q0cJI/nt98FoR5TNmzfMOYx86u+Y78?= =?us-ascii?Q?clT9KrnkXO3Xjp6TsgMjIAlVUj7JDoUE7Siu+ggyEHZ82cjXtE5Fd8hKvqWQ?= =?us-ascii?Q?R8BnfaCD0C8mCD1t44gdxD3qdqi5jXiKeJ0TVnWGpOIvpHjuG7LVMVZCOyuM?= =?us-ascii?Q?a8iZdLfWT+2pUn3U+jp8ziE4p8l3Y5weoyFnvY5QsOzgXitKDCStk9QRWIrU?= =?us-ascii?Q?W7s5ORVmSqGjXQDZ6fJkKaJtZ02GRbl343nj5gWsb7qbOz6jVI1drSNCrTuS?= =?us-ascii?Q?fzdZNiqiCYtz6bkVjMsjxd/Afrk3RX/vJ3PaeHAvTKOtV2bPHbW0V1CJx42b?= =?us-ascii?Q?na1RcftLwgrqn1AsGvQLxNNvIZEJMP9yxPQYtnjNHw2vMohXTik8E2QHcAV0?= =?us-ascii?Q?WgN62VegEETv/xCcvvKfIOstbna1DTOWrb3g1+RIqSBV9BrbUd5evXcCutmw?= =?us-ascii?Q?VEoLUJY3FXJyaf8maIMwd0wtji/XgLEyV8kBNQlX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fd730f8-0c31-4485-a2e7-08dd3b06570f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2025 17:00:57.2596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CVyucbdTkts6e7ig9g/nfnH5QLo+hr6sHn6D0W0pzCzMwKhOcZNjAaESHjJvzXwxybp03Bod2dvyFKVeDo6wHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4187 X-Proofpoint-ORIG-GUID: q6e1ES5e6i47Ek3i4KdlbUoYHFNolXsp X-Proofpoint-GUID: q6e1ES5e6i47Ek3i4KdlbUoYHFNolXsp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-22_07,2025-01-22_02,2024-11-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Nawal Kishor > Sent: Monday, December 2, 2024 10:28 PM > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Harman Kalra ; Ashwin > Sekhar T K ; Jerin Jacob > Cc: Nawal Kishor > Subject: [PATCH v2] common/cnxk: fix atomic load in batch ops >=20 > In roc batch alloc wait code, __ATOMIC_RELAXED is changed to > __ATOMIC_ACQUIRE in order to avoid potential out of order loads. >=20 > Fixes: 50d08d3934ec ("common/cnxk: fix batch alloc completion poll logic"= ) >=20 > Signed-off-by: Nawal Kishor Fixed the following issues and applied to dpdk-next-net-mrvl/for-main. Tha= nks Is it candidate for Cc: stable@dpdk.org backport? common/cnxk: fix atomic load in batch ops Contributor name/email mismatch with .mailmap: Nawal Kishor is unknown in .mailmap > --- > v2: Fixed review comments >=20 > drivers/common/cnxk/roc_npa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.= h > index f7cb4460e7..8525038810 100644 > --- a/drivers/common/cnxk/roc_npa.h > +++ b/drivers/common/cnxk/roc_npa.h > @@ -255,7 +255,7 @@ roc_npa_batch_alloc_wait(uint64_t *cache_line, > unsigned int wait_us) > /* Batch alloc status code is updated in bits [5:6] of the first word > * of the 128 byte cache line. > */ > - while (((__atomic_load_n(cache_line, __ATOMIC_RELAXED) >> 5) & > 0x3) =3D=3D > + while (((__atomic_load_n(cache_line, __ATOMIC_ACQUIRE) >> 5) & > 0x3) =3D=3D > ALLOC_CCODE_INVAL) > if (wait_us && (plt_tsc_cycles() - start) >=3D ticks) > break; > -- > 2.34.1