From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2622445D01; Thu, 14 Nov 2024 08:15:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC89B427A3; Thu, 14 Nov 2024 08:14:58 +0100 (CET) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1C48F400D5 for ; Thu, 14 Nov 2024 08:14:56 +0100 (CET) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AE3TXtL025162; Wed, 13 Nov 2024 23:14:52 -0800 Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2043.outbound.protection.outlook.com [104.47.51.43]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 42w9bpgsww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Nov 2024 23:14:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KVJH93uX4ZcoFkZZft/v+DOtVxzxrWeGb4RYXPkXnKuUlR4QgpIj1bBbubKrDzpGxyo9GYxXcZHIXiG6excHuyrt9i4t13DFsssdHhVcxcNS1O2/VZiZmmY7+wNOe+J39oHPqInt+YAkm0EL8R/hJund6A/WxeCoZER2cyBefOatz/s2ODFjQroxxnDShe3Ox1QlsJV7gnUXjsonikTbnCsnGydc4tB1u1sP64j3hOokX2AokREJsuvVdVpYJwllT9QteZ8zI9PEJhigdgnssbvm/XA21DUxtyjk/Y/VfC4/0fNOy7pXTbuGVytkWiqs6ScF/IEcMRxGXCuYtTakJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dr7YzCraVzZqsH6HSiOVjQJRGKRTiCbYBHlCA0v7IWI=; b=voZ5THazIP/pW1q7P2FELqij/3+iTa5q5GEj5v9/upP7q1xaZSIxrrS5SSxtwL0AZoNCVL0VtpKaKzYnNA9vPuE4pUvK/utphZkjq1gSaJyYT5bOi6etTh0RLhc0SbpOHqpE4zwbaEtT94cXm6qpWbvRLwxwvHzJd0jNAeSWYz4FdQkMgfVm6qLE4BxNQrkYrdRwv3f9qKz8rMeUTaTcBWvY7QgL+1rpcO2zORzASrY6myNpe7tGku/Gspo1fVaGwcEbEzI2d69wTTMi1JASBo4MQbXbM7Rp75tQtba6nsgxIb8G83yNuxc1a4YAjI/8WrEnYl9DWUF13GD3qaZDBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dr7YzCraVzZqsH6HSiOVjQJRGKRTiCbYBHlCA0v7IWI=; b=kN0dD7HjTiV2tcYxANErETb0xHOyh0/7zFzQ7qycrXrLMUCJdSuly0fZx5I+xWNQwGAwQ2DYh7pHWVAZXL431EvxNZ8LL8C+415CPMU4mqe+r3CDC6HTw/wFn2h6zs6jHTEVZq4BleiMizyDOcplTq3s+cvp1PrIK6ShytZw3ZQ= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by CH0PR18MB4129.namprd18.prod.outlook.com (2603:10b6:610:e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 07:14:49 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.013; Thu, 14 Nov 2024 07:14:49 +0000 From: Jerin Jacob To: Huichao Cai , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v3 2/2] graph: add alignment to the member of rte_node Thread-Topic: [EXTERNAL] [PATCH v3 2/2] graph: add alignment to the member of rte_node Thread-Index: AQHbNZ7TzoQUGlaCUEWwqUihgfkZibK2XU0A Date: Thu, 14 Nov 2024 07:14:49 +0000 Message-ID: References: <1731297797-3662-1-git-send-email-chcchc88@163.com> <20241113073553.6125-1-chcchc88@163.com> <20241113073553.6125-2-chcchc88@163.com> In-Reply-To: <20241113073553.6125-2-chcchc88@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|CH0PR18MB4129:EE_ x-ms-office365-filtering-correlation-id: dd196cbc-e34b-44a6-bd44-08dd047c06e1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?RX4JgcN6MmPJasTK95hfZl2tLrJ3PwzQmxC2ZJ1lDeCPnIlwXZDbfjNADPED?= =?us-ascii?Q?b2Jm1YXOI34uqZ7MBMtw3X4zqIl5kxNkNjczopOV+iO/Ws7X6bgLR59BWBwN?= =?us-ascii?Q?fwKDIpGuI9Zs7deRMganBiBothxbuMBa4vm+/huQpm/v0DDBeVDuB3jHzHEm?= =?us-ascii?Q?QNIaTziM3ppWVch8gcTDpG0WAiZUHZBRbmc+Lgtu+S3IcsIRPK/TnypmyXEB?= =?us-ascii?Q?qHK3K6CACSHQ9noDx00j0fyjqbnkQWP509/60pTMN/VIupcJP8vgEflA1BSi?= =?us-ascii?Q?p+2yODoo1sJXT3UV+e4titGwecV+3CmkuWIZSN0LF2kD/16huWT6jSyXQ9kW?= =?us-ascii?Q?90hMA5sKOLC9U1nmnc3xvimj0Uhti2JgJrDchvjZCpRRIgL0p8O/juTDKDze?= =?us-ascii?Q?HZk7V/FCzTdFNbu8hkQhvshEwASF0LaCRGLNjMhSTNxXLx4p4If8GqpsBJHA?= =?us-ascii?Q?HkkXtIpOFDNbTUAjE2eJI+zkXQUwYZhOnDrLMYgt2TAV2EhkZBbTpMUpnwac?= =?us-ascii?Q?bWLn1AFYGGGhq/euk8HFkcB45umH1Jp+KP0PSyHFocTF34ln0TE1FhncCHhY?= =?us-ascii?Q?dGm5/1SNvLfrR/KJ6ys0ujYDJWYEgscgcv6WfinA9wvs6ZMsqAKfGqqAP0mQ?= =?us-ascii?Q?fCkaB+ZixQ9UgwRjmGPm3bc+09H4iZiwaKcOpJGcj0w3h4d6inAN1TJvl9YI?= =?us-ascii?Q?XSgj8IMlCWVIUrVtpGIgKJ/RvJPuIUqh3zfbq5+lXyoWmjUfiUOhomvyIamL?= =?us-ascii?Q?9IIj7LZGd+bawPsIBv0mKgo/6+Nw5jyZDW58S2xSvY37pLoSBR3p0+v7rlRC?= =?us-ascii?Q?1JbV2nz8v+jXrBY92VOvtfTBjfdMqujwc7a3nZjKh1Dkop54ckikrCWEHyVm?= =?us-ascii?Q?NOvD2Pc2gEbQ2FQhRsKCq6TTowQEIPoD4JCQ3Ods/ORcTxmXIR32UBt6fC+e?= =?us-ascii?Q?IcTvaRVtdJFDOmaftU6q5eVdrAcxE2QLQvEyDFeRS571s3sl3gsIwmse3DNy?= =?us-ascii?Q?18IKaml6bmcAmp4R8J5XbBb+D3VbW3ytP+6rB375cz5jUfrLCVQdLdxVZ8g9?= =?us-ascii?Q?pBxxAIhu97yv2ZahdekgKWQvdHFMO/6QyVBso1bgxaHoN7ozp51WJmge5152?= =?us-ascii?Q?0q6d96EhDKAIV1Gdpw0enShH1jNZlOJrFRzU25CVepyMIflNQMT+VFfJUmu3?= =?us-ascii?Q?9QN/RRoAJdn9JJGegCPFIxJL+3AFCNKWZFtTtS6ntR1/Xdz1FcrMxuHYz0f7?= =?us-ascii?Q?WluNrGwz6Vpl3nsJxuBse7ogxv1wphr5UIn9iG5+v0xnyDj6bduDYE6yads4?= =?us-ascii?Q?mRjOM5NoDl6Yf9zHkDfZd+Jc?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qpYNHxUvBfTzyDJy/3jQs5fczi1wlAOmVCA6liJvXgWRfBsVfKEXncKacDOz?= =?us-ascii?Q?FVBtAjSY1Gjxq8ik47u+GTUPyQ5idJVKtXvQWmZK5ov/KWapExYmt1mNB9U0?= =?us-ascii?Q?aCDPJ0YipbrUwo9esWMBdBRJhsjjUaxXoFkMuX3RAqCH5rAKbIOOZtPJseUv?= =?us-ascii?Q?lcxujYhOawfrq2CiNnx8UIE/TtQkKP3fB6y/1ArDkYjO6EW/tL3UGCrsSvZ/?= =?us-ascii?Q?iheZq9tkJk1edgKxpK3R1w6DzrT29VvljNB61NQpf+UiqibzMu5HlpY5Qftg?= =?us-ascii?Q?nIDcuJR+UMi3eYdNBWZ31XbxJ4UoT2oHaguMNMY1lWjvWl30Wm0FXJsujeZc?= =?us-ascii?Q?uaJd4JSzZMFG3j4KlIeH3qlzCsvdOhY6d9ODKTUVVTlx6cxE6m72W6aq0LcJ?= =?us-ascii?Q?Egu4fCbVm2rIe6zov1gFN7Yy5koBR7kZhxCaq1UVKCSpjokG0A/oaXJ0L5Qd?= =?us-ascii?Q?fC5Gj2fWL/xOm6ThCP1ZhmwwUB/FXZNFLc2Er6OL1BtPEwjlumkZudGBu9p0?= =?us-ascii?Q?9YO2Z3Uevhvgq5c4t9doF0hFKpO8AZcjqy6jSTZJ8wAR/awk6Svc7TuN6e1H?= =?us-ascii?Q?mV8QGJgmty4bJg3j6y+mRMsjFM+DcSTRHK5RUrkg+a38DQ7uyaMad17ZGMwm?= =?us-ascii?Q?lmklmDXiGPt1m1pcQpsgeZHNYfUAdzomEEuxIp1QkelZhaQOP3JvEj+iwmT+?= =?us-ascii?Q?5qfcD4qv7dwOTWi0P7co2wZB1Zf/MICy4hddvOZT5O+aZ6yS+zYXH45NntH9?= =?us-ascii?Q?s7CcSZ8bthZlbxZH5TF+ghd6F8WOpXkYcGoAozQdbH6ZqjNX7UtwhosWlUVM?= =?us-ascii?Q?gSXZPyPHaRkci2X/x9H2LnrC+RH2RtzUwG2d4McnnDcrkP8V9rmfo55/HKAY?= =?us-ascii?Q?vS2Zv4R9l9H3d6TINlnw4wX+1WwGwQV4SOkF6IfWj6sleCLxusA9bWBuloSV?= =?us-ascii?Q?tpizFYrmIItQYXqEdveaIwjVsStSI+Kv9fYa31j2mKWNmeZFKRUtLPuzRPNj?= =?us-ascii?Q?65o3WQpcr3aiZHKqKxC9DAwqVy4CEeOaswk5uSUpxGn+N7EE214DUbDyCTMK?= =?us-ascii?Q?TX0FOLe8zkWddDS3s3U7HC6Q2OX8ZPEtjTcn1Hr1EQew7WCQPGhI3z20cn8F?= =?us-ascii?Q?mWzrPeyCFe0pM/cUZthe++Q36f+JTHUf22Pp2Cis3hKkOcGJolqDp981OL8V?= =?us-ascii?Q?WqMJNwqdpy2f7vpG/qiivYAqspkVM/o2If06SRq3gY5PsYue8HP/Fb0q+QPW?= =?us-ascii?Q?G3YYWrZzWlvqWZzOMM24FsxsTZKbMSdPuAAhWgvrave1kc0fWQZgyo9OfGYF?= =?us-ascii?Q?bFzHZo2Hz7WpJQmuW4iMj3RJwXXgfJpLNOYlC8xMCtsKI/6eUUkwpPwXFYTR?= =?us-ascii?Q?x14AUd0l3wRw9b1VXGJWhPJVwFyrLveYsi0NdZLvMbT4/wJzMUjeGSuWgXjW?= =?us-ascii?Q?f+spkFUBLpQkvfDgN9mblbrK5Tmc0qCz4ahU1rVoAvWzdyciFNuMXOpUgOEc?= =?us-ascii?Q?+Fs7UNRk+SYqMjSZkWp5EYg6bcEcTpomkfpxZEOzjZIjeq0zWJpJ84khtZFZ?= =?us-ascii?Q?TGGRFNCaa0VNYqGb+nE=3D?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd196cbc-e34b-44a6-bd44-08dd047c06e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2024 07:14:49.3832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nGM5YEHhqOTcwmaX86z/1muokFBTJ1PCyxXQb0Py4v+LGB2H4EL0DZ8vYfDUx41yv/yksXDupH445Sn0nqvSaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4129 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: flqTlhANPPd9WtfAdIRxko5jiXdgMSlg X-Proofpoint-ORIG-GUID: flqTlhANPPd9WtfAdIRxko5jiXdgMSlg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huichao Cai > Sent: Wednesday, November 13, 2024 1:06 PM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_163@163.com > Cc: dev@dpdk.org > Subject: [EXTERNAL] [PATCH v3 2/2] graph: add alignment to the member of > rte_node >=20 > The members "dispatch" and "xstat_off" of the structure "rte_node" can be= min > cache aligned to make room for future expansion and to make sure have bet= ter > performance. Due to the modification of the alignment of some members of = the > "rte_node" >=20 > The members "dispatch" and "xstat_off" of the structure "rte_node" > can be min cache aligned to make room for future expansion and to make su= re > have better performance. >=20 > Due to the modification of the alignment of some members of the "rte_node" > structure, update file release_24_11.rst. >=20 > Signed-off-by: Huichao Cai > --- > doc/guides/rel_notes/release_24_11.rst | 3 +++ > lib/graph/rte_graph_worker_common.h | 5 ++++- > 2 files changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/release_24_11.rst > b/doc/guides/rel_notes/release_24_11.rst > index 592116b979..6903b1d0f0 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -425,6 +425,9 @@ ABI Changes >=20 > * graph: added ``graph`` field to the ``dispatch`` structure in the ``rt= e_node`` > structure. >=20 > +* graph: The members ``dispatch`` and ``xstat_off`` of the structure > +``rte_node`` have been > + marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned. > + > Known Issues > ------------ >=20 > diff --git a/lib/graph/rte_graph_worker_common.h > b/lib/graph/rte_graph_worker_common.h > index 4c2432b47f..9e99278a0a 100644 > --- a/lib/graph/rte_graph_worker_common.h > +++ b/lib/graph/rte_graph_worker_common.h > @@ -104,6 +104,7 @@ struct __rte_cache_aligned rte_node { > /** Original process function when pcap is enabled. */ > rte_node_process_t original_process; >=20 > + alignas(RTE_CACHE_LINE_MIN_SIZE) > union { > /* Fast schedule area for mcore dispatch model */ > struct { > @@ -113,8 +114,10 @@ struct __rte_cache_aligned rte_node { > struct rte_graph *graph; /**< Graph corresponding to > lcore_id. */ > } dispatch; > }; > - rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > + > /* Fast path area */ Make it as two separate comment, Fast path area cache line 1 and Fastpath a= rea cache line 2. > + alignas(RTE_CACHE_LINE_MIN_SIZE) > + rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > __extension__ struct __rte_cache_aligned { #define RTE_NODE_CTX_SZ > 16 > union { > -- > 2.27.0