From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A3EA45CA6; Fri, 8 Nov 2024 13:22:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 399A743348; Fri, 8 Nov 2024 13:22:45 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 77B2140677 for ; Fri, 8 Nov 2024 13:22:44 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A84D9eN026174; Fri, 8 Nov 2024 04:22:38 -0800 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42sbdq0vwn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Nov 2024 04:22:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C8hqi+uFZO0V8cete6Z7ohCfw0+1P4tyyMefuv+e039aqsVe8SBuJzPByclfYZ+KSGKtcv5BdFc2rthK7ePKpjv65I7kIZbwATfGssE2kMzTxo1WcDDmBNFTdN3Vs8uUuJTf4I1HJlzMquUtnrrCEcE63UNzKBPcFgmqKQ3oEQJlG6O6Vk7rlYnPRxVo7F7xxH/4ygL7h1xGvZyiwvgZHOguMfGuA+uT/gb2VIIKoT7IsK/h5CWK/5AxqUuAaN2pk0FMLMcVw2YILIGF0mULopcoAwjsaEqAbXixwA3BCiLMCRdiZOeRIed2F8QvSpazUb8WLl2XPE5lEnPaIjab+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ETOf6f3HcRN0hnpND3p3fR16OAnNOwn8YD03UDXnlQs=; b=ebhSap4XqHqBuTlAU8MWzdeydg3mnoU92d8b9Yym1B7U+k3ublR5Ksrd6MYafCiG1xzMDJxpID1hAtLpkQTGJa/raUJdbgu/tABJQiCMw249qPS1HTWr5hoiRZRfTDK5duojzZOgkSX7GnlWI5bSjZuKtZ6nFPze8jVlTD9IXd6R+jYI3QaaYPq0yBnaQnnPMsLiSZNVi8CmT65vVKKZPo/mnWj2wuXgHgMpAJSG2XAbfsAR5yvqs34Ycm+Cxko0+0nwSIFalBGqyKRXq+Nj7U8ZX1hV2rWFkNHFizCJicQOCrduuhS8Cg1cOa6/43PG4Alww3OZAOV+W34Goo0srw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ETOf6f3HcRN0hnpND3p3fR16OAnNOwn8YD03UDXnlQs=; b=DpAnWFjYeTVgJj3h4zEU4VTyJqoqlpsPgkXcLSSOj+zg2YQ98NMHtKvz0SA+8wEkTLo57P2iG2Fgp87wOq9c8N05SpOjkxcBCvVxhwzCFVauqfQZypQ0TGnZOvIK0YwlDnSbvK1xjMHg0hvqIi4+SxWCOkO+j8j/JOG0XNGq5Ns= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by PH0PR18MB3992.namprd18.prod.outlook.com (2603:10b6:510:2a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.22; Fri, 8 Nov 2024 12:22:33 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8137.019; Fri, 8 Nov 2024 12:22:33 +0000 From: Jerin Jacob To: Huichao Cai CC: Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" , "dev@dpdk.org" , Thomas Monjalon , "david.marchand@redhat.com" , Robin Jarry Subject: RE: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes Thread-Topic: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes Thread-Index: AQHbMOvAG7PZCWtVIUGc8aK0tW06jLKrjYzAgAEOywCAAH+NYA== Date: Fri, 8 Nov 2024 12:22:33 +0000 Message-ID: References: <1730966682-2632-1-git-send-email-chcchc88@163.com> <44cd588c.1867.193096d6e2b.Coremail.chcchc88@163.com> In-Reply-To: <44cd588c.1867.193096d6e2b.Coremail.chcchc88@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|PH0PR18MB3992:EE_ x-ms-office365-filtering-correlation-id: fc7a423a-c1e8-4aeb-7262-08dcfff005a7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?windows-1256?Q?2DVgIunV//GQ6a0oBybbASJXxEG+XpLHnwNCn+ggj+FgLRsi6FPcuyCr?= =?windows-1256?Q?BC4UpfiwiBgfnS59iti1ig8JuKhgyMRDmUO+7qWFyq+NKrtcOf+wD9up?= =?windows-1256?Q?aOhyNWmaaLCtD0eBxiH36zPIMmKkPndsXoZrR83bwEUVVb/vnVh/HQju?= =?windows-1256?Q?u71xFHg2qKbo+Tp19G5Bvl0JtzXBamlWZzDgLL+5T6BJSPhqgW1erW3+?= =?windows-1256?Q?ThR9D1vmtlEOq403rUZLZsn5dznisEnKHlYFcjytwkm0k8BNUp2gKMjJ?= =?windows-1256?Q?xfHYz+nwpSZqdiu/MBoBrck4V0bHtDc5pkwxfyxcWA6PPJIBwzqsOAZr?= =?windows-1256?Q?Si5lEnEO01/+zqK1UObdt2x/oPMHmbfeiEhRRdMrTjDfzzHtY9uzTIhb?= =?windows-1256?Q?SITIo7t8IUwX7H5o5ATIPoCCXZuWNHvLmVvmCCk74D8fdghwx/iNIrdi?= =?windows-1256?Q?fAOxqD1QHgPttQfUErVqKG8/uFJMTSrCHivNzh57z4aAmAin1mUnoBTt?= =?windows-1256?Q?BbP2VN8gjLemh8y64Ptumvvhsnka/3N1JWJU2uBTyLKDYRl8EjRiOZ82?= =?windows-1256?Q?B+yx+ZRy9F7SIxjOfziVxisLrfktzLYt26g0SOkIivDBJEBhvAEYmAs2?= =?windows-1256?Q?IfWMdeNtM/Mbw0D4um2Mmigr3MJ3hmw6kQ4mFvyF8RvDG+DLIq1NJUyc?= =?windows-1256?Q?1bgjpgNpmRrsxZc2fFl8yhvmcbS03hGOQ+MVkuiShDvd2rUkgImYZZme?= =?windows-1256?Q?RgwUgTKHOqhujAyrdDi63rulplKaQicbZ+B9nMgYR4Ct1pWtz0ejiUko?= =?windows-1256?Q?Ee++oiNXuBl/2JbsaqwzN+0lVIz5K0Uqi1tpJR+zBtzbadWF9/LwCkEX?= =?windows-1256?Q?O/zsOQw2fxSiSnB+1rlRGxhKOGj8lBsgiGQlBdu4cStZqpdYt+Ge8H1v?= =?windows-1256?Q?atJY1Gf+kQzi7E/7R9emaTGEWE+dHAlhOwLesdHxwKskv3ZzlGAQw3Fq?= =?windows-1256?Q?b4KnH7rNmaGVj6DSx1dThmqR/IslIM6lf3yE6DlO0y+YVwl/haHtE5oN?= =?windows-1256?Q?pSHfsCpr28RZhE2XzBvwPMIYMoGfeys2XHfB7pcSG4cN+V/8IfXZoYAK?= =?windows-1256?Q?7hmnGpEpgXdJMSsJKooBYUdQOwFhqq6sjPSEKvSPEIXzESEEBWkYtyE7?= =?windows-1256?Q?oK0HNg+KJGccGKyOrGmJh8ILGQ+Sp/NoUaJfHhLP7Z50YiLEmpKISNZm?= =?windows-1256?Q?+V9LMWBX7t28zi0eCqtaepU5N3xpWM4+RuV/ySGphPGPlyhCLkX2Qjz8?= =?windows-1256?Q?wqarN/pAiEYsxyeytr67T62LIY2XRfit47wFpGvTc4VbO3loK4Xo/8rp?= =?windows-1256?Q?D/ihBWoVzAEQEJ1tcPiXrKIVNM5xYTD8nmqYq1hbipIaJYyTtfbgX6Xi?= =?windows-1256?Q?E3Zcobc1A9BhI2AAN3oP1dFjd2pBL3zB0qn8Oi/XoSA=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?windows-1256?Q?Dz5ytkW1R2UEgywC3Utgu2qQwxo1uzxUjMBIni4zIW0G9UnXaVZ7CivI?= =?windows-1256?Q?bKUxmTazse9rQDTPm0mNArP44zihQf7uZ+W49rb2DeD704n0H4GvbPeW?= =?windows-1256?Q?d0uu49PCMhMAVa+tosK4LiayzietA2nnAuFmm3XdPdzxoIkGNkxKSU86?= =?windows-1256?Q?YxhFpy8RI12djO3dTpbcPi4n/ORGwdGJobMmWIGha+KCrGwm2zB7NDPs?= =?windows-1256?Q?e9EnFDO/CVk3lHCuGUxdG34Mvjbr3F/YBCAhrUTxDrBr0pLj0fku+uWg?= =?windows-1256?Q?mkOaLsd1P8LcJWBUFhdhAm99qmwqdhfNfufntGtqBGunIiKidy6xwwYD?= =?windows-1256?Q?inJc9MX39vqTacARCGmEtlYw+KvWD6xaAVevp/O2URpmfjRvh9jyvR4B?= =?windows-1256?Q?rgF+OyWlCPdU5uuHge8/+p8FyXWxU/78P1jwoE33qIaEUMUa5L5H03it?= =?windows-1256?Q?fECKIflVGG5KUg1Uq0uX0T4Wr4kK2VPnZWxx0JRBkA0t9J7Kf2+dOY3a?= =?windows-1256?Q?FQ4YmvYkqWrhs7oPnIk/EmD5aXeKYz38RgUwj0XrajStPAkPK07SXWcl?= =?windows-1256?Q?TvAZ/3nOFHoUVWJGNRHKLQa7BLML45i87xek9LFIMFXiOpSAuybdpi02?= =?windows-1256?Q?WRB9UbNX/IuEvO7drqwHnmHhtP+Q41qID2XYH2lj88EcvQWDpRmJvI6k?= =?windows-1256?Q?U4aVe9Mlat0NfTloQeYvYnM694XD6APLxVO7gcVCHIWhfY2INGj/otWT?= =?windows-1256?Q?xb6W2HrYVlHHTorT6tDc2zHj8J+itB7hsWwPz0mxapdTVD+gFE6T0zgj?= =?windows-1256?Q?YDuubNKFGeO8Q82WhXeVSPKoiX17lT3AgItW46OKznoPBknJBeTN86Ll?= =?windows-1256?Q?gHp9o9TMLJFGXRJY/77gcBcya581PyaqRJfKAJreIkKO4cjhhS7W7EwY?= =?windows-1256?Q?3XJMnZh+n9SLhd5FxKS1+hftye9duhN23Ky4or4g6baOR/sR8htGjLG5?= =?windows-1256?Q?0fZFiSeXcuiM17LSEX+38iW/QZmac2ZwrY00tWGzGRE7iGDrclYXRX7e?= =?windows-1256?Q?v9S5sd0dHXY9f52U7aTBHIyjYH/ytIsPTZCxifr3vrbSpi73avd6iflr?= =?windows-1256?Q?a7a3N4EARpiSi73I16C/SmciEG4/msB9idRfU1RxwKwk3rV/wIQua3ra?= =?windows-1256?Q?lscIcRMCbtZ3S54Z++I38jgwiDpqgNpbMfvGJKNzF/kB5ECgCkmJ9U8S?= =?windows-1256?Q?DUcBdIu8ZBL1oPD3nqEPUgT9E1yFype9ucYy9q1krxIiQQdqJ17PeHve?= =?windows-1256?Q?AlzY/H20Iyd/IRZ8M4kn9i2M/mzXhgyhkWX/eXNwB5At0lIQMqo0oQJm?= =?windows-1256?Q?3VeSxDG9qYRp0//wgWL/HYSuoKam3msrNRicRDUMJHU8Mr/KWNxN7vyU?= =?windows-1256?Q?XsSx5L9fVbPfwyWk6qMlIx4SyHur5yUnEa/jsmhLBFAXS2+CFbpJNXSo?= =?windows-1256?Q?yUl4mbNd3NCQFU1pzKMIsp26mYjKY+6TkszIN/dLiU0fZc/qPb7QXusA?= =?windows-1256?Q?etMOCEethX3e1bOD1KQ8sCZ4UeTzFQhIzq20fO/tvFz0eK9kchStboGO?= =?windows-1256?Q?3w3UqJPaVKtfXs5eS+NPgujBaJmUTJEfV9tNLxCZeF3dqjcs2VoGpAbJ?= =?windows-1256?Q?Q5Jtt7DC2zZ22L6k/zPckd4OWFoEV2pd?= Content-Type: text/plain; charset="windows-1256" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc7a423a-c1e8-4aeb-7262-08dcfff005a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2024 12:22:33.1591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /Z5OEIP9mutA1GgEPygdy7W6Ak7QhbauZoIvEMNWMJOLdhlxWiBpyqOl6kGdaOipajCAtfoQKIxugcEuTZvYJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3992 X-Proofpoint-ORIG-GUID: ay0IEgTioBS-4F_2i6eo_1Fnt2bZbQKC X-Proofpoint-GUID: ay0IEgTioBS-4F_2i6eo_1Fnt2bZbQKC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huichao Cai > Sent: Friday, November 8, 2024 7:10 AM > To: Jerin Jacob > Cc: Kiran Kumar Kokkilagadda ; Nithin Kumar > Dabilpuram ; yanzhirun_163@163.com; > dev@dpdk.org > Subject: Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when > scheduling nodes >=20 > > Is n't breaking the ABI? So can't we modify the ABI, or is there any > > special operation required to modify the ABI? =9E =9E =9E =9E =9E =9E = =9E =9E =9E =9E =9E =9E > > =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E= =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E > > =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E= =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E > > =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E= =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E =9E >=20 > ZjQcmQRYFpfptBannerEnd >=20 > > Is n't breaking the ABI? >=20 > So can't we modify the ABI, or is there any special operation required to= modify > the ABI? Only LTS release (xx.11) can change the ABI after sending deprecation notic= e. Looking at the pahole output, one option will be making dispatch and new se= mi fastpath Additions like xstat_off can be min cache aligned to make room for future = expansion and=20 to make sure have better performance. For xstat_off addition, there was deprecation notice to update rte_node. If there are no objection, may be we can try following in this release to n= ot wait Huichao for one more year. [main] [dpdk.org] $ git diff diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_work= er_common.h index a518af2b2a..ec9a82186d 100644 --- a/lib/graph/rte_graph_worker_common.h +++ b/lib/graph/rte_graph_worker_common.h @@ -104,6 +104,7 @@ struct __rte_cache_aligned rte_node { /** Original process function when pcap is enabled. */ rte_node_process_t original_process; + alignas(RTE_CACHE_LINE_MIN_SIZE) union { /* Fast schedule area for mcore dispatch model */ struct { @@ -112,6 +113,7 @@ struct __rte_cache_aligned rte_node { uint64_t total_sched_fail; /**< Number of scheduled= failure. */ } dispatch; }; + alignas(RTE_CACHE_LINE_MIN_SIZE) rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ /* Fast path area */ __extension__ struct __rte_cache_aligned {