From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D245F45D03; Thu, 14 Nov 2024 11:05:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C136542E6B; Thu, 14 Nov 2024 11:05:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id ABAA342E6B for ; Thu, 14 Nov 2024 11:05:52 +0100 (CET) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AE69l02006502; Thu, 14 Nov 2024 02:05:47 -0800 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42wbprhc34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2024 02:05:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ykfTnJ2pfAB8kY10wZYVatr/chGgDcZrX248C0bijUtoE8FFn6DklNlm018M3hhsm6tT55EkmT5zB/Hmua1Eg0DYsiuIxuw72n1BfpHInUeNRV4k40ko0iiVGM+fzcYH7DtKc6WdXipoXhsjzhddhpCMwO2559b4/a2zAoLLy2UwLL0sS537s7dulqk37Qi5PjWaymVXErH7bm7ewrF9mgUQA+X4VpBuSl7/g9l1EY/DX8H2ew0vjcGtMuca1GheLVEWq16LFk8vqNkrW7ODtqc9DFDcZZ5OU/gt7JZI8nLgs9ZBmEdbwt6SlrYveKcMaHsmNVozZRs1ZABhvFxvuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1LGkbSBgT3oaZNSyMlJ+ovrK34MT1tmJAVaknp/2Gz0=; b=n63jbBBRjU3bZS4+Wykihs0YXx0MWUpLIubJ7KATWarqkwtYmBz0awQ7slQMXtfyvF3G2UHtkm8XleIkgxRp6heOWhGs02TusU0DtWnPGIczKPFDAh8svVodbajox4uvrqLK3kfL0W7OIKZj3njjGll9jp3g5heFgJDZS/Lo7RAKZgUIK8lqqZ2GsTRUAFoAxFFOOkETyKY8CAc39ujh7Su10txIW6i+dEB2OC54lEjuhhbjWzdF56fB1+KRQA2i5xovzO7fs0z7WwE3hMbT4n/l9NQPT9j9YFnXh0gGQPKtKoQM+DfNpfej21+efFDvg6/0Tv5fGr3kmRRAmuPpWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1LGkbSBgT3oaZNSyMlJ+ovrK34MT1tmJAVaknp/2Gz0=; b=cDknm7ct/PL6+g9QtsNHmbCfM4EtN+iugZdNHI1zr7WVwBqszKObBEyUELYMw5sWHONugiSmgw/owkqLZQ1mGgFKNOmSGtT6S4l9iubxcdG1QA402/AyF++8p5pDPc4Ge9lWTXgsmcAFYekmDVqc+QjrkrJPq2KY0nRJZoT8ojE= Received: from BY3PR18MB4785.namprd18.prod.outlook.com (2603:10b6:a03:3cc::18) by IA2PR18MB5850.namprd18.prod.outlook.com (2603:10b6:208:4b6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 10:05:44 +0000 Received: from BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576]) by BY3PR18MB4785.namprd18.prod.outlook.com ([fe80::4f9f:e101:dad7:c576%4]) with mapi id 15.20.8158.013; Thu, 14 Nov 2024 10:05:44 +0000 From: Jerin Jacob To: Huichao Cai , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" , "david.marchand@redhat.com" CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of rte_node Thread-Topic: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of rte_node Thread-Index: AQHbNnGYX5reFApDa0K5J3pLV/7yrrK2ipiA Date: Thu, 14 Nov 2024 10:05:44 +0000 Message-ID: References: <20241113073553.6125-1-chcchc88@163.com> <20241114084519.5128-1-chcchc88@163.com> <20241114084519.5128-2-chcchc88@163.com> In-Reply-To: <20241114084519.5128-2-chcchc88@163.com> Accept-Language: en-US Content-Language: en-US X-Mentions: david.marchand@redhat.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR18MB4785:EE_|IA2PR18MB5850:EE_ x-ms-office365-filtering-correlation-id: e7f62fa7-5fb4-40af-ca26-08dd0493e74d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?SXhfBu7IeUezMI+ly96zOApTBePdEvXh4jDNxKG5agV8YHgRxX595l7uAXpP?= =?us-ascii?Q?KJawt+3C8Q9yC7qasWgzDV1ZsI8PKuDHAm1jd/dEd2YURxNb4qLbSLprRcVD?= =?us-ascii?Q?ACV25It3CT5b4PNXLmnA1eXzJX6BCcnuiy1AfetDHqQD+khZjfiCtoRnKjPS?= =?us-ascii?Q?ytNl6tmhj5TNZu244bOYDaWEI5KkhLZt5p2N+3pBh22FUXNWJACCUHP2TcTo?= =?us-ascii?Q?QGlHmiSKcB6Xl74+BXOPCGTbRT49KIyw8qhoLp/FqT6JSMTuKboNp4S6LUsp?= =?us-ascii?Q?muUuQDDuhMWauARR7AA/FLggHvvkHu79TFUJJc7vapOKVZWkkIE26f8yav5e?= =?us-ascii?Q?ZbApchXOwi3+ycW6nOi9v4yGGVnpDBCI+potZr126TxzINoA1tHzgKIJnQaH?= =?us-ascii?Q?+vGmOosi+c7h1k7QSW/C4wiF90laIf772W8lXaTUoZHiXzkf7eu9fV9+qD9e?= =?us-ascii?Q?1gC6O7El2nIrQMdp+T0w9WymKb7DIVk5K0J6qFdH0E85ofh9yLvwcpX10hh9?= =?us-ascii?Q?EJPv78N64jQK/kM6rzlY16SrfD51YZzcjVqbPswVbG2LuEmLt12FMQKyD6Jq?= =?us-ascii?Q?SW4I6105mJ1g8A/SP2kVDvvIsZVLisvDdUuLAw0/L9h+Xb7IaU4XdgOw4wQN?= =?us-ascii?Q?L1OhstIx+BrwlfG/Vyq9OaqujNChuUkZ9qEtlYnYLc0Z7w3OtKAODAYlZIl9?= =?us-ascii?Q?sHTsl0v1WpUrrCW23anDw3+JZuxxY0xoJYxL1X8Dm/MV2kF8XqMvkfM9dt53?= =?us-ascii?Q?RBGkv2BNEFndlWf0OE74ru5eXhdYcLDvOWNAWwh1UjFu/nXG6eUvHE+u+90T?= =?us-ascii?Q?wzZ1GakstJa9LxYH0mr6lekaIhiEBGlnCWpr4rSk65OROEKJ3Ul2WLu8+b4I?= =?us-ascii?Q?qjjAi7yWMge9px6k+e7LRfYtRJooLnzu58k0gCz8pHUKurvL8gkjfzztDCv/?= =?us-ascii?Q?CO3DZuE9oyNTrZ2HhYIUarE1tVx4C4C6PGLXeubwBA9/wH74I+PyCdTsl8eu?= =?us-ascii?Q?INCfSsvuX+0DFkuXdpXnFAQErSNBiMZwcz6WqskafX94v983C5UrvQZSKpkF?= =?us-ascii?Q?MJ3KQW6GdEwnbQs+aXTRgBGovcAlEaf8KjfwgKF4B1vTGDuHu/zS6pgCpRCD?= =?us-ascii?Q?NNFhalcf17KOMI2nM2g3JCzw2R5vz1DCDHyPBPlgmwycyJpPuUTNXL8YG5oV?= =?us-ascii?Q?SvTCHNV4n6G9Z7A+6XLZesH7md0pB0WqHRLqzEsR9LXOQfJ++AzV3bXu+PXI?= =?us-ascii?Q?UrCplpNqZEQm0IRP+udgCxkRFqEkbDuCqH4c21PJeSxwHE1B9GMYvDraHOw0?= =?us-ascii?Q?yXtm7yRHpVKCjlSEOYxkj0Oc?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR18MB4785.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PNbQU9EC3CCNRc7Z9I3of/nUSUf25cVJ6Pu/XxhoS1ZLxZBNBk2+iXhImMjk?= =?us-ascii?Q?aaJpkDKlWh7tIGOSanyyqycRmx6mKiEe5yCDPW+tVPQ1vxi3M8X762Yap5Nd?= =?us-ascii?Q?eotbF1z9vJDXrL2GfNAJKRvSrYoDSIEheYh5VX/cydQ1jCDS9U3eoU9yrwjX?= =?us-ascii?Q?u+BvX3p+lCRMTwLQkkmGul6kMokkio0dZPxKTb73YS3sE69HUqIatJbAdD/M?= =?us-ascii?Q?pkP8ZzT0z6ceLgr2VAZY6bz0IktGwjG0E8oggpDmdakz08fi3LcL2jjDXbZb?= =?us-ascii?Q?vN/dM8slszhO76ZhEVGnWVx7FdOPVxZpH0C31p/OTCLFyz91U+LBsAz1flpb?= =?us-ascii?Q?HViIeddY/bqUOwe6BLzvfbSduGo3k2EbzIfOPtQwywnVBetOev1EXH+kE/By?= =?us-ascii?Q?Z20MVGqgDMPlAQ4Ub7RH/YuuXCJDEZE1iompw5kmRS6fvLMcDaVcnGkjpDqE?= =?us-ascii?Q?y3wS+kY4zW9CaXnRmvfrWWoG9OmA/rSV5GdX3/yr0Xlo5rnHImGDm/I5OIkf?= =?us-ascii?Q?QLVhSgDOwIpcqqI89oeRuu7Enelcrpx4m6YWA9Uv/GglJqFClUAB3zy0dlCB?= =?us-ascii?Q?qWVDmb8mLEPwa6CUCLwc6efiSFGyI+jI6VVS0iA0QUzQH/4F/J2s1MYjOj0V?= =?us-ascii?Q?VMqgOXmgDtyYc5v07OdS050OgGJzvXO5kPsxM2LblQnj4Fo4UbubRw2v5HRt?= =?us-ascii?Q?mWGY+cc5/Lkan1m8hqAOm3KarK5V4NtACTUYghKXnWx5hG0nTylTjYfO0En4?= =?us-ascii?Q?kpnYD1o+msdVy49FBozs522GvKjhNVDChbYUiFcK9b51spq4NZUM/pNjV0k7?= =?us-ascii?Q?4MGGODkaxrZc5HQJ6f+6PDoupRjgRUy6HDsACuto6S1x2lPDvM1/HYwcwBSY?= =?us-ascii?Q?Fh64vdDar7WKHrE8iXzgWKAXbT6ebI3Gk1HI6js1a9l+5qygxe0eL9CbQGvY?= =?us-ascii?Q?te8RxFCK3wubyETGZAyQKG7elY9kETQdxUcqFm/9RiMhol/YxJgwXl5kYXi9?= =?us-ascii?Q?6a+NUpDWQOn0XLaJXAEoBjk9SIpl+dksaesPorc25+62Vv9QbbHILLIMY/g/?= =?us-ascii?Q?7Afj8HTjk2X3VhERUCqjCwqPhHHYOwX0tXnU52GwFMNGZLVDhk4bYgLEa5Lj?= =?us-ascii?Q?nybruDPYy17laEnFL1SElcN/+wL1HwNTDeTpwlJ6MG3gydKIu/Ycechuxb0/?= =?us-ascii?Q?iVKoXZgpV25km0W9xUePrztb3ARq7BQO/++jMQV35eyEiPOyZGIxFdfydXxY?= =?us-ascii?Q?GbDQTf/NsB3S/J8+Usc78ZC07yAEmvC5qJ8BUFJj9NSqCWmwMeekbiTVwJYJ?= =?us-ascii?Q?OCUWLp+1LSFsH3OCq2bJH/SuNKPPatRxuCHW8p04pMEXbmDQMXFAHN/5L816?= =?us-ascii?Q?7dTwAmRMmaM4XwySjjdqKvcjCxqmcNcDLeEDCh8wR030d/Fu6dyy7r5RQFsZ?= =?us-ascii?Q?L0WT79bcRrFBClEQv3dPTGjaQysmMc+/5d0hNbGgaALtjNXkvdISCefVqWeU?= =?us-ascii?Q?uUMuQy3lgsGHxLmJprPjdIr/fhrtGSKMrHfkB7VLBrYMAqK3ZB+YwtUv8+Hi?= =?us-ascii?Q?fxHvEGwjHMjoy5i5oUQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4785.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7f62fa7-5fb4-40af-ca26-08dd0493e74d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2024 10:05:44.3650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y4hyEKmB9Y4t6n1SFKuxR+38+mH1A6+O5Ho0krbuFP3CrhGSdnH9jjkaVrBJkm+RCHISOfeEcLFxpD+bUEOeBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2PR18MB5850 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ieUEsLiW2K7houS1y9sML-o5BlgSAAv6 X-Proofpoint-ORIG-GUID: ieUEsLiW2K7houS1y9sML-o5BlgSAAv6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huichao Cai > Sent: Thursday, November 14, 2024 2:15 PM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; yanzhirun_163@163.com > Cc: dev@dpdk.org > Subject: [EXTERNAL] [PATCH v4 2/2] graph: add alignment to the member of > rte_node >=20 > The members dispatch and xstat_off of the structure rte_node can be min c= ache > aligned to make room for future expansion and to make sure have better > performance. Add corresponding comments. Due to the modification of the > alignment of some members=20 > The members dispatch and xstat_off of the structure rte_node can be min c= ache > aligned to make room for future expansion and to make sure have better > performance. Add corresponding comments. >=20 Please change subject to graph: improve node layout > Due to the modification of the alignment of some members of the rte_node > structure, update file release_24_11.rst. The above section is not needed. >=20 > Signed-off-by: Huichao Cai > --- > doc/guides/rel_notes/release_24_11.rst | 3 +++ > lib/graph/rte_graph_worker_common.h | 7 ++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/release_24_11.rst > b/doc/guides/rel_notes/release_24_11.rst > index 592116b979..6903b1d0f0 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -425,6 +425,9 @@ ABI Changes >=20 > * graph: added ``graph`` field to the ``dispatch`` structure in the ``rt= e_node`` > structure. >=20 > +* graph: The members ``dispatch`` and ``xstat_off`` of the structure > +``rte_node`` have been > + marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned. > + > Known Issues > ------------ >=20 > diff --git a/lib/graph/rte_graph_worker_common.h > b/lib/graph/rte_graph_worker_common.h > index 4c2432b47f..d36abec08b 100644 > --- a/lib/graph/rte_graph_worker_common.h > +++ b/lib/graph/rte_graph_worker_common.h > @@ -104,16 +104,21 @@ struct __rte_cache_aligned rte_node { > /** Original process function when pcap is enabled. */ > rte_node_process_t original_process; >=20 > + /** Fast path area cache line 1. */ Fast schedule area for mcore dispatch model > union { > /* Fast schedule area for mcore dispatch model */ Above comment you can remove it > - struct { > + alignas(RTE_CACHE_LINE_MIN_SIZE) struct { > unsigned int lcore_id; /**< Node running lcore. */ > uint64_t total_sched_objs; /**< Number of objects > scheduled. */ > uint64_t total_sched_fail; /**< Number of scheduled > failure. */ > struct rte_graph *graph; /**< Graph corresponding to > lcore_id. */ > } dispatch; > }; > + > + /** Fast path area cache line 2. */ > + alignas(RTE_CACHE_LINE_MIN_SIZE) > rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > + > /* Fast path area */ Fast path area cache line 1 > __extension__ struct __rte_cache_aligned { #define RTE_NODE_CTX_SZ > 16 With above: Acked-by: Jerin Jacob Looks loke we cannot merge new feature in rc3. I would suggest skip 1/2 and= send only this patch so that 1/2 can merged in next release. Please add @david.marchand@redhat.com in Cc.