From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct
Date: Fri, 16 Jul 2021 06:27:37 +0000 [thread overview]
Message-ID: <BY5PR11MB40556285E93C5DB63BF4A4E09C119@BY5PR11MB4055.namprd11.prod.outlook.com> (raw)
In-Reply-To: <e142db30990b40d2a9ca6b1e2fa2826e@intel.com>
Hi Jiayu,
> -----Original Message-----
> From: Hu, Jiayu <jiayu.hu@intel.com>
> Sent: Friday, July 16, 2021 2:18 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; dev@dpdk.org
> Cc: maxime.coquelin@redhat.com
> Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct
>
> Thanks Chenbo for your comments.
>
> Replies are inline.
>
> > -----Original Message-----
> > From: Xia, Chenbo <chenbo.xia@intel.com>
> > Sent: Friday, July 16, 2021 2:03 PM
> > To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org
> > Cc: maxime.coquelin@redhat.com
> > Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct
> >
> > Hi Jiayu,
> >
> > > -----Original Message-----
> > > From: Hu, Jiayu <jiayu.hu@intel.com>
> > > Sent: Tuesday, July 13, 2021 3:46 PM
> > > To: dev@dpdk.org
> > > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> > > Hu, Jiayu <jiayu.hu@intel.com>
> > > Subject: [PATCH v4 2/3] vhost: rework async configuration struct
> >
> > Struct -> structure
> >
> > >
> > > This patch reworks the async configuration structure to improve code
> > > readability. In addition, add preserved padding fields on the
> > > structure for future usage.
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > > ---
> > > doc/guides/prog_guide/vhost_lib.rst | 19 +++++++++++--------
> > > examples/vhost/main.c | 8 ++++----
> > > lib/vhost/rte_vhost_async.h | 35 +++++++++++++++++---------------
> ---
> > > lib/vhost/vhost.c | 13 +++++--------
> > > 4 files changed, 37 insertions(+), 38 deletions(-)
> > >
[snip]
> > > -vq->async_inorder = f.async_inorder;
> > > -vq->async_threshold = f.async_threshold;
> > > +vq->async_inorder = true;
> >
> > Do we still need this? It's never used.
>
> I think we need to keep it, as we may support out-of-order channel in future.
We don't like to define things when it's not needed currently. If in future,
the definition should also be made in future :P. Just leave the definition
to future patch.
Thanks,
Chenbo
>
> >
> > > +vq->async_threshold = config.async_threshold;
> >
> > vq->async_threshold is uint16_t and config.async_threshold is uint32_t.
> > They should be the same.
>
> I will change vq->async_threshold to uint32_t.
>
> Thanks,
> Jiayu
> >
> > Thanks,
> > Chenbo
> >
> > >
> > > vq->async_registered = true;
> > >
> > > --
> > > 2.7.4
> >
>
next prev parent reply other threads:[~2021-07-16 6:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 8:11 [dpdk-dev] [PATCH 0/2] provide thread unsafe async registration functions Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 1/2] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-02 7:36 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-20 7:18 ` Maxime Coquelin
2021-07-20 7:45 ` Hu, Jiayu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-20 7:25 ` Maxime Coquelin
2021-07-21 6:16 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Xia, Chenbo
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-19 2:25 ` Xia, Chenbo
2021-07-19 7:20 ` Maxime Coquelin
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-19 2:27 ` Xia, Chenbo
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-16 6:03 ` Xia, Chenbo
2021-07-16 6:18 ` Hu, Jiayu
2021-07-16 6:27 ` Xia, Chenbo [this message]
2021-07-16 6:34 ` Hu, Jiayu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-16 6:54 ` Xia, Chenbo
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 2/3] vhost: rework async feature struct Jiayu Hu
2021-07-07 6:39 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions Jiayu Hu
2021-07-02 7:40 ` Maxime Coquelin
2021-07-05 1:35 ` Hu, Jiayu
2021-07-05 8:58 ` Maxime Coquelin
2021-07-06 8:36 ` Hu, Jiayu
2021-06-04 7:18 ` [dpdk-dev] [PATCH 0/2] provide " Maxime Coquelin
2021-06-04 7:24 ` Maxime Coquelin
2021-06-07 8:07 ` Hu, Jiayu
2021-06-07 13:20 ` Maxime Coquelin
2021-06-08 6:36 ` Hu, Jiayu
2021-06-29 5:36 ` Hu, Jiayu
2021-07-01 15:42 ` Maxime Coquelin
2021-07-02 0:53 ` Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB40556285E93C5DB63BF4A4E09C119@BY5PR11MB4055.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).