From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/vhost: remove dequeue zero-copy support
Date: Mon, 28 Sep 2020 11:07:58 +0000 [thread overview]
Message-ID: <BY5PR11MB40557C791C379444468C4AD79C350@BY5PR11MB4055.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200928091712.7946-2-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Monday, September 28, 2020 5:17 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 1/4] net/vhost: remove dequeue zero-copy support
>
> The dequeue zero-copy feature from the Vhost library is
> being removed in this release, this patch remove its support
> in the Vhost PMD.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c
> b/drivers/net/vhost/rte_eth_vhost.c
> index ce32be9ce3..5a39293083 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -29,7 +29,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
> #define ETH_VHOST_IFACE_ARG "iface"
> #define ETH_VHOST_QUEUES_ARG "queues"
> #define ETH_VHOST_CLIENT_ARG "client"
> -#define ETH_VHOST_DEQUEUE_ZERO_COPY "dequeue-zero-copy"
> #define ETH_VHOST_IOMMU_SUPPORT "iommu-support"
> #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support"
> #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso"
> @@ -41,7 +40,6 @@ static const char *valid_arguments[] = {
> ETH_VHOST_IFACE_ARG,
> ETH_VHOST_QUEUES_ARG,
> ETH_VHOST_CLIENT_ARG,
> - ETH_VHOST_DEQUEUE_ZERO_COPY,
> ETH_VHOST_IOMMU_SUPPORT,
> ETH_VHOST_POSTCOPY_SUPPORT,
> ETH_VHOST_VIRTIO_NET_F_HOST_TSO,
> @@ -1501,7 +1499,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
> uint64_t flags = 0;
> uint64_t disable_flags = 0;
> int client_mode = 0;
> - int dequeue_zero_copy = 0;
> int iommu_support = 0;
> int postcopy_support = 0;
> int tso = 0;
> @@ -1561,16 +1558,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
> flags |= RTE_VHOST_USER_CLIENT;
> }
>
> - if (rte_kvargs_count(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY) == 1) {
> - ret = rte_kvargs_process(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY,
> - &open_int, &dequeue_zero_copy);
> - if (ret < 0)
> - goto out_free;
> -
> - if (dequeue_zero_copy)
> - flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
> - }
> -
> if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) {
> ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT,
> &open_int, &iommu_support);
> @@ -1674,7 +1661,6 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vhost,
> "iface=<ifc> "
> "queues=<int> "
> "client=<0|1> "
> - "dequeue-zero-copy=<0|1> "
> "iommu-support=<0|1> "
> "postcopy-support=<0|1> "
> "tso=<0|1> "
> --
> 2.26.2
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2020-09-28 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:17 [dpdk-dev] [PATCH v2 0/4] vhost: " Maxime Coquelin
2020-09-28 9:17 ` [dpdk-dev] [PATCH v2 1/4] net/vhost: " Maxime Coquelin
2020-09-28 11:07 ` Xia, Chenbo [this message]
2020-09-28 9:17 ` [dpdk-dev] [PATCH v2 2/4] examples/vhost_crypto: use vhost async-copy flag Maxime Coquelin
2020-09-28 9:17 ` [dpdk-dev] [PATCH v2 3/4] examples/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-28 9:17 ` [dpdk-dev] [PATCH v2 4/4] vhost: " Maxime Coquelin
2020-09-28 11:14 ` Xia, Chenbo
2020-09-30 16:21 ` [dpdk-dev] [PATCH v2 0/4] " Maxime Coquelin
2020-09-30 20:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB40557C791C379444468C4AD79C350@BY5PR11MB4055.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).