From: "Maslekar, Omkar" <omkar.maslekar@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Loftus, Ciara" <ciara.loftus@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] eal: add cache-line demote support
Date: Tue, 22 Sep 2020 21:53:25 +0000 [thread overview]
Message-ID: <BY5PR11MB42282B28E9812BBC2624E634953B0@BY5PR11MB4228.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200922082801.GA1604@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
My comments are inline
>-----Original Message-----
>From: Bruce Richardson <bruce.richardson@intel.com>
>Sent: Tuesday, September 22, 2020 1:28 AM
>To: Maslekar, Omkar <omkar.maslekar@intel.com>
>Cc: dev@dpdk.org; Loftus, Ciara <ciara.loftus@intel.com>
>Subject: Re: [PATCH v4] eal: add cache-line demote support
>
>On Mon, Sep 21, 2020 at 06:59:27PM -0700, Omkar Maslekar wrote:
>> rte_cldemote is similar to a prefetch hint - in reverse.
>> cldemote(addr) enables software to hint to hardware that line is likely to be
>shared.
>> Useful in core-to-core communications where cache-line is likely to be
>> shared. ARM and PPC implementation is provided with NOP and can be
>> added if any equivalent instructions could be used for implementation
>> on those architectures.
>>
>> Signed-off-by: Omkar Maslekar <omkar.maslekar@intel.com>
>>
>Few minor suggestions below. With those fixed, feel free to add my ack to
>future versions of this patch.
>
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
>> ---
>> v4: updated bold text for title and fixed margin in release notes
>> *
>> v3: fixed warning regarding whitespace
>> *
>> v2: documentation updated
>> ---
>> ---
>> doc/guides/rel_notes/release_20_11.rst | 6 ++++++
>> lib/librte_eal/arm/include/rte_prefetch_32.h | 5 +++++
>> lib/librte_eal/arm/include/rte_prefetch_64.h | 5 +++++
>> lib/librte_eal/include/generic/rte_prefetch.h | 13 +++++++++++++
>> lib/librte_eal/ppc/include/rte_prefetch.h | 5 +++++
>> lib/librte_eal/x86/include/rte_prefetch.h | 9 +++++++++
>> 6 files changed, 43 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/release_20_11.rst
>> b/doc/guides/rel_notes/release_20_11.rst
>> index df227a1..b844b96 100644
>> --- a/doc/guides/rel_notes/release_20_11.rst
>> +++ b/doc/guides/rel_notes/release_20_11.rst
>> @@ -55,6 +55,12 @@ New Features
>> Also, make sure to start the actual text at the margin.
>> =======================================================
>>
>> +* **Added new function rte_cldemote in rte_prefetch.h.**
>> +
>> + Added a hardware hint CLDEMOTE, which is similar to prefetch in
>reverse.
>> + CLDEMOTE moves the cache line to the more remote cache, where it
>> + expects sharing to be efficient. Moving the cache line to a level
>> + more distant from the processor helps to accelerate core-to-core
>communication.
>>
>
>I think you need two blank lines between sections here, not just one.
[om] you are right, I will fix in v5.
>
>> Removed Items
>> -------------
>> diff --git a/lib/librte_eal/arm/include/rte_prefetch_32.h
>> b/lib/librte_eal/arm/include/rte_prefetch_32.h
>> index e53420a..ad91edd 100644
>> --- a/lib/librte_eal/arm/include/rte_prefetch_32.h
>> +++ b/lib/librte_eal/arm/include/rte_prefetch_32.h
>> @@ -33,6 +33,11 @@ static inline void rte_prefetch_non_temporal(const
>volatile void *p)
>> rte_prefetch0(p);
>> }
>>
>> +static inline void rte_cldemote(const volatile void *p) {
>> + RTE_SET_USED(p);
>> +}
>> +
>> #ifdef __cplusplus
>> }
>> #endif
>> diff --git a/lib/librte_eal/arm/include/rte_prefetch_64.h
>> b/lib/librte_eal/arm/include/rte_prefetch_64.h
>> index fc2b391..35d278a 100644
>> --- a/lib/librte_eal/arm/include/rte_prefetch_64.h
>> +++ b/lib/librte_eal/arm/include/rte_prefetch_64.h
>> @@ -32,6 +32,11 @@ static inline void rte_prefetch_non_temporal(const
>volatile void *p)
>> asm volatile ("PRFM PLDL1STRM, [%0]" : : "r" (p)); }
>>
>> +static inline void rte_cldemote(const volatile void *p) {
>> + RTE_SET_USED(p);
>> +}
>> +
>> #ifdef __cplusplus
>> }
>> #endif
>> diff --git a/lib/librte_eal/include/generic/rte_prefetch.h
>> b/lib/librte_eal/include/generic/rte_prefetch.h
>> index 6e47bdf..8742412 100644
>> --- a/lib/librte_eal/include/generic/rte_prefetch.h
>> +++ b/lib/librte_eal/include/generic/rte_prefetch.h
>> @@ -51,4 +51,17 @@
>> */
>> static inline void rte_prefetch_non_temporal(const volatile void *p);
>>
>> +/**
>> + * Demote a cache line to a more distant level of cache from the
>processor.
>> + *
>> + * CLDEMOTE hints to hardware to move (demote) a cache line from the
>> +closest to
>> + * the processor to a level more distant from the processor. It is a
>> +hint and
>> + * not guarantee. rte_cldemote is intended to speed up things at the
>> +producer,
>> + * in the producer-consumer case.
>> + *
>
>Two thoughts here:
>1. Is it not more the consumer who benefits more since they are the ones
>receiving the demoted value, while the producer pays a higher cost since
>they have to demote the value on send?
[OM] CLDEMOTE benefits the consumer. My statement "speed up things at the producer" indicate proximity where the distance is reduced.
But I will make it simple and more readable.
>2. Rather than talking about producer consumer case specifically, I think it
>would be good to replace the last sentence with what you have in the cover
>letter about it being for sharing, and to indicate that a line may be accessed
>by a different core in the future.
[OM] Good point, there could be many other cores that can benefit instead of just a single consumer. I will update this.
>
>> + * @param p
>> + * Address to demote
>> + */
>> +static inline void rte_cldemote(const volatile void *p);
>> +
>> #endif /* _RTE_PREFETCH_H_ */
>> diff --git a/lib/librte_eal/ppc/include/rte_prefetch.h
>> b/lib/librte_eal/ppc/include/rte_prefetch.h
>> index 9ba07c8..3fe9655 100644
>> --- a/lib/librte_eal/ppc/include/rte_prefetch.h
>> +++ b/lib/librte_eal/ppc/include/rte_prefetch.h
>> @@ -34,6 +34,11 @@ static inline void rte_prefetch_non_temporal(const
>volatile void *p)
>> rte_prefetch0(p);
>> }
>>
>> +static inline void rte_cldemote(const volatile void *p) {
>> + RTE_SET_USED(p);
>> +}
>> +
>> #ifdef __cplusplus
>> }
>> #endif
>> diff --git a/lib/librte_eal/x86/include/rte_prefetch.h
>> b/lib/librte_eal/x86/include/rte_prefetch.h
>> index 384c6b3..029d06e 100644
>> --- a/lib/librte_eal/x86/include/rte_prefetch.h
>> +++ b/lib/librte_eal/x86/include/rte_prefetch.h
>> @@ -32,6 +32,15 @@ static inline void rte_prefetch_non_temporal(const
>volatile void *p)
>> asm volatile ("prefetchnta %[p]" : : [p] "m" (*(const volatile char
>> *)p)); }
>>
>> +/*
>> + * we're using raw byte codes for now as only the newest compiler
>> + * versions support this instruction natively.
>> + */
>> +static inline void rte_cldemote(const volatile void *p) {
>> + asm volatile(".byte 0x0f, 0x1c, 0x06" :: "S" (p)); }
>> +
>> #ifdef __cplusplus
>> }
>> #endif
>> --
>> 1.8.3.1
>>
next prev parent reply other threads:[~2020-09-22 21:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:16 [dpdk-dev] [PATCH] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h Omkar Maslekar
2020-09-10 1:16 ` Omkar Maslekar
2020-09-10 8:55 ` Bruce Richardson
2020-09-10 23:30 ` Maslekar, Omkar
2020-09-10 22:04 ` David Christensen
2020-09-11 16:51 ` [dpdk-dev] [PATCH v2] " Omkar Maslekar
2020-09-11 16:51 ` Omkar Maslekar
2020-09-11 21:22 ` [dpdk-dev] [PATCH v3] " Omkar Maslekar
2020-09-11 21:22 ` Omkar Maslekar
2020-09-22 1:59 ` [dpdk-dev] [PATCH v4] eal: add cache-line demote support Omkar Maslekar
2020-09-22 1:59 ` Omkar Maslekar
2020-09-22 8:28 ` Bruce Richardson
2020-09-22 21:53 ` Maslekar, Omkar [this message]
2020-10-01 0:28 ` [dpdk-dev] [PATCH v5] " Omkar Maslekar
2020-10-01 0:28 ` Omkar Maslekar
2020-10-08 7:09 ` David Marchand
2020-10-08 9:02 ` Bruce Richardson
2020-10-12 9:41 ` David Marchand
2020-10-08 13:12 ` Jerin Jacob
2020-10-12 10:19 ` [dpdk-dev] [PATCH v6] " Omkar Maslekar
2020-10-12 10:19 ` Omkar Maslekar
2020-10-12 19:31 ` David Christensen
2020-10-13 2:59 ` Ruifeng Wang
2020-10-13 16:20 ` Bruce Richardson
2020-10-14 1:55 ` Ruifeng Wang
2020-10-14 7:14 ` David Marchand
2020-10-14 7:51 ` Ruifeng Wang
2020-10-13 9:43 ` [dpdk-dev] [PATCH v7] " Omkar Maslekar
2020-10-13 9:43 ` Omkar Maslekar
2020-10-14 7:24 ` Ruifeng Wang
2020-10-15 8:01 ` David Marchand
2020-10-15 14:41 ` Maslekar, Omkar
2020-10-15 20:32 ` David Marchand
2020-10-15 15:18 ` [dpdk-dev] [PATCH v8] " Omkar Maslekar
2020-10-15 15:18 ` Omkar Maslekar
2020-10-15 23:20 ` [dpdk-dev] [PATCH v9] " Omkar Maslekar
2020-10-15 23:20 ` Omkar Maslekar
2020-10-16 12:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB42282B28E9812BBC2624E634953B0@BY5PR11MB4228.namprd11.prod.outlook.com \
--to=omkar.maslekar@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).