From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B239A3295 for ; Wed, 23 Oct 2019 16:47:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12F8B1C2B5; Wed, 23 Oct 2019 16:47:45 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9ECBB1C25E; Wed, 23 Oct 2019 16:47:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 07:47:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="209935433" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga001.fm.intel.com with ESMTP; 23 Oct 2019 07:47:41 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 23 Oct 2019 07:47:41 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Oct 2019 07:47:40 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Oct 2019 07:47:40 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 23 Oct 2019 07:47:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXwaCmYVu9eU1ef4X36yIwzAqt4GwE9thJMzawtHy38z2uNkiLQaobpzD0JQT+9U3vHrTq9axjlp+QIfXZeaqoO6u/RvTsyNzTzl6cqgpT2dcnHv7WKn5CuZJNcuxe1AJAbLffGjE8zZARWZRQmbVOdyXV4fah0KU0gCHxtBMQzVQuiGgkSEM4XHrvNNvF7JciDc0ARrp+tmxEuBHsK9CgCklKhp7MTXDL7k2gAhHFRVGUqGDhbxRV4NtgpfxzojwrLlcLyaZIZqYi8yOdTXIFhd3/BY8pqRoNPLl/ySs7DFF9B4cj54h4eHeOnDUa6+tzI1Y9W3ngva7UpOzj5bcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1eOY4sUOk4ceurqdekvbJdkyrOwDAbgMtnhwaHTE+fA=; b=YFC3MApghfPhPF8iOmmNp9tOS5xVtZ3YCmx3Ki/+Iw7+l1PJ18wXGSjwykV8MKx7gMYQ7zu/skvbMuCCoABFyDXy59SwU11XhvpRqmLnO6X241dWoDo+/d8lxx7kABlP5rstEX6UWWK8amCFugaFv4RfXHpjWV859cW3ATSgwgHXLGroVSse3QCDSOsmP45R9aUi0u7LyPvJBF2ZIKOs0xqaNRKDghx1jc53Kr1u45aoJSMTMeyB8/RSLjXv2We2Hf71cyeLeO23Ft3z/arZLAl/VyCX0M5uIFPOSwW9E40bd5LVzV1Rxp8f6XHzJpCLVpP6fvdbPp59qeDXNgM+eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1eOY4sUOk4ceurqdekvbJdkyrOwDAbgMtnhwaHTE+fA=; b=oBVzyTb+l5WilDBu+9ICxKOToSTeJqhhJeHBwtFf8BIKUgXGOwUmhZd7VjeEW3pr4Mqtl/PitOSyzIBv+QLV0B1x3gEjlDg7m7XA1S3CR0G7cxqqxomRUMc87sNWAZDdR7UvYEBdwdjZc5tpYmCcnbQYZ4iHKjDXw24Uh9kqxRA= Received: from BY5PR11MB4308.namprd11.prod.outlook.com (52.132.252.19) by BY5PR11MB4498.namprd11.prod.outlook.com (52.132.254.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 23 Oct 2019 14:47:34 +0000 Received: from BY5PR11MB4308.namprd11.prod.outlook.com ([fe80::b523:91cd:304d:cf61]) by BY5PR11MB4308.namprd11.prod.outlook.com ([fe80::b523:91cd:304d:cf61%6]) with mapi id 15.20.2367.022; Wed, 23 Oct 2019 14:47:34 +0000 From: "Power, Ciara" To: Thomas Monjalon CC: "Yigit, Ferruh" , "arybchenko@solarflare.com" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "stable@dpdk.org" Thread-Topic: [PATCH] ethdev: fix include for ether header file Thread-Index: AQHViaFEGvA1g4E1jkWNwrwY4RJDtqdoQX8AgAALNIA= Date: Wed, 23 Oct 2019 14:47:34 +0000 Message-ID: References: <20191023125300.45569-1-ciara.power@intel.com> <1705631.EIreq0Hp37@xps> In-Reply-To: <1705631.EIreq0Hp37@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmU3MmNjYWUtNDNhMC00NTRiLTg4MGQtMGU3MjY5N2ZlYjg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidllWYzZhVlFsSDU4K2UrZlhJTm83YkVBTHpmSjZqSElrRFY5TXZZNXRqcmJBMnZCNDM2WUQzMTNnRDFNaVZKOCJ9 dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=ciara.power@intel.com; x-originating-ip: [192.198.151.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 552857ee-fc0a-4acf-79c2-08d757c7f0e4 x-ms-traffictypediagnostic: BY5PR11MB4498: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(366004)(39860400002)(346002)(376002)(189003)(199004)(13464003)(102836004)(26005)(6246003)(64756008)(446003)(66946007)(14454004)(25786009)(66476007)(476003)(486006)(66446008)(66556008)(76116006)(66066001)(52536014)(4326008)(316002)(74316002)(5660300002)(7736002)(11346002)(8936002)(54906003)(305945005)(6916009)(478600001)(71190400001)(71200400001)(256004)(81156014)(81166006)(186003)(8676002)(33656002)(3846002)(6116002)(86362001)(229853002)(6436002)(99286004)(7696005)(55016002)(9686003)(6506007)(53546011)(76176011)(2906002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY5PR11MB4498; H:BY5PR11MB4308.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +T5sMG4A0YIXFsyHsGKLKTHiqs/2GzO6Yfh2GmiZlnhEso+ADssSrW03ZThacsabtVGEv/sM6YSENiZqnNqBRs8+ibXmw6z/9BVIe3u8SUmAU+SBPY4hKTmiN62TyM49gYCEtYZYpOzDjtQDslcE83rZoq8N4LnGLDFzzbS22hANC8ouT5rvdRc9/Eua46qqhyQ0NfT0DC1YUfD+/tdjuMn4ybyQfV8jO/QZVPj1wuXLN0Hlm/iFVEs8Ixwqf0PpDcxhE1Hsw7ylLwot9c4JHQtwoJDnMzIcEBCHS7KRyo6BSkI+4Ao0yDe9pb9jWeD0ycroq+HcYOStdU0c6jQgGiqwi0ZrbPH7lQg/NfxeI7QWaO6PoQLBBacgG3C+3AGx6vLXJTO9/RpUI2M4ShWCEgqu1j/vnaiAtxAsixQ5r443fXlneU35e2RKHanKBox2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 552857ee-fc0a-4acf-79c2-08d757c7f0e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 14:47:34.6558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 167Ia2ldNSVz3HZa4CU7e7i0OOFTo96It2ZIxxxe+G/kU53iUf1KtCb9xDVK5xeTLEK/JhhJaRLS/3Tj50QVPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4498 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: fix include for ether header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday 23 October 2019 15:02 > To: Power, Ciara > Cc: Yigit, Ferruh ; arybchenko@solarflare.com; > dev@dpdk.org; olivier.matz@6wind.com; stable@dpdk.org > Subject: Re: [PATCH] ethdev: fix include for ether header file >=20 > 23/10/2019 14:53, Ciara Power: > > The include for rte_ether.h in each of these files should not use > > quotes, as the header file is not in the librte_ethdev directory. > > These are now updated to use <> symbols, to search directories > > pre-designated by the compiler. > > > > Fixes: 57668ed7bc08 ("net: move ethernet definitions to the net > > library") > > Cc: olivier.matz@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ciara Power > > --- > > lib/librte_ethdev/rte_eth_ctrl.h | 2 +- > > lib/librte_ethdev/rte_ethdev.c | 2 +- > > lib/librte_ethdev/rte_ethdev.h | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > Good change. > Acked-by: Thomas Monjalon >=20 > I'm curious, is it triggering any compilation issue? >=20 Hi Thomas, No not that I'm aware, it's not triggering issues on our internal CI builds= , and I haven't seen any issues using meson or make.