From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F534A00C3; Fri, 17 Jun 2022 18:53:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7391410E7; Fri, 17 Jun 2022 18:53:28 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 40B4D40F19; Fri, 17 Jun 2022 18:53:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655484807; x=1687020807; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s7dFVDpb8k4Kwrrwqn3ywkuOMTC0wxl1Z1K0IPWrmOg=; b=OaVzQ6pya96az6ZbKkdltOax4T36zkjQ558ZfrxzWzPhFVsuWG/x4Shb qGjbD+bmwtgWb8eNWzQEOC7FzKc5JufBqoZcGdowobeXZ2EEs+MjbYOff lwqxVgrWZ4DjlyyxvG6PjBActLLCZ6QbNaDWr5j3vmG/QgAPU9WKJTK/0 RrzQ81VeUyyifUsNX4kcdo8nJNbj1c2EY/L0vaXIITq0i5oLboD/vqse4 okKDXWJB/NyjpoRRu8K9+XO8o4sqw4NXDOZ1eiybzodtdHZM9xjIR7Xw8 7juDulzTt5wKQkVnt93mOO5RFCcyhcgkjxzDZnrJk3BNpNvnXSNHCOMY5 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="268229854" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="268229854" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 09:12:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="728386229" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 17 Jun 2022 09:12:24 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 09:12:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 09:12:24 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 09:12:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZcnq8lyo0CSzl5zO3sZ0jOL+TKKvqnqqjcZbYhW9ASPRM1dkirvYYm8gjPfknTcxFDoic3ehO0kVd1bdkBx1JN7CaCLIL7qbHzzpw9FimQ5508NSpbdW4Enxu/dxKE1XI0+/rRxuvykqc14V6UYf6tdJl3TgNWmZ9t+lIaiNvHtr1UOFRmjlX8brQ7/LrTo+KfSsnZ/0keMPbXZcJhQnMA8CQh/hX9bY0wtR2Dic1K7NdS/R3zPjuZg3napAph6o9JFJk7+h8EWo0AeJEBoaeDnzgSmy8f87v/ILKZgR9ioLGNboCEHKy4mDo7wij45OZ7Vg7UJfKf6pZ3zyohrLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uyNuQKJvLQNHenHEjziZY4/eUScABdPdpdyd3LfntHk=; b=IhrMCp6RjqfmuxWb6X8hsWb/nT7iIv9nL2jQXErfNlwnF79JlR9dqMlqi9eWffobCekqgXFzekDGPWi+n4ItFpzXhM0cn/j3JfHrBdSeGKF1o91437H9HSgYSJTdG/e6h4JA6WN/01FvdcqQxl32bT1l/3V77k4cQZhNNtvJpJ0ZJOcZfUuH/u0ZPtp5xbQLZdurYswyuK0PIR8TbdSNT407RrbDwAiqepSQ5w85UW130aaXhdS5FgdfkMBkTnrqGzlEyHWsCF2eD46uCoCM4G3DSkJ7EVo2PAzH/fUx8WJM5XJEK8r3ikGulsh3rg6MzqBeuJLEAWJcd56SuBROwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by CY4PR1101MB2264.namprd11.prod.outlook.com (2603:10b6:910:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.19; Fri, 17 Jun 2022 16:12:22 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069%6]) with mapi id 15.20.5353.018; Fri, 17 Jun 2022 16:12:22 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "techboard@dpdk.org" Subject: RE: [PATCH v1] bbdev: allow operation type enum for growth Thread-Topic: [PATCH v1] bbdev: allow operation type enum for growth Thread-Index: AQHYf1Ru213M4cswzk+hiLnE85rzMq1NpwGAgAWg2wCAAIGJAA== Date: Fri, 17 Jun 2022 16:12:22 +0000 Message-ID: References: <1655144675-14363-1-git-send-email-nicolas.chautru@intel.com> <1655144675-14363-2-git-send-email-nicolas.chautru@intel.com> <6579285.Sb9uPGUboI@thomas> In-Reply-To: <6579285.Sb9uPGUboI@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c64faafd-5d14-40e6-ea82-08da507c2945 x-ms-traffictypediagnostic: CY4PR1101MB2264:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tyDqLy0RQzmi+rciE/GMM4nJ4kHIw/x1EA7IfA8wnQqnZxrq19sKJAj1wdFjmIcOhsANaaWVqO9lmw+m0O8WRr1i2p2Ntpnv8cZ5CrschpQ46KWoO179RpGRqjvFw5DBqsx+XpWmcW4EOCuV/9tDmXZ8PbMfTkuewf/85BUalsIjogOnar+LNeGBp05xYBjMchy5SjhvEov//on7ZLOcos5eZeM8mHe3P66LUU5qOGe0eEBUqqDlmSl0Y8YghCbpHCr8QlLfGfJMPjNqAWkLnOJSoSdfWHVghOF3o88eBmzTKP+GiGJzw1KF1Ao0X9ihaibUbzTY8tntOR/FuV+etc6hVvxGMQQfmMW+l9de1j6a2ap9AjAj6hT+Veepjle3spl9Dwms0HPQkXfJAVqiXygob0jkllJsSvx0QLVR2XkB4wBfq2AfXwD6AHiHAsMftRNbodzs7gIsYq8mDvPwXUGzFv13oRQbtG3e2atBHz1TBSr8V+JYm0tnddi8Z2gGhU9vztw6rnWsbeG5W8tIXqCAUWiOqZS+80SECBP881ibYm+7MUkPx9fnagAF/8YSKToIIXxRfrPX/e+ifXCM+O2AX01d8UNzyt94ZEd0/OUH4ykaqfMHJ3jgbNuCP+K0lbCRK+SI3ze8r4VmuGEsV4yARREUuqMFd96yT5FxVl3sFEksLZaIaanRNj0uHSDSwgKKT6cAISAzKnPD+r8KxQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(9686003)(38070700005)(6506007)(8936002)(55016003)(71200400001)(8676002)(5660300002)(498600001)(7696005)(86362001)(83380400001)(4326008)(76116006)(38100700002)(186003)(316002)(66446008)(52536014)(54906003)(64756008)(122000001)(66946007)(2906002)(33656002)(82960400001)(66556008)(66476007)(26005)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iiqV0qCMCbkgtii/GvXVlEP02jX9vwLc4/Gk7QsdW9LhZPmpqO6FQv5ZcdZ2?= =?us-ascii?Q?urpUAWklRG5c6GdMgMxpMriT6DGnL1fI97zAzy10Pjss99MlvaiO8jh9+8kI?= =?us-ascii?Q?PEQvBK0ceUxR9rm84tnXffvZ8jQKizUWlbnh5/r/QQdwrK5J0szWRPiolxbF?= =?us-ascii?Q?ISdYJWM5kXQX0ZkPxzEZipanI7Tv6VYPBo1wVPUu9D3lwQuPK1ZPaafqFp8U?= =?us-ascii?Q?BPTLJSQbjVejeO9hKYlqJkbbMbeMIWAUvmAtDsMm6SEz1YhfiOHw6PTclkJK?= =?us-ascii?Q?z/eFR0kyxAD1ysN/7WoMOy5Lzy8aI/jgflG4nuoHeykie0AgqXQI82YeLmPj?= =?us-ascii?Q?bSkuTA4Xdsb/cHjLRklC68HP8TpTivRcPrMMZNCNHJ/7la/F8geqnVIK+mjs?= =?us-ascii?Q?Xm6XEOfZ9TbCWt1ov2D0QLt2s7h1eutdqeTC7hly5d2fRt5JS/WtY/fDhMKb?= =?us-ascii?Q?DMfFj/0nlMdz1+M4xLzNNNLvYJdQ+FxCrGwNfVD11d6RSF/T2+iS12zp68xZ?= =?us-ascii?Q?JA5yh8MbGwgQ5Q9Sp9YOcnwT3t/DaQ2+HdYfO9Se23jq3EaEWqzNZfzXi24n?= =?us-ascii?Q?XntOLEf11eYFJBTqocDDK9OsnQeymeNk8JXKUdyJDbsH1jq7xfo+3mIr8vYB?= =?us-ascii?Q?JObklAVxjch0ofzOzHEZ5i5fps69goTn9UG9gmSpVS4nk4ERIN0pOji+wTCO?= =?us-ascii?Q?44XBsUxmWgWRajVXgCOnx420kk4usZp2/toSsdhkOc8oqVctiUoKHVYUup50?= =?us-ascii?Q?9p/ntRewvhUsDc//J4xYqfVl/2I9QwHVIR9vaaRnpYbZ4NoN5wigqGowjEZE?= =?us-ascii?Q?a5SU2rgXxz+tPgaJWLFHW69xEhlJkjtqBfR8Uda1BVTfqV3c/cRNgltxR5x7?= =?us-ascii?Q?4h7wPt1G3T1IQaUIwtBfu9xcwoKaTojgiTqFLhhpXg2FN+vFygRdTlhhk1FQ?= =?us-ascii?Q?z1M+PUvDE4uNS7xDqDxp4mRN5wzSQR7hFeW4aLWwvZGDytY7bf8gxRfq8pnH?= =?us-ascii?Q?tOZzjfZgzWFriBIXgKmFwAad2ANYcRo2lOAvEuBsDDVpmgGKuhKan5gcoHKz?= =?us-ascii?Q?pN1C+FZWmItMvLyDv1Aa+gm6W9lDSZ3LmXpHNduyNoNJt34+7iBJficEmB8u?= =?us-ascii?Q?PW6ZICOHpl1EgngIYYLX2Uw+sMi+fC4/75yYMsozpkTDQWI6uiBKeH/QAFtj?= =?us-ascii?Q?AlbQVXBoH0hpz5IR4kze9T/tYewCGe6iABHnuVTc3LPgNRcNi0ejF0kpYjyd?= =?us-ascii?Q?+XKd6ZBE50lHbCLjfcXEl8wqhok3eUziZeTGDZHYzXplfJKSZd05Hli+07k8?= =?us-ascii?Q?Gih/JHCE+g7jfFtGwwDM37Q8hw+P59bDZagrx7dGJlzyDqEfKxLLGSMdyEbz?= =?us-ascii?Q?yxLoQybn3v6V27yfAFEmmoPvlUbhKGmzPHMfdbIe45llxbzECeSTHeyU9RYY?= =?us-ascii?Q?Qqge4l8JTvb5jWzErZyVRn1VxwSkUsFGtZ/Mw7bmZ0ujf6CLCeM/NHxcxcR1?= =?us-ascii?Q?1REp5wFHjwOO/2om/TKrEK04PmvUbAVODBd6InWcTtzSjZ3hYtNV4gSN8ryL?= =?us-ascii?Q?1/osTcWRPPbTsLpFhXNw3xF1z8K15LetJgeEzMreq08KQ5oG1Y2GS79uHq3S?= =?us-ascii?Q?4driIGQ2wXFMI4uA+24MqkzydU2ZOjpILURfPPwSCaTeRucw4rn9lxEqePK7?= =?us-ascii?Q?Nbp9kUA+Hu2J6BFE096hdmdOlbAvsYC2qCp1u8L+IoRQAPyp1ZThSLtFJ9mi?= =?us-ascii?Q?U9meEHOx/FNBiwlZD/gIroqwT3McatA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c64faafd-5d14-40e6-ea82-08da507c2945 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 16:12:22.4336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1MsQqrlIQ5LAmGImeVkbTHMzMijoM1PDJnJqGf/TMsJn+5rTEnMUIyBOJugS4iEqfPMabugKQgBl4p5AygxR2xV3/IsaiJUhOw5v2V/CxZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2264 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Thomas Monjalon >=20 > This solution is what I proposed to the techboard some years ago, but the > preference was to completely remove the MAX values. >=20 Thanks, good to see you had similar thought! I don't believe there is an ac= tual recommendation captured in term of how to remove completely MAX values= in that case below. I believe that this option is still compatible with th= e spirit of keeping AB future proof.=20 >=20 > 13/06/2022 20:24, Nicolas Chautru: > > Updating the last enum for rte_bbdev_op_type to allow for enum > > insertion. >=20 > Please explain that the reason is to keep ABI compatible, and you want to= keep > the MAX value for array needs. >=20 > > --- a/lib/bbdev/rte_bbdev.c > > +++ b/lib/bbdev/rte_bbdev.c > > @@ -1122,7 +1122,10 @@ struct rte_mempool * > > "RTE_BBDEV_OP_TURBO_DEC", > > "RTE_BBDEV_OP_TURBO_ENC", > > "RTE_BBDEV_OP_LDPC_DEC", > > - "RTE_BBDEV_OP_LDPC_ENC", > > + "RTE_BBDEV_OP_RESERVED_1", > > + "RTE_BBDEV_OP_RESERVED_2", > > + "RTE_BBDEV_OP_RESERVED_3", > > + "RTE_BBDEV_OP_RESERVED_4", >=20 > As Stephen said, you should make sure that using these values with the AP= I > functions will lead to a clear and expected error. Yes will do this.=20 >=20 > > @@ -748,7 +748,7 @@ enum rte_bbdev_op_type { > > RTE_BBDEV_OP_TURBO_ENC, /**< Turbo encode */ > > RTE_BBDEV_OP_LDPC_DEC, /**< LDPC decode */ > > RTE_BBDEV_OP_LDPC_ENC, /**< LDPC encode */ > > - RTE_BBDEV_OP_TYPE_COUNT, /**< Count of different op types */ > > + RTE_BBDEV_OP_TYPE_COUNT =3D 8, /**< Count of different op types */ >=20 > You must update the comment to explain there may be a padding, it is not > exactly the count. > Maybe "MAX" is a better fit than "COUNT" in this case. >=20 OK