From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3956BA052A; Sat, 11 Jul 2020 00:48:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D7CB1DB43; Sat, 11 Jul 2020 00:48:29 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 659911DB30 for ; Sat, 11 Jul 2020 00:48:27 +0200 (CEST) IronPort-SDR: 6h2s6/94qsfasB/nnwr9fxkgtVbEXgLg/Yadj3DV9lwEDdR7e2d6V/aOKZt1L6OK5BRjNbhK+H Vq1Fu0ZgDuhA== X-IronPort-AV: E=McAfee;i="6000,8403,9678"; a="213181959" X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="213181959" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 15:48:26 -0700 IronPort-SDR: pUs5TxWAe7ZSOiIEg/BQ/adrnKQFVKByOBop7NcEZObhq+MxPGi9dSg9vkGDvvgnoT9yt3aGA3 Ss6tXDbjt8zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="428701770" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 10 Jul 2020 15:48:26 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 10 Jul 2020 15:48:25 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 10 Jul 2020 15:48:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jul 2020 15:48:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsokZj7YLGoa8y9dtGnY/xteprVlW/NfvrHexPOr0usSNwELZWkpnZlN0OlVwZDR41k94c01YtNO9ZAj6DX7dy+psJiuhtzhh8QQq2Dbbi2LXxR0m15HSuMEpu/X4cf9oVbMnI3w7H2NMzX0NUpqkNJpah2IOqUcV8iT3upcNWmli+9JQiKIw6gGTyjPiOf18MEQIWMSzygNjr6ihWV5TXo2X6eXptIIrda/qsl7h2APVtgUhK5Z3x4Dd4Y0NX3va8RS13afSlGTEx4rMX11aXbxxhhDB8hnooIOoI7K5avlHcMSy89PuDr/ju4FfDENLevfUnRZ4abYldWo1EJN2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTYHd0JneJXk0/KtvV1sLFCrGqPtuiATuTu7k2cPi9c=; b=c6Gdz66aY7jDRClfyfY7VOnAlVZ1udGAbdhYFRIJJ6X0r9p3+5angGHrRDDwALAwfmSQtlHp3LEd5nPfEc9pK/DsEDBuXEeahGPDhXwOh2kc8KXyVTtc+PFoMIXT98goIGBLP1t1E/q5MZBsrdOf1tzqzxxzmLMEnl25dy97ODGG8YhJmzDu6sMwCpn70BbtVft3JPePlD1+AW/BE/3K3cSmV27CuzrHt9cpFdGEejnGXOGIU9yTuYrdh4wBRma92yKhXb5CJIG01SVqdix5OU3lpQRGNjb6hpIq8UBagTPd7vk2gMUjizmzINl7aBZgO/TlvvwEbdKFrlj8XjzPlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTYHd0JneJXk0/KtvV1sLFCrGqPtuiATuTu7k2cPi9c=; b=LXgTM7P6gyw5k027RJifHPTqO/g2mivpytm7dkh6kl+DLH/vmb/h0ubNxYAgZhDYZihKOzkukmjU0Yk24AyH5QZcE9B+7iJJzIexxf2Fp4hzMG69gFevLfb2JDcsINXYehOXSIUEU++4LFX0GBduWSpRhHCdyVKmuj1v6Md1GSw= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Fri, 10 Jul 2020 22:48:22 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150%3]) with mapi id 15.20.3174.023; Fri, 10 Jul 2020 22:48:22 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: Akhil Goyal , "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" Thread-Topic: [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Thread-Index: AQHWBia5R0/Gp5PdrkGqhlhqLpHPAqh8s+sA//+q7ECAF60+UIAEzVkAgFAnemCAAIO6AIABGlfwgACYVgCAFtSNUA== Date: Fri, 10 Jul 2020 22:48:21 +0000 Message-ID: References: <1585526580-113508-1-git-send-email-nicolas.chautru@intel.com> <2158398.uQ6CQvYSmG@thomas> <5002345.Tnmucr0XKv@thomas> In-Reply-To: <5002345.Tnmucr0XKv@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f838dba6-2f61-47af-a1d6-08d825235900 x-ms-traffictypediagnostic: BYAPR11MB3799: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mPUmBJhvse9/3F+y3/m9szSD/j3fdL4XuAC8lnSZCAEaCVfJcqIRHM/3ibDrUTMuaTfThzgrsJKGjTqI/dYNsLEBeVLxMlM6508jYi8TRncLKc5oeg0XcAoLI1DbQYB2sFhx5GmcHZiUGXvGqpbcFiThk5G3xZtM47Bhw7MRVz2e9kYtDZXfCFFpGcoPH3Vy/5vsBPZCfdtDXyBdTv6tV5YL/mFpTkOfo7C+R2zZKLwr1YG0M+wLEUXP/k80UlaA1Dn4qJrCmtIHMYp/WPqnosoget+6nc8cq8/QIEoYayq6wkHL6h28/D/5C/jv32pe110cQhZYrpsl12BoDJuBm1ozYcwHg7esOA2iVn7SaxLbDDxU1BMWX3GsIRJisCvLPUeJAj1ceX6H0zVZrqTJAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(366004)(6506007)(54906003)(83380400001)(55016002)(7696005)(6916009)(71200400001)(76116006)(66476007)(66946007)(66446008)(86362001)(64756008)(8936002)(8676002)(186003)(9686003)(52536014)(26005)(316002)(66556008)(33656002)(4326008)(107886003)(5660300002)(2906002)(478600001)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: PL3N+qDmMmnk3M4d10GDBgVjW6UVwDI3GmApfQ8xkioH2TushopPJW3sodoj/+v1XVTkuEHonRO9ffBHkhhHDLSr8+cs/cHXFuBy3jOhJUJZryCwkmV+BF6FwcDPABQCX3KILoAXKi7u3HgCnqPUWr1nheqGStFS8HaEQtKUTk+vw0HOUBclebwk2qzviJf9+PR4UzI+47um8lAW6zis+5mjn7dFdTKkliU05R+dN5HUhYgtAh8WMcVEIzsMsZH5UwHg1gxnCtbWuhQLavVr/DJEmC+mxLYBCR+0DqiiKF11Zip8RyGGMSfIT9S/fSRGFGJYQKgZCluXuPP3VRJU4IhCuHKbBw8ieQ3/2GCV0ywGjPXT/Tq3RJHpvmilnZcFmq26x13rxxhzSMrAZ8DuUfHvdCMHzpmkSjC3LHhOIMrc6VkvcDxwEFW5NZwYejUAOd9nhEb+RywBWWRLICdFDLbZPv0LOx1SNr3cMIwsq7Y= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f838dba6-2f61-47af-a1d6-08d825235900 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 22:48:21.8452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QBOv6e5bilyIXP1+IL0sOizVv/EmElGZyQtepPIMWSClQqKfYLK091vln/VOGHfbMIOWusc9LX5K23WvzaltGevJPfxc7VLMv1FZaGKsiCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3799 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon > 26/06/2020 03:14, Chautru, Nicolas: > > > From: Thomas Monjalon > > > 25/06/2020 02:30, Chautru, Nicolas: > > > > > From: Thomas Monjalon : > > > > > 02/05/2020 01:15, Chautru, Nicolas: > > > > > > Hi Akhil, Thomas, > > > > > > > > > > > > Following up on that previous discussion below so that to > > > > > > confirm whether > > > > > there is an available option to handle this usecase within DPDK r= epo. > > > > > > > > > > > > Basically traditional deployment for VRAN relies on BBDEV/DPDK > > > > > > running > > > > > within container where the workload is processed behind BBDEV > > > > > API bounded to a VF of the accelerator, all that is fully > > > > > covered currently in > > > 20.05. > > > > > > Conversely an application from baremetal still has to be run > > > > > > at initialization > > > > > to do the required register poking to PF MMIO so that to > > > > > configure the HW so that the VF is functional. Without this it > > > > > is not possible to use the VF driver form within the container. > > > > > Said otherwise the BBDEV VF PMD cannot be even tested with DPDK > > > > > repo (only the PF PMD with the workaround discussed in the previo= us > discussion). > > > > > > That small userspace application is purely doing mmap and > > > > > > writing to > > > > > register based on xml file input (relying on igb_uio bounded to > > > > > PF, or other vanilla kernel module) and has no dependency on > > > > > rest of DPDK (DPDK would not be installed outside of the > > > > > container since no packet or wireless workload is actually run fr= om > there). > > > > > > Is that sensible to add such a small companion application > > > > > > within the > > > > > related PMD directory even if it has no dependency on DPDK > > > > > libraries per se, only the fact that is required just to be able > > > > > to use BBDEV from the > > > VF. > > > > > > On one hand I see reason not to do this as this is not a DPDK > > > > > > application per > > > > > se, but that companion HW application is still required to be > > > > > able for anyone to use BBDEV driver + being within the same repo > > > > > enforces that there is no risk of version mismatch. The other > > > > > option being to put that on a separate repo outside of DPDK > > > > > causing fragmentation of > > > ingredients across repos. > > > > > > > > > > > > I wanted to check whether you had any strong opinion on this > > > > > > topic and > > > > > whether a patch with such a companion simple user application > > > > > may be approved. > > > > > > > > > > I feel it is best to have the required app in the PMD directory, > > > > > as in "batteries included". > > > > > > > > > > > > > Hi Thomas, > > > > For such a companion application to configure the HW within the > > > > PMD > > > directory I want to confirm two things before pushing a patch : > > > > - This is okay with you for it to build outside of the DPDK build = flow. > > > Ie. Separate Makefile, not planning meson support. Again zero DPDK > > > libraries dependency. > > > > > > I think it should be built as part of the PMD. > > > Why not? > > > > For the same reason as above : you would not deploy this companion > application in the same OS or container/VM as DPDK; they would be built > without dependency on each other, but still provided together so that you > can actually have all the ingredients in one place without mismatch and b= e > able to actually use the PMD will all required ingredients in one place. >=20 > OK I missed the DPDK environment is not the same as the environment of th= e > companion application. >=20 > > Also based on the dependency below, even if adding option to build with= in > same DPDK meson framework, it would not build by default by anyone as the > dependency repo would be lacking. >=20 > What is the dependency? I assume it is freely and easily downloadable. >=20 > > For that reason that would be a bit artificial to me to be built with t= he PMD > really, but I could be convinced otherwise. > > Any thought Thomas? >=20 > OK > If you think the application is tightly related to the PMD, I think it co= uld be > hosted with it. >=20 >=20 > > > > - This is okay with you for it to have dependency on other open- > > > source library to build it. Ie. we are currently linking to this > > > https://github.com/benhoyt/inih (BSD license) as a simple input > > > config file parsing. > > > > > > No problem with dependencies. >=20 >=20 Hi,=20 Note that the related contribution is capture on this new patchset. http://patches.dpdk.org/patch/73785/ Thanks Nicolas