From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADCF2A0C47; Tue, 12 Oct 2021 18:36:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CD81410E8; Tue, 12 Oct 2021 18:36:23 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id CBE7D410E2 for ; Tue, 12 Oct 2021 18:36:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227161415" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="227161415" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 09:36:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="460438322" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 12 Oct 2021 09:36:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 09:36:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 09:36:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 09:36:18 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 09:36:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WK4rgdHTQ8DSWkez6Th6MiE3m08+zthh2Mb60tpwiWuGWbmnOn2PC2m1PM4yqidNt/B2Ud9XQr+6Gv0cK9kMRNygyzVxziZxLnPOeHoFQKu06Km/56gogVvjjNa7E9FArYzKn1xIii3u5oaSw/CrNr80oxsQ4be791KUFkYAdjFgslaEUV4EI9CEDkzHJF9fwbjfAB9KtM5uCW6SAixHcKOd7QzaH2sR2G0255Y4U7e7/aKCZwGvU2pY4u9CjyZ1Gx/pArY7SjEytW0dsTHyzYK2B+lZUSklxjFRWGRhkndqOIlcU2AN0P5iDLwxgGBuVPpC145rIX5FRC0fkkngvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/rSAN+pXGM8tKMwk108eZxKkGTwlTw9r/pL+KBxU2VY=; b=JD70K+u+pjtbVwdp9saJPXehJEtbETAKeDsGaBGXbd6uZKiGl/GmvKw7DnuWPDCIDFCW38SBhnqKrllFBGvPaEZHk4h8mNgjCFVVhMLg2BkHl+HtCUpZB1vEQebuStQZuiAtB1QmHMv8JXDtI2yeWoAqlCoEId5IQdfqN9B0iJ8auN1dTuNK+ZZhQWKAs99PUZocT+ppVZlCJJjE3wxpaZ9T4Qw14boXzYXMNv0IFszJM6t5PjZhLfx54kyO0ylev2Z3ECycOiNs5oo3HHVBrMEfAQaOijbdR9Zf6pyhEfRe33gjuIOzi3J6p++M6Lxws3pmXh4Z/J3fCg385BMQiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rSAN+pXGM8tKMwk108eZxKkGTwlTw9r/pL+KBxU2VY=; b=KvPr68+whkMZ+OP7hNKO5xJHWs7ucLkavBeOIrxj2jeoWjSAv4sOn9wACGJHjvnRMeUIIA3JKa1iiK4y4XDj520CYRaN93QYdi2WWDiJ/ski4LujTuymAwF6X0BZUUOFEmKl2HOpYEXoF4x9x/gJMNd13vVrNBAq3RwMbJUDoa4= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3640.namprd11.prod.outlook.com (2603:10b6:a03:f7::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Tue, 12 Oct 2021 16:36:10 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::d2d:4882:88be:85bd]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::d2d:4882:88be:85bd%7]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 16:36:10 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "gakhil@marvell.com" , "dev@dpdk.org" , "trix@redhat.com" , "hemant.agrawal@nxp.com" , "Zhang, Mingshan" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check Thread-Index: AQHXkGN9A9EiJhn2l0q5yFywiDASPqvOmSIAgAAEhTCAAK0xgIAAmL9g Date: Tue, 12 Oct 2021 16:36:10 +0000 Message-ID: References: <1628873485-30596-1-git-send-email-nicolas.chautru@intel.com> <1702526.DCS0tWCQBP@thomas> <2349964.oiB3URGJAo@thomas> In-Reply-To: <2349964.oiB3URGJAo@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 616e8440-1308-4067-23a9-08d98d9e65cf x-ms-traffictypediagnostic: BYAPR11MB3640: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TZcu1wDPI7v6E96dOBM4lrMRv5U9/w8tJxmFwssA7YpjHQiG5qwc+Kza75zx9R26hxPA/emeXqUNwODjfQqdv7MG/licgF9s9DK+ociL+nN9KC19twSUPnopSiijM0OPmmI7L1Hv+xbkrt45oT4u2tq9uR8W27+eZJFznVO6s8baXzZPqUdUG0S0xxN5VjGqSNK4Pq+w04Bkl6nry6e15zVtVcyXGz1XOWI5BOrBFP2QMvB85TVtg0IkM0pGRAwWSlROnADulDXH0QAiYmXi6PPod34HwzDGeeDX4ZGesWaU1Y5X2dwgV7UiRPv4enC8RpmvW2Rud2Nqh7uH+nXFk8mXGqSh1CJI03nKLOppdu1KVYn4T3raWjjMyKwRDdjyr43rOMo+nGF8VHDI24UXUjYiJu1A9CmKHWexi2Tluz7Jr6xr5HbtUiFozYZi60xurIMgRYkE53Q+wI82+rGQXEUGBGIZ+ADUJ7VHIo4Yp16voOCdQTanfUcoPb7bZl3nTW/FCbcFPA0zrrz4wgxgB8+w4p2u/+Gg/ODPrWe/Fj6AI5wmkBSedi4LGuzuC9gJhttGyUWiZAdAscsNsPMAxHvpZxFVHfQtlnMzOdLRRGo8YL6diumovwLBIeW/POqwTmk/XgTRGcYQKg6XRA1Jaek8rZgzuDdqAHoZOkW+Tt82LZv7Px97FmmBEoEw33pH/n3rIcGj1U8Gjf9gXXv6gQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(122000001)(53546011)(54906003)(4326008)(8936002)(5660300002)(9686003)(71200400001)(55016002)(83380400001)(6506007)(186003)(26005)(76116006)(2906002)(66446008)(508600001)(64756008)(66556008)(66476007)(66946007)(107886003)(6916009)(33656002)(38100700002)(7696005)(38070700005)(8676002)(86362001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2xnctD2eG70waUDOvFHrYs8MBf0nsuz9DAU6dAs+ay4+Hb+PdhaOxNN384ow?= =?us-ascii?Q?QTMuMBiSFq2c8qsfOse2DPmlqXwV1fZkAIUN/IKTuVXuRw62lbVd0TZ+Ka0f?= =?us-ascii?Q?BM9J3/MIc2P5kfQJDFBb+Y92NZ24BHzmSrVuqEdh+OL6pKfNYJix6Fpoxzum?= =?us-ascii?Q?YMlTl5SWCmpc1h2oF8eBKm6Y+xSrJjnlvaxcAQZlqRYPtE3VFsn0kzXbjcYM?= =?us-ascii?Q?VJyKCC7++/sSRuxXBB+TrY3cX/wnzicbXtatSCdDjZt8VAMUjOao1ql/Wo7h?= =?us-ascii?Q?3Xklb95b1Vu2yWRplwd84bRRU+WQ1Ikiy3kuBZ2mCmEBbKJkub4Q+QLp48pn?= =?us-ascii?Q?OiZ/CBS5EFExd/caw4NPUAfIjTutFE5rOCl35VO0y/14AEpx+1x49+WQ90Mu?= =?us-ascii?Q?791moVmYHkxjDL1lgIqWO8zmyMBOr9u82BNXKU/xxFtAZSBaA4VrTbFm4l2v?= =?us-ascii?Q?E8vyo0nWq9zpPfyevBTmfMxltmt0FO5S7rm2hudiW9NcjT/ViUO34a59+R9Q?= =?us-ascii?Q?qBc23zhhw7caOrXg1AcPxvR7CJmuiuUrdTioaRPxp7NZ6VteAkJ7rod3peQ3?= =?us-ascii?Q?Cl3gPGyuH8hUOiRHK/RWKEHHH08Os0YVsbern4utuIDqHwsc5MzRkUxGh/Ra?= =?us-ascii?Q?Q40snmhE6ayo4RA8njZsq1qTkC6f3MHKeWYPn+nWfFdt9tW4rSU0B3jtVS45?= =?us-ascii?Q?24pihRgPwwbx5FYs/oRh9LwpDhVr+5l35iNooVf93fSCG4m2Ats0vB7iB90d?= =?us-ascii?Q?d/ul6A/AcpruxA9Cf7jz0z6fh8z+5eMkBUw3K9jklenawU4qibIdn4dS3OEc?= =?us-ascii?Q?9tTCq0GGjai5dxHvkWE3Z2zYW3UpLNVsN3KcJC4EwaB3Ve6cAOd1pC9SNwaF?= =?us-ascii?Q?MKnof0tstLlp0Bk+jvim9xD65v1xnH0W5QdyEBKctI14/bpWx3Znj9Fpvope?= =?us-ascii?Q?MPMTkQZb1Z44gTIpJ5fuaPpeyPjlnOy8KjzVIyV+m6IQ6iU5jpFcyzA6g9vR?= =?us-ascii?Q?r8NTNdKK9/QyhaHllaOtGLiUNqMizsnnUBHEBt8q3kTlxz73Tvl400BAdVDJ?= =?us-ascii?Q?Ysl2OnLuMDk7n2H8sb+CUbG5lZLny/NGmeyidnY0EczRqgU3RTpFqL+Gf8iF?= =?us-ascii?Q?kR9ztaDmUOI0ZxxelFpSe2brHpXljY5udikna5hjwuOcxKGF6pcRHfMsHMhU?= =?us-ascii?Q?j0/YlYHS9fUHGgJ8sx3l0lLYFWQjXDFKzEiLWDpNdj/bRpiibi2pUmngZ97b?= =?us-ascii?Q?d4hYPILvDzHPQFSV1p0BhLOuOAKTodzJ9/eXka+26X7AeImkvh8GVVlo4ZIt?= =?us-ascii?Q?CfxnEglbbMDpTUxe0tsQBmvo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 616e8440-1308-4067-23a9-08d98d9e65cf X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 16:36:10.0339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EFf6mbvr9r7W6f7E+tC8ZuwwZULGWarPm/rs+qFJiOj/TFHrV1eIkZJjgUIMn+JYV/GemJA3Te6Ln0MPOtBKQRyobb/YNHIP5DIrecd8F8c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3640 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas,=20 > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, October 11, 2021 11:53 PM > To: Chautru, Nicolas > Cc: gakhil@marvell.com; dev@dpdk.org; trix@redhat.com; > hemant.agrawal@nxp.com; Zhang, Mingshan > Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 > check >=20 > 11/10/2021 22:38, Chautru, Nicolas: > > From: Thomas Monjalon > > > 13/08/2021 18:51, Nicolas Chautru: > > > > Adding a missing operation when CRC16 is being used for TB CRC > > > > check. > > > > > > > > Signed-off-by: Nicolas Chautru > > > > --- > > > > --- a/doc/guides/rel_notes/release_21_11.rst > > > > +++ b/doc/guides/rel_notes/release_21_11.rst > > > > @@ -84,6 +84,7 @@ API Changes > > > > Also, make sure to start the actual text at the margin. > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > > > > > +* bbdev: Added capability related to more comprehensive CRC > options. > > > > > > That's not an API change, the enum symbols are the same. > > > Only enum values are changed so it impacts only ABI. > > > > Hi Thomas, > > How is that not a API change when new additional capability are exposed= ? > Ie. new enums defined for new capabilities. >=20 > API change is when the app source code has to be updated. Thanks. What you are referring to may be strictly API breakage as opposed t= o generic API change. I would expect an API change could be either backward= compatible (extending API but application only has to change if it wants t= o use the new functionality) vs an actual API breakage (application needs t= o change regardless even to keep same functionality as before).=20 In case the intent is to use the 2 terms interchangeably (change vs breakag= e) then I agree that these 2 bbdev changes do not constitute an API breakag= e (only ABI).=20 It might be good to capture this more explicitly except if you believe this= is obvious (doc describes ABI change, not API change). Regardless for next= time I will use that distinction (change =3D=3D breakage).=20 Thanks > ABI change is when the app binary has to be rebuilt. > > > I think I see other similar cases in the same release notes " * cryptod= ev: > ``RTE_CRYPTO_AEAD_LIST_END`` from ``enum rte_crypto_aead_algo ...". >=20 > I don't see this one. >=20 > > You know best, just checking the intent, maybe worth clarifying the > guideline except in case this is just me. >=20 > Given my explanation above, how would you classify your change? >=20 >=20