From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A42FA00C2; Mon, 31 Oct 2022 22:41:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFB8A40685; Mon, 31 Oct 2022 22:41:16 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B90A840223 for ; Mon, 31 Oct 2022 22:41:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667252474; x=1698788474; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EINi4+vAGiD5t6jKY1lNxqujmbiiuP1Ka5a9Xm4oznE=; b=WU0ULODGdSERy3a8MAzblDlryGBSho0PlpkrGKVjd+mMCQCE8or33T7G h8iOx6a0di1vq9MJl+kC0o7RUCoT8vzTEvH8AC8jR8HpDf3PJsd3+IXJD sE1CADr7lcIaFwOdBLYC+E3CFTzeukznow6W7uCdXnRrYaykgXcM9lJKD Z2lD0B0ug4ZgAkuQkC2lCCapV3FLZAjRZTv5IlERIuL9bPLY5mWwVkF9w k/XA8d6yPXBB6v/pTEa56xIkz5Z+2zSV3D//wXMVocOybKcpoWUzgsa0W a4Ebdctw5S8yiYcspa3Eit1r/qOF5vn4Sx9cSH58lyAhmX86MeW6xbtc/ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="307730585" X-IronPort-AV: E=Sophos;i="5.95,228,1661842800"; d="scan'208";a="307730585" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2022 14:41:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="636195609" X-IronPort-AV: E=Sophos;i="5.95,228,1661842800"; d="scan'208";a="636195609" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 31 Oct 2022 14:41:13 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct 2022 14:41:12 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 31 Oct 2022 14:41:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 31 Oct 2022 14:41:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kC0xvfHNYDel/EYQkauz93nzZVwcu4A2srYpQpxWWQLwGjin9yujjyeJInIAHeAVR1zWXlYds9548KVLDbtYNIaxr/UOTgUYsW+WOCH22bb9PJ+g55IT8Uf68ONWcfmV7pXM35MPhUxf9X5B5aZIRitXxzPtF5FH5EsFeRPZUvMLGqqTKMln6QZ64j+WeUr3IzuVE+70Wq1Ie/tUDF6GMhJdFEVP+rqLDmpMyyhoDV2bputZssuOjkKk1wb1Iz7yr/mQaVY5tfbk1tifcaAkg7WX3XhgOKkG4sQwh922Gq43pfOH0gzodLpTru4IJE0CzFYvcBo8RtuLb42i1bKxAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Z4FjQq3JuRkUQImrA6JmXAusxObsx/N7IB2kXpKuxU=; b=O04XjHi9MgtOJcnBAMBU+1qoCIiJvRQjwUc8tEkgBactn++vYGMT5KDvUiHVwdzVJxPTx8DtoYTxC4xDuXsC1Cw2ia9ZMyTQvlV/GMyWw95bX/J0tFDDU9YY8Pw6UhTRQJ6bHHBvYo9+wKiMA8z7oldlrAbo4P0aUWm439N7vNuyiP3q6UKZyYGKm1i7dn5eK4DKHt20kd2QOei6dPRDqoIBh2X2EP0t9gHo2qnbMi+vINMahCKXivtJ/V6agaepAmh5CszrD7LzAToJ9OoAxVS9isVjd8cpWExtNeyeIv5rewWccRuSJY4ZPUUDHfOU4+DxZZNZidP4KUr0YUVHPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by PH0PR11MB4821.namprd11.prod.outlook.com (2603:10b6:510:34::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Mon, 31 Oct 2022 21:41:10 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::de48:e4af:4bd1:b30c]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::de48:e4af:4bd1:b30c%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 21:41:10 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , "maxime.coquelin@redhat.com" , "trix@redhat.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Vargas, Hernan" Subject: RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Topic: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Index: AQHY3mR/OJU5Izo8vEyVyrRhEklaea4nNV6AgAGKGiCAAAWagIAAValw Date: Mon, 31 Oct 2022 21:41:10 +0000 Message-ID: References: <20221012175930.7560-1-nicolas.chautru@intel.com> <3141057.vfdyTQepKt@thomas> <2968027.687JKscXgg@thomas> In-Reply-To: <2968027.687JKscXgg@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|PH0PR11MB4821:EE_ x-ms-office365-filtering-correlation-id: 642a8ea1-6d9d-4c88-eadb-08dabb88a062 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aEfyIwSXJ2C83lKdQy32+rmYjLjzYcd/rwJ09/lOQr5eo0P53d7EC1qge5+BV2pxL5Ryc3NXe41YU09P3Y66jFq6++1yu4b5F9OpIatisP/+3nvP+KCLQdOwUc1pMJDkHKuRX/HvSG9ZaHZ0eSFiEfd63yBTlUe42xzebMPvM6EGRkDR/IMMvJfcli23Ez88MpNkvY3CSOR1pLnFAfBuGLEhiDgKP6pgrt1s3HFKJjCs8D7BksVvTnjp3i0ErlouDyFe8mUIVciT3L4UdMmrKnA2jzseVqi3veqt+sw/aZKdD/n1AW/XB90ZxWJRtsJUoZvGWat+hfWohR+Gskmw7uURdlYhQbK3qPWYQ7mjj1g3kgPtA9BFSRisvxsZuVxvLt81ydqEbZFmun8ts1FnecbMgNbGY+PNmYuCoVewjkWm9j1z+ZAv9gKm+cZcuqHd3YiUV41Xbq72Dkisc1xfX19zodeF4uOlDG+/GfPOkSIwxhpfOFC4cc6qUNiv6VOkPyZlVCjupBE+QbM/JtRAHLN9FyA9p8dGNGkXksaEox8ZqBJPc0DxUveVrMVglDC04Tubocsq5cWJoAA9Fjekm2E+Cvub3lF66a9I6SxtuCF3wp6MuCLvR2jGqR+vMhP3lHb0IeoHlWD5f8YYpqWGHHVZq/fcvGU1R5lrWkc14W1D3vaSzKdt9ESP5i5M2f6JdkGrmLJDhPDYVZzxZFCr5JX9+0/vqffcAG5i4ZwFQPNSCH77bKag5mWhfIYqozpfSgxcYdeR6rR40wQeG//V6froS9NVjywuUmgHYtE2hvM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(86362001)(122000001)(82960400001)(38070700005)(38100700002)(33656002)(83380400001)(55016003)(2906002)(9686003)(26005)(6506007)(478600001)(186003)(107886003)(7696005)(8676002)(966005)(6916009)(54906003)(316002)(8936002)(66556008)(66476007)(66446008)(64756008)(76116006)(66946007)(4326008)(5660300002)(41300700001)(71200400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WnLItvwpB//ivihDgTAUWR4LPgUtBzjR+wAtYCIXPd3IXD7Wed8UPOxub8w3?= =?us-ascii?Q?lE2kBca8J4ez/TgoCzQNeNDJpj7KlRO+yJIXJFwaDVYAMDdFm+H9lYDaiNVY?= =?us-ascii?Q?kXcgwT8tDWd20rliX40c8/7za6s9trr4vwPM9SuxJhS/ab81ah2ivXNXpqm1?= =?us-ascii?Q?7ZvBqaT7sfFIekRzUnURudPOefEorYCWiESrR1mxmZB1Ywwn9Tb+H9bxIsav?= =?us-ascii?Q?vN2Hgvn7V30liS38DlGrLt3oZ9uTh8y476vDsHzI/3hiNK1ovwkP79u0Ciwp?= =?us-ascii?Q?s6moyI4gVAk5YhYiLyMVPx9TacBxRzTiszSIaEnFV0gsZd6X3JwVqXCp6PYR?= =?us-ascii?Q?q2OZmXmHirm+7Suo7rRayzCDCsHI/jhNNomIEQCWdsP9kn1T/mlqmwgAdfaC?= =?us-ascii?Q?KN4DSRC3bJXgZExCp5lLbLF68AoL1ar/mF+iAKyNzypO1S0rWWNYHLYq1B+G?= =?us-ascii?Q?VRYi8aBfFAgvJS7WTB81PU+9yNmBaFUAk2RcsvhfZFX+t2ZPTX3jr3ilVmjA?= =?us-ascii?Q?C0PyETdiSQ4MzJtVu/uyriJ9O/963CpBM/85WxfzwspXxziYZzs0Ix33+VFC?= =?us-ascii?Q?9PNwoQR3diQA3HG+dkTJyRqvAMS28Jk1aMDwzdyotJ+8XN4+5xvQPo6QDbb8?= =?us-ascii?Q?XOdbIsH92Kz1WyEtdXHbmfWq0Pe8BAqgUXR7qVuqS75d8Zx6yVRo5djWVRQm?= =?us-ascii?Q?9ahnJ1C4D7qVAJfzGN/y2uirQzD18DoF/xhEFR9aDARgstXurSeqrwmEwtSW?= =?us-ascii?Q?1fyX73rfFiqdFNqKpDqyaTqpBfvtT6MqX7lwkPbT+jhzcepNhQM8j8AsJfpi?= =?us-ascii?Q?PjVqtJZkoiytoqyyM0TerSzUBW35Xds7D4Gwi+/pCQcpI5FZu2497AKlMPmh?= =?us-ascii?Q?rNSQ72kzPgGqnksHrASrxKhMmURw8zP5PtNu/tE8lPscPn7mfJCORSfjE9gb?= =?us-ascii?Q?/FuJ20c11pLztLN+X7TU0ZL39IWsvBelbHYgVw+V8d+2+lGWEvBBxvpZCgVk?= =?us-ascii?Q?GtJ1XyBuJlwr+55Givu8LSE3kK4rAee+YWLZbUJhfJtzbfALyQwciNeESOLb?= =?us-ascii?Q?04TM/XJ1nCI1PsrfVAZIbJUaBgmE9WoIHSRBr+tfU0yGhOahMsUJpg9gtrL3?= =?us-ascii?Q?EhVDClQSKWprD0ExeByJhnnmsDWAl4ZYoH9M6B/Zb2K0l/IvJPZh3UTjo5H1?= =?us-ascii?Q?WgK/NOcTdGfHyg+Vs0CPd8SgUjJze/gpcHNFOqZX7p2nnyBrBKwImfpwGkut?= =?us-ascii?Q?VRJE3DD5l5DPIQndx3XDlh/kh2ujgZo/nh4qq8J2sq8V/A6aqTCLzckpuTPn?= =?us-ascii?Q?9Kj8bbY2oxewfo+6LxYT+UlqWVHopV2QdlflmLFI4fbAWZJgYfWZAniDiVK/?= =?us-ascii?Q?O/COFrLxwEg9aQ8MWaWC4Ki3nWkpMNQM/i1NWYSFsnpXXFt2OW8rc9Bbihvy?= =?us-ascii?Q?/A1DNHrVswAB2wgsFaW4Y8N4ST44oji14goGV6h6WoA32ZqMzz+aeYFoJvgJ?= =?us-ascii?Q?HgxDn34bcD/ITZ4DAmlOi/VAC/AuwK0eeEsXfDu+TJ8xsYuVIzUzwSb7tGzN?= =?us-ascii?Q?fnuDuel8HyL4KPZ6Y5CTuzPr2VbGOrfOIbkwOi1C?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 642a8ea1-6d9d-4c88-eadb-08dabb88a062 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 21:41:10.6973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sqPMQYDP9INYNPDWlpe6610vmb/9lH7tLO03100LfQamVGT0Jw6V+/+Jb2yX7bWyz+qy83DnHZ1FuJdNktFuw5+aYQOr9SIL8pbl0Zwixuc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4821 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas,=20 > -----Original Message----- > From: Thomas Monjalon > 31/10/2022 16:43, Chautru, Nicolas: > > From: Thomas Monjalon > > > 12/10/2022 19:59, Nicolas Chautru: > > > > +Bind PF UIO driver(s) > > > > +~~~~~~~~~~~~~~~~~~~~~ > > > > + > > > > +Install the DPDK igb_uio driver, bind it with the PF PCI device > > > > +ID and use ``lspci`` to confirm the PF device is under use by > > > > +``igb_uio`` DPDK > > > UIO driver. > > > > > > igb_uio is not recommended. > > > Please focus on VFIO first. > > > > > > > +The igb_uio driver may be bound to the PF PCI device using one of > > > > +two methods for ACC200: > > > > + > > > > + > > > > +1. PCI functions (physical or virtual, depending on the use case) > > > > +can be bound to the UIO driver by repeating this command for every > function. > > > > + > > > > +.. code-block:: console > > > > + > > > > + cd > > > > + insmod ./build/kmod/igb_uio.ko > > > > + echo "8086 57c0" > /sys/bus/pci/drivers/igb_uio/new_id > > > > + lspci -vd8086:57c0 > > > > + > > > > + > > > > +2. Another way to bind PF with DPDK UIO driver is by using the > > > > +``dpdk-devbind.py`` tool > > > > + > > > > +.. code-block:: console > > > > + > > > > + cd > > > > + ./usertools/dpdk-devbind.py -b igb_uio 0000:f7:00.0 > > > > + > > > > +where the PCI device ID (example: 0000:f7:00.0) is obtained using > > > > +lspci -vd8086:57c0 > > > > > > This binding is not specific to the driver. > > > It would be better to refer to the Linux guide instead of > > > duplicating it again and again. > > > > > > > +In a similar way the PF may be bound with vfio-pci as any PCIe dev= ice. > > > > > > You could mention igb_uio here. > > > Is there any advantage in using igb_uio? > > > > > > > Igb_uio is arguably easier to use to new user tend to start with it or = specific > ecosystem. This is typically the entry point (no iommu, no flr below the = bonnet, > no vfio token...) hence good to have a bit of handholding with a couple o= f lines > capturing how to easily run a few tests. I don't believe this is too redu= ndant to > have these few lines compared to the help in bring to the user not having= to > double guess their steps. > > More generally there are a number of module drivers combinations that a= re > supported based on different deployments. We don't document in too much > details for the details since that is not too ACC specific and there is m= ore > documentation no pf_bb_config repo for using the PMD from the VF.. > > > > Basically Thomas let us know more explicitly what you are suggesting as > documentation update. You just want more emphasis on vfio-pci flow (which= is > fair, some of it documented on pf_bb_config including the vfio token pass= ing > but we can reproduce here as well) or something else? >=20 > There are 2 things to change: > 1/ igb_uio is going to be deprecated, so we must emphasize on VFIO Is there a date for deprecation? Do you mean to EOL the dpdk-kmods reposito= ry itself; or something more specific for DPDK code like removing RTE_PCI_K= DRV_IGB_UIO; or last to just take out from documentation? It tends to be historical but uio has value notably for ease of use.=20 2/ for doc > maintenance, it is better to have common steps described in one place. > If needed, you can change the common doc and refer to it. Do you mean to remove these sections and just add a pointer to https://doc.= dpdk.org/guides/linux_gsg/linux_drivers.html instead in all these bbdev PMD= S? Please kindly confirm. I see specific steps for binding in many other PMDs = docs in DPDK, a bit redundant but provides simple steps specific to a PMD i= n one place. I don't mind either way.=20 Thanks Nic =20