From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0A2CA0093; Thu, 17 Mar 2022 19:42:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D552407FF; Thu, 17 Mar 2022 19:42:22 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7970140040 for ; Thu, 17 Mar 2022 19:42:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647542540; x=1679078540; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sHvSg9PTJ2xTwwYqFkbU4ThHsOdOk0j6MuWw92PJ+Y0=; b=MkxCjYUW/v/CUeHUOA9nIwSTQnykw4zf/xOX6VAO/BimrYIymbblBjqh WmUTUiR3cfRZgER8p8XVlDlYQj5M9k4OHq43TSW3+4dqBcPPemGKXP6BT UzjaW3lKW5D/fM0mnlaw3Foc7LW3QoTKqKu+RGA4ekXWAMXDEFSt/GavU 9aOLHITjOVsNayU4Q3IE06mttRCaKJWDl9lLe0MmK+IsogulCK6IyT6O/ WmMENfFK7JQVChESLOy8UNuIJ7qJkLOOSb/J6f7tDlLyALRc1ZwXApMzy s1DLPxwDVsn8bC4KfbeQX07t9tEvD8/juK6Y/8g+uSBLAg6MjCSZSKU5C g==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="320163634" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="320163634" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 11:42:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="513531853" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 17 Mar 2022 11:42:19 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 11:42:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 17 Mar 2022 11:42:18 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 17 Mar 2022 11:42:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRdBaMEUBoDZbmyFdKjLfX1As0b3AopI+F66zgJOlvphJEcorlyWXtGev3OOgJKbv9FNuMgGY8HKRttLa8ZMiNnzA8MqDoZNN1x8g/DCpGhUjmSokrqSyMXa59bEdxT8x9XRSUu1r0nV0K49Me5pTR2CMOdatUm0eHeI9dlxCaY/d+vjmhvNg1AC1ivTMFFnsjCPUVY5CkmC3psRM4O9cBIaeRiFrZIFNRTzgPRp4KkkCSYPW0dmtVJS/hXhADSjTXalJqgXzp3xkHqpPpMKMRAnEzyH4tbVCNve5o8UnSv+UesmrAlOyM7rQ0ypW63540r7w5o35P3A+TNzvCLGAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gcpXiG8XkrXOpjfmF/PWOumRNI8RcLoEraK5nOEF+wc=; b=dBTqDQqgChNAZ3i/9Q6otqbYH7PZwCnnv/bNGdUsAl9j4+NKbMt9WNOO2NSbgTkZtV+1kzApg52/k2WFrRJg071k2nZpyh7SyIWC5EBsBqjW9c6ewtTWTiopdnU2r3VAf8y9kAQncfzaXvny8jgeMyUfc0RnE53TpIVEQEkiO7HYp7eizXfIZHxnxsvyTl20inCYQyLw9wavDLIFzWzKf6EIxUEjItbRloGRljJtCiQedTzh1CBxn8k+hCId5OWSOwutChFognC4Dsfrq2IRP2FgOG5uvjE47/rGRevvU3SEj5OwFhHeWp2m+xh1UJfU8kEM38PLXHRLve/eLzyzWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by DM5PR11MB1468.namprd11.prod.outlook.com (2603:10b6:4:4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Thu, 17 Mar 2022 18:42:17 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e1ca:ec6e:51ec:37ff]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e1ca:ec6e:51ec:37ff%3]) with mapi id 15.20.5081.017; Thu, 17 Mar 2022 18:42:17 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger CC: "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , "Zhang, Mingshan" , "david.marchand@redhat.com" Subject: RE: [PATCH v1] bbdev: add new operation for FFT processing Thread-Topic: [PATCH v1] bbdev: add new operation for FFT processing Thread-Index: AQHYNNwtFAfoThWsJ0qXGYYGKOaEYKy5STCAgAAXSQCACpECQA== Date: Thu, 17 Mar 2022 18:42:17 +0000 Message-ID: References: <1646956157-245769-1-git-send-email-nicolas.chautru@intel.com> <1646956157-245769-2-git-send-email-nicolas.chautru@intel.com> <20220310171238.526eb597@hermes.local> In-Reply-To: <20220310171238.526eb597@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a9cb30a-6c71-4547-eb53-08da0845dc92 x-ms-traffictypediagnostic: DM5PR11MB1468:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I7LP8bhU0iER5gdymma/+wORNDOIIedY6klVjqcIlQjzQEhwzCDRYE4V5D8CNIRZuxwiqCmUI60ABke3WqgZCAJR1622w7m+gbLn9W++OSEfrpIwSnhMlZFiYNPH8+cvQEB38YG4fXE6tBqrj4/DnJuE1C+viEscIJqWet3HCycAT2/3KFjub2hoQIF+8P7oI8xRbKuRAkymWZZ3hJmnGByOmUkCFwnTnDEXhFxwi9029plpWT+65M1CaX5CX36zlP0SLdns096uhfozdivFKJbs/MQP6l7Cl6Tvm/znAsbsrxQ2fvL5I2X0jpLKNfYHbUxsqTNW1Bji64ORNTMLzQjxa7joJFePuU4+TKdBDZa8hCMJZ+aT4rHk+zg0TnK1MWGhJ6l1POWlGkhukbv3DrpKkATAlIzJFBSPrjExP8h5Ps+qFBNr2z+i+MWv3XlMaLy24KexfPTf8t6qgW+Cj7acjgs5eVrh4cJYYKkwkMXl9scVE1TbtxtF6sA1EN7FvZZMXjflM/e8rsUgWIFopY6YbYLgDg7Lo+84rhKgNujQDbYKTog6Gva9kEqZubGP6+iy0elgf9PR0jByFdAjZ++MQHo0182UqWNedeWJxksQ+Mi6QVO1n9J+D1DSMV60OksSjsg+GqD4f6wZC3QYAHGUKmCYiZ5Q7TPeSMfDZeKBFuI+cpnEzsPXZBfYoAv0b51wGN6rtqTii5/3+JFc1+UYdp+8L9v+MhY0QgJ7+ybolPoRuislTYqfubjHbRt8kAPoyHFmbKYlk7QMRNMfs268wNZk4jz+RbKn/Un2gkM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(966005)(508600001)(38100700002)(2906002)(82960400001)(54906003)(6916009)(316002)(4326008)(86362001)(66446008)(8676002)(66556008)(66476007)(33656002)(64756008)(76116006)(38070700005)(66946007)(5660300002)(53546011)(7696005)(6506007)(9686003)(83380400001)(8936002)(186003)(26005)(52536014)(55016003)(71200400001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vSM7mqB3AjlNaFypU5W+cCyhXEB4JNejplExM8NDuX9NyxX/E4OjCiThqPpT?= =?us-ascii?Q?sLqXpKBNXtpiXP/CICy6RZ7s4z7Ca622lqBF/p8qLhOO+TI/kCsnCXY3bFLz?= =?us-ascii?Q?8H41taWEUWau5CBfftRFpyYaPOOumVO/7pWtKWki/owdFQ7Gi4F2xjnTMEpO?= =?us-ascii?Q?qY0CBBqExdm526B8kaEOIxfJRl4+09l8PRBm1vOHXskeC/0Lz4rCTfrvVJrW?= =?us-ascii?Q?yWxWfblO/GUX7rtPc9LwfykDyf8lCeD2zdGoAQ5SrkaWu4XJ8dM8UA+C1umu?= =?us-ascii?Q?sjcMgqy2v5QGJDpxr7R1F13Qd05xnqulLOQUftDE05dQv9x+ehW0mDT1Ud7M?= =?us-ascii?Q?fHjdh3Mg/zL0DMXvaYK7bkzetMrMI3NcvLiyM70f8rZMtW5dHr6eEZ65F+0E?= =?us-ascii?Q?OA5f1uo7J9j3HIWxHa8f0NSlcF4yTE6LGJucvW/vYRyJGuf47aJ0EMim0GIS?= =?us-ascii?Q?bKl+XduTXgeMtsBeyxHlUAv5LuXtcs+nLaAJmQ127Aw6GoZWESMfOHakhuf0?= =?us-ascii?Q?VJEe3ue5pcbaKAIpdfR27qyXQzfEIeA6S8fl73i4SkcjG8uQ3kWk6+kNpb3V?= =?us-ascii?Q?CAjLM6Vr5Twc+HS3mhFqRuEnE3PZv92+/x2/6MtEToUeGAs3olMriivGuk8z?= =?us-ascii?Q?12t61TZRk088P93SdvXbaO47eiF+svS1Jl6kVE1U0Li+T98VKQbiZABspgh0?= =?us-ascii?Q?kwlpHAmajyaiCiElIJyTU66Fg9fb38CZkgSWkiIkDLR3sBpkUxrdLLwrNRab?= =?us-ascii?Q?F5e5OVkboU0cIhqiN+AHLJri6jZne2MtMmstoTel8S6LV6V5RZ69dWk4OA6w?= =?us-ascii?Q?b3qj5EU5AIrRcVnuGVdbWXjPwPicKYVioGo72MkuSs0iv1hA7tVf0NhLm9bf?= =?us-ascii?Q?a7rA5XYwQbYYsUIhYRhqeC9OopTQcDkWTmwYW+pW8/ZEEUjQ+2w4Q6l3yTF/?= =?us-ascii?Q?fdPtER6r7EbBX8g423Yx7nK27zH6XfaIaY/HbLGsdYROz9JoeUf1gLMvBmxt?= =?us-ascii?Q?7JmUQ0Gi7tysmvo+/c2KWVTcnG/nnPZJxwioTh2Iis9No+SndcCbzw/aACXv?= =?us-ascii?Q?fQyI51ptZrwwF+Hfd29dvmM1vlXz8VbNnVB5JJOJzbzMlmHrb0V+PpHfF3Uy?= =?us-ascii?Q?1py1HzhzfGyjfgkNIKzZZzImAXW4tM70HnI+LwBsr3EzUQbxPt+r2JRu8rOe?= =?us-ascii?Q?yLFRc+Vy4HGPfWWmx3F9ODeEgLaoO19iXS0EGlY/684Dcnx64Z416OrhLu1X?= =?us-ascii?Q?jCtS7aAuvCn+yCUmT/HNQRFnBsnpWx+H+iJjT2UeN2PtcY48lPz4d2rtZiTm?= =?us-ascii?Q?sG4KMdHYPrcepkaNLU3LRY0t3Jg/fGqCtBbKnkfkQ9ksFhM9xmlM1kNRkeNV?= =?us-ascii?Q?ntrEkS5apLY+wfKNffZk8LEbDBiFt+6umQdI1cxYCFcftKhQWTMOdbV3K+CS?= =?us-ascii?Q?J+NigQwkzxVnWm2PJeoryx8xVgEs10dVGQs8WOkRpEc5mAylbrtnsw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a9cb30a-6c71-4547-eb53-08da0845dc92 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 18:42:17.1790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CvnYDoY+/OpauBpQCzwgQsMEXu8xFSi2yq8sQ2MEjDRauMYaN2Hp4240vBWvlM3bx5ivThSG6aw5/mrQoXt+UQ7cH2Sz7Fc6BIrMisgkQ/E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1468 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, Yes I am deferring thispatch to 22.11 due to ABI breakage that cannot be r= esolved using versioning in a few places.=20 Still that patch can be used in anticipation of 22.11 to get early comments= on the API extension. I have marked it as deferred in patchwork.=20 For 22.07 I have pushed this notice to highlight change in 22.11 so that to= clean some of this to be more future proof and extend the API. Ie. no actu= al change of API in 22.07.=20 =3D> https://patches.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-sen= d-email-nicolas.chautru@intel.com/ Thanks Nic > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, March 10, 2022 5:13 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; > thomas@monjalon.net; hemant.agrawal@nxp.com; Zhang, Mingshan > ; david.marchand@redhat.com > Subject: Re: [PATCH v1] bbdev: add new operation for FFT processing >=20 > On Thu, 10 Mar 2022 15:49:17 -0800 > Nicolas Chautru wrote: >=20 > > diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index > > aaee7b7..a72ecba 100644 > > --- a/lib/bbdev/rte_bbdev.c > > +++ b/lib/bbdev/rte_bbdev.c > > @@ -850,6 +850,9 @@ struct rte_bbdev * > > case RTE_BBDEV_OP_LDPC_ENC: > > result =3D sizeof(struct rte_bbdev_enc_op); > > break; > > + case RTE_BBDEV_OP_FFT: > > + result =3D sizeof(struct rte_bbdev_fft_op); > > + break; > > default: > > break; > > } > > @@ -873,6 +876,10 @@ struct rte_bbdev * > > struct rte_bbdev_enc_op *op =3D element; > > memset(op, 0, mempool->elt_size); > > op->mempool =3D mempool; > > + } else if (type =3D=3D RTE_BBDEV_OP_FFT) { > > + struct rte_bbdev_fft_op *op =3D element; > > + memset(op, 0, mempool->elt_size); > > + op->mempool =3D mempool; > > } > > } > > > > @@ -1123,6 +1130,7 @@ struct rte_mempool * > > "RTE_BBDEV_OP_TURBO_ENC", > > "RTE_BBDEV_OP_LDPC_DEC", > > "RTE_BBDEV_OP_LDPC_ENC", > > + "RTE_BBDEV_OP_FFT", > > }; > > > > if (op_type < RTE_BBDEV_OP_TYPE_COUNT) diff --git > > a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index b88c881..e9ca673 > > 100644 > > --- a/lib/bbdev/rte_bbdev.h > > +++ b/lib/bbdev/rte_bbdev.h > > @@ -380,6 +380,12 @@ typedef uint16_t > (*rte_bbdev_enqueue_dec_ops_t)( > > struct rte_bbdev_dec_op **ops, > > uint16_t num); > > > > +/** @internal Enqueue fft operations for processing on queue of a > > +device. */ typedef uint16_t (*rte_bbdev_enqueue_fft_ops_t)( > > + struct rte_bbdev_queue_data *q_data, > > + struct rte_bbdev_fft_op **ops, > > + uint16_t num); > > + > > /** @internal Dequeue encode operations from a queue of a device. */ > > typedef uint16_t (*rte_bbdev_dequeue_enc_ops_t)( > > struct rte_bbdev_queue_data *q_data, @@ -390,6 +396,11 > @@ typedef > > uint16_t (*rte_bbdev_dequeue_dec_ops_t)( > > struct rte_bbdev_queue_data *q_data, > > struct rte_bbdev_dec_op **ops, uint16_t num); > > > > +/** @internal Dequeue fft operations from a queue of a device. */ > > +typedef uint16_t (*rte_bbdev_dequeue_fft_ops_t)( > > + struct rte_bbdev_queue_data *q_data, > > + struct rte_bbdev_fft_op **ops, uint16_t num); > > + > > #define RTE_BBDEV_NAME_MAX_LEN 64 /**< Max length of device name > */ > > > > /** > > @@ -438,6 +449,10 @@ struct __rte_cache_aligned rte_bbdev { > > rte_bbdev_dequeue_enc_ops_t dequeue_ldpc_enc_ops; > > /** Dequeue decode function */ > > rte_bbdev_dequeue_dec_ops_t dequeue_ldpc_dec_ops; > > + /** Enqueue FFT function */ > > + rte_bbdev_enqueue_fft_ops_t enqueue_fft_ops; > > + /** Dequeue FFT function */ > > + rte_bbdev_dequeue_fft_ops_t dequeue_fft_ops; > > const struct rte_bbdev_ops *dev_ops; /**< Functions exported by > PMD */ > > struct rte_bbdev_data *data; /**< Pointer to device data */ > > enum rte_bbdev_state state; /**< If device is currently used or not > > */ >=20 >=20 > Since rte_bbdev is exposed in rte_bbdev.h it can not be changed without > breaking ABI. It would have been better if data structure was better hidd= en > (hint). > But you can't change it now until 22.11