From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F400FA0350; Thu, 25 Jun 2020 02:31:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D80685F69; Thu, 25 Jun 2020 02:30:59 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 746345F2F for <dev@dpdk.org>; Thu, 25 Jun 2020 02:30:58 +0200 (CEST) IronPort-SDR: dADmuG5aaQXQa1THfEkQ+BXr03noY094ZMBlImeKKkNF6JrPYJMEzPRaHv8fef04KfDlijnaNn vLbzxDsrWe8A== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="142909709" X-IronPort-AV: E=Sophos;i="5.75,277,1589266800"; d="scan'208";a="142909709" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 17:30:57 -0700 IronPort-SDR: ovZ5lfgki1kazP2+f8d+seqTqxeVWHpMTH2ybqBeyMSQRaGYPQ/Y8STqP/sGB2CmR9mgPcAd+1 EIKr3KYPFWqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,277,1589266800"; d="scan'208";a="479463362" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga005.fm.intel.com with ESMTP; 24 Jun 2020 17:30:57 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 17:30:56 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 24 Jun 2020 17:30:56 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jun 2020 17:30:56 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 17:30:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHHDMY+q9nMOWuQQbGlToNObkwTI4lW2UQjxOTYrY7B+XX/02qAD4TRMAU0KtY0DyQpqPCryT3YAzPe6dc3s13keXSX+YqDDLi2YkJbXCnoQhL2i8Z1gespbyhu6QnT6ial8Kx3XTsOgabrJwihHjYPbCtVX3Bj+gK4bEUekOZlZl37jK89hIvRB32pW/LnS372UsiUhebQzZK/mZEW0xkjP9YrnLdNk08Mwji9Npo3USEIVVnxVxwS3mqA5lGO8RU9iWn+fYtvIx/4h2QCSQDE97xxuQWDRuvGD1VbV489+ordhVcYsRM2j+kV0nXjQeVu0TRDLcn93DT7m6rN00w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cy85Q2dQtTe/RRVL37IVH1hav59t6kcfRNmpbqqb6VY=; b=IHbPxlde2Tviw77lklUbliH0QbXukiDrRfa5bOw9d0KlBOy6VeTsW58MU2aIIfbrjMNUXZn9vAlVo+25iEi0F5P0HoS2NaD1CdvYh6jJM3vnnfe6oV1ZPS8gmz73fytxlSsDc7UXCx+5U2l0dlt/dBqPwNGcKiBiHPV1rVTlyGms9QSLTCKQ5SpXhG71s86XdR2tr6QOvrYfCdYBoPbrULZJjVn8IFaFMbkorIFB+tcrgN00zdtNVMA/MSNj2wcksK/e4kEYrPKTabJMcQw/tRdgcYvey7zV2j9jn28mRdXRUMiiOFo6faeh4gSo/sZmtwZT1+PN3oHtBv33qjzrHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cy85Q2dQtTe/RRVL37IVH1hav59t6kcfRNmpbqqb6VY=; b=xEdoZ4ca3OxDDwzpOyMPTLEBPro4lj50vZRHw6UUvHfYxnFhJR2h2c2POelqKKhl/NGs42+B+eprboHzU3BYwmyB9Ev5eo8I1qJgq34Vpg0RRsSRz0nLkJgo1wXdTs/gDAC/KVtVB0y5lIaMkPx/8aKdMHFSCHJhDtK8dxtaVec= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3573.namprd11.prod.outlook.com (2603:10b6:a03:fe::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Thu, 25 Jun 2020 00:30:44 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150%3]) with mapi id 15.20.3131.020; Thu, 25 Jun 2020 00:30:44 +0000 From: "Chautru, Nicolas" <nicolas.chautru@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Thread-Index: AQHWBia5R0/Gp5PdrkGqhlhqLpHPAqh8s+sA//+q7ECAF60+UIAEzVkAgFAnemA= Date: Thu, 25 Jun 2020 00:30:44 +0000 Message-ID: <BY5PR11MB4451A8D5B9930E023723AD82F8920@BY5PR11MB4451.namprd11.prod.outlook.com> References: <1585526580-113508-1-git-send-email-nicolas.chautru@intel.com> <1183128033837D43A851F70F33ED5C57893CA2A6@ORSMSX155.amr.corp.intel.com> <1183128033837D43A851F70F33ED5C578940A89F@FMSMSX109.amr.corp.intel.com> <3297014.iIbC2pHGDl@thomas> In-Reply-To: <3297014.iIbC2pHGDl@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b47adf2a-00cf-4c8b-8527-08d8189effcc x-ms-traffictypediagnostic: BYAPR11MB3573: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BYAPR11MB3573D8EDB3D6D110B5FD0D2CF8920@BYAPR11MB3573.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0445A82F82 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cOA0N1O4UP2nSDDev/uayKUXMTfEEJzFqSXXl0C0QKONm5EguT9cbw7Wr0JStnoJr37FykRH2hBTHnwl/WWvWAWyE6qW1tQJBYG2Lk5yeGeS+yPwPvb8pAhLsotiNJxcRwvyhsXC4NeP+YtAG/UwM/W/I3AvY3f2SP1ZscfgTHr89DI+AUINMtR8uAmG1W86JZVAUBivXap7po1lVlFMZleoRO8NpINuLKYMi863hNzNLITaowW6crrtvTWOLOoSfd7S9hKjeV1DPfGroicXHJ6H8zFiRctfZuxin76QcrHJrNZQvn/7fyhzh5sf1m3MyHX+mnW/T3nT9rotSVFwHJtyX3tYNjJbUFQ+otnfGxr10WdyBb4CxL7eYlLLePEiN9rRizjCF4n3jaB3AVeIGg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(55016002)(83380400001)(7696005)(26005)(186003)(66946007)(6506007)(107886003)(8676002)(4326008)(8936002)(33656002)(966005)(54906003)(5660300002)(9686003)(76116006)(86362001)(64756008)(52536014)(2906002)(6916009)(66556008)(66476007)(478600001)(66446008)(71200400001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: B1TsrCOz/rZu876ssGVOrbaWyixhOAFVNhxBsa9fxDl1K9DXjE2WxaYhm89TOoWJplVw9pwP/i6durV7s2+pIWScI+6ZZNInDl9/yau8UtjOr7UTQUJJCFmi951oMCsPtfkG5KB/6LBcIXS1K5qBaVK1TFP2vB6C6gNk9I8cs8kiXCZsQC0Zsps2T3M9Jja7cYzLLvZ6fuNa9SJ5d8Wfvnz/Eiex7fdI4tiAVI8Qh6L6W4KAaFMN6PcWbjTskXPlbiH7gndN6zEWahF4UeTYhwgSfg5uZrNN2tQlQ1m+VIHjXL8NDqy0mgVbhovUVxaJ80CuinsFKCX3h0cmU7q2nt5mvc6xRgonhAN2J0xWM1XnxCXFIbEd/VuMg0YaDJ5746zfqKTVGUdA0ZtmnMjtaTokyPZeTONfWkTuVYuhrgXRR331Zuwu7Uxs/fDnjWL6Tf/0nM0IBMkFAvBR2zkKUs8eE+JSUfjJkeA1oJDxRgzI3Xp4XFhlXc1dDXMHFeRD Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b47adf2a-00cf-4c8b-8527-08d8189effcc X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2020 00:30:44.7268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0DRyHaY5uJtvWxOeS3Md6f9ggDnPq6b9B4EjTTD31h8UVlBzXAZ54vv4cT/kurpC4OeL5IKf5s7MZbXBn6mJuFfUAcnamEU+HnhwjyBVocs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3573 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > From: Thomas Monjalon : > 02/05/2020 01:15, Chautru, Nicolas: > > Hi Akhil, Thomas, > > > > Following up on that previous discussion below so that to confirm wheth= er > there is an available option to handle this usecase within DPDK repo. > > > > Basically traditional deployment for VRAN relies on BBDEV/DPDK running > within container where the workload is processed behind BBDEV API bounded > to a VF of the accelerator, all that is fully covered currently in 20.05. > > Conversely an application from baremetal still has to be run at initial= ization > to do the required register poking to PF MMIO so that to configure the HW= so > that the VF is functional. Without this it is not possible to use the VF = driver > form within the container. Said otherwise the BBDEV VF PMD cannot be even > tested with DPDK repo (only the PF PMD with the workaround discussed in > the previous discussion). > > That small userspace application is purely doing mmap and writing to > register based on xml file input (relying on igb_uio bounded to PF, or ot= her > vanilla kernel module) and has no dependency on rest of DPDK (DPDK would > not be installed outside of the container since no packet or wireless wor= kload > is actually run from there). > > Is that sensible to add such a small companion application within the > related PMD directory even if it has no dependency on DPDK libraries per = se, > only the fact that is required just to be able to use BBDEV from the VF. > > On one hand I see reason not to do this as this is not a DPDK applicati= on per > se, but that companion HW application is still required to be able for an= yone > to use BBDEV driver + being within the same repo enforces that there is n= o > risk of version mismatch. The other option being to put that on a separat= e > repo outside of DPDK causing fragmentation of ingredients across repos. > > > > I wanted to check whether you had any strong opinion on this topic and > whether a patch with such a companion simple user application may be > approved. >=20 > I feel it is best to have the required app in the PMD directory, as in "b= atteries > included". >=20 Hi Thomas,=20 For such a companion application to configure the HW within the PMD directo= ry I want to confirm two things before pushing a patch :=20 - This is okay with you for it to build outside of the DPDK build flow. Ie= . Separate Makefile, not planning meson support. Again zero DPDK libraries = dependency.=20 - This is okay with you for it to have dependency on other open-source lib= rary to build it. Ie. we are currently linking to this https://github.com/b= enhoyt/inih (BSD license) as a simple input config file parsing.=20 Thanks,=20 Nic