From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26F4CA0579; Sat, 24 Apr 2021 23:59:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DC0F40693; Sat, 24 Apr 2021 23:59:27 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 35B6A4013F for ; Sat, 24 Apr 2021 23:59:23 +0200 (CEST) IronPort-SDR: 6onlx0Pv2h9uzZoVOFgiSmZTrj5booWg4421LyH5GvPsTdCSAH42VSp09fC9ialXD/3WZHpZbe bYi7krEh8yhA== X-IronPort-AV: E=McAfee;i="6200,9189,9964"; a="183683012" X-IronPort-AV: E=Sophos;i="5.82,248,1613462400"; d="scan'208";a="183683012" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2021 14:59:22 -0700 IronPort-SDR: yceaF0TTU6wGgrFepGqobEDiR1LjNCAEjC+77wxgYoRrkZJlufmWGCJsWVTMtAmksqgNSIRnVo LGCDkXnzsmVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,248,1613462400"; d="scan'208";a="456639780" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 24 Apr 2021 14:59:21 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 24 Apr 2021 14:59:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sat, 24 Apr 2021 14:59:21 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sat, 24 Apr 2021 14:59:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QXlkvfHeqW4dR3VxH0E8qxL/NL8NwajEczVoJ6P5VYNbir8iJXRbbTmH5IeR0nlRXJ5KavgS0Aota4Zf6UQSLpUAha2Ndf2kWxn4ldQew1pSMpKxvhQ38ocKJk65EIlQGWZJ8kEhLqvbE74rleTUbge6f+y34yUroZKwG2RC0DyqDJPnP4ijRymjIaA7QJaXaVyOJS6tU84gxf+LZXbcUj7IAFBbTbQKjBoioA2KOrohg44r36rbzev9fku5mx526YFXuIekl9rFtF6Ea4wWIyFDPffxHvf7fUt7IbdxpBIIJkgH7t2/waZZ+eDDYoqSznKm/EwQ8pE4X/GCF5rf2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c711xWxJZn0wJ11Va76pOh+Yxuo2DucPN4VL+2KadZ0=; b=WUeIWETeIKIEuDH44hDsznwEyBX9+cwhkefo/FjuHNrrMHo8+fDbLLe2f97iU2clOkq/ByNqNconqMhU/L9oDSrcYoir66H4iozVRbDi/LNWnPWtFg3rxWWD/dg2N3YMTditCkXSRyNnTk23Py2X3er8heAClaus0k7MW2iVgCangwjsWwmjCSl8ontQ7yu/ci7frk1xAEPr7EAlQF7kPU7Sq8mFtQCfWGdTVYBWrfHQIQ0OW+ZfHI7OIkQWb3gzaSOnympdq+Fv1/+UFQ/J8d39/Cr45GXiJCZCZ0scWeKHEGs676X9lekPCu0bJ052sUJyH39Navb0WkHjGkvWUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c711xWxJZn0wJ11Va76pOh+Yxuo2DucPN4VL+2KadZ0=; b=IAAGqjvvI/0gvm4ckVZGlysYEca1H2XkYUeo4Sz6xQicuIw9RR7uesu8eV8Y9A1EdPJ6KxCfgxNLu63i9oi8I7KZuw6U8nPLFx4zc5k//PEh1nsMHXSYlpWAvFxQRg0tu4QDhGNLdrIiI3p9lT1fCMl2ZuI4sL4CfH81zZV4IiI= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB2869.namprd11.prod.outlook.com (2603:10b6:a02:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Sat, 24 Apr 2021 21:59:18 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::756a:2aef:40b1:11c8]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::756a:2aef:40b1:11c8%5]) with mapi id 15.20.4065.025; Sat, 24 Apr 2021 21:59:17 +0000 From: "Chautru, Nicolas" To: Hemant Agrawal , "dev@dpdk.org" , "gakhil@marvell.com" , "thomas@monjalon.net" CC: "david.marchand@redhat.com" , Tom Rix , Dave Burley Thread-Topic: [PATCH v4 1/8] bbdev: add network order data capability Thread-Index: AQHXOPX++SaiQhmA90GxljXzzf5YO6rEMkpg Date: Sat, 24 Apr 2021 21:59:17 +0000 Message-ID: References: <20210413051715.26430-2-hemant.agrawal@nxp.com> <20210424103700.8098-1-hemant.agrawal@nxp.com> <20210424103700.8098-2-hemant.agrawal@nxp.com> In-Reply-To: <20210424103700.8098-2-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 243524b2-44fd-456f-a8ab-08d9076c352a x-ms-traffictypediagnostic: BYAPR11MB2869: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rxSEg7j32UxLXhpvE44GBgRn1KtsWp4ugaPT5jB53dXVvNdVvS7bSR+W97BYFDYJez7eNWAZQg1rjk2oOwc8Lup/qeM0PzQCLY/v35Du43p/9gqqhDzudWYzByaDzVf0hNW/lqpvARaXFNDEUHnA9V+Gl9PzVFxGvzmXdjnnyLfshcDAmR8UOgKaN619mJlucq7Rf0BPENYEHJbg96KCgY+EVUH1oYBcY/CKCaAGvM+E31o/IOno88AauhtkFkAognd4NtycMApxq7wkrJbExSxrj0svsJS0NBHsSOaE2eB93VE2Bjc4v1NTqH09VEzVAWVJB4dcZBceLko39LXoYVT/eUux+IiQQ6uvh8DhKDb4u+qqEP2fCKuRPgqONHhESg64rqgfvI2RMKK8yq6AWQAj45xbXV58of6za0Efv55VGHSbwTJD2b0dmCr8UMxr39WV4t8jTzs/PPpxczYBzZuP0O2yPZJJutkDUHX1l4tKMm4PF9ZJwyBwfuM7rcAB7drV93rMOtGIS3S0RpWlgRPI8cY8MqmA2EvXrVIb9aQ7TZEqvhB4LJD/bcf/tc3YID0AeD0+GStf97+UktqK9TK2lnljRDUN36rpoXxfAt0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(39860400002)(346002)(376002)(366004)(4326008)(478600001)(110136005)(26005)(122000001)(186003)(316002)(9686003)(33656002)(54906003)(55016002)(53546011)(6506007)(83380400001)(86362001)(5660300002)(52536014)(76116006)(8676002)(66946007)(38100700002)(66446008)(2906002)(66476007)(64756008)(66556008)(71200400001)(7696005)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SoahZYcdQ8chE6IE21brq4zmFL21mFGc+34hXzkgnmV7ncwLZgobBmbNpZQ4?= =?us-ascii?Q?hmoI4tBfndeeD4snsFLnWCk23elcyQs5mnpAuGZEHdet73jVnWMcx1iVCB16?= =?us-ascii?Q?6QyaFfiPsbxWUMT/1aKwp6DlccmVF2zEtHPpJO3/VcKZZzAMofxBMkW7f7Nu?= =?us-ascii?Q?5ISX+FoW5mbBqXmNKUcd5IuS8HMZGMyD32XnQCIUTtjM3A7jP8omqGm46sfa?= =?us-ascii?Q?UiioCZZC5b0A2C2YJq7mNn/F2FtV84vpPWeI0j7TMC0Z/6HDENTKkmK8lGSY?= =?us-ascii?Q?zriR1JdcPlHEG0co4hUB+j9LhvAI/HzxxcurRVceyofg996EhuMGBdIuhZiv?= =?us-ascii?Q?931mtNLGYuXVigYK37HLg69sI3R2hOa+AmHRZ+ljaS6RCpc4cdckKQ4642lV?= =?us-ascii?Q?q4PpVAT41yQZ5y3lCuswdMDHNh9R+/K8goFDydesbZRVap77O839HF2AYfmP?= =?us-ascii?Q?Ar+LcN/j7QSKWaKNyZzXaYkMd3SKBmpnS0aPslP3Ul73p6qSWy+Zq0+/G+vd?= =?us-ascii?Q?dEXtMLECA+ROr1XXV/KaAOtWtpenQQnVXNpMZCmNedbtqy/YKj4w/XbGCTnP?= =?us-ascii?Q?VjzFm64SAW06sHs/yEa+P3hSweLhXkxxlMVztp3i7EeV7EnQqU/R1MYRioIX?= =?us-ascii?Q?2pP3gGxA22dGbWNB+vgsm8Q9aw5z8GscPuOZXueVkvmTrWZ0N5AMkMS/VIrq?= =?us-ascii?Q?HxYfp5a3due6dHXncJFsHFaR1DR9VpnjLyPU5ekry8LinpymOLDOeJy0+g6g?= =?us-ascii?Q?mmFmUOfE+4GpD+3Ex0Zm0zH3Jn5xh1nkzOzMifzLfOtrB5npPail1K3m5Fif?= =?us-ascii?Q?l0h36pPKJy+SJvzwGNrDac4w3PQkUCbSX6XszXexjjq+ez55X3lg5mOPfJ+R?= =?us-ascii?Q?Z5q8Kzwq80Nzav5xC49EdPIQ5t4d1JjllwQKMmGEtlnGJH0FBsYx1sqtrEVV?= =?us-ascii?Q?alS1P7S9Q1Gntk+enlC7pg8GHnxClK0LQnUb4OSApFEs45zbMrSezXnziJdU?= =?us-ascii?Q?llulFaYKzEenlYXR4GtQ6q7sTVEvxrbtkavUuO9iWi2KqdwfFYMLSCdbu25A?= =?us-ascii?Q?J/lK6ViQl3Nuj8F+MRADoE6EVLZQTuKKovzUT4bQI2inel4JP8vGYjgtMk86?= =?us-ascii?Q?j6JdhS/o8ua9E45RXGwcCBuxTQCupRvzTBFZDCvJqYMesuS9pXdJ4hRL5DHg?= =?us-ascii?Q?3bduUeMwQ7cidbnFFMGv9CpwV7vR7L4YHIy2Z47hC0lZ4SmuuCe5SX8B75RQ?= =?us-ascii?Q?HDcX09rnTEMbGOuzNsp/0yy+MerIlJR2kOZWYaS7YKxwAOJiBL6dykq3/fl6?= =?us-ascii?Q?kZw=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 243524b2-44fd-456f-a8ab-08d9076c352a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2021 21:59:17.5388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D5JnMBKOr6mr3zXibtsTb5Pc6TDcKSO8p8F/nrqNZ1AHP4Zws5wUaIiyrvu6kPFsfpaCauCC90THuroD3b4UtshqR3tdZj9DXPctUAEF9V4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2869 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" + Thomas, Akhil In case this is for release 21.05 isn't it a bit late for introducing a new= API change? > -----Original Message----- > From: Hemant Agrawal > Sent: Saturday, April 24, 2021 3:37 AM > To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas > > Cc: david.marchand@redhat.com; Hemant Agrawal > > Subject: [PATCH v4 1/8] bbdev: add network order data capability >=20 > This patch intoduces a new capability of the bbdev device to process the > LDPC data in network byte order. >=20 > Signed-off-by: Hemant Agrawal > --- > doc/guides/bbdevs/features/default.ini | 1 + > doc/guides/prog_guide/bbdev.rst | 6 ++++++ > lib/bbdev/rte_bbdev_op.h | 8 ++++++-- > 3 files changed, 13 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/bbdevs/features/default.ini > b/doc/guides/bbdevs/features/default.ini > index 5fe267a625..e5da644099 100644 > --- a/doc/guides/bbdevs/features/default.ini > +++ b/doc/guides/bbdevs/features/default.ini > @@ -14,3 +14,4 @@ LLR/HARQ Compression =3D > External DDR Access =3D > HW Accelerated =3D > BBDEV API =3D > +Network Order Data =3D > diff --git a/doc/guides/prog_guide/bbdev.rst > b/doc/guides/prog_guide/bbdev.rst index 6b2bd54e1a..89a86d10fb 100644 > --- a/doc/guides/prog_guide/bbdev.rst > +++ b/doc/guides/prog_guide/bbdev.rst > @@ -747,6 +747,9 @@ given below. > |RTE_BBDEV_LDPC_ENC_CONCATENATION | > | Set if a device supports concatenation of non byte aligned output | = +------ > --------------------------------------------------------------+ > +|RTE_BBDEV_LDPC_ENC_NETWORK_ORDER | > +| Set if a device supports network order data processing | > ++--------------------------------------------------------------------+ I don't believe this is an extra capability extension per se here, but actu= ally a different assumption. Tell me if I misinterpret the intent of your s= erie.=20 >From looking at the PMD I assume that you may mean " Set when a device `req= uires` network order data processing" Basically the distinction I am trying to highlight is that it depends wheth= er we want to expose this as an incremental dynamic operation flag that you= can set at run time (enqueue ...), or whether this is more of distinct ass= umption that may be different for each PMD (either one of the other).=20 I assume this is the later, please confirm. Ie I assume that your PMD would= not be able to process the data in case this is presented with other endia= nness (ie you don't check ever that flag in the op_flag in your driver), in= that case your driver would fail many existing unit test if considered as = an additional capability on top of default one. You probably see such failu= res if you have tried to run the regression which would confirm the issue.= =20 In that case we may want discuss whether this is not actually more somethin= g to be capture under `struct rte_bbdev_driver_info` as a bool endianness. = Both arguably may work but later arguably closer to the suggested intent an= d less convoluted. Worth discussing further/ But basically if as this under that structure that would be exposed the sam= e way as different LLR numerical assumption and that can be handled gracefu= lyl in the application/bbdev-test.=20 + Tom Rix, Dave Burley=20 >=20 > The structure passed for each LDPC encode operation is given below, wit= h > the operation flags forming a bitmask in the ``op_flags`` field. > @@ -942,6 +945,9 @@ given below. > |RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK | > | Set if a device supports loopback access to HARQ internal memory | > +--------------------------------------------------------------------+ > +|RTE_BBDEV_LDPC_DEC_NETWORK_ORDER | > +| Set if a device supports network order data processing | > ++--------------------------------------------------------------------+ >=20 > The structure passed for each LDPC decode operation is given below, wit= h > the operation flags forming a bitmask in the ``op_flags`` field. > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index > f946842727..8fab617768 100644 > --- a/lib/bbdev/rte_bbdev_op.h > +++ b/lib/bbdev/rte_bbdev_op.h > @@ -186,7 +186,9 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks { > * for HARQ memory. If not set, it is assumed the filler bits are not > * in HARQ memory and handled directly by the LDPC decoder. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > 18) > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > 18), > + /** Set if a device supports network order data processing */ > + RTE_BBDEV_LDPC_DEC_NETWORK_ORDER =3D (1ULL << 19) > }; >=20 > /** Flags for LDPC encoder operation and capability structure */ @@ -206= ,7 > +208,9 @@ enum rte_bbdev_op_ldpcenc_flag_bitmasks { > /** Set if a device supports scatter-gather functionality. */ > RTE_BBDEV_LDPC_ENC_SCATTER_GATHER =3D (1ULL << 6), > /** Set if a device supports concatenation of non byte aligned output > */ > - RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7) > + RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7), > + /** Set if a device supports network order data processing */ > + RTE_BBDEV_LDPC_ENC_NETWORK_ORDER =3D (1ULL << 8) > }; >=20 > /** Flags for the Code Block/Transport block mode */ > -- > 2.17.1