From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE442A034C; Fri, 16 Sep 2022 02:39:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 900A44021D; Fri, 16 Sep 2022 02:39:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4085440156 for ; Fri, 16 Sep 2022 02:39:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663288759; x=1694824759; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=y68OjofQYGkrv7FBOQU7e1XCvamm4R4SDOSbVXGYzVM=; b=Knu2EeUn4sIt8GZeiF6L9k06WAcWVhVHRelSApRkrGsVY5o2kdavfO/8 WRq/py8WuaQ8puZ7MFqLCMXT4+nVke0xAxcyyc9CmeQhAKa5TdPAnbCg0 Ri465PQEP+Nw6K/3ElXOMRbK77OTV4TMihbCI5ewjm3Lah/ncCYupOsKL seqyDUZ5VPYMh9gMjJ3DRe1XqCDFPco3/hTqQqkMp4/PvRIr66uv8JBXD AamKnvHVPT5iGcMUI+DM5YC49aUPSiZ6NLVwpJEr0bWO3nWFck7vNlTlt rkwg0PX4SrPHH0OkLZmIqLJz6GEFM4f6OJ96YKtO8f6LoiSwyUApnwR2a w==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="385166969" X-IronPort-AV: E=Sophos;i="5.93,319,1654585200"; d="scan'208";a="385166969" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 17:39:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,319,1654585200"; d="scan'208";a="679764075" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 15 Sep 2022 17:39:17 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 17:39:17 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 17:39:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 15 Sep 2022 17:39:17 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 15 Sep 2022 17:39:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNoeMDdmZnDJGVaakeyljBYtmU5AwJqaQE7TOy8d754cwJHxF6lzMF8qMgnxAV2L52aMU53Kw8uEOWcJvNheJ9kb/hde+BK/ra51/Vh5xcUKqLbOJAPD4lYEBpvHwJ52qeoKd9LbTELxUUUUuqMlYV1WoC0tqlG725fpFTzoO0oEBTyTADPFMMeT0m8tlhdESzw1kLx6/dd2CsUvZyGLkE7Q0vorv/Puujs/7UqU8PaxDyjwElx5t7IrXfo3d54OqfLJdLdIZY6mE8vNOghOQ++QSjO2Dh8Gauk7b4RReA/JzzCSHJoh8t4kTK3ZU0FA9+9FZv9TUv+UKbONHvzF7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0lj/qtAujv2/4yD3H8OCWNIZqb4UhExTJCFNRMHO+AE=; b=jeBwTJuai8KNxu1zqcNdxpR94uB3nXVxZxzlbRdrI9l1/GiSERCkyn6bsyBD0WdeMYJ8xM8SxGd3J534GMvDb2FUHyfmFL6267kMO3RnfW0fjBJAAPwov9TFj6OhT4R9fjnBbzIcB1jTa2Tc/AwdAYo1ybSautYPjZLTz0Sif5kXWZNZqIYA92oWcw+UvlPUezSggDwwy30Ytn7vCdRQwYzjyY4Ua72r7c6ngK/evqAc0+35+BvCqaMoD/b4axNZ4VwJlciYANFe2TEccrZXWuBL7uJW7bQsJvl2fgi/1Klmm+5pj5u0pqoUBxTOTOCLyiGQnPyQ9kYQDED6Amf6GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by SJ0PR11MB6743.namprd11.prod.outlook.com (2603:10b6:a03:47c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 16 Sep 2022 00:39:15 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::57c7:4e41:d599:8df1]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::57c7:4e41:d599:8df1%6]) with mapi id 15.20.5632.015; Fri, 16 Sep 2022 00:39:15 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon , "Vargas, Hernan" CC: "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "Zhang, Qi Z" , Maxime Coquelin Subject: RE: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency Thread-Topic: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency Thread-Index: AQHYs/qdeUql/VKtUUKn2z84AopDRK3gdMiAgAAHLQCAAOP68A== Date: Fri, 16 Sep 2022 00:39:15 +0000 Message-ID: References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-35-hernan.vargas@intel.com> <86ecbc97-a280-903d-7ccb-62f3843c1f98@redhat.com> <2608223.q0ZmV6gNhb@thomas> In-Reply-To: <2608223.q0ZmV6gNhb@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|SJ0PR11MB6743:EE_ x-ms-office365-filtering-correlation-id: 4f5af164-8230-410f-9f8e-08da977be205 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ASePUjZUWwbOJzSnYxAaZ0NKsLfQ/VrrXoiK1+f3cTMABrkmBdbv9FweG4kVja+gEPgZsE/T6qdQq9+BCkVevhlPCK5Ew3qHYGb7ZR7jIWvKmwNFBn6LXbYDB8tfrSj2Zd8V7wSsmF08hL7J565Xm+7RGjQMCbAqnKV6tNyh4VOU+g/+KcZ6jClm8j7YCkPfvMmP17qR1e1rTbDH4pY9W8SRX2kiLBEvVznWEU18pDJXPXSq5cl21AiTVCEk0HB58N/M4WeuPKTbpYtAHfxUS+UyKOUEUoLBrHfLRbu2bQtCke2j6sKbsiyZEcxQEV7yzgIyZ3zicNtitQM9bwiAEvWvD51Yab1dnTpzvfRuf8sTmlmJdi+nvTiQjMv2fdJFOVmURuOXPzrFPSUkICPPBW0Z1m/bnv1+3liiutTHQ0z0hkKzPsUHt7U3EMGVxCeNHzCkWiyCputwsCU40dG/Pp/XzxLs2NgduJWFNETnOG9znUGLu8WswWQSU7OTXh6DcwgUu8dXwmgJa2ka1OufV9qJEQKfkid7qkN/IAFPTs+hmiocCEsQ0S0dHijUyKbnfSyG/q3jpd9fN0SuOe90zsN+2A6FyzLxjdDkYn7QDvWgTHRyWDSu+DopsOPXh4Od52RbpBcUTy4uIRHTEaP1zfy3vU8Ji8MIqTkoymHpdAaejujLZMMGKj2/e+/x3Zk2lvk6b7Awdm0Q6DJCUpJXT1gEzZJtAgZ2vpVLAX9VM09ACSNwZKSQb7W6HPL0geLL2vgCo9o7LVtFfWxUkueZJg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(396003)(366004)(136003)(376002)(451199015)(76116006)(41300700001)(66946007)(8936002)(64756008)(55016003)(15650500001)(186003)(54906003)(38070700005)(66476007)(83380400001)(66446008)(52536014)(4326008)(26005)(316002)(6636002)(110136005)(66556008)(71200400001)(9686003)(8676002)(2906002)(478600001)(6506007)(5660300002)(38100700002)(82960400001)(86362001)(122000001)(53546011)(33656002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FH+XpNDPhBNShigeNDXjnJM4znc1Im+wXmHzDWg43lnK/bv40pz8OD2/5adZ?= =?us-ascii?Q?7+sRVGznFQ2aLKfXzCEIuUquMsWHYASefvRrznz5mnS4d8Wq1I2cRkDJmP4j?= =?us-ascii?Q?xgYTX0FPa5KsQNf153wn5+Yg7W+lnw3SSu91gL1nyRqbVzGBc1Gtpyei5l3I?= =?us-ascii?Q?SH0vvOR3w5CW0I8hT6kldwwF1vrRQa7toameVkerewC6M7KEATrClgNDcb7M?= =?us-ascii?Q?83hVjsfHsIUeZ+zdTrqxkSJ1s2LySPCQOyll9cU8oc25Sfn4vt+Mi/IGu1tL?= =?us-ascii?Q?53PG09wMb4Qc2vBO1laR7PdiPZ4jD7+roZ96ytxMdHU4FHSF2x6maKpXbDhr?= =?us-ascii?Q?hidLAShyLyZsZzC0bFBbLFpKN27iA4gxXa9AHRlFfIMuxwSR8HIIQPCvJoJ2?= =?us-ascii?Q?jG+eRSS0VvWINVSZV7hLslqhJcSpaQxQGm6QQiLVEOQD9ZHr2Fsyl5sMVJD0?= =?us-ascii?Q?wXpJHKoAzbbTH/rL9W0AgQErfjeCkQVXHHjJEpN/s32wRXtgew/N1TPMJp0H?= =?us-ascii?Q?zm1MvSn/zLrzGHDotmORLRHhhLm1/tHSahIzlkB0WnwR3UOQXpRyJCXFjkEb?= =?us-ascii?Q?RBWofitDwEw3mzufREn1uCWqEJgLH/6WZ+ZRheiOH4+ZWuT1NobaJn6bswRc?= =?us-ascii?Q?UCkI0iVm+2zAVGv5a9fAbRUyGdJ0TJEgyJ5kAooTYNTFsW8M2sWrVfQi460I?= =?us-ascii?Q?xphQa1DAQrZZnlz/NZz1j1KM70MiEl05GGfhdNoOM5gvtbzWa+9wdbZA/LpL?= =?us-ascii?Q?NQeLuBawYy1NNjXi76CDgHGxUsCGncWctYPtzP6nUJalAOdmxCxxICECpYTP?= =?us-ascii?Q?yapEBb5ETpemQSPj55BVD6rgOZy1U2UZrE3OE5/x8dpSNZluiN1t5BWvoVer?= =?us-ascii?Q?wTFyT6wWEqF7T2kcV/7MxYYNGM6x90P3HkgdovcJwqmiziBtBM6EazvMBWYI?= =?us-ascii?Q?etnSqv6Z7AKGp5XIKmVMlmsWHNqjdBEVH44Yfal3AFXf9e8ZKt4V7Qz60kfW?= =?us-ascii?Q?FNBk9z8J0jaoMeGnxZ8M23Y9oARK1Bgv1EZeIEWxtAkMzxAJpSssbo9JR3be?= =?us-ascii?Q?0JkBPlZCAE3kC4yld9Ge2motFdDSkeBFzAgCuwkRJGOX3pjtenh36nTd0mhG?= =?us-ascii?Q?NRPCRAfmFfn7h571kcwn5fsZSJGixYfJb4nLm8CapA0xRNqPqSYwvW5ANKPP?= =?us-ascii?Q?n7XBeQfLVrEW0+49EMBkWNx5M4UrZX2UeY+4BXkaFUAPG+7fmcshrxGtXaDG?= =?us-ascii?Q?SI2ngzCg+Tj5Zm+G9LUExZA8tQMjbxWV+BaMzJVHejijBEy8kAMrtsrsIfCB?= =?us-ascii?Q?w69Vaq4QiLNnDa9w0+xvBAIbesnFyW8350puRI607kgJ+ThHkef4so3FnFNM?= =?us-ascii?Q?aw2WZi7sXMMjACcs+Qb5SmwmhZqLuqJcxsAb7gWvYu4aNCZANIv38v+CiSWQ?= =?us-ascii?Q?8+BUczhH2FkjvSeID5xTN6AejqGK7sBXoM49rC33GU6e3OuMONYE0oggMaJQ?= =?us-ascii?Q?UAXZKUC+H7ikUN1rU8tmlPcOirWF8XCGanr83YRoiJ9reRxAs8XpW65SoxIg?= =?us-ascii?Q?YID0sUQVqH5NAK/CMxE05BCV1vXdL5UKWhLmpL2d?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5af164-8230-410f-9f8e-08da977be205 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 00:39:15.4824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mFZJLbO1Y98bTJfDDvMNpTDa2qMZbzvc4+sWbD09fQqTdYu/7kgBxkQpulScqkHg+QToG2tlRTSVCmcwnAUaZIZs/x4g3NCgCNWCy/aaCzo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6743 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas,=20 > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, September 15, 2022 3:58 AM > To: Vargas, Hernan > Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; Chautru, Nicolas > ; Zhang, Qi Z ; Maxime > Coquelin > Subject: Re: [PATCH v2 34/37] baseband/acc100: update meson file sdk > dependency >=20 > 15/09/2022 12:31, Maxime Coquelin: > > > > On 8/20/22 04:31, Hernan Vargas wrote: > > > Update meson files with FlexRAN SDK dependency. >=20 > There is no reason for this commit. > If the reason is that you need these dependencies for some features, it i= s > better to introduce the dependency when you use it. > Patches should be split per features, not per file. Agreed this is a mistake and this change is actually required by patch 15 i= n that serie.=20 >=20 > > > Signed-off-by: Hernan Vargas > > > --- > > > drivers/baseband/acc100/meson.build | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git a/drivers/baseband/acc100/meson.build > > > b/drivers/baseband/acc100/meson.build > > > index 9a1a3b8b07..3b934a25ca 100644 > > > --- a/drivers/baseband/acc100/meson.build > > > +++ b/drivers/baseband/acc100/meson.build > > > @@ -1,6 +1,27 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2020 Intel Corporation > > > > > > +# check for FlexRAN SDK libraries > > > +dep_dec5g =3D dependency('flexran_sdk_ldpc_decoder_5gnr', required: > > > +false) > > > + > > > +if dep_dec5g.found() > > > + ext_deps +=3D cc.find_library('libstdc++', required: true) > > > + ext_deps +=3D cc.find_library('libirc', required: true) > > > + ext_deps +=3D cc.find_library('libimf', required: true) > > > + ext_deps +=3D cc.find_library('libipps', required: true) > > > + ext_deps +=3D cc.find_library('libsvml', required: true) > > > + ext_deps +=3D dep_dec5g > > > + ext_deps +=3D dependency('flexran_sdk_ldpc_encoder_5gnr', requir= ed: > true) > > > + ext_deps +=3D dependency('flexran_sdk_LDPC_ratematch_5gnr', > required: true) > > > + ext_deps +=3D dependency('flexran_sdk_rate_dematching_5gnr', > required: true) > > > + ext_deps +=3D dependency('flexran_sdk_turbo', required: true) > > > + ext_deps +=3D dependency('flexran_sdk_crc', required: true) > > > + ext_deps +=3D dependency('flexran_sdk_rate_matching', required: = true) > > > + ext_deps +=3D dependency('flexran_sdk_common', required: true) > > > + cflags +=3D ['-DRTE_BBDEV_SDK_AVX2'] > > > + cflags +=3D ['-DRTE_BBDEV_SDK_AVX512'] endif > > > + > > > deps +=3D ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci'] > > > > > > sources =3D files('rte_acc100_pmd.c') > > > > I think we should improve build coverage with stubs. > > > > For example, we could stub bblib_rate_dematching_5gnr(), and so all > > the code under RTE_BBDEV_SDK_AVX512 ifdef in > > enqueue_ldpc_dec_one_op_cb() would be built. >=20 > Yes, having code built even when the proprietary dependency is missing, > would help to track some issues. >=20 > > It would even open the possibility to have open-source implementations > > of these libraries if community feel the need. > > > > What do you think? We need to assess at compile time whether the SDK is present or not, as the= processing would be different (or in the case of the turbo_sw PMD using th= e same dependency to talk out some dependency). So I don't think the stub is an option except if I miss the meaning of your= suggestion.=20 Note that other libraries could be used instead of the Intel ones as long a= s the same prototype is used (this is notably used by 3rd party company to = provide their own implementation of these modules). > > > > Thanks, > > Maxime >=20 >=20