From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A32F43885; Wed, 10 Jan 2024 18:19:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DC9E4025E; Wed, 10 Jan 2024 18:19:51 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 08E1E4021E for <dev@dpdk.org>; Wed, 10 Jan 2024 18:19:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704907191; x=1736443191; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bPWrG4RiZoKfbioWUB5ybuIsGPsZ0AkXorau7WGj7as=; b=QHXbzl3YPRrhhRSp0KFpwbrolSVRQZJLqph99EYIY6IE/P51Ql5nNQVs EW9aRWFLlzHmBxA8Fv0Y2kddnC30RMqgMFGdAND1pEk5n1ox48AnTRjuH unZd3JPBXf3he94icKENSH3eL+H+x9dLF+AmkpUi1/G36rtOeypjuU/t4 usKKjofAqm4MaUtK/vKIAHzXts5GeX/4ogy2jQb6bWeN5nzjRWMw69s+L WXg7jFCCGS95s0ldA9SKEwpn67ezOWSqIIX0p+qvenaR10Cb8KI2m9U83 yEA3wgAhFuICKrU2BbH8A1zOEhLhQ+EPhrldgoRTGEJC+tfoHBS3EHJl5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="5671552" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="5671552" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 09:19:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="775288685" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="775288685" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Jan 2024 09:19:48 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 09:19:48 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Jan 2024 09:19:48 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Jan 2024 09:19:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzE1Uu7HFB3bfjHrY3x84UJB7eF5LyN1fbwpUd3/S0hxEF654e1HCC0r8Ac/DNk/OaCCuUHPK3p1xUK5XDaBma6EJhzUMCVueIKzx/gSLK1ErngvR2EULpDOu+JL16k31AMgDTMJJzfghEf4BpicFEyt/yLxnZYqClE+hX5wiK+NgP1pCINSQO0D1gYLLQDpGROELcBANB3MiaXSsu8dpDNM2Mu8ocbBcY8mV9FeWFjatR5vZ8Rwr3VigEs4jixwxRshq2rNfWAnoNgdg/8GbHgTXMyAFixB5m6VG89UfcyVHTRvaLE1uNlcpRoHWOfwVCCazbcxG8C6/gqebS1zVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IR7A/Qv2CdC0QmMUZP74dNpMeZGU0MaYoPBPa/v5fWg=; b=kdFDVofMVjofxtvUVcgDysG0q8dJPWpEzc8e7igckeowG2WBKVhuvLMPljG66Sr5fw+jCHgey9HmtKM7fkInj64XYbiDD2K0mRGzGwy0IyV8G2sXSwjePe33qRTrCwZ4sq0PecGuuiTju0/dR6qu5CgpU9vwKj1Ujs7l5rbnXq5RXnyPsHmaQCxWp8Vl9LdVBwBg9t1/FcOtIgkEl2a2WmlDMb7e1V2VehuRGXwwnOPNP3NihXNEJshSb2I2+eGkmQm96SafVWB0BfpmrGNeo9ARJpjcufz8khEBr/UnWELAecAvGi+bsXCgtJy1eC8xzg68x6uVxK7F6btntHll9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by DS0PR11MB8070.namprd11.prod.outlook.com (2603:10b6:8:12d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 17:19:45 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::1837:7a0c:f8e0:2354]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::1837:7a0c:f8e0:2354%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 17:19:45 +0000 From: "Chautru, Nicolas" <nicolas.chautru@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, "Vargas, Hernan" <hernan.vargas@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "gakhil@marvell.com" <gakhil@marvell.com>, "Rix, Tom" <trix@redhat.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> Subject: RE: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Thread-Topic: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Thread-Index: AQHaQBzMe0s1Al3qAkiPLyCsLvg+z7DLxNkAgAeMlwA= Date: Wed, 10 Jan 2024 17:19:44 +0000 Message-ID: <BY5PR11MB4451CE5728D8C39737553A70F8692@BY5PR11MB4451.namprd11.prod.outlook.com> References: <20240105211519.185086-1-hernan.vargas@intel.com> <20240105211519.185086-2-hernan.vargas@intel.com> <20240105140004.7389f645@hermes.local> In-Reply-To: <20240105140004.7389f645@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|DS0PR11MB8070:EE_ x-ms-office365-filtering-correlation-id: 3f4ffab0-6e26-4ae6-b726-08dc12005711 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yk6nqKr5Q5LCEVDeEf2qADFjUNai7PBWwKZ4pEMtGuHpM/VGVa9g7NSVuE60D9quMUMcnH0YIKzvuZQQqbn09hL2t0O0PwpUIsAmdl8QvQws2qT+2jFu8IVJ+LStdpLqHxBT8OOuYxYtH1DZO15tcbtqdU3ZdSyZRMqkrmNn5XzgZncxyijHNsmB/dIklo3Y/dYqmI3JI5XceMQajznQm/crvOM8mDpyXn8tP42e+bEZhClkoK2k+XliELtJo17X+CrQCp8WmCifcg1cXaSowtfcvGU9U9cxrkUt2RWoNBkKkHgOssngMf6Jmlq8WYJkuso/57/EboRK7lAtGcc37kBlOeiP5nNP1j/ELeKEE1kjwugtS5VadMbiGrEDgzw69rW+rcHLQLHyLmq0jn/msh4tdbv9+50JPsLLHQjr3o0oRBc7DY4qfiztloPV2S8dMesEEKqw8KcmqE2DIOZWdI3W6456LSfjfl2mAYs+anTryfrU8Z8q4eno+NVIesPhtvOl2BxTi1emU66a67CxqBnQMkEcbZEcKntDiDTFYqAVsGmGhxjSSSn969sKu5agMZZvbpDHFsc/dWt4L+GVBKNqOrY0vaCjHLGF3CMfFfRArK2Kho+dAF+9+hUsj2r9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(376002)(346002)(366004)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(38100700002)(83380400001)(71200400001)(122000001)(66446008)(55016003)(64756008)(8676002)(8936002)(52536014)(66556008)(66476007)(54906003)(4326008)(6636002)(76116006)(316002)(66946007)(110136005)(82960400001)(53546011)(9686003)(107886003)(26005)(7696005)(86362001)(33656002)(6506007)(478600001)(4744005)(2906002)(5660300002)(38070700009)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fcl5bTVr5HxBQRLf3oZuADZ5+l0v/h1oqbZT6kXW5zvNS+5ZAabDHtvc00q+?= =?us-ascii?Q?QwIimm39pd88yz8/Rx11Rsr+d2enOP3afitWo12so1a6RTruS0Ct3UPOeIiy?= =?us-ascii?Q?IA4CdFLLRo5cYeufV/CRvGNsF6ntPW/zNmS12G/yItqjyYONijK03xaMxdQV?= =?us-ascii?Q?dz5OjoQvjq9+t4Zo9HqJBo0EApEssVb6n69wumRMTBIPnmIJR0yT24i9izXV?= =?us-ascii?Q?KWCyKGx1isB5sPWTyBvlxyYvZvllGCAQzdAyRY4PK3rxPbBHC6e5R51WWLXo?= =?us-ascii?Q?bK07byJt5/aor9pWx3tUP3un6wo1O2oktLxj9FiU9AJdWjTFXzXa7bTrFKUX?= =?us-ascii?Q?kmqdp7QGxqBb6iaeuOZViR1dekFeFBkSs+DHsJxMFacSeVTPHE3LCrk8ik4R?= =?us-ascii?Q?JCjObcfEXgYtF/ENeanBtHRq9arYbx3F15qoCyBdnqZZuOHn46Pn5dba2+pm?= =?us-ascii?Q?TJE+wfJSiLQRb9jns/KGEofZC7cFDB8+VgMbar3Po2lwMIDPnPf5WC9qlTnj?= =?us-ascii?Q?ItnBj1qoCiOVKInxvixC6oAvJhCGJpXnx1iOlEi4KE13fDrbfqrTQHzwgq3B?= =?us-ascii?Q?JXTbWKdHOTh2uH2Rciq45eLNiEXEhWBqfIRGNKUHLhPAg/95WuPy9+mGv84a?= =?us-ascii?Q?z8tRnSiBNImHXkmTtMl3plJIZb/QDO1G17rfckkgaNKh/J7sRm8uhzTfqJUx?= =?us-ascii?Q?ij+ZKaQWF3is7nW4x69GJk7tacbx0/2mFyqyS9lUmTXpP92iPOHJvtczeuM8?= =?us-ascii?Q?nZIay5QzR1du3NhsMMb2+kwxDu8PgvzNyOuZ41f4Wr8OtdIkySNQ/RMlqeMD?= =?us-ascii?Q?vx8i5kgAVMlTs1L2dEzDVa/p2lM5Tspt7e6F6Md6Cs5z6g3yteqHRGq5wwqC?= =?us-ascii?Q?xqsXISshmCTqRiQ4JlaGzqk9OJt9GZd6QAyFyTrypkUqeA3BIHRe6EZBsrkz?= =?us-ascii?Q?2cd8kU4WTgwPsueY7TgA2DqI/AkquA13Lju+Eb8Tmh9hFhukzz+vlfkbYMdM?= =?us-ascii?Q?BMiWghtd6h4yUXFch5U0ZVqNdSWpHGc27oaMgpLZLuBJXyEe2CueijMZ3/UB?= =?us-ascii?Q?Ls46Dxvh/tE+dXipueK9hZAIrhOwxcKvYvgi6OKd3JlpxFeNRXP2Dhjr0Mho?= =?us-ascii?Q?MjQDJzI7dyzwl3eq9Flwoy6TCwdzGXb/Nbh+VqKN7SH5HnEV3cP3ix3xoaoN?= =?us-ascii?Q?3BSjzvIkbv5HpEwp6jj1nT+jixJBC97VYG3hYWI4IR/XBSnNsIf1l6qdFkaW?= =?us-ascii?Q?thZ2eSTiX8vzHvk5RUAnp5KxfMqX6WbJhQ0IRKmENLqdo+Qc1wghq2fn7ypK?= =?us-ascii?Q?8wcTpvgBnpON36khNpYFPsZQYbmM6wvTAGWFOBLN+0mDA/4pidDCw3PGLc7a?= =?us-ascii?Q?T6cuTNXAuGVARBiFe8Hz2kjvtgrRpUjLg4fUTE+ZvR7sePstw7VRFPT38PJK?= =?us-ascii?Q?y36uQ2qwCgB66JDvHcU4DlsiWmMhR79Wgn+tUjIecdizfujWUPpS8D53fIHL?= =?us-ascii?Q?7UriTWAYEhiCn4vn8j8qgCoTHIOVxCY6FoNd6039IWdWuxn1ebzqnsApTtMJ?= =?us-ascii?Q?yJG3kvbeQ2/GRMXC+NBA+fIoeqA4Eng5QaZIYwTm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f4ffab0-6e26-4ae6-b726-08dc12005711 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 17:19:44.9316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UV/e91Trfl6tcIU0OHzW0/rcHrqx+9q+FdjVvE55bzZm/Eis1MuX8Z0I3Qd1wdHrlbKpyK7bhdDgMm9RyEZ4nrMMDg1Vx1ygQmWjc1tP6y0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8070 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Thanks Stephen. Noted, I believe this is okay for that very case, but I agree there is good= balance between being explicit and being readable.=20 Thanks Nic > -----Original Message----- > From: Stephen Hemminger <stephen@networkplumber.org> > Sent: Friday, January 5, 2024 2:00 PM > To: Vargas, Hernan <hernan.vargas@intel.com> > Cc: dev@dpdk.org; gakhil@marvell.com; Rix, Tom <trix@redhat.com>; > maxime.coquelin@redhat.com; Chautru, Nicolas <nicolas.chautru@intel.com>; > Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for > consistency >=20 > On Fri, 5 Jan 2024 13:15:16 -0800 > Hernan Vargas <hernan.vargas@intel.com> wrote: >=20 > > +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000) >=20 > Just my opinion, no need it doesn't have to change but. > These variable names are getting quite long which doesn't improve readabi= lity.