From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC028A04C7; Tue, 15 Sep 2020 18:39:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 243761C10B; Tue, 15 Sep 2020 18:39:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 814C21C0CD for <dev@dpdk.org>; Tue, 15 Sep 2020 18:39:35 +0200 (CEST) IronPort-SDR: Irj1dTNeD2ThBX7MysX8IGs7kcEdSrEC7GJcGzXZtwlIy1t6qDvH2mzWqsDHKC+ZJJ8S+sO2lx R6HahRrNmNtA== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="159352259" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="159352259" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 09:39:33 -0700 IronPort-SDR: I32ZZkZbnfu2CfV0V3M2kDy3jPwnR2AIrSaD8Viso51S8dXzFr1HHj2O3DVtJjcJM637T/lxPV k5e1BY2n7RzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="482893381" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 15 Sep 2020 09:39:33 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Sep 2020 09:39:33 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Sep 2020 09:39:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 15 Sep 2020 09:39:32 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 15 Sep 2020 09:39:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLEv4xEZt/tf4M6BP3wigUW3aTWf4POhG5xWey5cOJ7soP01HE7O7F2N3NHPQIQL8bp9nbuTmCV59jYuYB8NcV0k+6h+L5OIWdZ9ww/ZgH4NPIhlks7kUqbTCiCUvm3kLGIHjo0TB1VoEgN95IrTiEJPdRPWKGU+m2F+y4H/wDJuYs+gGA8NIqaCwLc/7XRpkvV1XeiZIbidBXlDevy7QIT2/ZxwOd1+9JcXgkDKJD4ElLj1awyvgEcrJ7pAYpJzHL6xZm/DeeAUTYMjyhc7//MNze5jELHv6yZoNqNfPPoptQCCmrqEUHASBR16Rx2hfkPU3DIM0YPiFXN0D1rhlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3ahD9eUjcC9srDELwQIUlVYGGqvTxR+EcRfV2R9fqs=; b=k2xV4Zu1SoWxiyWBwvVTyWbORVOma37Bsy8iRsU3sGme26LqSsPFU20NoWBevk+VmVlsnt8qee6gHmDTlz9nR0RfrrCQ3BnOzNLomdPRHp+YU2Zp9Twyw3pNcFX01lABlqkg77uvNE84EkRVGtytPolNMp+vgJhGERmnE6/Cv+wkjU8Kr/HUGxmzz0mn2CJKBvFyy1B/GFcMj20dMRUM3IEzx4QxrHhnwVyMYLH3CMCWslKxJW2z9Jrw/e8GGjq2XCGUYraLVmLJXxmGCBHxBNWTlDrVkSdSZE9Uvg1K1YjUHnaGkj8sGSGGUsRIC0VrHf49LxFBXapp2QiQOkZxqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3ahD9eUjcC9srDELwQIUlVYGGqvTxR+EcRfV2R9fqs=; b=K+BIZ8FQX5i7NK3nd7bQQxgBAChLP0Aqw50uUsW/ItXL0v52+FNhCBeTPnohoeDQw8VJp58HqQAnpeoPLOziDr4XikKqKp4vzTGJh1kVQQIYKckMSlRKZ7b6jYv4o800QeqegXu638atSFeWnPdz/yJPSENe7Gh/v5vwXY9FPF0= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3158.namprd11.prod.outlook.com (2603:10b6:a03:1c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 15 Sep 2020 16:39:23 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::4162:97e1:7d04:a508%7]) with mapi id 15.20.3391.011; Tue, 15 Sep 2020 16:39:23 +0000 From: "Chautru, Nicolas" <nicolas.chautru@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, "Power, Ciara" <ciara.power@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> CC: dev <dev@dpdk.org> Thread-Topic: [PATCH v4 00/31] remove make support in DPDK Thread-Index: AQHWi2laW+S3EKtAc0WOKRQAphtcQqlpzVMAgAAJ6oCAAAPaAIAAA5YAgAAC6uA= Date: Tue, 15 Sep 2020 16:39:23 +0000 Message-ID: <BY5PR11MB4451D19150EF314BACF1E976F8200@BY5PR11MB4451.namprd11.prod.outlook.com> References: <20200903152717.42095-1-ciara.power@intel.com> <3216590.6Dkn3NIytC@thomas> <569c544c659c48dcb5a75af2581a1a8d@intel.com> <6470705.gZyV2GM0uM@thomas> In-Reply-To: <6470705.gZyV2GM0uM@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3bffd21-a74c-48e6-52b5-08d85995e71b x-ms-traffictypediagnostic: BYAPR11MB3158: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BYAPR11MB315805EB4300E185438B74FAF8200@BYAPR11MB3158.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +mUN82lgMINpq1lQxMFPh4Q/kKDAzFVcSfhvgcqbLjsh6Ft6P80Jdw2hYNpaU+UhLQEiou5WyrXH4WgS+vqGjnXik91ywP0MRTpYzj7Qt9yWg46USmnkOVpDJyWts4Rr+geP6XmYeNn0/TvTlXqxK1+B7hiT+FGsiUi4/cxn7STM00iNjAHUamTUnqBmzukaycKk965kxzvlYTZVJmiez2Oobx0R3/NsvTOOW6MVHHmYw19ADbQcwWFXu6hJ8eb+2fm9cHx5CXrFHPUmVTONb4U+hJMiPnf65AS8mEPE5bflki7TTukKoSS5J4zCN/d0gZK/QxXMZepjvgLftvWLvP6C6aD5I241cSjSbNNefraeOHCfBIYZ1cAxgJ/mT+ic2SHJMQQpvnGxpFeoNIjk6aHe5aAg1xrpXinbSS30Hkek0t3WAEDloROXvrO8dZHZMw5hBryPpQHvuHVTaGq/gw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(66446008)(6636002)(8676002)(110136005)(7696005)(26005)(2906002)(186003)(4326008)(71200400001)(86362001)(53546011)(478600001)(6506007)(33656002)(5660300002)(52536014)(64756008)(76116006)(55016002)(83380400001)(9686003)(966005)(66476007)(66946007)(8936002)(316002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +5Wi0Qo8zypZZ4E9DH3LjAuBbWYE18UiStGfMs3cDyLpwEKnrw/qpvdobWUr3e5bUWMZAqPrvG3flFesEdRvINxh30QnBRwCQ6RaAvXSbVIpkTn+xT1Qwz7u8RIX3AzgT18bCT7/+Shd9WDOa1rft4cc1OrAZfIgZQY+ilx+481VeG1VTFcKFdGso1yWkX1LQWfyRrE9XjIrdBcnltlQ7lGTXCUdEV6B4I2L6lIykJoFyUMBita0ew+R70hQEX3sT0QIEn54uedVSRXAnQBwySEq+0MD0DSFkWQ0FZ1WNk1LPv7nBTNbFxdU/KY01yzD4zsbG4J8iq4ve0NUUJM472IQEtyPAjuSD21uB7GcSUbvmcne7/GeEddVYpRwuTMgjlroXqUz9YW5qGqSBPotef7Zj8MFJyRGV7J2j5qNvvLnyRVu9NbC25yg1deCCOLopeYqXN4Zs9tNxEf/MXihP2MX0BNbpD/kV398c+kbGH9d3MP6kp0mQWTi+3pX/VPrs5mTt3svZnqsD4XbwXiVtnw0JzYdFGBBUx+Z1jQrs8De6BArwScusO38ZKtGKj2cSFajSuu1MEfNQPyaCyKg9jnwz3EGQGwsChTqut9IxtL9opU07RvsJCnnaTMhyqR2LM1Z41CguIEjxE4Wy11zZw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3bffd21-a74c-48e6-52b5-08d85995e71b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 16:39:23.3882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EnqU/0wzlKXYBVPzSFVYLXHQq+2iRrspJyS6pzW4XDZMy4Tjq4NLpXxuuXt3p/Z3It41dcIZqvyEAu5utr9SL5mN8ctXRdePHhb6o6/7lNg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3158 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi,=20 > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, September 15, 2020 9:11 AM > To: David Marchand <david.marchand@redhat.com>; Chautru, Nicolas > <nicolas.chautru@intel.com>; Power, Ciara <ciara.power@intel.com>; > Richardson, Bruce <bruce.richardson@intel.com> > Cc: dev <dev@dpdk.org> > Subject: Re: [PATCH v4 00/31] remove make support in DPDK >=20 > 15/09/2020 17:57, Richardson, Bruce: > > > > > -----Original Message----- > > > From: Thomas Monjalon <thomas@monjalon.net> > > > Sent: Tuesday, September 15, 2020 4:44 PM > > > To: David Marchand <david.marchand@redhat.com>; Chautru, Nicolas > > > <nicolas.chautru@intel.com>; Power, Ciara <ciara.power@intel.com> > > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev > > > <dev@dpdk.org> > > > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > > 15/09/2020 17:08, Power, Ciara: > > > > Hi David, > > > > > > > > > > > > >-----Original Message----- > > > > >From: David Marchand <david.marchand@redhat.com> > > > > >Sent: Tuesday 15 September 2020 15:03 > > > > >To: Thomas Monjalon <thomas@monjalon.net>; Chautru, Nicolas > > > > ><nicolas.chautru@intel.com> > > > > >Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev > > > > ><dev@dpdk.org>; Power, Ciara <ciara.power@intel.com> > > > > >Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > > > > > >On Tue, Sep 8, 2020 at 11:05 AM Thomas Monjalon > > > > ><thomas@monjalon.net> > > > > >wrote: > > > > >> > > > > >> 08/09/2020 10:16, Bruce Richardson: > > > > >> > On Tue, Sep 08, 2020 at 12:06:40AM +0200, Thomas Monjalon > wrote: > > > > >> > > The first 13 commits of this series are pushed to the main > > > > >> > > branch, making the make-based build an old story. > > > > >> > > > > > > >> > > The last 18 commits (devtools, app and doc) are pending for > > > > >> > > more reviews, especially because the doc rework is still in > > > progress. > > > > >> > > This is a big change which requires to be split but must be > > > > >> > > completed soon. > > > > >> > > *All*, please make the documentation update your highest > > > priority. > > > > >> > > I will be reluctant to merge some driver changes if the > > > > >> > > related doc is not updated. > > > > >> > > > > > > >> > Thanks for the apply of the code patches, I think it will > > > > >> > make all our subsequent patch submissions a bit cleaner. > > > > >> > > > > > >> > In terms of docs, I believe the Linux and FreeBSD GSG guides > > > > >> > to be ready for merge, or if not 100% they are at least good > > > > >> > enough IMHO to be applied now and have some minor tweaks in > > > > >> > subsequent patches later. While I'm sure the Linux GSG could > > > > >> > do with more major rework, that should be separate from the > > > > >> > doc updates in this > > > patch. > > > > >> > > > > >> Of course I am not expecting any major rework in these patches, > > > > >> but I don't want to apply clean-up half done, which can drop > > > > >> some relevant informations or introduce mistakes. > > > > >> > > > > >> I will review the Linux and FreeBSD user guides first, as you > > > suggest. > > > > > > > > > >I could not find a patch in patchwork for > > > > >app/test-bbdev/test-bbdev.py which still references RTE_SDK and > > > RTE_TARGET. > > > > > > > > > > > > > > >-- > > > > >David Marchand > > > > > > > > > > > > Changes to test-bbdev.py were made in patch 15: > > > https://patchwork.dpdk.org/patch/76796/ to remove the references to > > > RTE_SDK and RTE_TARGET. > > > > > > I did not merge this patch because it is hardcoding "build" as a > > > directory. > > > I'm sure we can do better. > > > > > > > We probably can, but is it really worth holding up the patch over somet= hing as > trivial as that? It is really likely to cause people issues? >=20 > I give one more week to Nicolas to better fix this script. > If not, I will merge that patch as is. >=20 Hi Thomas, Ciara,=20 I had raised that concern a couple of weeks ago but I was personally satisf= ied with document pointing to `build` as default staging build directory an= d seeing limited reason in practice for it to be impactful for bbdev users.= =20 Also the argument to the script `-p` can be used to bypass default path to = any location. =20 See reply here https://patches.dpdk.org/patch/76426/ The only request I had was to change the default name of the binary (mentio= ned on same link above) and I don't see that change being made (I may just = miss the superseding patch though) Thanks Nic