From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17DFCA0350; Fri, 26 Jun 2020 03:14:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23F83FEB; Fri, 26 Jun 2020 03:14:32 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4E5E9CF3 for <dev@dpdk.org>; Fri, 26 Jun 2020 03:14:29 +0200 (CEST) IronPort-SDR: v/5HQpv5rUtZY4kdKUt65b/4qcCyQwvZM33PXUKr/BaIvXPy0LJ3BE31D38tocuZ8rQkV37A/c ZsVtiq0Ez3dg== X-IronPort-AV: E=McAfee;i="6000,8403,9663"; a="163219576" X-IronPort-AV: E=Sophos;i="5.75,281,1589266800"; d="scan'208";a="163219576" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 18:14:27 -0700 IronPort-SDR: ieZxZ8vSvlBHEqVmQ8zMTT8DhV99FxSxjELDoz8lEwYHzJ1WKLICFGIn8CA2wimlq23icExZEN /KkcgXbpguNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,281,1589266800"; d="scan'208";a="311274231" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2020 18:14:23 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jun 2020 18:14:23 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jun 2020 18:14:23 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jun 2020 18:14:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n23ZZNgSacAwaEWsqjxL0nPI9VKSEuy+faxfbzKOZhAlAoONLlfOKxRwGH54nNSK/MJfmNfWOz+Dlx2Svbf4CBksGscXmJdIRsgsAzhxlmgg+Xwm9xwKjwMGvc+KAY1LMBtaql6NUBeKSJHdrDKEBF6Xb46XguDKjDRKLJJGiEYKlqitfMnPdgm+uZ3PRxT4Cs+ZAri/CcieNEyxDbdO/kiygKebfywNIyz2tIGSUD5c/p71Y9FSxy+S3n2YnkfSkyNVOENcTt7Mf8T7d3KgwCym0q6mpy5RLtA9AmIDWpujkyJOk5BDlt4kfNfNrLKZGjQV8NP2dCmeggSt4MLUSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qHVCzJUjzL1GPIi4rIt660WU33DoIlGt8iIeRKxBd9k=; b=OfPq7cHRDGNNi6FCO7j/vxaYxgQcTVvNYM2L+CnV2Db7APIe0etCv2z3y6lx2JHppf6L3uYFPzRPvXimYnHIcZmQ8k6qMUyZiPuOxIGcZRlajS1871cIkA4izM5Oqf8AFPEZCYvzuDkbUWcyhG2qRAH8jRoA8ZxVkli6HGZzQjUjC/FYGGfLAkoh8NQNcJzytLHjPppGtO5fu5QTuPJzQShFlj8fYWK+F0Qw36VvwR33U6EQDLvbeFwizV0MGNzOPfHV18ArPBE5sUuu6z5lYESYxn6N/Q6ThDcSVfiWnHljEW/jGIf+/c80dBFGI6X/m0Sufo20evHmQMFTDNICUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qHVCzJUjzL1GPIi4rIt660WU33DoIlGt8iIeRKxBd9k=; b=QCI9ECggWuVEcQIwX+fDUnZlrlJiJ+/fLH9IF28wG7vYPMUtRqvFLXl19m1vq6d3W6APoBXaRPwMoAzdp3/H/k/10twtNwN1CmelrfNaav3FJ8QJeoi6fbVMbP1R36Omj+GXhi3zeayyxktYByrYTBsZxyGnwGXAQONarGUdd1g= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB2869.namprd11.prod.outlook.com (2603:10b6:a02:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Fri, 26 Jun 2020 01:14:21 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e4c9:8ec0:1923:1150%3]) with mapi id 15.20.3131.020; Fri, 26 Jun 2020 01:14:21 +0000 From: "Chautru, Nicolas" <nicolas.chautru@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Thread-Index: AQHWBia5R0/Gp5PdrkGqhlhqLpHPAqh8s+sA//+q7ECAF60+UIAEzVkAgFAnemCAAIO6AIABGlfw Date: Fri, 26 Jun 2020 01:14:21 +0000 Message-ID: <BY5PR11MB4451DF6740C77C0F64D1F622F8930@BY5PR11MB4451.namprd11.prod.outlook.com> References: <1585526580-113508-1-git-send-email-nicolas.chautru@intel.com> <3297014.iIbC2pHGDl@thomas> <BY5PR11MB4451A8D5B9930E023723AD82F8920@BY5PR11MB4451.namprd11.prod.outlook.com> <2158398.uQ6CQvYSmG@thomas> In-Reply-To: <2158398.uQ6CQvYSmG@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [45.28.143.88] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79a460fd-aae1-469c-c772-08d8196e41bc x-ms-traffictypediagnostic: BYAPR11MB2869: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BYAPR11MB2869FEA00BD3C68E44675CE6F8930@BYAPR11MB2869.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0446F0FCE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n2eOyBUl3oVavUcgwkm2ke7aBGr+CmiyMUhy26mY60O1bxb3xhiSWMD+Bu59LRzQm+pceWljNAlaJ2PU5rKVfjtz11BATlwhajXHG0C4tfzpdoK/04MNn/CEsO6PPOzi6JEjiRsz8SRhVUAUL/Luh3u9ljadNXifjgpKJMNds3TeWt6hIG/DgtrDIaBc/QUTHgjWr2/P0Bapk/WYaTMyzP5vcNbbAHEdoFVzyqgmw8DECHCfKWJkcYffqj4HZjJZy8SpwVFFSGa0WOk9z7BhVU0QwwhjX3HOUadRJiOq4Vy8SUEI9ttKaIdnwum0h4EfgR8WD3VVGu+BHVMA+OeNS2XsyH4pbKy6kHjAwwpoV/vypDmxxsN+drWZrHE1+7nKQ7KdfMpGZFxI5HqsFJPVlw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(66446008)(186003)(64756008)(66556008)(5660300002)(66476007)(66946007)(26005)(9686003)(55016002)(86362001)(52536014)(76116006)(6916009)(33656002)(478600001)(2906002)(6506007)(4326008)(966005)(8936002)(7696005)(83380400001)(8676002)(71200400001)(316002)(54906003)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: vUEzl7mZk1+cgMF8VEVq1tpM+elG71+rQ5i5KaFYg5I3PBLEU6L1JHzuazawplxAFRKr+BYd02AM0n+IS4JswHwwUpIvsvc0lWfm0F5uhIo3xXdmN3jJkoAv2KbwE8oWD9da0+RWO3hFn7HzPEzM1QP3IXvk6E5YHQaJti9TqZFQe2SsVG+lBP9SRbzX8FMjKll/AeJpFwRrNkb1YQcmNsNpKW4jO5aRYbSEtRFvGMUDdOOosdGWQMufYa2Rw8C8+8uLM9UioEgDXBF3jvjrWfxm+H1Ky6vaDjPhrJkvxiTSfQ+OR4jc2pQCj3R72971gE49tUwYXTEduEWTK6b/bS5Mxav0rMqYN3NymgEdpjgvTHCYaPC1zxjyWgvgh32s9xaRciQ2iufGSNHtZKNosMfJJ7bTXgWlnzQdIY9CAXbfwsxEf8VuBF8IHHdijbAwNaeX+0CcHCemivyAGJIAusH4KXX8D40WhRW8SmXhXjM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79a460fd-aae1-469c-c772-08d8196e41bc X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2020 01:14:21.1373 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4WCErjn5Z3T9XdHBzuQV27ZzHwf/R53eS81mcuvDNSgeG2FumgUO6Bp2QB6W2rXksd2v0+I5VefmCVhR1o8PwhQ921TGaCnoUEk/tLMYWqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2869 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > From: Thomas Monjalon=20 > 25/06/2020 02:30, Chautru, Nicolas: > > > From: Thomas Monjalon : > > > 02/05/2020 01:15, Chautru, Nicolas: > > > > Hi Akhil, Thomas, > > > > > > > > Following up on that previous discussion below so that to confirm > > > > whether > > > there is an available option to handle this usecase within DPDK repo. > > > > > > > > Basically traditional deployment for VRAN relies on BBDEV/DPDK > > > > running > > > within container where the workload is processed behind BBDEV API > > > bounded to a VF of the accelerator, all that is fully covered current= ly in > 20.05. > > > > Conversely an application from baremetal still has to be run at > > > > initialization > > > to do the required register poking to PF MMIO so that to configure > > > the HW so that the VF is functional. Without this it is not possible > > > to use the VF driver form within the container. Said otherwise the > > > BBDEV VF PMD cannot be even tested with DPDK repo (only the PF PMD > > > with the workaround discussed in the previous discussion). > > > > That small userspace application is purely doing mmap and writing > > > > to > > > register based on xml file input (relying on igb_uio bounded to PF, > > > or other vanilla kernel module) and has no dependency on rest of > > > DPDK (DPDK would not be installed outside of the container since no > > > packet or wireless workload is actually run from there). > > > > Is that sensible to add such a small companion application within > > > > the > > > related PMD directory even if it has no dependency on DPDK libraries > > > per se, only the fact that is required just to be able to use BBDEV f= rom the > VF. > > > > On one hand I see reason not to do this as this is not a DPDK > > > > application per > > > se, but that companion HW application is still required to be able > > > for anyone to use BBDEV driver + being within the same repo enforces > > > that there is no risk of version mismatch. The other option being to > > > put that on a separate repo outside of DPDK causing fragmentation of > ingredients across repos. > > > > > > > > I wanted to check whether you had any strong opinion on this topic > > > > and > > > whether a patch with such a companion simple user application may be > > > approved. > > > > > > I feel it is best to have the required app in the PMD directory, as > > > in "batteries included". > > > > > > > Hi Thomas, > > For such a companion application to configure the HW within the PMD > directory I want to confirm two things before pushing a patch : > > - This is okay with you for it to build outside of the DPDK build flow= . > Ie. Separate Makefile, not planning meson support. Again zero DPDK librar= ies > dependency. >=20 > I think it should be built as part of the PMD. > Why not? For the same reason as above : you would not deploy this companion applicat= ion in the same OS or container/VM as DPDK; they would be built without dep= endency on each other, but still provided together so that you can actually= have all the ingredients in one place without mismatch and be able to actu= ally use the PMD will all required ingredients in one place.=20 Also based on the dependency below, even if adding option to build within s= ame DPDK meson framework, it would not build by default by anyone as the de= pendency repo would be lacking.=20 For that reason that would be a bit artificial to me to be built with the P= MD really, but I could be convinced otherwise.=20 Any thought Thomas? >=20 > > - This is okay with you for it to have dependency on other open- > source library to build it. Ie. we are currently linking to this > https://github.com/benhoyt/inih (BSD license) as a simple input config fi= le > parsing. >=20 > No problem with dependencies. >=20 >=20