From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E829FA034F; Mon, 11 Oct 2021 22:33:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE67C41139; Mon, 11 Oct 2021 22:33:05 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0AAD141134 for ; Mon, 11 Oct 2021 22:33:03 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="224378659" X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="224378659" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 13:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,365,1624345200"; d="scan'208";a="480023355" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 11 Oct 2021 13:33:02 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 13:33:02 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 13:33:02 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 13:33:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 13:33:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j47imfxeNBNgRH1TDrF7l2iPnDOpb92SjBcMvEcLmOSohLXeZL0SOpTw7MuqeQbKvzArhtKmQz3m9ZXpAJb1xBc/Jagsp+LzXSHSWtgDlTIcwMeewX6Qo7CmpR0DOIB8M/nfG8Qau05EomfRCRcRcLw19bo1tmvCnCj3A3nPHDlKUnMf2mZgJ53ozKrwXNt69QI69zfQr1m5IZN0d+A6Z31ePbc41O7OW4ogZlrrZnx2JJSzaQGXtYUD/5OF+prekokw/j2vDMaTAQDHNNIueQdflFXzAZswZrS0uYnfVEX3uw9JyPdG91NzHgSNSk60KXz6RY+z1zeSqZFgR6965A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qsk3Pq5ML1ITrSE68yeMgt1b+3RCovVz80oY2ZoXWws=; b=RI5TnOLehI7cxUtsh9A+d+LMd+xi/C5A88ztrJw3ih3hIcA2LrxGiIXZ/t56XcKQlGswtNWAc18XGfAaxgCgJNLNzW5/+ubovAvY8oVs3bOlUAbF+epmmbeE3WT4H4uIrf7ZyTP4tO2s71BXFk83PlRG5I4AKESJZMRTdLtNSJ8FuY1+Ug9TpsG8i/hDBti++5XCl0244+JkhniEK4U20WeWEgbH+45W6FLhR0NKByj0YwIJA5ASA0P/lDSfK1U3jl39jX0H88Fp5WwxGYjy+ePI/QqGYrcxUXnDRHwSAtHQsrlQ+6qjLkTziBAspCr4jr10kTTVNzeo3/lZVEJJmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qsk3Pq5ML1ITrSE68yeMgt1b+3RCovVz80oY2ZoXWws=; b=W3vC3BNXb2tlComDTKgu8rtD9gWCXsEcXFnHC9jzuu/HIapGdxPFOceSc2DGblxz4IyU20HIVas4pNGwQFgfoRdEQytonhw677nPe4NW0+y+f2E40Wr5gKNEZy4gy255sy/NWl7bJR6xeJlCvNtqOIsPvJold0HI0ghTFlgWyQc= Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB3365.namprd11.prod.outlook.com (2603:10b6:a03:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 20:33:00 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::d2d:4882:88be:85bd]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::d2d:4882:88be:85bd%7]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 20:33:00 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , "hemant.agrawal@nxp.com" , "Zhang, Mingshan" , "Joshi, Arun" , Tom Rix Thread-Topic: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc Thread-Index: AQHXpE8bw9C2CEylRUuP5sY8x4cZ0qugX0qAgC4VWICAAADWwA== Date: Mon, 11 Oct 2021 20:33:00 +0000 Message-ID: References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com> <1631063741-28631-6-git-send-email-nicolas.chautru@intel.com> <2192559.Aoev046PIl@thomas> In-Reply-To: <2192559.Aoev046PIl@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e36c6e31-1def-45a5-b5ed-08d98cf65155 x-ms-traffictypediagnostic: BYAPR11MB3365: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XT6cYT2guZkR2hTOADd+Tfc/kuzYP6uibeYSH2oSUpMZ/XbP+GlxCOrHrCGKKtSxN+HqUX/YjbHKX9onKayycMcBxPGQXwOPuiiEfybQSpwOMLM9Ykh1gzZqr6oIb5MidAxXpQaL4FywYrVF/aaLBNtAsEZorUS6clzGTl2P49KFaFtlPW6YmHj25pQfgbxyiZHfrKw7W/xxYr2VDOpLUpHI9g2VuKqHVZ72ih3WZeJ0oBlYYF193SYX+wAR1oWAOlyoy49lA7lCTnnYNcBLq6c4lL2zzxTe37CyuWOBJakJ8lQ5RqqOMO9t+kByZdlXckz9SDPMIshfoOUbRWneC5ss0LHwxegH6O0A0v0asTD4Sz45PMHWbszJgOhxx4p6KgLRpwlLqUQ8/ez26l18TnYjdS/aRqCSG9sk2AU1kH36fHfFWJvM/EAyEQWaHSU8y9uomI8s63aCV/33EBVgpOhskJ+1SuALN/Wq0WtQSRjhL6b36aygtRhRa+XDEozMpt2dQVVILFt88/PWh0Wm+9FetGU9QcinIsuPmThHlsaLcfpXijmJhxIaKfB+JKmBkriaEyLLCpa7LS5YbLNQRKaqvxZup2Dp7eDhEhr6ssAToZ48R+B1V3nawjZSYmJlBMGZktm4zJKofobfE80I0mFX7dEa7RAmb4Tj6AvSXMlOg+h63b7inpkXVUD2wztIhK2ZbvWtNA16w0jFpwlmdw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(55016002)(5660300002)(26005)(186003)(66556008)(8936002)(66446008)(64756008)(71200400001)(7696005)(66476007)(66946007)(76116006)(53546011)(6506007)(52536014)(38100700002)(2906002)(38070700005)(83380400001)(8676002)(6916009)(122000001)(54906003)(508600001)(33656002)(316002)(4326008)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?htWx/wcJ67JgDfOdwIB5vKIHrkUH7c/WyEFsdmAF5fxpNsieKvyUQfa95Hud?= =?us-ascii?Q?+xbZf0KhRKA6OSy1DvtYXqrsBn6zyegTHwK1/rd8tBt7nITvRpgg60sKb4O7?= =?us-ascii?Q?Ea7UGmofWbsmIuQ71bZ5tthTLV/Kqt9SHUy/hRS3njKMH4TAHTmF9c70o/Qz?= =?us-ascii?Q?8FdDqIx5vfvjxeoT0+5GM+N/jR0lvhc0ASfFVc7z/x66Tl+yw+SUmKNJidl4?= =?us-ascii?Q?jURVcvHRdGxjn/F9nc5eAJhmrMJh8K4s+fmMjdbp/k4ayZadhm7gvwyNl/al?= =?us-ascii?Q?aVJWCYoPbdN6jdmuiPcRCb0FpRD06mIcW6L5ve3IjNooxEZl1D7d+gLQ8JVk?= =?us-ascii?Q?EwzCnJZiudb9+VB9SkOgIH6Vxma5PjPOCTOQLI3V9xNATV5y05+Nn2WZHW0J?= =?us-ascii?Q?T59yC1iz9LNBr/NqdPzKqPSrxtRLd/iXO3n9eW9kPXUz2DXdfmIngkawt8BV?= =?us-ascii?Q?9nfkQ6lUErLVR2SfG0NsVhx8gd1o3y9Ou/6QK3XGiwuJAoCBEmEGKU4woFbz?= =?us-ascii?Q?0cksiichhLPrpw94Sqy8MGnNYyMw7CQPiu9g6NWFK+ExOfhRIxmrIXE256LB?= =?us-ascii?Q?a1ZvEmFvNt8IcBUL1lGKaaXTfi/ydJb8QT8DT02FSeYib0i7LlOXmbyJ4FcW?= =?us-ascii?Q?ASFYWnAdBDQdfyIk96SqIHjp+jBKBfQT0KmG3tmdMN/N0DJOs/l/rBnVs6yZ?= =?us-ascii?Q?+dqA5gYV8cSN9o5E8Bjo0D5BkCtrvscjC6RoDChcZcglpmLNzb48MHHeSSzX?= =?us-ascii?Q?5TgrU6bWcC14ftTQLFfH3xka+JDFfG6ut1qDDs+6wFyP0ijmwKAg5l7/Ggri?= =?us-ascii?Q?oHGqXUFVYAvtT0jTBvQ+PAKSAbJOErUuBAEdrfAkbiVoDPiKM0YUtPr+u8+D?= =?us-ascii?Q?e5HUi+2H3O3uPbHP/nJis78UVSAkvkEbqdOG/YvIk5xD2MYmvxFMIoydPh0z?= =?us-ascii?Q?2BV7KejkxLpf2DQSXgA88P2PeqOX0PtX2KJMsq3Wo/JRa4jTJjnSFM0rdfTX?= =?us-ascii?Q?Io/k0KzeDiRXOjwd5fIqmahiXWnLQMpDsBDFvN6FSzOOyHGVo8+fKBLeIk44?= =?us-ascii?Q?3cXg/aQuC5onDye2AyoVF8f9MBIaUbZQ5mJxRgOsz/XONW1HsYbZ1u7Zus9d?= =?us-ascii?Q?ONCJ050xUkdDezY+uf/vyQM4Yo+taTZHFGnCoLNBQX6yskxhRLD8e+oyD8vZ?= =?us-ascii?Q?Z2rOY92Y0A4KkOTHN0quShxiOjr2cvHxfyteqxLRBFcFQaVH8vLnGRcbkojO?= =?us-ascii?Q?/zUEyxKgEuHWuCtiueJXCGe3e7MImTQYpUZeI5HJkiiLdZcyLZnfi3s4SiXw?= =?us-ascii?Q?FPXdJ4jcPfjGhQ0fBefWrfdU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e36c6e31-1def-45a5-b5ed-08d98cf65155 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 20:33:00.2861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DUpHDA7Va+jG0FMwSYrA90i6jQLZg6WkzBdHsU6uHAdwwnPjzospJIljS8G+V6uRvTUtcnUqAZs0izs1MDScTz1OY3GYGAqckbA9R0tuS+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3365 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, October 11, 2021 1:29 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gakhil@marvell.com; hemant.agrawal@nxp.com; Zhang, > Mingshan ; Joshi, Arun > ; Tom Rix > Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HAR= Q in > bbdev doc >=20 > 12/09/2021 14:44, Tom Rix: > > On 9/7/21 6:15 PM, Nicolas Chautru wrote: > > > New paragraph detailing typical VRAN usecase and mapping to bbdev > > > API usage. > > > > > > Signed-off-by: Nicolas Chautru > > > --- > > > doc/guides/prog_guide/bbdev.rst | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/doc/guides/prog_guide/bbdev.rst > > > b/doc/guides/prog_guide/bbdev.rst index 8bd7cba..f39b62f 100644 > > > --- a/doc/guides/prog_guide/bbdev.rst > > > +++ b/doc/guides/prog_guide/bbdev.rst > > > @@ -1054,6 +1054,29 @@ capability > RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE is set > > > then the HARQ is stored in memory internal to the device and not vi= sible > > > to BBDEV. > > > > > > +.. note:: >=20 > blank line missing >=20 > > > + More explicitly for a typical usage of HARQ retransmission in a = VRAN > > > + application using a HW PMD, there will be 2 cases. > > > + > > > + For 1st transmission, only the HARQ output is enabled : >=20 > no space before ":" >=20 > > > + > > > + - the harq_combined_output.offset is provided to a given address= . ie. > typically an integer index * 32K, where the index is tracked by the appli= cation > based on code block index for a given UE and HARQ process. > > > + > > > + - the related operation flag would notably include > RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE and > RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION. > > > + > > > + - note that not explicit flush or reset of the memory is require= d. >=20 > "*no* explicit" >=20 > > > + > > > + For 2nd transmission, an input is also required to benefit from = HARQ > combination gain: > > > + > > > + - the changes mentioned above are the same (note that rvIndex ma= y > be adjusted). > > > + > > > + - the operation flag would additionally include the > LDPC_HQ_COMBINE_IN_ENABLE flag. > > > + > > > + - the harq_combined_input.offset must set to the address of the > related code block (ie. same as the harq_combine_output index above for > the same code block, HARQ process, UE). >=20 > "must *be* set" >=20 > > > + > > > + - the harq_combined_input.length must be set to the length which > was provided back in the related harq_combined_output.length when it has > processed and dequeued (previous HARQ iteration). >=20 > lines are too long >=20 > > > + > > > + > > > > Fine. > > > > Reviewed-by: Tom Rix >=20 > No, it isn't fine. > Fixing some typos and formatting while pulling in main. Thanks Thomas.=20 >=20