DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"gakhil@marvell.com" <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"trix@redhat.com" <trix@redhat.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"Zhang, Mingshan" <mingshan.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check
Date: Mon, 11 Oct 2021 20:38:45 +0000	[thread overview]
Message-ID: <BY5PR11MB4451F3BA7BBA9352215C0424F8B59@BY5PR11MB4451.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1702526.DCS0tWCQBP@thomas>



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, October 11, 2021 1:17 PM
> To: gakhil@marvell.com; Chautru, Nicolas <nicolas.chautru@intel.com>
> Cc: dev@dpdk.org; trix@redhat.com; hemant.agrawal@nxp.com; Zhang,
> Mingshan <mingshan.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16
> check
> 
> 13/08/2021 18:51, Nicolas Chautru:
> > Adding a missing operation when CRC16
> > is being used for TB CRC check.
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > --- a/doc/guides/rel_notes/release_21_11.rst
> > +++ b/doc/guides/rel_notes/release_21_11.rst
> > @@ -84,6 +84,7 @@ API Changes
> >     Also, make sure to start the actual text at the margin.
> >     =======================================================
> >
> > +* bbdev: Added capability related to more comprehensive CRC options.
> 
> That's not an API change, the enum symbols are the same.
> Only enum values are changed so it impacts only ABI.

Hi Thomas, 
How is that not a API change when new additional capability are exposed? Ie. new enums defined for new capabilities. 
I think I see other similar cases in the same release notes " * cryptodev: ``RTE_CRYPTO_AEAD_LIST_END`` from ``enum rte_crypto_aead_algo ...".
You know best, just checking the intent, maybe worth clarifying the guideline except in case this is just me. 


> 
> 


  reply	other threads:[~2021-10-11 20:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 16:51 [dpdk-dev] [PATCH v1 0/6] bbdev update related to CRC usage Nicolas Chautru
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check Nicolas Chautru
2021-10-11 20:17   ` Thomas Monjalon
2021-10-11 20:38     ` Chautru, Nicolas [this message]
2021-10-12  6:53       ` Thomas Monjalon
2021-10-12 16:36         ` Chautru, Nicolas
2021-10-12 16:59           ` Thomas Monjalon
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 2/6] baseband/turbo_sw: add support for CRC16 Nicolas Chautru
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 3/6] bbdev: add capability for 4G CB CRC DROP Nicolas Chautru
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 4/6] baseband/acc100: add support for 4G CRC drop Nicolas Chautru
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 5/6] doc: clarification of usage of HARQ in bbdev doc Nicolas Chautru
2021-08-13 16:51 ` [dpdk-dev] [PATCH v1 6/6] bbdev: reduce warning level for one scenario Nicolas Chautru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB4451F3BA7BBA9352215C0424F8B59@BY5PR11MB4451.namprd11.prod.outlook.com \
    --to=nicolas.chautru@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=mingshan.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).