From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1AF5A0542; Mon, 6 Jun 2022 16:54:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65C024069C; Mon, 6 Jun 2022 16:54:31 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7C9874021E for ; Mon, 6 Jun 2022 16:54:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654527269; x=1686063269; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gp3PnEgOD0IsAHYRFzZG+LimKkOq7b7WYUQgIxKHyLI=; b=Uadqg4H+ysLujRRSwLE6v6PbnrYda40HtFZIaAFb3Q7pUzkq2NlzJd/u Fs07Odav5swrFy6vm4R7KqI9pQ28EVdRne8dPa0Mq1IcnmlKwM0XEimNO uF7XbtEvaFvpr44WAx13ys1hphQtLpyXxmNqEJaWImTK7zp9prQNcddUw QRApmn4ER0Tc+rie8nKu79Y9goqAdUlBvx2EWtzArFgIfEfL9k6bf/QXc PHuV3niBx25IupvChILPO2phl4PFMeu2hnkliQt6FISwouYd6YY4kWJJ5 ZJIPNUo8z1siKmT/eiOlYingROfD/Ru/MndoV2CWNhLa9+m64RizzKfJ5 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="339994397" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="339994397" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 07:54:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="579190778" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 06 Jun 2022 07:54:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 6 Jun 2022 07:54:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 6 Jun 2022 07:54:27 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 6 Jun 2022 07:54:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEc4yma8wi85Sha5NSQsWIAcmBN8l3uDJ3siBGTELfbC/jxO8bZ0cvfUHclA7hG8moO5VU6qn/aHZrDXPW+S1xsSxudfnwoqgCOj/NZBJmm46oM327BAl+4AoydJLA3/Q5AQiBNjgzymVWsHjPL+zuPp5sKxf03BGm6e4tF+9o2dc7vC2Rc9EcSHtX+FxtxG3wMRTGH4NCtNDaRXzRTn6mq4tXFjcbZs3IZXECcoH5VpEfyL8R5VJJUE10M2nFfZfJIn3F/jrnT8gS1S5PvhMbrbZX8MS0o+CQtFXpSmF7I8v/MoEKd6+CpgHlX+w8PP73kLFcbFzytZjzdOHrZTqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0l5AActqxCB8VwD8G3ygwq9n8n8A7G+bzdL7EYk7QKE=; b=Y/NxGemNnT+tz7GtJoedOvAxWqKVmV9kptFHwVxp6nynqg9wdUlZivsy+5pPMfxJSi51EW/KaIGknWPA8wCsg17dwoe3PsD8QiI5GR/TpZAVYbswAx+j/NiUkN2PINb8chWHCAgjAgnmtfv/ZNN7mktdYJS4rlbqPiUyUeOPAWa0t/Xq0+pfmpaoX5G8Vz3WngxHSgeW26Gx4BWNT8CR7w8ubByEoIkbbacf41e0MiTY0QhPLkqX87rQvSY8Xa8Z0d6E0Rg7xnLbfWsRGdSXxurz9xUruU6LG5zlPueRGxjRAoS0fPGiDht9xI94m9YMbcgbqJq4DI94ajCdwBAJFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by BYAPR11MB2984.namprd11.prod.outlook.com (2603:10b6:a03:8b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15; Mon, 6 Jun 2022 14:54:20 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::cd54:e1b7:e3f:4069%6]) with mapi id 15.20.5314.019; Mon, 6 Jun 2022 14:54:20 +0000 From: "Chautru, Nicolas" To: "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "thomas@monjalon.net" , "Kinsella, Ray" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" , "david.marchand@redhat.com" Subject: RE: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Topic: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices Thread-Index: AQHYdT+S9VFrq6MAPkGdkVvLV0d8ja1Cf9pg Date: Mon, 6 Jun 2022 14:54:20 +0000 Message-ID: References: <1653350912-53876-1-git-send-email-nicolas.chautru@intel.com> <1654036307-182860-1-git-send-email-nicolas.chautru@intel.com> In-Reply-To: <1654036307-182860-1-git-send-email-nicolas.chautru@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8af3c052-f275-4dcc-a375-08da47cc7034 x-ms-traffictypediagnostic: BYAPR11MB2984:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 87z8iTiJDxW45QaYp2pHqG704CqeYHV4+dpvIwPbi1hy3bV5TIdv9V0Cce3dqfQ7jU9/YXH/dXtBdqKtkD6HZwrWq5xmHjlkcH+8sWrb4Z87nNcaBci0B9v/PY771IPehMkV7SkU2htykh8GgC+Zq783JlL50Dk/UWlV8MR+v7jz2Sz/rM7hb/m+oYvqIbEvWmgfHSo8nc2op968Sh/2iig21R4BCmD4SzWLzxOE/XH2DU1FACRZdjBMZ+I0E7HKFb+KpGANkEJeyx6ovOtGA67GqUa5FxuCi1vQ/6EZHQwLlUhibiLyO3u04l4v2q9LO4V+myXIdD020uA/iKCmsCazePudeH3BRvrXQypzcTyDVgAAlHuzC5mAGlhqBhtfYi5YGr0qb73wLWTvt7yZvWenvQhF0cHTU1y1wQYL8YdzTdnfCiHN5R/QB7CwEqsySdaRT5tZgcxYSxqd30XwocXfxqTDoXweFYc1tzCzEgYOW8+uauphUEdL8dSS8CUaKjKY0WbAogrYRWWaFxm5Lce+n0G+YbwNlkoMKK0K9S5vm8dc3a+Ks4UPKbO9wy7mcLB49ZbpZHmMG6Zc5C4nhgicQZF9guTLCR08Bxrri45RMkF1pALbTPJJ4eLq/Ox7mkReyhNyQAeka1M1lozczP0Dg7RQkTWYO4brY/wQX3i40H/HHrZ53RgQfBLoKyclvxsRK/PB6ofTJ6/erNNJjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(122000001)(86362001)(33656002)(4326008)(38100700002)(186003)(7696005)(6506007)(38070700005)(316002)(66476007)(53546011)(66446008)(64756008)(76116006)(66946007)(66556008)(26005)(55016003)(9686003)(110136005)(54906003)(8676002)(83380400001)(71200400001)(508600001)(5660300002)(52536014)(82960400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3JFx0pIHf84LcNj0DEq0ddjVTHQ9w4eB+2+nGwW6XStuGP/8oUVq69a2oIuM?= =?us-ascii?Q?UQ3Nm0sPY/YZd8bzTqNbzVP+NwWAitJhndJbS5g3rnaDcZwQon9MuKs501eB?= =?us-ascii?Q?+UQVcX3S5cLH7Bi3FRH2Qz9wF7ucdUR31soFj/BSWAd7ndWU3Gvz4oTI7NIl?= =?us-ascii?Q?UEwv+CsiVTkF5ag7CR0gGfqsdKoaBXWRlDZKj5KHub5vKVC9YiEgwmu613EF?= =?us-ascii?Q?DKHxBI+abNqD1sZase8uKYWN2j6LIQ7R9sxsfXX1B+2qT1XyL5/y9mJIKs66?= =?us-ascii?Q?ZVIqbSF7dcXI3Q5NuG/OkGq7+nubGD1IpY/oeQ8Ivbqx/QSAoYkx+cZgJXBF?= =?us-ascii?Q?RcQSPFLIrPQmm7Dz2t2JCz48hVQVh8fXb7qJb54H7MHw0NT6P5V88rcoEjVi?= =?us-ascii?Q?DUwUuP4nAHRe0XzoGnc8FJFoW6xjMkyFNGyXtExphI1mEM6Cdy9naD2XgArB?= =?us-ascii?Q?gHjWEtUSMIXEb2UOlS+f8cfqA6OjWxtROpfccB/qHVohJ2AsnoqYi7ws2c9X?= =?us-ascii?Q?kKlTvbi2wBCaKMaRdhX7gSoEvBGu+WPxwnSDHyEKXbmYSOKa3rhkF96KczrZ?= =?us-ascii?Q?iu+pEqDWo6LjtnN/EhMPU0O3dJlExnU+3blFnF6ekgFW+Q347GyvLyO6qXNS?= =?us-ascii?Q?GXeIJPeoow8ayRVlg936/EIbVGcwyl2Tz6cB2BxVFFMuZzLBq+REz1P8qMhL?= =?us-ascii?Q?orO+YwG7QFvdLoPhnLwO/bct56J8Xx5Y2tvpW94SCELMObA2HOkkwX/sLk7y?= =?us-ascii?Q?OQXZDBAxAlpdD7jqMS7OtZN7MlyReXTLJdHt7Rom5h9mdjMRygNa/H80kR9x?= =?us-ascii?Q?hXcd+wge+kr8nMGmBwxx3xx3m7zFdt3X9rjxiMeZqh3NvT2J5Hzv3HOqzT7A?= =?us-ascii?Q?Sy9rwWPMk9mE8uUgG0nM2SUmxU3GA6adJW+yilKIs66HJxRbN8yfli4lE4V0?= =?us-ascii?Q?ADmZQUPdV2ukgHF7h08gXhVS28Ji7VZQHo24tUUadt5ytQzJS0Zu6q3SC0rA?= =?us-ascii?Q?ggMl9gvROS1cxReHJBWxdOGtTk+3r1B0SkxY0hg7cikxTZX2gTlzNLpatd9l?= =?us-ascii?Q?dEaCqK2Ddq7AlwL0e8UwkGGUCa83N240XN/lRvfAtytx9b4usKMgJMhXcTqq?= =?us-ascii?Q?oRa7aebkfN1x8ccjyTt34jmlZiFe+W4txV6xtMZRQkvMZRizZpMxFxr1OZWN?= =?us-ascii?Q?D6QjKai7WoibqDln7FHMbeeKZvJJNipEZY5tr3eT/boLF0sdLsZBls9cg2Wm?= =?us-ascii?Q?zqyLXYqf20You+kH8Nbmw2j3Cnl4OGBYeB8Vh+Fvd3qd0TYyhsUdk7v6XeV4?= =?us-ascii?Q?PAlf0rDcjUlHSuV6kGSJooKR7v5wvGWYzB5dJ5pcRogUwhCPYf4QJgbxsuIr?= =?us-ascii?Q?oWSbL3cTwkXRvRbQduSWX/JLQPg7H7ClGurSNn6IcSrqCEAXhaMa6sB/mU4x?= =?us-ascii?Q?YkZsy9FLcb1y9aQpsI6BwQuKCJIhKdzNCLMH0HhL87bpJeIUC+g6QUkr9Qz5?= =?us-ascii?Q?0uAjJMJK0ruhhCAbyuoV9YFFNsvze2LbgCuzGr6rru6et3IpuxHMH2QW2x/1?= =?us-ascii?Q?0BfN25aChFfOivCZbs8MvTvfdOFTsxmyYVYSgjtldJ2j/bxwwvHikdYYc9Ny?= =?us-ascii?Q?eLOyZztTYQo/zTVb+o/n5p8TkcCo/3Jb8fkBor5ByDqzhYsyaZclQ922Qxrv?= =?us-ascii?Q?Wn7q/Ww9RxzkB1Ntpdm/RWq5+qQvIY/lGPDJWRB1cn37UpMHbbl87rejtVsC?= =?us-ascii?Q?BZ+lSjD1qQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8af3c052-f275-4dcc-a375-08da47cc7034 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2022 14:54:20.7119 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vlym/P4P2gYgkh+a3eF1gil4pnwwBYgd3VbIfDgDwMdnQPgafnloDGZBQvGJXWyQ+/J+r520RHqVUvxboM4U7j+evIqYbgBmdl+Al2e6va8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2984 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil,=20 Checking that this series on track to be applied. Let me know if anything r= equired from our end.=20 > -----Original Message----- > From: Chautru, Nicolas > Sent: Tuesday, May 31, 2022 3:32 PM > To: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; > maxime.coquelin@redhat.com > Cc: thomas@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agrawal@nxp.com; Vargas, Hernan ; > david.marchand@redhat.com; Chautru, Nicolas > > Subject: [PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 > devices >=20 > v7: updates suggested by Akhil and Maxime. Removed RTE prefix for interna= l > #define, removed build-time single FEC engine configuration mode, > documentation fix, coding guideline fix, renamed new file without rte pre= fix. >=20 > v6: use formally an unified driver for AC100 and AC101. Exposing single > unified function for the PF device configuration used by bbdev-test. >=20 > v5: minor fix to doc and intermediate commit caught in CI >=20 > v4: incremental updates based on reviews Changed order of patchset to > include two ACC100 specific commits first: updating formally the companio= n > configure function from PF and the protection adjustment. > Then next 3 commits for the actual changes specific to ACC101: the devic= e > specific function for FCW 5GUL generation used as a local function, > combined documentations into a single .rst common to both devices, > updated comments, removed unused #defines. >=20 > v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section > calling the configure companion function for ACC100/101, taking the Pmon > commit out which is not directly required. >=20 > v2: Based on good feedback from Thomas and David, now implementing the > ACC101 PMD as a close derivative from existing ACC100 PMD with hooks to > have different behaviour based on variant. > This prevents code duplication and only rely on different functions and > behaviour when hardware requires or support differences. > Note that these are pending changes for ACC100 which would be specific to > that device and not ACC101 but these can be managed based on the new > implementation, ie. is_acc100() etc... (such incremental changes for ACC1= 00 > trending 22.11 but confirming this is future proof). > The serie also includes commits which were meant for ACC101 but are also > valuable for ACC100. >=20 > v1: This serie introduces the PMD for the new bbdev device ACC101 (aka > Mount Cirrus). > This is a derivative from previous Mount Bryce ACC100 which includes sili= con > improvement, bug fixes, capacity improvement for 5GNR and feature > improvement. >=20 >=20 > Nicolas Chautru (6): > baseband/acc100: update companion PF configure function > baseband/acc100: add protection for some negative scenario > baseband/acc100: remove RTE prefix for internal macro > baseband/acc100: introduce PMD for ACC101 > baseband/acc100: modify validation code for ACC101 > baseband/acc100: configuration of ACC101 from PF >=20 > MAINTAINERS | 1 + > app/test-bbdev/test_bbdev_perf.c | 6 +- > doc/guides/bbdevs/acc100.rst | 37 +- > doc/guides/bbdevs/features/acc101.ini | 13 + > doc/guides/rel_notes/release_22_07.rst | 3 + > drivers/baseband/acc100/acc100_pf_enum.h | 18 + > drivers/baseband/acc100/acc101_pmd.h | 50 +++ > drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- > drivers/baseband/acc100/rte_acc100_pmd.c | 687 > ++++++++++++++++++++++++++++--- > drivers/baseband/acc100/rte_acc100_pmd.h | 37 +- > drivers/baseband/acc100/version.map | 3 +- > 11 files changed, 768 insertions(+), 91 deletions(-) create mode 100644 > doc/guides/bbdevs/features/acc101.ini > create mode 100644 drivers/baseband/acc100/acc101_pmd.h >=20 > -- > 1.8.3.1