From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F431A00C2; Fri, 14 Oct 2022 04:46:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 275434014F; Fri, 14 Oct 2022 04:46:11 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 367BC400D4 for ; Fri, 14 Oct 2022 04:46:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665715569; x=1697251569; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KWZhhxzwd0eD866sHzh7fJNSzCAL3tw0/SEmXZbBbGM=; b=G4SVFr9LjqPgzPA9mQaVDNUQYC3evc3g7GZ6KQpFqyVIabpbLdVQVUDM E074BFf0W3ZzcILVXYUZOfj54FJtd/WsRxz19nAyiJAuJCzpiEoVVDdFB iEtZqxWAH0Eqivvt2Sk6ERjVx2XVerMZ0F1mTRmDHp0sGn10SWKZHCq5G 27SI3h28BsEqAkJsc/s1ljOFgG47mZiqJAPw/B1ZVqHWKJGerYu0jcw29 ixNt0Fy+NXyQnS95ZlKetxnhNPnbM51okGsTeYUWY0t7mXi7W8zMeteG9 bZRTDR/dAJdG06lWMv4iW+xSA0NqmRf0mXvJMXM0Ln/nGFs4Hpdmub3QH A==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="288547173" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="288547173" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 19:46:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="732128547" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="732128547" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 13 Oct 2022 19:46:07 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 19:46:07 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 19:46:07 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 19:46:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACAhj6Bp4P+nK/EGvcbI3nwxGZWE05DDLO5riBuZDbxMEAU4DL5CuiM++7oiVH8hmlDjAGVRtTWd+3/yge70qH53jCyW3eHhefwDWeJVpF9VpfVreUn5/7ilTrI5ib9z+o6I025O8CEc6CmLW0fWm2NYx0KGR154ZnXJORDfJBmNTlwWjB3vtljsw8TQKcrbih5n1/HyRD47W854yCcQqr5fBZo0xLQELlni++p3AyC36aWAqiK1uv1fjGMtD8DiaNWGmAI0KiG4mA+6tI68il8w4O9glwOdZYPiFRJjgU2scx7TAlEFx2N4DivQekdyCKkYVK3sAQcHy3NziObgxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9KYvfcOeMCGhQGl+P7parSMFbJJiXHk5muiP3+kAkYs=; b=aRuIu9m5PRnhHX8Gwh8KRRuIsAIquVCsv/huOjXJ/DdPAecEH9p6+F3SHALW0wq7r5irFFsoR+wwQWD9VwLb2Sj4mIQsNGCgy5w8s00Sz3XbcCARPBn3V9w+EOGo8UYEBTb9zVHL4hJZAgydypBxM+Qf1GpVcoaCPRmkwyrRzemP/j2VlHF9ZZOT0/7e3INW6MnI6tLhEQokztXDUdVQ8y/xGzCC1aEq3JlcflkNfS1dAKswOUTP9z+u41R7XEcD1Swh3Y4d3TRVGzl0+qi5x6ML04a6vF/CImoTC0c4MSdH8kGlUyDUpujT5jDAMaEEV1OyfYDkaEqvWSHVfg0/5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4451.namprd11.prod.outlook.com (2603:10b6:a03:1cb::30) by MW4PR11MB5869.namprd11.prod.outlook.com (2603:10b6:303:168::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct 2022 02:46:04 +0000 Received: from BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf]) by BY5PR11MB4451.namprd11.prod.outlook.com ([fe80::e6be:3feb:17fd:bdcf%7]) with mapi id 15.20.5709.021; Fri, 14 Oct 2022 02:46:05 +0000 From: "Chautru, Nicolas" To: Akhil Goyal , "Vargas, Hernan" , "dev@dpdk.org" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "Zhang, Qi Z" Subject: RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11 Thread-Topic: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11 Thread-Index: AQHY3aNOn42RqZZW9k6uwGDyCR7FB64MTJUAgADfFNA= Date: Fri, 14 Oct 2022 02:46:04 +0000 Message-ID: References: <20221012025346.204394-1-hernan.vargas@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB4451:EE_|MW4PR11MB5869:EE_ x-ms-office365-filtering-correlation-id: 5620c4b6-7c8b-4ec4-0b1a-08daad8e3d28 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y9CmFWvgz0uKR5MEPiCPbrEUVCfpSyzsUe8+RjAdN/EcgJ1dP4xq0PfOeBupi1pJde0ecS+mMKhfMt/xhIuahSIjqRF0NqGcB6tygxSqkfYUTPdFArqjn9lvMFcDVm/4HLZ0/j3x07ul28xQhe0853GZFJ5Vlzs9f17aATK2PmMOm4ksbTP0TMKvmUUZBWudMW5JahwsGqfLu2JGZcjh3XbCC9nulUW0MpjWvjBZwUZ5eaUt/ntpHpU5fZt78U3oPlBkBLfVrs0jjzcbbOVcCIgmBzG7wX+GYTIui4V9tmZh/nFJnz9x02znLwA22vsvKnZ2vtlu4E38q4UR8cf0GYesH3q66r1+VNCCS7KmuZVhCKpNqeBWZ2HayECtzC4d/M0xloHaRSZyu4xSswBSL3KVE2K5/7GUxy/5ZtBnHDpFPRJZnN+p4qUd/id9HhjVcFDEOcK/xyZlGQQpb1MlNDi8tVWzEreRj+EOcmSDu8cUr9KKaJnY3Cb6yWhTmobGMc9c67TfOaY3faKmMBrhk8LCztvCLV0zEPXgwCsopICc4Es7M7Q9vjE5HUi/R0QRsgjdMR+Hu0QTvHlL2e5nAxl5fcaTMwOrBVA79o3MqXV9SR8DDlL65ycmIKeuSHgltW2ZSK3PXjxNEyq3VPNwBVjnjBZ3kmwJJlK+dGVSsLm6ssQfwxlCWfsQE87VbjhRVWj0AVib+jh/omgKyWgqS79PALVXWCvYd/v5/LpeADeKMc6/ujwUBs1Zzr2MVwiQEKF8FMv1jDNb2ChF/4dEgw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4451.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199015)(38100700002)(83380400001)(86362001)(38070700005)(122000001)(82960400001)(66446008)(66476007)(316002)(478600001)(33656002)(66946007)(8936002)(8676002)(186003)(64756008)(110136005)(9686003)(7696005)(76116006)(53546011)(4326008)(41300700001)(2906002)(55016003)(6506007)(66556008)(71200400001)(26005)(52536014)(5660300002)(66899015)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F7Aa5Utd5ACWRvW+is0l80kLJig6X3enNpPedIah03FvMCDeEdOo4ypbvBvq?= =?us-ascii?Q?ctlt8BZRI9pGbxsmVWTSXrPbzuVZwhJBB1VJfkUYBOdBeqeiBlIwSIXN4v5/?= =?us-ascii?Q?yWmHlT19C90xRARDWauSgLDDY1d7pM6GPZpiPyyytKa3+Hi9IGS3nyCDOfGy?= =?us-ascii?Q?q/Mf0aXwMuOXqTSdw5k9ucZ7druzeziThlNuGp8BOg7cmM84tJp3xtVWvzj9?= =?us-ascii?Q?UPfMXynpyQgvhs3pYzrwQqsGUX+PXAa8OjJdf9A09Tp5rxdRMYCplbujhPw9?= =?us-ascii?Q?9wEU9DiyLShmwEM+TS/ayvJX4JiRDKUp6L+cLfheQvMsRZGHgritKkPjx08B?= =?us-ascii?Q?GVTqkoigXcx9zato6KroO/WDwBBA+JH5oHmkPLIo19ig7f9Vl5ucfmx2sPa+?= =?us-ascii?Q?vD95dQ6S9umRiIhUn2non/+elHPuotTEqhutqn/dIeBLAOVw1NVLXKLVKOGg?= =?us-ascii?Q?QrceDBEM5shypbtLBx+fdonN4JqcStvbT49FVUqFvf1WO2QL82CpwFI3GW72?= =?us-ascii?Q?3XZIgnwDmJIjnLJEKJ3PWBk8XIxFKXuUmUiZJ6fB3jdMP2Bg7+fCxdNT33R5?= =?us-ascii?Q?CJ4i1ROr6ck52zbIra7h5kGya0gjvRDSL9ZqN7+lUIM8RleNdZ9jQBS9ONXO?= =?us-ascii?Q?Ac17CGWHWY0E8p/Y1NW1NtxfZ3Abex+1yNKJHaQvx2OWdCAmdEc/CrdrN+Wq?= =?us-ascii?Q?Y4TFlgAb1/NgmL0UGJV6fieiTfCg044soBQqy5XCPiaAq5q/ohFvriEbKxKh?= =?us-ascii?Q?FHfUGATT/qNySeFJ15kVOirrPPmGF214kflILCZL04sJuvtwW9ah1+t3yotl?= =?us-ascii?Q?3Ug2RdFGMqMGeGYpT4S7sNfcyoOHNAjhGF++Q+04pATTBVBTLl17J5WfvrqG?= =?us-ascii?Q?Oth9cfwfTwmYzLNFY2lKvjKtLByqhUtZpX8keKq3QY2h5WWSP/iDDinCIcCK?= =?us-ascii?Q?AZIfZ0aaXr+8SeFJVLwVE/lBuX6Zkf0DsA6ZXVkpE5y18NO761wgKmppM8ij?= =?us-ascii?Q?D+URJooHl7h6tveP5cuC6awAe+O0W6XZeI15w7razADh0wExVKIuNBzVn6Rj?= =?us-ascii?Q?N+A+M9ZRYcZxN+FBxyAbAlTiUwrPqDmJeoUw3rz/zb/xjJKxH0Udoitlfxiq?= =?us-ascii?Q?5D6mnFjzOewUK1K7tOXx+a7fvFE1OBp6k9/XGthGfcrTdHkLQvtlmhh1JP9O?= =?us-ascii?Q?MwJtLGWsYA/WEThX1XVpsidrBW3/LRZXjvQ6fsFV5k/lf+RBWQsVc3Pq9OKh?= =?us-ascii?Q?kcYRw57zRh2LsgHbaPBIXGASJ9kPv3RAhqEIVCUGqdLM+iZ61htho7QTwH4/?= =?us-ascii?Q?RGozv4CdALV4FYddhfnqSQEl5zv8Tm0nQNYgKRmxGou0rT/V9nI2Gm34j1+u?= =?us-ascii?Q?zjp7jnWvnNunlYihmiRuASzVwYkxaAie8I+LsOAb+FB6L/kGUsSoZFheCv3i?= =?us-ascii?Q?8wgUyxIP3VZTUNtX3UxqLN/GMjpAoJ6BadBUBSrxU9yHRkgdKQ/92vHSMnxH?= =?us-ascii?Q?LjsM+bq9QPjAxg+y0F6bJe8xJ84bNMbZpMveRz3dhc8SujwK4L2oQS+5EcCg?= =?us-ascii?Q?StrgZPaXaNR04CFkd5CedT+EEi2l8BOYR3K15XGU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5620c4b6-7c8b-4ec4-0b1a-08daad8e3d28 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 02:46:04.8717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IjSER6T83SawJ7i58AbhwqFAp+zlvjhqLIum1XXS+p6LMHVBCpm+MujQwYfeNiKpqNIGD+kXEZqG+hYaRz9n7BETtFzfkwKER2YqaFRY7SA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5869 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil,=20 > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 13, 2022 6:02 AM > To: Vargas, Hernan ; dev@dpdk.org; > trix@redhat.com; maxime.coquelin@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11 >=20 > > Hernan Vargas (30): > > baseband/acc100: fix ring availability calculation > > baseband/acc100: add function to check AQ availability > > baseband/acc100: memory leak fix > > baseband/acc100: add LDPC encoder padding function > > baseband/acc100: check turbo dec/enc input > > baseband/acc100: check for unlikely operation vals > > baseband/acc100: enforce additional check on FCW > > baseband/acc100: allocate ring/queue mem when NULL > > baseband/acc100: reduce input length for CRC24B > > baseband/acc100: fix clearing PF IR outside handler > > baseband/acc100: set device min alignment to 1 > > baseband/acc100: add protection for NULL HARQ input > > baseband/acc100: reset pointer after rte_free > > baseband/acc100: fix debug print for LDPC FCW > > baseband/acc100: add enqueue status > > baseband/acc100: add scatter-gather support > > baseband/acc100: add HARQ index helper function > > baseband/acc100: enable input validation by default > > baseband/acc100: added LDPC transport block support > > baseband/acc100: update validate LDPC enc/dec > > baseband/acc100: implement configurable queue depth > > baseband/acc100: add queue stop operation > > baseband/acc100: update uplink CB input length > > baseband/acc100: rename ldpc encode function arg > > baseband/acc100: update log messages > > baseband/acc100: store FCW from first CB descriptor > > baseband/acc100: update device info > > baseband/acc100: add ring companion address > > baseband/acc100: add workaround for deRM corner cases > > baseband/acc100: configure PMON control registers > > > > drivers/baseband/acc/acc100_pmd.h | 5 + > > drivers/baseband/acc/acc_common.h | 10 + > > drivers/baseband/acc/meson.build | 21 + > > drivers/baseband/acc/rte_acc100_pmd.c | 1197 > > ++++++++++++++++++++----- > > 4 files changed, 1010 insertions(+), 223 deletions(-) > > > Hi Hernan/Nicolas, >=20 > I see some ifdefs being used in the code and there is no documentation fo= r > them On when and how to enable/disable them. > It would be much like a dead code which is not compiled at all, if any of= the > build target does not enable them. >=20 > Is it possible to replace them with runtime devargs instead of compile ti= me > ifdefs? In term of documentation gap, that is a fair point:=20 - I believe the build time variable ACC100_EXT_MEM can be valuable for very= specific troubleshoot (not for production) to shortcut the DDR on the card= , but good point to document in the acc100.rst.=20 - The RTE_BBDEV_OFFLOAD_COST is used across PMDs for a while. That could al= so be added to each PMD .rst.=20 - The #ifndef RTE_LIBRTE_BBDEV_SKIP_VALIDATE is to skip validation of user = API which protect from negative scenario and hence save a few cycles by not= recommended by default. Can be added to acc100.rst.=20 In term of runtime devargs usage, can we decorrelate this from the series? = If we introduce such dev args and expose them more explicitly we would need= more updated validation in place, are you okay if we defer such change to = next year? If really this is a big concern for you for 22.11 (this is indeed not ideal= ), we could limit/strip the upstream of the series to the default build con= figuration only (hence no new #ifdef) but still these options can be genuin= ely valuable to users (until moved to devargs) so I would prefer to keep as= is but with updated documentation in acc100.rst.=20 What do you think? Thanks Nic