From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0EF9A0C41; Thu, 16 Sep 2021 13:11:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E18C40151; Thu, 16 Sep 2021 13:11:47 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 34A414003F for ; Thu, 16 Sep 2021 13:11:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="209768682" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="209768682" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 04:11:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="434462158" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 16 Sep 2021 04:11:44 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 04:11:43 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 04:11:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 04:11:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e41hM/yD+hkZ4lmQeLumDjNZ114Uc4tvHpXIMeC2B05zK0voEyOy7TSXsIFD3awgD6x3wGH+/ClgpRVzrr+paNZsF7pSOJEZPcKgd1G69UwntiwI/z0WY2frXesEtqY1E+bHYeB7+oDYm4UlsRmi+9Nl9B/O2FWhepKW7x+hJv14xlcLvZ3IkQ5LG7Nn54VYQNUnjezN93d/d4EZ5aCcAQO3Xg1KBCNc8slzkX8fg41+EUqjTFPv6BEPWz5sx1YjPmLgmVd5Lvkeg8mE4tqx/rUdtNd3vRbqxUsxGFhKjzNOHbnc9CDg3BGHjIKjdMDmYd3lgVqxw9zahP7Ai/LYRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5BtF1m86y/tNT2EW73gxFQNuocCVqmw+OIjiJysrZMY=; b=I6m/kICicWYq6+mvOe6GTGiNLCJawF1hLebsZ+5nRTlv0DidJ8TRQdWOFGxxyr8PlmRKjroYdGldVmDIuF6CDHODMFNOU6Qmk0NsRfWNZ1IkY+fUZSj6tXFC9CW7BTvGMnogSG37hxye1I/X/b1PZUNSgqs8WOn7XyfuytkCPwqHW5cpVkRPPGPoSSE1Q5shNS5uxuXTVxKwEXzoYKQvChov12GxFsB7mdfeuyFsrFniWZ47FW0epeXUpuYWMGGmxpfSeaUD/NbiyHvqtKAumn2d9MdHgZTyhTYA/adt7F72hxLOnMRG9J+4XhC9ZsfkNLhBnnba/CGy2BkdOLP70g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5BtF1m86y/tNT2EW73gxFQNuocCVqmw+OIjiJysrZMY=; b=rYvULqP+KrbT3JUdeZ7pCli8Wx22+WuqhjUGY6Z9c3z6P4rSWZvWilncuSWx2sfCh8G5NQ4ANmTQEFi1ADFOn7rI3Z1OP+23RO20L5bVtsWy7kMChRG9+cPSjMjitMiGpl93dAEB1+aWoWXUZLHnNlYoWzC+PaNUZYo4/tlpd7g= Received: from BY5PR11MB4482.namprd11.prod.outlook.com (2603:10b6:a03:1ca::33) by BY5PR11MB4054.namprd11.prod.outlook.com (2603:10b6:a03:189::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Thu, 16 Sep 2021 11:11:42 +0000 Received: from BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334]) by BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 11:11:42 +0000 From: "Ananyev, Konstantin" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , "Power, Ciara" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v2 6/6] examples/ipsec-secgw: clear soft expiry configuration Thread-Index: AQHXpAaQXAYMMi7bqEqXXA9wTiaxz6umjsuQ Date: Thu, 16 Sep 2021 11:11:42 +0000 Message-ID: References: <1629207767-262-1-git-send-email-anoobj@marvell.com> <1631032372-275-1-git-send-email-anoobj@marvell.com> <1631032372-275-7-git-send-email-anoobj@marvell.com> In-Reply-To: <1631032372-275-7-git-send-email-anoobj@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac764914-5d73-446c-8f58-08d97902c37b x-ms-traffictypediagnostic: BY5PR11MB4054: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L7hLpAaC+EOln4AbZoQT/L3oQWfd1MpymAT5lc4mc5Cp0WT0S9Kudn05413bivHmQTdaUOBpdyqiPFIVqnwvygAC18sOVZpF7Vl/u3Lj2Rf45kvduhThjXEBE5Me0ChebpPOr9vn9hoFVbFq3sdwAhGlpmsIXXCrVrN6CtYExQo52FqhaqpXXGaNzVFd9nsEG89aE/ngFDkr1KhH2Q8GhsZDPCNQOEkwCX3HuvODEKF6bpL6TWYoh8H2Ko2CzrtO+RuLv9DUcakyH/46TShxq000sMqRF28xMKv6R/AZLOi3FRiKEHAAQgjBDw8jf9STRYXswvNtt6BnY00MA944DGOi9zNVHtEWtBLyzhMGHD/L8FaBpsQ0rIoFa+svkrzNVFKJsaNGmv4r2oO/ag616pazrcdAE17Zh01tFPK033oVTO5oTlqKmUbMO0NS3h9jasaNaH8fou8JoDkQzQN0jU4WyJYqGyYaYu3ahTzdKG4k8IXEizNNu9O2+bVvhQArYvSi/RVQi8v6AXmplecIF+XLnZEg5nctDN6D5KjZF9dVk0SH7gOUcBGjG7WTsyWDoWRSr/QILqRbZgVRpYoHITGT8zDyGdeSRNszCdtjVubPzqHb4HX+ugNCUWO5evTVwS7moodqJbaXHf/uB70YcAejmT6rynI0Gbtcd+Sa5XMWMGWzUwCxHvFf1YkzyOf6ramqNVsiNRCUSywzQFioxw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4482.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(38100700002)(66476007)(64756008)(478600001)(66446008)(26005)(66556008)(122000001)(186003)(76116006)(8676002)(6636002)(66946007)(86362001)(7696005)(8936002)(33656002)(4326008)(55236004)(6506007)(316002)(54906003)(110136005)(52536014)(83380400001)(38070700005)(71200400001)(2906002)(55016002)(9686003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CeDmL6vRUW7oR4usj+Zmp4uO1y0Q5sdaEYVPPENT8M801tM8ixYKU2aEaHxT?= =?us-ascii?Q?TKwOnsaU1ybCNLlkAVriT8+Fg3fIQ3eGtf8y0/4dvj1VT25IK4CSDcnzPrRD?= =?us-ascii?Q?O6QHMCGDU35PnH5H+GTDx77GUl7m2xVEPvfvAkwuSWCuGubCs4JZEZd0mXKr?= =?us-ascii?Q?n1DWKRYo2rODSEiqG1j55sDqOx91wjw3n8ZCd85T43J0O/w/yj95cwhPrfEn?= =?us-ascii?Q?HGS35g2WWq5jf2CL5WLP9ebayYecPClMH4chc15rTjMndBf2z3WIy/yM9XvJ?= =?us-ascii?Q?j9VyXO1x+0yWMWXpGf1is7xwm0nMHrsS4sCfriSout/S8mX7DKroND5mMLXx?= =?us-ascii?Q?X0trMk8iffzQAxh315zXa1QIFwif4kYQIhVkNWwW4mFUPun/I9Nz3mj0ZVRw?= =?us-ascii?Q?X5t8EytM7E21Z1UyPbfmv65LOwbkmP7eBsMWj7kCshecXiKLuPWdDQ5McymR?= =?us-ascii?Q?vxxbxIOB6AiPkwiKYe7PelM0jh14guIu4SAIOxKP75tOrT9JoLzF+wZCJyaf?= =?us-ascii?Q?iBuw+ffGyfCfc9c1Kmog2oLvZDeRMt6Rf4NMr//aYKGACUZyCKn3ur4B2N2w?= =?us-ascii?Q?E25d4m1RFO+3/uwK0PvfveWor9rEoVjrnSMSd576jCLZgOEFpDLKrV7bRwVq?= =?us-ascii?Q?olhQYHiISf3uvYq2sYJpTd4vvbnl0O/f7WTZCw0jk9KHwGu4kR+wgepJ5gko?= =?us-ascii?Q?KJWFU7tdi5YsvuywNoQPTSp/5ZY3O/jOHg5i/3oGz+FupsWnjiSsPSUdlbAu?= =?us-ascii?Q?BHTyircZv5tINyV7X/ZaYg8Cw4PF6oUpRxvv9bxImnPuRufXDesSsSW7X1gG?= =?us-ascii?Q?lnG+8HOTJYR0kIsoJ4laRUtSwTrdPrympV8wZAE0Q9L/iXrQ6GI2Uz3Di/Gs?= =?us-ascii?Q?ZIXDNdoPMMm/ffYwWQtKSm4nkXbK7Sd9dXIovDzeAkJorNzg4BTKrt01Goi8?= =?us-ascii?Q?Ewp+SMjiP4r9prOlndO0l3vxwVLKMVXrPepC+DHD63v/9UaWO7ZCXs4Piq1i?= =?us-ascii?Q?87tFGIP8cnJFcHnzorau4C6bPXPXPiVLOXMOKs4i0nCW/Jb7E4LgO1tOhjYg?= =?us-ascii?Q?B96Wn6zQfGEmdEBFrSCqKS4DxRWUoxdQn9whVKBuN9lCQa//QWl+TlFCA2Jl?= =?us-ascii?Q?SGkGSJuiGxxKgLUKAPQNYeWo2FjB/a3Ez4hji0DAXfW+QPAMNDA+smoqMK0i?= =?us-ascii?Q?CwrgrfDtf+Y/ysbLKY09QMYEFWcVikVAYbjWPt6KQ/17w64HZhjG5aeDE7Uw?= =?us-ascii?Q?YXrbgEnluYZgyjKofi5XuraDTSOKvdzLDqvmmPEcXNdgecMgeRIY9yFML3Cs?= =?us-ascii?Q?/sXu2UvDT6OAxM1XZLylae/J?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4482.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac764914-5d73-446c-8f58-08d97902c37b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 11:11:42.4537 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sA0HgDeEcZkcQdJ3TRiqXj1XrRuTVwQge7pLUd8oz6XZWdxXdYoHk273nGDBvXpMwM9F65jCb/ty7lehq4ffwsxF6qdTXOgwhPzu6SoQ++o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4054 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: clear soft expiry configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Soft expiry is not a mandatory IPsec feature. It is verified separately > with IPsec unit tests. So configuration of the same is not required. > Also, soft expiry tracking can cause perf degradation with some PMDs. > Since a separate UT is available and the same setting in ipsec-secgw is > not verifying the functionality, remove the same by clearing life > configuration. >=20 > Signed-off-by: Anoob Joseph > --- > examples/ipsec-secgw/ipsec.c | 5 ++++- > examples/ipsec-secgw/ipsec.h | 2 -- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c > index 4868294..7f936c7 100644 > --- a/examples/ipsec-secgw/ipsec.c > +++ b/examples/ipsec-secgw/ipsec.c > @@ -49,7 +49,10 @@ set_ipsec_conf(struct ipsec_sa *sa, struct rte_securit= y_ipsec_xform *ipsec) > } > /* TODO support for Transport */ > } > - ipsec->life.packets_soft_limit =3D IPSEC_OFFLOAD_PKTS_SOFTLIMIT; > + ipsec->life.packets_soft_limit =3D 0; > + ipsec->life.packets_hard_limit =3D 0; > + ipsec->life.bytes_soft_limit =3D 0; > + ipsec->life.bytes_hard_limit =3D 0; As a nit: as I can read the code it would be already zeroed at entrance to = this function, so explicit zeroing is not really required. > ipsec->replay_win_sz =3D app_sa_prm.window_size; > ipsec->options.esn =3D app_sa_prm.enable_esn; > ipsec->options.udp_encap =3D sa->udp_encap; > diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h > index 90c81c1..8405c48 100644 > --- a/examples/ipsec-secgw/ipsec.h > +++ b/examples/ipsec-secgw/ipsec.h > @@ -23,8 +23,6 @@ >=20 > #define MAX_DIGEST_SIZE 32 /* Bytes -- 256 bits */ >=20 > -#define IPSEC_OFFLOAD_PKTS_SOFTLIMIT 0xffffff00 > - > #define IV_OFFSET (sizeof(struct rte_crypto_op) + \ > sizeof(struct rte_crypto_sym_op)) >=20 > -- > 2.7.4