From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45909A0C41; Wed, 15 Sep 2021 17:25:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F7474068F; Wed, 15 Sep 2021 17:25:40 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 80DA84014F for ; Wed, 15 Sep 2021 17:25:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="209581107" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="209581107" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 08:25:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="433452344" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 15 Sep 2021 08:25:20 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 08:25:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 08:25:20 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 08:25:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQ8VgxiaOtWiwKm2PvIss0bQto25DLiElfOL4+4C8ECAd1hUEwPRHxE1jNOqFGQTKVztSif0XG1VFWKz3XMjlHVjydPyBR0+oEUN5JgNU3N5Bt/ubBTbvZ7n5yszESmH46dPjH/rap2Lxam1/hSd14i9AQeuHj6nSr/WfLTf18EnZXwqJ/GyNaWhBT9eOWKsVxXFhk7iIa/vwgX4ye9B0cZSbQSp4B0+KSnhrrJXooFsaciKsz8HQscb1doE8Nh76UiFhBqdInJnZ+OMwrlH+PdsR/t2R5Y/CDP32J1yJfyTlIkYUa4iRk7yd0jQGc8cecj/PURZk7sMInyRJVhI/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BgqHNN2Qb6kFZygGWb1QHfV1lw7psIFQNscQ8tqAYjU=; b=lx263YDuN8mkuhIK3KANMmVssi2IS+PaBKCIiCStHHXnCbz+ZvWlnvh/DAruNfVh+BlgXwwnhH3xKOTQEYQq6UmyOUVQhtPSQu20KBYvDeWeYsjpogzUkGDToZqrRmb1CNYuOECtpDtxJwYvf7oYaG6sMjxwCL4nsGIELV+g4mXX/NpihQ2vC8FrZSGEsR49IaVVne1vFVU0GozfbmtRdHXDuPqflggaQkI2NGQm3X4/bQD8cVIW+VjDOH9N2nhkHnaWmBch/TB/Hz+K+zCl9yCSeEmz2UCv6h/QX476pKmqKUgo91J/JBW+o3O+73yI0TKjKW6pNh8PCNoYD4vlBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgqHNN2Qb6kFZygGWb1QHfV1lw7psIFQNscQ8tqAYjU=; b=Q1KkepKJHNXtyQGo5ZHkDJsDy4Oi9sYn0OK0zXHd1gEyKYMDTsCf4xBUrhy4g6Ay3UNdS0SpU4OGLJ5eHgNRg8TYJD6GRxRHg3aqoHeJFsSW+d6WtZognXcBX9dp+wPUZ7BHM86c+kSZO/xa+48YA5XCwXqiK9dq1n0w1iYsPjE= Received: from BY5PR11MB4482.namprd11.prod.outlook.com (2603:10b6:a03:1ca::33) by BYAPR11MB3013.namprd11.prod.outlook.com (2603:10b6:a03:8b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 15:25:10 +0000 Received: from BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334]) by BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 15:25:10 +0000 From: "Ananyev, Konstantin" To: "Nicolau, Radu" CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "Medvedkin, Vladimir" , "Richardson, Bruce" , "Zhang, Roy Fan" , "hemant.agrawal@nxp.com" , "gakhil@marvell.com" , "anoobj@marvell.com" , "Doherty, Declan" , "Sinha, Abhijit" , "Buckley, Daniel M" , "marchana@marvell.com" , "ktejasree@marvell.com" , "matan@nvidia.com" Thread-Topic: [PATCH v5 00/10] new features for ipsec and security libraries Thread-Index: AQHXpjiRT5VCiS4KBU2rhTdlaAyHKaulPn+g Date: Wed, 15 Sep 2021 15:25:10 +0000 Message-ID: References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210910113240.872971-1-radu.nicolau@intel.com> In-Reply-To: <20210910113240.872971-1-radu.nicolau@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f06624cc-a5e3-427d-d40e-08d9785d01ac x-ms-traffictypediagnostic: BYAPR11MB3013: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lXpc9OTdQ8FjFZV3osB84ffGCne2OblT4IaLFEWkdVXnS99DCOX1d8IIoxfYtfbLDMJe+bXGs8VDlx8+ugItK4kZM+/SGhn/ubo3k0R0NZH2w/x/AEAxeyJoOx+IC/m5SGf/FOyDlZyDDnL7Ll1YJy+SAvRTYdJnyJV9qlkCXuNQLF9Gy7WQRBpjEZuJqorRg1l7ZMxwUKe1caOYCo1ntr0BYk85JI1UOY4Ih5w6MvnBB1bUuUJYgzIjxz7vG6y2UjfXGSm4pm5+7j3S9oZXRnBGpZxlbcvh0I0XQ/rJmTW8v10l51/Z/6yV4cxedTyI3zTPhR6VFBrdMzXeer42DOmlOYmnrFdgSgzAQz8hgcVEB45DAFl0ZFLCYmotIKyqUP03x9MaDcu+QVu1iVeKaklV6fP6aNeW6Eq6TW2p+uaOF1Zd7Kt67uGfba877Xv09JvuJ8ZgfmuaSrAIiDCjvsIN4dfVquBcsA1tU4qw1WXl6krMrIuSUzQ3krKv3k2MXla4Ni4iVQyOCVbk6RhgH1hBc5GYFmY9I2lchrqZnJangy5SPicijhRNLvfgL+x0DF4/JyIQ7xMWTn1KaUv5R9G1SWB4C9SpByigl6vGp2rtfgMb6UijEZPGcS7F/Drd9zSFvEaL+O7dGcafBrSLuHunR9GPcAoh9dVC/cRum61icL6MgQ7/gcRtf+48uwljgAB3lKTEAoNHjfNZm2gCfQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4482.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(478600001)(38070700005)(52536014)(186003)(33656002)(83380400001)(2906002)(86362001)(6506007)(8676002)(8936002)(9686003)(7696005)(66446008)(26005)(5660300002)(64756008)(15650500001)(4326008)(316002)(76116006)(55016002)(66946007)(66476007)(66556008)(38100700002)(54906003)(71200400001)(6862004)(55236004)(122000001)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dFe4h6STqcCLJkFbJVeM99YLWatDEmnVq3JmKfDfQmu2mqTuRYBS91ckmphU?= =?us-ascii?Q?xGnJQtqVHBQCTyt/xdsPh5zjZKiQO8gFzGSYhoBCZGcwVOM/sZ2D3qao+6ue?= =?us-ascii?Q?EROcfXxRKa6xBfOuWbhUNIUMMZNMcry5G2XUsfcrr5J6nTWVerGLHzYdOEBg?= =?us-ascii?Q?hJ1Vx2StHo80xscNequf+2mdkoP01d6AZVCObC3plVud/LnfCqsvnTbqHrIm?= =?us-ascii?Q?d3QbZMBKZDHAY+IynRl6B8hnAG1cSPUGxFRJRDWtCkHyH+4QXS6tZ2doGEI+?= =?us-ascii?Q?6jmvM4QRuACa38i6Nn1TZVmB+/vdk7wKK1M74IwmApDBYBzgRyAXu1Z0fU1F?= =?us-ascii?Q?4i6Lh4bcPsqigc0YogOXnpGfDgIuJLiA37irrQv9qswmGzR8wwVUiG2msgcJ?= =?us-ascii?Q?T6yf0+C8tw0UsYJQbrOyt9UqCiqp6YGcmUoS61QDG902kSxZaKe7VqNb16Lk?= =?us-ascii?Q?KsI28skUkvKfxp7PJBBWTlMDhOsdAFm57ib/L92OoqgfY+EQYgYx+CYm83a6?= =?us-ascii?Q?Wv/eS5qbQq+fJ/TpIvnoyMgPMN9flLBJXsEPdrKZ1QsExa4qS85INSmRPgXd?= =?us-ascii?Q?SuT6K5OagCVCz6Fwer1jAdCQtYT4lAmkjVHNdjs0xYCMN+flk/Qn+hAdsvP9?= =?us-ascii?Q?qA29H7SD0chYL9jnCdM3fziGLRbqb1PwGaKgA1RGGgsyD0E6RHRfP4exGtPD?= =?us-ascii?Q?mTWnkeiK1Av0kFGH2dJTKoK2WtF29FjvEKpu3AsEkF1PlsZSCMVbFF9/NWJf?= =?us-ascii?Q?QCTq/gIaVFYhu2ZrJtT+Rk0lfn3mC9fqDcTgaxjQ2mYJIjTK+Mu7Obd5QFhw?= =?us-ascii?Q?Yp+taS87DCrOi+fgN2HboAbJ1aE+c1rMHJ0okaJzk9LsfVjs3KW4hYQuk/ay?= =?us-ascii?Q?RV07c0sE5W1Yi66lbKVWlkfwkJHfy+zGJp63eDZtDCJO0A1cOgkILFCwZWSG?= =?us-ascii?Q?qyIpionJWs9IZq6uu/WYI1IhFcpIH+t41/qNbJvJg6Qw363S0BMTPywrTcj4?= =?us-ascii?Q?vFO3EkQqaZ0lfLx/kitZxTESvbhLnnn17GxWkzmT90SlIBvkPNgp29qPzoSy?= =?us-ascii?Q?OjuXUlp4mgrHps1DFhTH01e/VnIP4R8ic/kCf9VHobnvw4J34DYWJZwnttzW?= =?us-ascii?Q?Wv25VOSj77Yy/g4R37GvLEWDQM2QPm6EPhuXJ2DV6Y8paFDl8WetzTKNTfRp?= =?us-ascii?Q?+gVn0tB8DU/Ci27q4Njvg9w0hsAkkDz7hJjuXGUV7vgblIduAdjyUfxiSqgG?= =?us-ascii?Q?+D8137unzHoVRU/uHORNWIrPlXmBE5LiERa1Vfv/qjexDN/3y7phrOtYuE4J?= =?us-ascii?Q?qH5SAI89m9r3WMBdN1PvFwyZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4482.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f06624cc-a5e3-427d-d40e-08d9785d01ac X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 15:25:10.3851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4w82AgrTVBORI/ASBGO9aJ7xxqMVJjKvR0vMlRZ1n8+HLs1UQDFo12vNpuQ4fa9u5oPgAnrEFnc5KJRbiTpvJCT2PJUuCYIyS6Hw+crN4iA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3013 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 00/10] new features for ipsec and security libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Radu, =20 > Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value After applying your patches I am seeing functional ipsec tests (examples/ipsec-secgw/test) failing - both lookaside and inline mode. Could you please have a look. Thanks Konstantin >=20 > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley >=20 > Radu Nicolau (10): > security: add support for TSO on IPsec session > security: add UDP params for IPsec NAT-T > security: add ESN field to ipsec_xform > mbuf: add IPsec ESP tunnel type > ipsec: add support for AEAD algorithms > ipsec: add transmit segmentation offload support > ipsec: add support for NAT-T > ipsec: add support for SA telemetry > ipsec: add support for initial SQN value > ipsec: add ol_flags support >=20 > lib/ipsec/crypto.h | 137 ++++++++++++ > lib/ipsec/esp_inb.c | 88 +++++++- > lib/ipsec/esp_outb.c | 262 +++++++++++++++++++---- > lib/ipsec/iph.h | 27 ++- > lib/ipsec/meson.build | 2 +- > lib/ipsec/rte_ipsec.h | 23 ++ > lib/ipsec/rte_ipsec_sa.h | 11 +- > lib/ipsec/sa.c | 406 ++++++++++++++++++++++++++++++++++-- > lib/ipsec/sa.h | 43 ++++ > lib/ipsec/version.map | 9 + > lib/mbuf/rte_mbuf_core.h | 1 + > lib/security/rte_security.h | 31 +++ > 12 files changed, 967 insertions(+), 73 deletions(-) >=20 > -- > v2: fixed lib/ipsec/version.map updates to show correct version > v3: fixed build error and corrected misspelled email address > v4: add doxygen comments for the IPsec telemetry APIs > update inline comments refering to the wrong RFC > v5: update commit messages after feedback > update the UDP encapsulation patch to actually use the configured por= ts >=20 > 2.25.1