From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60EC6A0C45; Wed, 15 Sep 2021 17:55:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FC74411A0; Wed, 15 Sep 2021 17:55:07 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0AEA341149 for ; Wed, 15 Sep 2021 17:55:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="222416013" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="222416013" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 08:55:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="553352146" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 15 Sep 2021 08:55:04 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 08:55:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 08:55:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 08:55:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMP/4BtmfjG3ED207mZ8oFlWKPW/3MQbheYIphVO0L6r0JrpcTS/A5aLo4LcfC+qOAt9QUihDJL6f3xgLWvW1GlQ99Pqw8b6Gv+EIBGOpR3br86RMlTTjuRF3YUBtVD9pJQR2s9Y4+gx7iJEWENJqGGU8CSSkXdoJWip3VbVZtL/1wkvDr5NRiWDuhj1ZvKoGO4v+fxUfpZXnvpDODey70eG6yHvOhsmtB2GlJWPZLBkKtJEPzvfIOW7iBczUoTDmwcvAkqWc0bXtB1f77Bvgcp5Q8XO47s2Hq1BO/HTuEmgbxxzb8a8MvmOUkXEkc/Ll6LYqiXjXIJsI9jY8mtI4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rzkndag5YLUpAYpIjyAlnNA3MpjG5aLkAMzWskpyXOw=; b=GkzosuglBTcYC8asDTTjZWNuUKdnqB9LGBDlGjwK2Wk/5WDvlxddmJ1vetvIx8KcnjObSBJ01EOi+ZlDYPkiJS8eYChCYyf2u97MHeWWG/HFtBz2Fcf0w+Wwi/WS0qxgiJzxU1neYYEfjkwNbSXSB3hGmQ9oihJ42vjjTfMD42RvPD0KO+mUZyPCYWqIlhDUHQyJRwqvi1JWwibX1BVxOuHK2HFUZP8eyCZAVxM2xLFOH9oAOEJJJ1nEg7cs/kdZITHyDug5FLXaSjFE0v0mzoOnRBonMHAPZ6Zr0DzGmoUSE6cZ54wVHj1UFHsYM+UBLYPh2KU4ZW06F7Ab2O207g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzkndag5YLUpAYpIjyAlnNA3MpjG5aLkAMzWskpyXOw=; b=KtK6Znns4Q4CLU/08i5pvvN2C4F8HsNEzEMDHirR8RHuVFC+YEDB/qXeefhv+sth4f1El5yQ4VlcWDwmw3IRaVLTTzDunAcCDq6rNrtWAfDaBqhdKEJpAwnVekBFouVyeDe28M7vgySZDiuRHz6gBbxPXqKCvsF+VpgMz/x7omc= Received: from BY5PR11MB4482.namprd11.prod.outlook.com (2603:10b6:a03:1ca::33) by BYAPR11MB2742.namprd11.prod.outlook.com (2603:10b6:a02:c1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 15:55:02 +0000 Received: from BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334]) by BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::a850:4ae9:9444:7334%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 15:55:02 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" Thread-Topic: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields Thread-Index: AQHXhjfj0tjtYvUrqUiQoEeO7MVu9aulh5Yw Date: Wed, 15 Sep 2021 15:55:01 +0000 Message-ID: References: <20210731181327.660296-1-gakhil@marvell.com> <20210731181327.660296-5-gakhil@marvell.com> In-Reply-To: <20210731181327.660296-5-gakhil@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01652c1c-0fb1-49ee-f4c1-08d978612d97 x-ms-traffictypediagnostic: BYAPR11MB2742: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aX0Z0uWZpFkr1r30X52aJCmvm5npZerBsSZye0tYLbDve+ya6HUl8PPI5H0efMHguR3ZuzVP/WxY1xpd1HqiKVNRu+ZaFFhq9/vOGmbBppOlTO8G3dQDyHr0Xwz0TEyL0x6UySl/gpqGtGBWc9aqb74xENORBsJgn8USs7/R2co9P8nGOocqVV3kub7xhK+xXW8Git6j2l1xyfUifevsDG/xzjXvuK71dqPQwHC50gxUQX0e9v+8rIIztyCieFHBrUkdhm0hytsK/XDiJhBHd48mSS2QAc+4oF8la8SBQbAwLWDlCFQl/bkdDRq6POd8pevWAFCFm084GdWWgvC+ORtwplsUJwubiUUvOqTmqwRmZFwiAJd/Cuq6aT1E3jhR604gn+6T5drKtdOWHRVclbSgxx79ipBT1tXRMDuzfNBP5XQ15kp3Pm/jJ8iyDYk0HyKMC0Z9vK9YQfAsuL3pk0eGXbU74JrETu5DoIK0st6wWfz+j3RmHyNyhlhMy+SMi+g7AagOfstymUnPZSKZXXg0vyZlZhnekZWGQq+99985W+rD0803D/EzPNlaP59euUeCjhE3eInXeD3kThYDqU0z90Bqq0Jns6DVIki0Y+7lLY0vkE4oPLak1pRgDeUm/TIp1NWebofib7JqsYWgwHtreKSJUBKkdZ44s5QbzCZt/JBa+r6qXuXkbTLnKgJDyPHizwFGzwA/pBoLYawwq0puzKQw3+tqKw5QrCxLSVMsL+fZ35gidCS4jy8iJCcRrVxXyoy7Uuvfp7s46rIUwocRxOPNNyZlhJIFa7b/MlU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4482.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(71200400001)(64756008)(66446008)(76116006)(66476007)(66556008)(66946007)(4326008)(15650500001)(966005)(8936002)(52536014)(8676002)(316002)(38070700005)(38100700002)(5660300002)(122000001)(2906002)(33656002)(55016002)(9686003)(7696005)(186003)(86362001)(6506007)(55236004)(54906003)(7416002)(83380400001)(478600001)(26005)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J//2UK9BR1nOdvjKl+VOFlYLs/KG+C43hZrC34MeuhQIsHoxMeZXlzTx0DvF?= =?us-ascii?Q?U0bG7bvcPOEzFoWtI1qs1v4ynGS6lYAKav/smvZaKmC1v8qRySQlqgtINjM5?= =?us-ascii?Q?ebwwk8z6H2ERec59gn7QmP2vvXaHRtrjcMufngt0dcgrXSYBJR0HbtiqHekW?= =?us-ascii?Q?d/s6dicOKm4hMgSp5eYnb1QBLt832jRNHFLrlK+UTuhu+rVhOPjmbZSJEqwB?= =?us-ascii?Q?gKi4LtpbG2fUo6+AYNvpr8OkOVoqrrPS1jj+FIfmj6uRU8AUVjfL5k+53dJg?= =?us-ascii?Q?mDORunytQ1S4ELsA4D6/KBBgb4l5qosXtfOdH/QNLZu6lEvKNHBh96AA0JZa?= =?us-ascii?Q?Ofkei91a90lfv9cCjIBgMiZ36iK3I03fX/ksveaQH6fupdD3ubfw+7EMMcXC?= =?us-ascii?Q?GijYUurQCgPeEHDl5fu7sdhjbvKDW4H93tIzmu5lgNyyUzy4Ig+OVNnYlUYn?= =?us-ascii?Q?O1ucEQi+Gp9OLJnrzJ9wR5N4vmZuHipiSvfFA3/5fxqQ31zxiHEAPjOaRxxy?= =?us-ascii?Q?bJIUejI8m9HhcZbedi+5m9XreV0VjXOEUcyamGwFy5FZ86VKJ02ut8bNX5Dn?= =?us-ascii?Q?bbKpEUw3gXHKuad5SYSsrDKAke0oIsJ31fJZ+0eyEU9yCGfGhfFHr64IPql5?= =?us-ascii?Q?CBy7INluaBO9q0+4Dkb4DE6JDD0Q4fam1L+rGjzX7LEZcvBFnv+LvvljzhCb?= =?us-ascii?Q?JbxCNzn3kLUFzwk9G1nw5tCIeS+h5LmMxvDU/f9KEuulcHELvSlHCQpoJGXD?= =?us-ascii?Q?bYRTy4oVOCJhBI6IN5cPqhhXp/iarFZ6tWV9IFIKVmWoV/aNQ4juXFLo6f3S?= =?us-ascii?Q?ZpOtexYRufKbS6UC4k7ODHMRSRA5EbvTofyB9CDvboWn+f20UGjT8dtkgSrD?= =?us-ascii?Q?JfC/Oq84zw5LAZ+GlL3HIcayxKkI12MXRcJWiHvlktuqWwRCvXW0gf8vwB/u?= =?us-ascii?Q?88udTjxoVkUg17n8+DJimHhal2nagtxb9fPuPNmZlFkf8U5ts82o//84RFAj?= =?us-ascii?Q?KdeHK4Mofv5PDXFJsMinpsUhEx+H++YBb4zS0qKH9ZQcdZKM0NCyNsKCAwUr?= =?us-ascii?Q?SRx2qoC6WMp2t2j9tRMXHse+Y3YAPEUbM8YkyT+XnE+dxAMKbGqZPK9wXiET?= =?us-ascii?Q?qgEuMy0P+ArIbbU3AMka0weWw+n9VZQOffGbM4+dfXaiEi2qUOAUuhw/Ber+?= =?us-ascii?Q?O5d/NxBduTONEvB6VYqiiKX51hHOH/FyARlJZwp7w4TV9FnmzIIKkAJ6LkSW?= =?us-ascii?Q?EfWMMOd5b8BHcd+CHB6sFPLwyU+uIQ66h5Dw0Yr+X/F52OJ0A+pZbMMAxTjk?= =?us-ascii?Q?ev65xycGoWzhoDSIKKohuDgb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4482.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01652c1c-0fb1-49ee-f4c1-08d978612d97 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 15:55:02.0160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nik90qtJ4fR/hwgJ3fecjNVw6aCADo+BLF/H4Q4uXmSQapzCYsnMaU0oL75eHkpE4QyFambFYnB1IJRTPvRWY9Nnm4lJc+3LHl8XVmw1Pvg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2742 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/4] security: add reserved bitfields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > In struct rte_security_ipsec_sa_options, for every new option > added, there is an ABI breakage, to avoid, a reserved_opts > bitfield is added to for the remaining bits available in the > structure. > Now for every new sa option, these reserved_opts can be reduced > and new option can be added. A corresponding exception is also > added in devtools/libabigail.abignore >=20 > Signed-off-by: Akhil Goyal > --- > devtools/libabigail.abignore | 4 ++++ > lib/security/rte_security.h | 6 ++++++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 93158405e0..5d8da28e55 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -52,3 +52,7 @@ > ; https://sourceware.org/bugzilla/show_bug.cgi?id=3D28060 > [suppress_type] > name =3D rte_eth_dev_data > + > +; Ignore changes in reserved_opts bitfield of rte_security_ipsec_sa_opti= ons > +[suppress_variable] > + name =3D reserved_opts > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 88d31de0a6..4606425e8d 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -181,6 +181,12 @@ struct rte_security_ipsec_sa_options { > * * 0: Disable per session security statistics collection for this SA. > */ > uint32_t stats : 1; > + > + /** Reserved bit fields for future extension > + * > + * Note: reduce number of bits in reserved_opts for every new option > + */ > + uint32_t reserved_opts : 24; > }; >=20 > /** IPSec security association direction */ > -- Acked-by: Konstantin Ananyev > 2.25.1