From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7823A04FF; Mon, 21 Mar 2022 15:24:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A289427E9; Mon, 21 Mar 2022 15:24:43 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 840704161A for ; Mon, 21 Mar 2022 15:24:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647872682; x=1679408682; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=5OCotZjzinC7YQjOTEkloQvstobIVrKN5FsS3cFFZo4=; b=KEsjWWi6Gq2b2sbvLyjWqsyQ4bKStqkVy6B2390nax6OP0J7t3WvVNCB QWqoIBBGgkcTbebj07Njn1Y1kilSUdVT44IT+9p1Q70iPYJV3kXFleQuO fYNdMaWkysWB8FiT06APv/B3i1HGcvOWeOSxlBD1PA+gaLCTj/Yd0KlIP x51oxQ2/87czOxlOo9wyJXTgt8NFndKIJLi+VVlhPPJtUz4PMd6rAsUY8 NaY/RWDJkxBJ2rNX+GQ53uPvpPpC0GQ8GhBzbGn8T/QBkhRvLT+KxFDZq gwRgObudjeVaIa7JWfQEkPp5mFYu/DaFFnpSWYLQ5+BCEeia7KftHzcw8 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10292"; a="237506417" X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="237506417" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 07:24:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="518455041" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 21 Mar 2022 07:24:41 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 21 Mar 2022 07:24:41 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Mar 2022 07:24:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 21 Mar 2022 07:24:40 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Mon, 21 Mar 2022 07:24:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9DvLdCmOJ/NmwnkuL6FOSq6bW6kVmcQ1O3PDDW1hDiATSGu/EwCc88m+NQwLW85DgDKH1aWsLikJ9tVYyeuCbsf/sogQTjtRrlRo5bDqd0SLc63H17kf5GTa4yeOVVai0VBe22v2gkNZzymdrPtoBHJDFqUos8Lj/0NQZVKR0l07oCD/tlQ8PQUhdYNUOChYS/t7S8GX9gNq/ydV4evea+P8J4301vTcvttTw9A3eL6HDakyCtE+kTc84QGZb8kgfCJjyt89vp0oXyvJsjhwAccZc2pojEx0LVbCEJldNjH2b6f0f5C4CTcAuo4eFv1Gd4mQKmsp2O/hrTL1wbOWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XCqe7eVaWp8x1HXnE2PPy6FAqzxgynigi1DB2iJuB2g=; b=c3oZH4Us73NRQf2FeOHNsBygeHcCZkfEml+h4+07FYLnr36cc9BNsM7uRI3ic3g0FJWWa3fXLG9L3trkbToyIrsHGGdqE14fytB22mSqkbuOSxBk8eNd5HXiCy8c6+nivlvktwTIC7VdAY5Peg1w+0qo7IHlFLWEDxK51waNQDeGNZs0AlciytcjSiggtry8vJ99VV+Qa9zZjizcl7dYKWnraqYMSqqkCm/j6zXHbLnOnnm7K1dYlTgb6O012IQuXX7D1CiSrMMhNa1g3j8o9VGyBy5KZv24BfbwPiYDNbPZeyho0BdaZ//TftbW0epEOGK/SWpLe3KAj1F1QyXvZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4482.namprd11.prod.outlook.com (2603:10b6:a03:1ca::33) by DM6PR11MB2923.namprd11.prod.outlook.com (2603:10b6:5:71::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Mon, 21 Mar 2022 14:24:38 +0000 Received: from BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::1402:5293:5dc4:2386]) by BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::1402:5293:5dc4:2386%7]) with mapi id 15.20.5081.023; Mon, 21 Mar 2022 14:24:38 +0000 From: "Ananyev, Konstantin" To: Huichao Cai , "dev@dpdk.org" Subject: RE: [PATCH v4] ip_frag: add IPv4 options fragment and test data Thread-Topic: [PATCH v4] ip_frag: add IPv4 options fragment and test data Thread-Index: AQHYOD2DBRsh7qLtOE2A0o7Dyhj5HazJ454g Date: Mon, 21 Mar 2022 14:24:38 +0000 Message-ID: References: <1645413440-3431-1-git-send-email-chcchc88@163.com> <1647328926-17118-1-git-send-email-chcchc88@163.com> In-Reply-To: <1647328926-17118-1-git-send-email-chcchc88@163.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbf46ea0-6c0f-45ca-4584-08da0b4687d7 x-ms-traffictypediagnostic: DM6PR11MB2923:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G1yPQzVSwmHz/n4sOqvqaG33gOcxpl6wiwzPDmXmVu3mrC4VcSPUVnMpTqRum3vCBpDx83HU52lrnXHdqRbJhKtT/p19QMTipL90dOp6RZUwE8OZeSW2iuj8tHdSQaLN0kRs+BcTT4bVrKS/4kMWNUx4k3WVzpm3fmEqeby3F5fNa3aJPMphUDCc6tGR02iXlKwHMDkOFhDC4JzBAhiSUkLG58QpDz4ml/wCSz8X/fcu9SPyWoSGit+QPw2ukpKxew1MFjMlUJU76WOL0mIt7hUaOfuGyW2uA8t4Txx87LUnvD3YuHhgCVjbRmkfIYxtLeVsVmsdvFlRnIDgdht1Zp4aSvbaW6x5YXOjFvP2uGGoFYtx7YAosRS32aMJfFma3RQDpvvU0r1W8/cDkCwG8SBQU4+eRjRRLZHUdgq2dtbZro5UJeXrHM5rNcFuKNbiVnJFqC3BAXCj+VZjLjiqWYZ/NoHibCEmi8xYjwnHSmDTYXqTvzoYHHK5pNE2p3Aux8+52vLqLiSuF22bD+QMOnzyJFx06hCviWDCa9xcqE9k4HrSFBvxXRnTYi/oOijyFXr+5M6h5/cl/J2783bkkQ7/sEKurQTzrs2Xbj81En/l5u3psP9uTZ9OknzfRNBHoVxbn65Mz+TNEDEn61edHLgTtTHE8kGoYC/qGwwLoIsLlnQFs2qyhoBEwmU2gl74SBze2ORy3P+DfqMAw3CiHA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4482.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(26005)(52536014)(82960400001)(86362001)(5660300002)(55016003)(8936002)(2906002)(9686003)(76116006)(66476007)(8676002)(64756008)(66446008)(66946007)(66556008)(83380400001)(122000001)(71200400001)(508600001)(7696005)(38070700005)(6506007)(38100700002)(110136005)(186003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Op+J1sFA/b5zOso+qui80wXQPpJRH1lv9FK1+GY9JLlf9jYhSwczFSps9Q1w?= =?us-ascii?Q?J0/U4q/lvB4oA20Q2lBy2sSGHgsW7YTBkKJ3uFWAE6a4n0P33VwSqtKSUJWv?= =?us-ascii?Q?3/lldFW71IDfVUNCT8rREfX85GOmF7KpXKjVp8/8RoxScPZbPd0pVuI4Zvn0?= =?us-ascii?Q?RJKDYPqbJp8LfghDmG5ZXdtDEN3XmuTRYJB732wJfwJEbqZN1qf5A8PkrkZU?= =?us-ascii?Q?/L2h+3awe3XwD/f1Yy3FHGXfUoYLgNH9tJkMRImhPFvfB8qFRgjUyh9zi2vq?= =?us-ascii?Q?kiGT3IVsF8EbME3pynFodDuh2uHTguulkie79SwdvnfqcwC+cLC2ApUteHSr?= =?us-ascii?Q?78jHi1lHo18Cl53TYhaX/vOm8vUBVoJAhKFnIsZsPGddLWfbQl85rJg3Aa2T?= =?us-ascii?Q?wMbqXcJKJTzs2dSsonqNA81m2XcSFMpvBujv6k1n14fqLfiTgB0LLEOFhe4e?= =?us-ascii?Q?MU52l5TC+aaoxdeuyB15Q7QR2FXrOnrZ5jvtEElCRWqLPiOEsml3DmA7iK7M?= =?us-ascii?Q?bAXymRWXkZLJnrbk08TXNif6yMBTtkKTZobD33INcRuICop+YaIexJpAJ3tp?= =?us-ascii?Q?fphjbhwq6AQehhrL82n6HeZPKztYMozQGiKuZKo+vhBHT7IkOC6HNXYCu+BH?= =?us-ascii?Q?WvkMCgB6nUqUbcDZhnYdIzFPyRzwTZHd07im31xXay3YI7CNP6ncOnNO++93?= =?us-ascii?Q?ljvZ+vZso8zB6m6wGpIIVarwKtv85giQ+yc9r7b0MjZiuU81yGZZdaDkvQvG?= =?us-ascii?Q?4lPfYkDHTtrxeZcpQv0YH0JfOY0+RHVNB2hHW1X4Mu7BzKfPCi0YsRylOrgF?= =?us-ascii?Q?O3kKP+8hC5w8J3Z0lak+OEEXACD83gUB0eqTv9QJHviaL287TqypHBNgopdk?= =?us-ascii?Q?K7vPkhcR0dR2Ppho1Pr47YYl3fbCVjyLJg7J9vlaQcDkDY+Xv9NGRiWi9VSe?= =?us-ascii?Q?ywy+neeeEH8wW02B9QCL7US/mEmUzHFbHJymHTVSxGQjsb9KdXH8gpEeu6Zx?= =?us-ascii?Q?fuV7btC0IDgQeOtxrsIyMeZl3GGwzqwh29Tow863ucfCBxsxsdtlzTvETGPO?= =?us-ascii?Q?6O821luPNSkm9yLJO0jF2JoBvoZqjebwXLoQJUprytAsUCJFOhxi2Rvhc8v7?= =?us-ascii?Q?8VgvJEqf5bn1qcBar1o63hUcFFFcRy4wlDgriCEx35PEZ49GWF5ZVhjfCf7D?= =?us-ascii?Q?pZpJJI/5BQ2L0tgiHx73pBQ7wDWRWuU/z4lCp5DgnT9OM2AV5kJPhlgc6zBY?= =?us-ascii?Q?OzMxfduBVoyiEPWQaFbG38SK1FVFYlwCKBoqcS36eJdz10MiCi0qkmblRmuK?= =?us-ascii?Q?e/PmyEzoVX7bs9VBIM+3LluXo3HvRMXu3x0rTscKpamflzx2//7SUcaoKjhZ?= =?us-ascii?Q?q/uNE+i8AFXlToieiqpWbUVqIcK9NX9pCsu764t5VYJG+Mvtfw7uY2ICS6nG?= =?us-ascii?Q?VerxEjkarfgsJW9kNE09WKiKRmz6e+4azLx8clDEfbNWfThP2owQuQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4482.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbf46ea0-6c0f-45ca-4584-08da0b4687d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2022 14:24:38.0370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qHTUMsD8qBHF2SauZpaxwxn0ZNDVB9VfXy0OwmqXPiRzMzLT7EKp+sPL+ajlZNj14YzRDcvv/f93NWYEmjjB6C9hYxveiWl64/U6CzP6AWM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2923 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting process.Add some test data for the IPv4 header optional > field fragmenting. >=20 > Signed-off-by: Huichao Cai > --- > app/test/test_ipfrag.c | 319 +++++++++++++++++++++++++++++= +++--- > lib/ip_frag/rte_ip_frag.h | 6 + > lib/ip_frag/rte_ipv4_fragmentation.c | 70 +++++++- > 3 files changed, 372 insertions(+), 23 deletions(-) >=20 > diff --git a/app/test/test_ipfrag.c b/app/test/test_ipfrag.c > index 1ced25a..f6ff2d0 100644 > --- a/app/test/test_ipfrag.c > +++ b/app/test/test_ipfrag.c > @@ -18,10 +18,109 @@ > #define NUM_MBUFS 128 > #define BURST 32 >=20 > +#define IPV4_IPOPT_MANUAL > + > +#ifdef IPV4_IPOPT_MANUAL Could you explain why do we need that define at all? As I can read the code, right now IPV4_IPOPT_MANUAL is always defined, so all '#else' blocks are simply dead code. Is there any reason to keep it? If so, then the code probably need to be re-ordered somehow,=20 to make '#else' part to be enabled and executed:=20 let say a separate test-case(s), and/or separate function or extra paramete= r for test_get_ipv4_opt(). Konstantin