From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD8FAA04FF; Mon, 21 Mar 2022 15:42:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45448427E9; Mon, 21 Mar 2022 15:42:45 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A1BDF4161A; Mon, 21 Mar 2022 15:42:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647873764; x=1679409764; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JkcpmsleWdEZLkTQGqTh/lRK7CeD0q1bsDHRi+FS0kM=; b=IGwoAXfJm3uPrVhzF6sGjBG5FoWDcgrNo0nxlveFe9YgE/ZkqGohfbLW 18WD5GTNMJMcH7jysz/fpc5cOGL7BgcxVlD9rAwwGwLZNtphSEyHKaVSF FVnv0Jl6ZJEj2MxdyXbnvCA+nlqFzKvg033zewJXBhrqBRdZ98BF2TbBc +H+L4SJ1S4Wq3STp/Eb20iI9cMv4CMmmn96ezS+nB5sDsemR9B59ya4iO bBRSHr6CVnrK6cSmGYVlcncPxvUKlNNGNWEb+hEACfD/f/S+k5+Gb/82c MQ57hS+bl8xRUtoXBGkeXDrf2xQC/jSjOEqz6XpxMuNte67YyCB9HWV4L g==; X-IronPort-AV: E=McAfee;i="6200,9189,10292"; a="257757269" X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="257757269" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 07:42:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,198,1643702400"; d="scan'208";a="716520972" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2022 07:42:42 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Mar 2022 07:42:41 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Mar 2022 07:42:41 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 21 Mar 2022 07:42:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Mon, 21 Mar 2022 07:42:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsBuJoX9XIcD7h5X2iYuU/Nsn0s2r5a8oQCjEamIGitE58CEUnq/MY+ADOTYqJMGy62sqsOTIIAQQ3ujx2j/mHbzbeOCtyW1RVvhQtu8v7V82R89mCLfUTLDMXujT4NB8T03JStByuTZIJpQ5okpJ/jDXiiGkD3NK4rYG1WxslLaMSsPWrOwwFGzkrhqG0QalTkugHRGWXjgjFK/VhuLPlJRSZ0mfOEpM3XkSRHVuTAF1d+2RJXLBxgBJ8vShZ67VF1s2iLTDm2GP/L8lWSC8Fkv2fhXYrYh+pXI/32rb2rtXGiw1KdabY6BhWKjd3JqzLkT5ziHf9nvWNR6CunYPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13uxde6uvzvC0mfmPDm0dk3B/3XmqvT483Dp0iMvTgI=; b=R7RX/CPGK8HzKTooryUcgEcGKPYRfJK+0hTRbMfvqeCjIP8vU2LGIrpN5hSgxchzUD5E5YxBS7cNBAH/o94pUresG7ObvsovCn9Ob2vlvBD8rTAkeeOOsMd71rsmzCWJJHvJ+xkDxzFXcMHrc9+dLXrXsTtco792qlHk27+O1pA1yeCHv+7gDJPb3eGGwse+4oix7Fn0Q7clBG6IHYej8WyfXd4t8vOnuxA3V6tkcf8NM0NNN0nvuAKuMeOegvhtQimeEPiE906PmOeKPt7liYQ6o5WQhtN/ZbLlWt7kO1cYvj+UvXsWsVd8E/dYEGfm6mFEYSfk3VxkO6/8G02M3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4482.namprd11.prod.outlook.com (2603:10b6:a03:1ca::33) by BN7PR11MB2564.namprd11.prod.outlook.com (2603:10b6:406:b1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Mon, 21 Mar 2022 14:42:39 +0000 Received: from BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::1402:5293:5dc4:2386]) by BY5PR11MB4482.namprd11.prod.outlook.com ([fe80::1402:5293:5dc4:2386%7]) with mapi id 15.20.5081.023; Mon, 21 Mar 2022 14:42:39 +0000 From: "Ananyev, Konstantin" To: Tyler Retzlaff , "dev@dpdk.org" CC: "stephen@networkplumber.org" , "Burakov, Anatoly" , "stable@dpdk.org" Subject: RE: [PATCH] test/bpf: skip test if libpcap is unavailable Thread-Topic: [PATCH] test/bpf: skip test if libpcap is unavailable Thread-Index: AQHYPSXFQ33mMmT2t0C8gpILt7IYs6zJ6Ohg Date: Mon, 21 Mar 2022 14:42:39 +0000 Message-ID: References: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23612cd2-96a1-4163-73e5-08da0b490c70 x-ms-traffictypediagnostic: BN7PR11MB2564:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2FNFe14WXcCFxFNLOxc5vCRAQ6WQvIm1lkDELevuZvNrF4eSUEoazSM4xVYpNwC3x2Mo5cGRhTTmAQ/+tGQfXV3ZUikVeDyqLM2juz4OrMzhSQJZ2FQV5CPdBrQr3isl11REDVaUtJ4wgMcTIBN9NQw5SU86+sDWSxfoovwlZLv6z5PURozyH0c8u6HNCeErrKWFtzB7UPHngMfBj4ye52fnnNv0oso7hjpA55BRLRho9koK/WyW/gX0afYqtWqcoMk9t/k7BDHYFhfGcZ0hWOpBBf+gWmtwN5pi8yndXNK0EQLA8/JbEYNSRaNpX9UDP/rxfDel+PnOLnGpxmQ+aBjQL/PZm4HIkEUHn+3c6kO/p4B+FyVnqNOhfZpFp1o8tVX6C/y0UBj82r7THT6a4fG4+jLlLzYALqUbRH4g080DhgWDga3CVWhj7/kYzDK5X65tueoDywAVvDzk640kHdMR3z1MEsMq/CRhHuKmNVpGX1i5LujXLRPyjOPR6YtHIpJ6CTMJz/2BppaOsmYOo9xq20RZ5qfpaF4hoRs41Px9qaK1PrcPvFTM9ogfbw2vbizQ4q/Ynxqrpg1ebH0ZIuipP/k2+gbQvVytf72jELzaFQ9m1BpaJ9FtZbTLTLfYZnctmUP1IO917rQuZdoZnTuqHAYd0el4/VHxhKAPulNr/9ewzq+kDFTJWeTKGPa2MiO3nPdT1rjOis5XgUUlVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4482.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(55016003)(86362001)(508600001)(2906002)(8936002)(52536014)(38070700005)(8676002)(66946007)(4326008)(64756008)(66446008)(66476007)(66556008)(76116006)(316002)(110136005)(54906003)(71200400001)(6506007)(7696005)(9686003)(38100700002)(26005)(82960400001)(122000001)(186003)(83380400001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z4N0pSGO+NEZGQHRZiqqGsay3Mrq53O6EyA2M/jNVgj/lUOJWtduIpPSgWOY?= =?us-ascii?Q?y0W49NhR/GcqLo0gMsbvw48+NVIV/x9oIEfPTr4vhz6uqm6en6AZT3hDhT3O?= =?us-ascii?Q?wzc0FVEc4frRSbhEI+Xl//4E2x6ob/j/XHleFsZTg/VKHO8ksNg7KtVIzwEn?= =?us-ascii?Q?dgx82rlyPiWz1OkkpKMsKcnGHE0vyjVThgM0Je7YxPZpT0IhLZM4ST3JJTEV?= =?us-ascii?Q?8Ab0DcmE7V1l0kr8u1Z2njxWTFM2E7zxK3MQf3BHDIq1+ZShcgG1EGuddjjl?= =?us-ascii?Q?bpLIIua0bfGzZcf4rG8xk3x4JueXSSezu5qH9IImd/13pC+cZBX5f3JXQj+s?= =?us-ascii?Q?zOom++Mul9EgHqMC7OldmwK0eu3i71Flf4n0k4tJopDK5AimHdYc11A8Vdj4?= =?us-ascii?Q?E/AM5H5qUzDl8Dgnai1V9kNJwzr2KnfIM26M4nVi/CM2O91cVxJJlBScXuKz?= =?us-ascii?Q?SbHyntywhsi2FNb8JM55P5L3p+2Xs2tx/5ik05gfkiPZVjdfrzpHiyvCqwhB?= =?us-ascii?Q?ZzkKB0x/wrK80KUoUmpnXE/bmB8uKJIlKGJe9llbNBb9r2Se1KdqoOQRsHd1?= =?us-ascii?Q?eDe+4i3KjqZSJEHhvgGmQ7xnMeMM4tJrPKUGZYeroVUywtoM43Xqs4tC30B3?= =?us-ascii?Q?gZwRzn1OWEFGWgGG4ehbIQeQakLmA2+1xKYO9CbhEksYlFAHQ5rxUAPJo6GK?= =?us-ascii?Q?uBRTPQYzQQBXzvLfblQVyNgO2hlZZout4PI4bKb5tUeGaIWQUVacKEeH9kmK?= =?us-ascii?Q?yyLgz6oCYNtlLO9pA4p+o6YYwO3QIosxleApUWLRUnSz1g/QGAV0a5q4Vfhn?= =?us-ascii?Q?o1x7qKWcA6xBEszSBcp9gF5iUAvykw2U2YOO50A0q+/KQTGwu+2re0VHv+Pi?= =?us-ascii?Q?hmXYatbpKLBdl4oErcdZMjzrVYuaBwPhX0rwBtpLoNJNXxbDoHx9/WwL8qZD?= =?us-ascii?Q?QhbHrC5WB+GvRaAUfL0IJa0yS/65lfjloUHAFWA6aMswXNyaeeSVIq+W0+xR?= =?us-ascii?Q?FDUscXi9T2xzXv0S8/4rMJooO4/oOOMGlExgvlGFkpRPsr04M2qlM0UHkYa0?= =?us-ascii?Q?4tUas5rlFLTKBWfsx5ywvHEDqlDV9occIKgqIo8U6ICOtGk1ARPCu2ex7OOF?= =?us-ascii?Q?3E10s3c9il/eoA+zVS2Bukf49qaCkwOo72B4RxrST3l/8DRAg7KsmzMxpv/2?= =?us-ascii?Q?7RPQFRIT/+RQvwKU8sWZ+4CT9TdTXMg1av6fUAj5ItswDHlZjRRsQGN/gznz?= =?us-ascii?Q?pzQnS8V70Z9ejEkIK7ZFZ+v8nMS6k0nmJa0VeOEj5zZ7P7JFJk1xfSAJ6cOa?= =?us-ascii?Q?fyAuOXrT85a8jUcLNat6UQ5XlUF3VN5lnsllSzuQ7Ckq83Fi/7ZBvpi7GViP?= =?us-ascii?Q?tnzZHBD2e/bF+0KfHl1oKv0RI5NtG5tKUe+VVhVIAKo0vwCdt8QtQY9H8O4C?= =?us-ascii?Q?2D2wKnpVuDzdgmnznawbCuK9S2x6NAZHFcCVl9wi/q849o8NTKDQKQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4482.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23612cd2-96a1-4163-73e5-08da0b490c70 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2022 14:42:39.4623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: caRQOhZJ8YnWZQ188Q9OHaomkFUBR7JFAfX6ejx9+u7pV2nFl9ohuJYFelBm5aw5uxjlyvFCYw2hrdhZ7s8sy1FsMEC8/QtD+hoPmgNglmk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2564 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > test_bpf_convert is being conditionally registered depending on the > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > test to run. >=20 > when the UT runs test_bpf_convert test-dpdk can't find the registration > and assumes the DPDK_TEST environment variable hasn't been defined > resulting in test-dpdk dropping to interactive mode and subsequently > waiting for the remainder of the UT fast-test timeout period before > reporting the test as having timed out. >=20 > * unconditionally register test_bpf_convert > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the > test is skipped similar to that done with the test_bpf test. >=20 > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BP= F") > Cc: stephen@networkplumber.org > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Tyler Retzlaff > --- > app/test/test_bpf.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c > index 805cce6..de1fa87 100644 > --- a/app/test/test_bpf.c > +++ b/app/test/test_bpf.c > @@ -3264,7 +3264,16 @@ struct bpf_test { >=20 > REGISTER_TEST_COMMAND(bpf_autotest, test_bpf); >=20 > -#ifdef RTE_HAS_LIBPCAP > +#ifndef RTE_HAS_LIBPCAP > + > +static int > +test_bpf_convert(void) > +{ > + printf("BPF not supported, skipping test\n"); One nit: the message above seems a bit misleading... Probably "LIBPCAP is not supported" or so? With that fixed: Acked-by: Konstantin Ananyev > + return TEST_SKIPPED; > +} > + > +#else > #include >=20 > static void > @@ -3462,5 +3471,6 @@ struct bpf_test { > return rc; > } >=20 > -REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert); > #endif /* RTE_HAS_LIBPCAP */ > + > +REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert); > -- > 1.8.3.1