From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F16BAA04AF; Thu, 20 Aug 2020 10:41:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8AC11BEBA; Thu, 20 Aug 2020 10:41:03 +0200 (CEST) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id 4B054AAD5 for ; Thu, 20 Aug 2020 10:41:02 +0200 (CEST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 20 Aug 2020 01:39:07 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 20 Aug 2020 01:41:01 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 20 Aug 2020 01:41:01 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 20 Aug 2020 08:40:57 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 20 Aug 2020 08:40:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S/JP8TQf0J8Xz23uXfigFenUZmzV5bso9ehLu1DjVFYCk4JP87LEjIENOYFzRqmCVfD0VlT2CEuAk8oSzxL8fF4KNO6yzcbhbuSGza9XY8TqF7CaHGHn3yirMbt2d5ptfH0oDhFJX4L1QA90SeWvAQ5X/74HltxqwTvpIFyjx9zK5X7KBxCY3H1bSK/faYikmP503WJyTRJx+n6Cta8jft43W8xMCug++yvmaj6aj4tT9R/C38AeB3vhZOlK5mfzX3SyEcWqhMVucyO+n2YK8fDLFfLjIBXJ9NEu+FFNkdiLPH3UfwEz16Id1m+zHmXQM7Jx2HHzVWkzwXFNt1yXHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CRBYcZbU19IujxUbCalQt5clSwMzW9E57O+xmyt4Xs=; b=KcItFkp7ujvTobtUcv9yC/c9lhEqZtaBRtruhRPXGpEbVWpxHl3cjSWTyx1sdt/7Xqp2C65QNYNL0+WGFFVWtEoHNpVw5X+7Ty/Ffy9dBL9yWbIZArTxsZa2GxRyiNemqm18VnJRZfzYj/di9lrfsksZmtKxx/bXgIjPQNTZ+ICztXQQmSIXaszzfP7Am7481Hz8PflKDaT8n3EVv0RkkHG1nvoxyZ1UBxyU1uAfJQ/8uc+/OTHHJa02FZ40u23MotATeCT7RIXuyX3KZfbIZSe71GYEMBdjFLWb7p9IJMTg5AO2mp/ZcH+RW0ttw+/wdsruq0JDXa7+iaXYYsRh/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BY5PR12MB3668.namprd12.prod.outlook.com (2603:10b6:a03:194::25) by BYAPR12MB2933.namprd12.prod.outlook.com (2603:10b6:a03:138::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16; Thu, 20 Aug 2020 08:40:55 +0000 Received: from BY5PR12MB3668.namprd12.prod.outlook.com ([fe80::c876:5bb9:796f:9cbe]) by BY5PR12MB3668.namprd12.prod.outlook.com ([fe80::c876:5bb9:796f:9cbe%4]) with mapi id 15.20.3305.025; Thu, 20 Aug 2020 08:40:55 +0000 From: Gregory Etelson To: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Thomas Monjalon , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , "Ori Kam" Thread-Topic: [PATCH] app/testpmd: fix flow rules list after port stop Thread-Index: AQHWbzFyXGU1EcCMmEW9rOvS2E5vSKlAuzBg Date: Thu, 20 Aug 2020 08:40:54 +0000 Message-ID: References: <20200810161523.6904-1-getelson@mellanox.com> In-Reply-To: <20200810161523.6904-1-getelson@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [176.230.227.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed70faaf-3fd3-4a69-a61b-08d844e4c0c8 x-ms-traffictypediagnostic: BYAPR12MB2933: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CcxTrpd+Wylr+uyC998A+RUQqamaNBTShWYz6Ezl1h4Vdab7M8H9PzXcp6Z4s7cjxDzCe03RqrKb+cJVCorqNSIuBhlxSwlWhsVon/Rg3rSYhLlJ9+wTYaOi1H4CAqZ2E7aFOEVT7y554+KUK1ygLd2KvL5DsCRti3qz7OfXMtu1lPDybYlLH+La//Tn4WoIszAkyjK3VSIwyD6v07iIEK58TlXAvZP2z32f70WYXF53t+3Z0lbqhYNwRhlsxeJAmlpby7gj/+SnT91EOXJcAopFRpIMC5HOvc1KkswsjZtFSejuLOV0J1VQ5rJd+JcSoB8JExC6ft7Kicq0fDK5bQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB3668.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(4326008)(83380400001)(33656002)(71200400001)(110136005)(2906002)(316002)(86362001)(8936002)(8676002)(107886003)(76116006)(64756008)(66556008)(66476007)(53546011)(6506007)(66446008)(9686003)(54906003)(55016002)(66946007)(186003)(52536014)(478600001)(7696005)(5660300002)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 5IRgAvMo9NwKrLxpQisstq4v8flT8hgT8DG9krwl1Lmd2t/4mxdI0GIxfECFUuFzcVxAC09vrAlPL4GIrqiLlMJXDyy7FusRXnJuXhLDOmg7Ok6shZHLJeUxZokCr144ZDRvIplcme4J3rCaND1j49GEmwe/7Ox0/N+B7w15phnnTw0doMVXumqsU3AcvqMCeJyOQ2VOgQ/W+AGACQm1MDIAMCasaM6QQFdqtLZ9fCXl3QlGN27hqnUNgHNKWURMnI1BN1J6VXQ9QGIBpH66lrfwgiwwPAa/pRCqkKPbvXEfJitGx8y/g1XzoyTuVSVrB5XsZtfljZavBjFgvz+I3i2DqrpJxN5nsvWyTiasF+1jJ1yQB4SUK9tn9p6EHlfuAPlgUczuPFj/4y7FA0/PNz2ysrYXrY7XZNx3aBIECxiqTQtvnvhYS4976JEdHx9nsy+2uw66tYYRUDZdbC+IdNLIf/nnTiZC170wR0qs94D+LOewMKSjFPqNHGQ5RsPGOPjZmpc8beSspPVlpd1lSGK8pCku/4ttOFs+f2g39zCmeY3ipcWrtF7wCAsGwrYUufHvtzgrIL3Yd87Sj4ox9/r4y4FLEuP1SmT/J4rlBN2dm2icqeBixriYE5mGUolFgWIJVif1MezdHcpPXVVj+Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3668.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed70faaf-3fd3-4a69-a61b-08d844e4c0c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2020 08:40:54.8283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akcia3hcMWmh6YcGMyWXq90Xd7je+JKVzpoaZBIxg4lfq0NcHdMLPJuSZpipKqNWdtCEIUrMbFNU4YIevi1j/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2933 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1597912747; bh=5CRBYcZbU19IujxUbCalQt5clSwMzW9E57O+xmyt4Xs=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=hbR38BzmzLaHDU4SYbeKEt5aT1FjcIuaJZ3wkSZ0dqlG0MtY+Y7sJzCP3nueEJ1VC F/W4p3WCpzUv+WZu+wU2VK1hc4dOQUKEI2/fAm3s6tc71mJ4xD3uZUoYWRwN2J4sXK /zrbwGgzbjOo6NUn7Vi7/wviW4lYawEKnq00i4FOWlldDPlv+cZ1fw66frhvOgq1H6 hsAYcxSvR698i1YfzZgedyG0V6pSt+2SAJKS5FzlsN7++5XM6vCAfeDddYpLnMWf3A HbywoWx4sXfwHCBg4EEEuvVLLdWP+c84Ol1OTWrA/NidOQ+hHl8IwAnyRDrspfmOkT irHNoSnAq+57Q== Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, Is this patch scheduled for merge with dpdk.org ? Please update me. Regards, Gregory > -----Original Message----- > From: Gregory Etelson > Sent: Monday, August 10, 2020 19:15 > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > stable@dpdk.org; Ori Kam ; Wenzhuo Lu > ; Beilei Xing ; Bernard > Iremonger > Subject: [PATCH] app/testpmd: fix flow rules list after port stop >=20 > According to current RTE API, port flow rules must not be kept after port > stop. >=20 > Testpmd did not flush port flow rules after `port stop' command was calle= d. > As the result, after the port was restarted, it showed bogus flow rules. >=20 > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 7842c3b781..4ba5c41c6e 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2627,6 +2627,9 @@ stop_port(portid_t pid) > RTE_PORT_HANDLING) =3D=3D 0) > continue; >=20 > + if (port->flow_list) > + port_flow_flush(pi); > + > rte_eth_dev_stop(pi); >=20 > if (rte_atomic16_cmpset(&(port->port_status), > -- > 2.25.1