* [dpdk-dev] [PATCH] config/x86: add support for AMD platform @ 2021-11-02 14:52 Aman Kumar 2021-11-02 15:18 ` Thomas Monjalon 2021-11-02 18:45 ` David Marchand 0 siblings, 2 replies; 10+ messages in thread From: Aman Kumar @ 2021-11-02 14:52 UTC (permalink / raw) To: dev; +Cc: thomas, keesang.song, aman.kumar -Dcpu_instruction_set=znverX meson option can be used to build dpdk for AMD platforms. Supported options are znver1, znver2 and znver3. Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> --- config/x86/meson.build | 9 +++++++++ doc/guides/linux_gsg/build_dpdk.rst | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 29f3dea181..21cda6fd33 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -72,3 +72,12 @@ endif dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) dpdk_conf.set('RTE_MAX_LCORE', 128) dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) + +# AMD platform support +if get_option('cpu_instruction_set') == 'znver1' + dpdk_conf.set('RTE_MAX_LCORE', 256) +elif get_option('cpu_instruction_set') == 'znver2' + dpdk_conf.set('RTE_MAX_LCORE', 512) +elif get_option('cpu_instruction_set') == 'znver3' + dpdk_conf.set('RTE_MAX_LCORE', 512) +endif diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst index 0b08492ca2..e224a06cbd 100644 --- a/doc/guides/linux_gsg/build_dpdk.rst +++ b/doc/guides/linux_gsg/build_dpdk.rst @@ -111,7 +111,7 @@ The instruction set will be set automatically by default according to these rule a common minimal baseline needed for DPDK. To override what instruction set will be used, set the ``cpu_instruction_set`` -parameter to the instruction set of your choice (such as ``corei7``, ``power8``, etc.). +parameter to the instruction set of your choice (such as ``corei7``, ``power8``, ``znver3``, etc.). ``cpu_instruction_set`` is not used in Arm builds, as setting the instruction set without other parameters leads to inferior builds. The way to tailor Arm builds -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-02 14:52 [dpdk-dev] [PATCH] config/x86: add support for AMD platform Aman Kumar @ 2021-11-02 15:18 ` Thomas Monjalon 2021-11-02 15:56 ` Song, Keesang 2021-11-02 18:45 ` David Marchand 1 sibling, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2021-11-02 15:18 UTC (permalink / raw) To: Aman Kumar; +Cc: dev, keesang.song, david.marchand 02/11/2021 15:52, Aman Kumar: > -Dcpu_instruction_set=znverX meson option can be used > to build dpdk for AMD platforms. Supported options are > znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > --- > +# AMD platform support > +if get_option('cpu_instruction_set') == 'znver1' > + dpdk_conf.set('RTE_MAX_LCORE', 256) > +elif get_option('cpu_instruction_set') == 'znver2' > + dpdk_conf.set('RTE_MAX_LCORE', 512) > +elif get_option('cpu_instruction_set') == 'znver3' > + dpdk_conf.set('RTE_MAX_LCORE', 512) > +endif Ideally we should try getting rid of this config and make all structs depending on max lcores allocated dynamically. I think it may be an interesting target for next year 22.11 release. About the patch itself, I am OK to merge it in 21.11-rc2. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-02 15:18 ` Thomas Monjalon @ 2021-11-02 15:56 ` Song, Keesang 0 siblings, 0 replies; 10+ messages in thread From: Song, Keesang @ 2021-11-02 15:56 UTC (permalink / raw) To: Thomas Monjalon, Aman Kumar; +Cc: dev, david.marchand [AMD Official Use Only] It would be great to make max lcores dynamically allocated. Thanks so much Thomas for your confirmation that this is to be merge in 21.11-rc2. Best, Keesang -----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Tuesday, November 2, 2021 8:19 AM To: Aman Kumar <aman.kumar@vvdntech.in> Cc: dev@dpdk.org; Song, Keesang <Keesang.Song@amd.com>; david.marchand@redhat.com Subject: Re: [PATCH] config/x86: add support for AMD platform [CAUTION: External Email] 02/11/2021 15:52, Aman Kumar: > -Dcpu_instruction_set=znverX meson option can be used to build dpdk > for AMD platforms. Supported options are znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > --- > +# AMD platform support > +if get_option('cpu_instruction_set') == 'znver1' > + dpdk_conf.set('RTE_MAX_LCORE', 256) elif > +get_option('cpu_instruction_set') == 'znver2' > + dpdk_conf.set('RTE_MAX_LCORE', 512) elif > +get_option('cpu_instruction_set') == 'znver3' > + dpdk_conf.set('RTE_MAX_LCORE', 512) endif Ideally we should try getting rid of this config and make all structs depending on max lcores allocated dynamically. I think it may be an interesting target for next year 22.11 release. About the patch itself, I am OK to merge it in 21.11-rc2. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-02 14:52 [dpdk-dev] [PATCH] config/x86: add support for AMD platform Aman Kumar 2021-11-02 15:18 ` Thomas Monjalon @ 2021-11-02 18:45 ` David Marchand 2021-11-02 19:04 ` Thomas Monjalon 1 sibling, 1 reply; 10+ messages in thread From: David Marchand @ 2021-11-02 18:45 UTC (permalink / raw) To: Aman Kumar; +Cc: dev, Thomas Monjalon, Song, Keesang On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > -Dcpu_instruction_set=znverX meson option can be used > to build dpdk for AMD platforms. Supported options are > znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > --- > config/x86/meson.build | 9 +++++++++ > doc/guides/linux_gsg/build_dpdk.rst | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/config/x86/meson.build b/config/x86/meson.build > index 29f3dea181..21cda6fd33 100644 > --- a/config/x86/meson.build > +++ b/config/x86/meson.build > @@ -72,3 +72,12 @@ endif > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > dpdk_conf.set('RTE_MAX_LCORE', 128) > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > + > +# AMD platform support > +if get_option('cpu_instruction_set') == 'znver1' > + dpdk_conf.set('RTE_MAX_LCORE', 256) > +elif get_option('cpu_instruction_set') == 'znver2' > + dpdk_conf.set('RTE_MAX_LCORE', 512) > +elif get_option('cpu_instruction_set') == 'znver3' > + dpdk_conf.set('RTE_MAX_LCORE', 512) > +endif I already replied to a similar patch earlier in this release. https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ So repeating the same: do you actually _need_ more than 128 lcores in a single DPDK application? -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-02 18:45 ` David Marchand @ 2021-11-02 19:04 ` Thomas Monjalon 2021-11-18 12:25 ` Thomas Monjalon 0 siblings, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2021-11-02 19:04 UTC (permalink / raw) To: Aman Kumar, David Marchand, Song, Keesang; +Cc: dev 02/11/2021 19:45, David Marchand: > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > -Dcpu_instruction_set=znverX meson option can be used > > to build dpdk for AMD platforms. Supported options are > > znver1, znver2 and znver3. > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > --- > > config/x86/meson.build | 9 +++++++++ > > doc/guides/linux_gsg/build_dpdk.rst | 2 +- > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/config/x86/meson.build b/config/x86/meson.build > > index 29f3dea181..21cda6fd33 100644 > > --- a/config/x86/meson.build > > +++ b/config/x86/meson.build > > @@ -72,3 +72,12 @@ endif > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > + > > +# AMD platform support > > +if get_option('cpu_instruction_set') == 'znver1' > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > +elif get_option('cpu_instruction_set') == 'znver2' > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > +elif get_option('cpu_instruction_set') == 'znver3' > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > +endif > > I already replied to a similar patch earlier in this release. > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > So repeating the same: do you actually _need_ more than 128 lcores in > a single DPDK application? Yes I forgot this previous discussion concluding that we should not increase more than 128 threads. The --lcores syntax and David's work on rte_thread_register should unblock most of use cases. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-02 19:04 ` Thomas Monjalon @ 2021-11-18 12:25 ` Thomas Monjalon 2021-11-18 13:52 ` Bruce Richardson 0 siblings, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2021-11-18 12:25 UTC (permalink / raw) To: Aman Kumar, David Marchand, Song, Keesang, techboard; +Cc: dev I request a techboard decision for this patch. 02/11/2021 20:04, Thomas Monjalon: > 02/11/2021 19:45, David Marchand: > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > > > -Dcpu_instruction_set=znverX meson option can be used > > > to build dpdk for AMD platforms. Supported options are > > > znver1, znver2 and znver3. > > > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > > --- > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > + > > > +# AMD platform support > > > +if get_option('cpu_instruction_set') == 'znver1' > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > > +elif get_option('cpu_instruction_set') == 'znver2' > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > +elif get_option('cpu_instruction_set') == 'znver3' > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > +endif > > > > I already replied to a similar patch earlier in this release. > > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > > > So repeating the same: do you actually _need_ more than 128 lcores in > > a single DPDK application? We did not receive an answer to this question. > Yes I forgot this previous discussion concluding that we should not increase > more than 128 threads. We had a discussion yesterday in techboard meeting. The consensus is that we didn't hear for real need of more than 128 threads, except for configuration usability convenience. Now looking again at the code, this is how it is defined: option('max_lcores', type: 'string', value: 'default', description: 'Set maximum number of cores/threads supported by EAL; "default" is different per-arch, "detect" detects the number of cores on the build machine.') config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) config/arm/meson.build: it goes from 4 to 1280! So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. Techboard, let's have a quick decision please for 21.11-rc4. > The --lcores syntax and David's work on rte_thread_register should unblock > most of use cases. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-18 12:25 ` Thomas Monjalon @ 2021-11-18 13:52 ` Bruce Richardson 2021-11-18 14:05 ` Thomas Monjalon 0 siblings, 1 reply; 10+ messages in thread From: Bruce Richardson @ 2021-11-18 13:52 UTC (permalink / raw) To: Thomas Monjalon; +Cc: Aman Kumar, David Marchand, Song, Keesang, techboard, dev On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > I request a techboard decision for this patch. > > > 02/11/2021 20:04, Thomas Monjalon: > > 02/11/2021 19:45, David Marchand: > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > > > > > -Dcpu_instruction_set=znverX meson option can be used > > > > to build dpdk for AMD platforms. Supported options are > > > > znver1, znver2 and znver3. > > > > > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > > > --- > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > + > > > > +# AMD platform support > > > > +if get_option('cpu_instruction_set') == 'znver1' > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > > > +elif get_option('cpu_instruction_set') == 'znver2' > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > +elif get_option('cpu_instruction_set') == 'znver3' > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > +endif > > > > > > I already replied to a similar patch earlier in this release. > > > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > > > > > So repeating the same: do you actually _need_ more than 128 lcores in > > > a single DPDK application? > > We did not receive an answer to this question. > > > Yes I forgot this previous discussion concluding that we should not increase > > more than 128 threads. > > We had a discussion yesterday in techboard meeting. > The consensus is that we didn't hear for real need of more than 128 threads, > except for configuration usability convenience. > > Now looking again at the code, this is how it is defined: > > option('max_lcores', type: 'string', value: 'default', description: > 'Set maximum number of cores/threads supported by EAL; > "default" is different per-arch, "detect" detects the number of cores on the build machine.') > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > config/arm/meson.build: it goes from 4 to 1280! > > So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. > Techboard, let's have a quick decision please for 21.11-rc4. > I would support increasing the default value for x86 in this release. I believe Dave H. had some patches to decrease the memory footprint overhead of such a change. I don't believe that they were merged, and while it's a bit late for 21.11 now, those should be considered for 22.03 release and then maybe for backport. /Bruce ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-18 13:52 ` Bruce Richardson @ 2021-11-18 14:05 ` Thomas Monjalon 2021-11-24 12:36 ` Thomas Monjalon 0 siblings, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2021-11-18 14:05 UTC (permalink / raw) To: Bruce Richardson Cc: Aman Kumar, David Marchand, Song, Keesang, techboard, dev 18/11/2021 14:52, Bruce Richardson: > On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > > I request a techboard decision for this patch. > > > > > > 02/11/2021 20:04, Thomas Monjalon: > > > 02/11/2021 19:45, David Marchand: > > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > > > > > > > -Dcpu_instruction_set=znverX meson option can be used > > > > > to build dpdk for AMD platforms. Supported options are > > > > > znver1, znver2 and znver3. > > > > > > > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > > > > --- > > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > > + > > > > > +# AMD platform support > > > > > +if get_option('cpu_instruction_set') == 'znver1' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > > > > +elif get_option('cpu_instruction_set') == 'znver2' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > +elif get_option('cpu_instruction_set') == 'znver3' > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > +endif > > > > > > > > I already replied to a similar patch earlier in this release. > > > > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > > > > > > > So repeating the same: do you actually _need_ more than 128 lcores in > > > > a single DPDK application? > > > > We did not receive an answer to this question. > > > > > Yes I forgot this previous discussion concluding that we should not increase > > > more than 128 threads. > > > > We had a discussion yesterday in techboard meeting. > > The consensus is that we didn't hear for real need of more than 128 threads, > > except for configuration usability convenience. > > > > Now looking again at the code, this is how it is defined: > > > > option('max_lcores', type: 'string', value: 'default', description: > > 'Set maximum number of cores/threads supported by EAL; > > "default" is different per-arch, "detect" detects the number of cores on the build machine.') > > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > config/arm/meson.build: it goes from 4 to 1280! > > > > So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. > > Techboard, let's have a quick decision please for 21.11-rc4. > > > I would support increasing the default value for x86 in this release. This patch is not increasing the default for all x86, only for some CPUs as given at compilation time. I think it is the same logic as Arm CPU-specific compilation. > I believe Dave H. had some patches to decrease the memory footprint > overhead of such a change. I don't believe that they were merged, and while > it's a bit late for 21.11 now, those should be considered for 22.03 release > and then maybe for backport. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-18 14:05 ` Thomas Monjalon @ 2021-11-24 12:36 ` Thomas Monjalon 2021-12-17 20:12 ` Song, Keesang 0 siblings, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2021-11-24 12:36 UTC (permalink / raw) To: techboard Cc: Bruce Richardson, Aman Kumar, David Marchand, Song, Keesang, dev Ping techboard for comments 18/11/2021 15:05, Thomas Monjalon: > 18/11/2021 14:52, Bruce Richardson: > > On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > > > I request a techboard decision for this patch. > > > > > > > > > 02/11/2021 20:04, Thomas Monjalon: > > > > 02/11/2021 19:45, David Marchand: > > > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > > > > > > > > > -Dcpu_instruction_set=znverX meson option can be used > > > > > > to build dpdk for AMD platforms. Supported options are > > > > > > znver1, znver2 and znver3. > > > > > > > > > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > > > > > --- > > > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > > > + > > > > > > +# AMD platform support > > > > > > +if get_option('cpu_instruction_set') == 'znver1' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) > > > > > > +elif get_option('cpu_instruction_set') == 'znver2' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > > +elif get_option('cpu_instruction_set') == 'znver3' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) > > > > > > +endif > > > > > > > > > > I already replied to a similar patch earlier in this release. > > > > > https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/ > > > > > > > > > > So repeating the same: do you actually _need_ more than 128 lcores in > > > > > a single DPDK application? > > > > > > We did not receive an answer to this question. > > > > > > > Yes I forgot this previous discussion concluding that we should not increase > > > > more than 128 threads. > > > > > > We had a discussion yesterday in techboard meeting. > > > The consensus is that we didn't hear for real need of more than 128 threads, > > > except for configuration usability convenience. > > > > > > Now looking again at the code, this is how it is defined: > > > > > > option('max_lcores', type: 'string', value: 'default', description: > > > 'Set maximum number of cores/threads supported by EAL; > > > "default" is different per-arch, "detect" detects the number of cores on the build machine.') > > > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/arm/meson.build: it goes from 4 to 1280! > > > > > > So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. > > > Techboard, let's have a quick decision please for 21.11-rc4. > > > > > I would support increasing the default value for x86 in this release. > > This patch is not increasing the default for all x86, > only for some CPUs as given at compilation time. > I think it is the same logic as Arm CPU-specific compilation. > > > I believe Dave H. had some patches to decrease the memory footprint > > overhead of such a change. I don't believe that they were merged, and while > > it's a bit late for 21.11 now, those should be considered for 22.03 release > > and then maybe for backport. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [dpdk-dev] [PATCH] config/x86: add support for AMD platform 2021-11-24 12:36 ` Thomas Monjalon @ 2021-12-17 20:12 ` Song, Keesang 0 siblings, 0 replies; 10+ messages in thread From: Song, Keesang @ 2021-12-17 20:12 UTC (permalink / raw) To: Thomas Monjalon, techboard Cc: Bruce Richardson, Aman Kumar, David Marchand, dev [AMD Official Use Only] I don't see any update since Thomas's. Do we have this patch taken care of submitting to 22.03 and backporting it? -----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Wednesday, November 24, 2021 4:37 AM To: techboard@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>; Aman Kumar <aman.kumar@vvdntech.in>; David Marchand <david.marchand@redhat.com>; Song, Keesang <Keesang.Song@amd.com>; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform [CAUTION: External Email] Ping techboard for comments 18/11/2021 15:05, Thomas Monjalon: > 18/11/2021 14:52, Bruce Richardson: > > On Thu, Nov 18, 2021 at 01:25:38PM +0100, Thomas Monjalon wrote: > > > I request a techboard decision for this patch. > > > > > > > > > 02/11/2021 20:04, Thomas Monjalon: > > > > 02/11/2021 19:45, David Marchand: > > > > > On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote: > > > > > > > > > > > > -Dcpu_instruction_set=znverX meson option can be used to > > > > > > build dpdk for AMD platforms. Supported options are znver1, > > > > > > znver2 and znver3. > > > > > > > > > > > > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in> > > > > > > --- > > > > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > > > > > > dpdk_conf.set('RTE_MAX_LCORE', 128) > > > > > > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > > > > > > + > > > > > > +# AMD platform support > > > > > > +if get_option('cpu_instruction_set') == 'znver1' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 256) elif > > > > > > +get_option('cpu_instruction_set') == 'znver2' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) elif > > > > > > +get_option('cpu_instruction_set') == 'znver3' > > > > > > + dpdk_conf.set('RTE_MAX_LCORE', 512) endif > > > > > > > > > > I already replied to a similar patch earlier in this release. > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2 > > > > > F%2Finbox.dpdk.org%2Fdev%2FCAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqC > > > > > ua6UdMXXHgrcmT6g%40mail.gmail.com%2F&data=04%7C01%7Ckeesan > > > > > g.song%40amd.com%7C621ed6a39c304c905dbb08d9af4717c5%7C3dd8961f > > > > > e4884e608e11a82d994e183d%7C0%7C0%7C637733542157359380%7CUnknow > > > > > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > > > > > 1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=L9IM4ZtukVwY5qdbGgkt2zlu > > > > > sGm0ZmrQmE9oMeg1RDo%3D&reserved=0 > > > > > > > > > > So repeating the same: do you actually _need_ more than 128 > > > > > lcores in a single DPDK application? > > > > > > We did not receive an answer to this question. > > > > > > > Yes I forgot this previous discussion concluding that we should > > > > not increase more than 128 threads. > > > > > > We had a discussion yesterday in techboard meeting. > > > The consensus is that we didn't hear for real need of more than > > > 128 threads, except for configuration usability convenience. > > > > > > Now looking again at the code, this is how it is defined: > > > > > > option('max_lcores', type: 'string', value: 'default', description: > > > 'Set maximum number of cores/threads supported by EAL; > > > "default" is different per-arch, "detect" detects the > > > number of cores on the build machine.') > > > config/x86/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/ppc/meson.build: dpdk_conf.set('RTE_MAX_LCORE', 128) > > > config/arm/meson.build: it goes from 4 to 1280! > > > > > > So I feel it is not fair to reject this AMD patch if we allow Arm to go beyond. > > > Techboard, let's have a quick decision please for 21.11-rc4. > > > > > I would support increasing the default value for x86 in this release. > > This patch is not increasing the default for all x86, only for some > CPUs as given at compilation time. > I think it is the same logic as Arm CPU-specific compilation. > > > I believe Dave H. had some patches to decrease the memory footprint > > overhead of such a change. I don't believe that they were merged, > > and while it's a bit late for 21.11 now, those should be considered > > for 22.03 release and then maybe for backport. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-12-21 9:05 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-11-02 14:52 [dpdk-dev] [PATCH] config/x86: add support for AMD platform Aman Kumar 2021-11-02 15:18 ` Thomas Monjalon 2021-11-02 15:56 ` Song, Keesang 2021-11-02 18:45 ` David Marchand 2021-11-02 19:04 ` Thomas Monjalon 2021-11-18 12:25 ` Thomas Monjalon 2021-11-18 13:52 ` Bruce Richardson 2021-11-18 14:05 ` Thomas Monjalon 2021-11-24 12:36 ` Thomas Monjalon 2021-12-17 20:12 ` Song, Keesang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).