From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8054A0032; Thu, 2 Dec 2021 10:35:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42C5140692; Thu, 2 Dec 2021 10:35:59 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2067.outbound.protection.outlook.com [40.107.223.67]) by mails.dpdk.org (Postfix) with ESMTP id 3EDA84067B for ; Thu, 2 Dec 2021 10:35:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n84hA38wtCXEashXqueQs397d6DEC2sP5feS1/vkAMBxERJq3NLakngQG6tOL8n9CrQvJN/fLCpp1vzrsC24D+xtYzLjznIqYVY5AyrHZOR+rFnPd2SsbEfW9x3UAyVezl9+4+HqKraKvG91tLYyu+7NlL7T1LWJ3OSu8UT/axP0r2TiFfea9HBhMFathseaaZsueROMRDELEDJH8SrE0BUCh/yLklhY2e9LMKQuQmEiXc5WIMEfo82yTzAGr+ZwoCbVcnUqfAGj3SFhgK55f65cGADAS9FiINoIcn6/Aa6FVpPsF3agv+hMh2o/hizQkxLnRIjCKPLqCJbXcvczNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0ohYPsU4C1bIdNGmY0cUrNJXPP1dLxEy8bEWOHCab0=; b=Ol5s32JRG9/+6+lzHvVP5CQrjyGgpZ4uNQncnp4EqpO0AMx87Wr0gvzunH3H86BdAoKuc4etxkLC6hrluFtFB5oxYWThRYKQ48Xp7geokbKGGuHCT8aZM42V+oovaCqLz61kn0qaY9W826Yt0dhodfIsCJJ9MukbW0h0Y5kWjryjwqz4Pyeivf+HTDyAeDHhVp5rf1vnAHZNJQ+uDp3co8IT48rCbeNDk7f+/hvX4r4PvQVtEKSzq1VjDINd6wlnu1qvoNOcJ9QmOrQHvi+T6DDwdaulWrUC3S970SvBzqt2YzOzyevO451fipiHOGafiMDvVEVOmbAXfxoP1hTNog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0ohYPsU4C1bIdNGmY0cUrNJXPP1dLxEy8bEWOHCab0=; b=XKhI21BK7npLOdn6cQEitFNxzkl46jJzUL9+6P58caU55jynvxtLmKJKr3S1zQU7X/nhtNKiY4eRnYsVEDqyOQUxX0NJdUVBzn9H4p80CScySJ38BVS09KlaEqX1+oALcfBRF8bOcs5Z9gXHMbE6q5vB9elt+RCugUDUobcNx4t2TizeTistXvq/uBFomQqAaWQR0suiZkogH6/zpecR4KR4PDGltk5DYckmDC43u4vYQvO8td8c2M5Tv06TtC4iNUyKxrEQUg4Pf4Nu7Vo8RrbCkuOYC+EgTCwWl0zU9wIgJmpKdvvLFinqeRcCxY1aITTQ0rpW5kqylEmHxBJJNQ== Received: from BY5PR12MB4227.namprd12.prod.outlook.com (2603:10b6:a03:206::21) by BY5PR12MB3987.namprd12.prod.outlook.com (2603:10b6:a03:1a8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec 2021 09:35:55 +0000 Received: from BY5PR12MB4227.namprd12.prod.outlook.com ([fe80::c131:667d:a776:dd47]) by BY5PR12MB4227.namprd12.prod.outlook.com ([fe80::c131:667d:a776:dd47%4]) with mapi id 15.20.4755.016; Thu, 2 Dec 2021 09:35:55 +0000 From: Dariusz Sosnowski To: Huichao Cai CC: "konstantin.ananyev@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data Thread-Topic: [PATCH] ip_frag: add IPv4 options fragment and unit test data Thread-Index: AdfnXqudrD156mwhQv+slaBjlANOxA== Date: Thu, 2 Dec 2021 09:35:54 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87ac296a-8a9f-46bf-5154-08d9b577237e x-ms-traffictypediagnostic: BY5PR12MB3987: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f/uj1HJg3qdkw+ZQmcA+5ISfEay3v1olMTFmpVsdNvs04DCbkbUGuzIUjD13kg01TLw7Yss3xrUyUvw/BFP55yoFwonZ906fhmGZmIW2gO7D4asJL0MSsfXhVha8vt+p3kyJMlbEzJI8bzgSAdjv68g7s84CH8xYznoquFzkUOq98FjjvghxPXEnGIWK29iMRoH68a1N69rJ2uzFEV9g2OgrKlY9vXO7HilBe8xdKvPB7z2xWw16nA2ox9LLMKAFKW+OrQWeuhAmu2CtcYJyZ4SVhRJ/OMQ+cw4eSLt7OIAiASwiaYZyrxcaux6Bm7WIVmmEy8/9CIOj+KaB8bZTdNWIWZOCNbZMa0s0VwEjn9CDGhZPCHCm//3L1c7IRy7zx3HciwRB4y+2Qvavg626f51oOCb9ODa/siZwlMR6QVMq3j+z3wCWGuoq2/GhH0uMOVzC8BwmphKEY3lnEWK+Ysu5M07OlDGBsOHEWItivemHe3R1P7uY4eI19kK9NvviUTVMJ3P+rsZNWuORN0jmFncoH48nAXS9vtMyl7RSgMn20Z3f078yiUe/3pqICyk4QE6G7RtOfIHWSyocF8Y9HkZR5qKzFlbw9QjtT8NztK/qEPMjfkdmPTimhpjoxEIGGyNBYY8mMOn71rvdlbcvuXSJV+GlCmFJwB7aK9JivvRCPfv4MsheAl+RlOKyP8/muFnqByvzxprGOFu3wVuzwQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4227.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(76116006)(7696005)(38070700005)(2906002)(55236004)(33656002)(64756008)(66556008)(66476007)(71200400001)(66946007)(6506007)(66446008)(38100700002)(122000001)(4326008)(186003)(55016003)(86362001)(4744005)(52536014)(6916009)(5660300002)(8676002)(54906003)(316002)(508600001)(8936002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?wAKLYPGT1hJCslM5rtDP/lxMWZ1wd8BK2pGMGqrGOlA+5YZHKxfheO052s?= =?iso-8859-1?Q?lEgy45avxF5qbDOTXYwkfgrlrAVfpBAz1HxOXOOCZgDTUuJVrb3j/bDNul?= =?iso-8859-1?Q?9rJVZevnzB8JYBNCssUVIRKK+LBbPFuAC6tIN0YsxselvkZ9QJj1504aR+?= =?iso-8859-1?Q?hYkZKvp7l1Z1jlAm+MzC8U4R15tmDqxz8D5ZTpPy3VvNvgvUEZQO6OVqFS?= =?iso-8859-1?Q?5ul/e+wO11o8AD3F07YBnhkr4srdmZTujh3O5Vly27E6om27omBnDzCVr4?= =?iso-8859-1?Q?6LVwjbzJ+ajUWtWnwk/0OoQWS8Uuo9sRv+p9ug5sSpkbJqZzFJguRwMojv?= =?iso-8859-1?Q?1NQpoeEgDjeagxOBtMQlIkQFgtZZE+OoBv19DtwOmA5eHTzqsSFBt4GNR4?= =?iso-8859-1?Q?pIDJg8Z4i2TsJeneJSSF2JOgt0Pj/Cxa28jYZ4dwwnVi/KvMvRhCE3S/Id?= =?iso-8859-1?Q?oeDjHZDvWxiYHiniMpVgN7IKzFRFoDkhZXHs4QqANPGx7xLzUQ0iF3UmxB?= =?iso-8859-1?Q?xZaPuqRrFbj2q4o6NZ+36iQkFhokD34lXPdSy6L61jtun/42qxr+lZSslY?= =?iso-8859-1?Q?4Ddf5iJQP4EbXSLKKsEdNpkk9vThHHb6cDaQ+zPQS4eeh68GGQU5rWjGXw?= =?iso-8859-1?Q?oEdMcIz/t7gGQkeaiuMMdkhqxtIsTFgut81bmh6KggWojOQBcUllQd5Vk1?= =?iso-8859-1?Q?Trsdx0TPFH4rNf8IPcmlWYxUmc/ez8vmR7VbjDvIDgkNbUHHEoMd2hZafa?= =?iso-8859-1?Q?cXE3kWlXad86jmMcLEahu2t4miJNeX3yTskQNzTmcvtqqhk0YQCb1NP4Wu?= =?iso-8859-1?Q?9DToFHuTwXi6WoHqxL7QsW5egmaPE62+RBpUD0rmneDCnexEnTyGFKCmBH?= =?iso-8859-1?Q?cMxS2Ja47yz3M8dzIGz4t1Icg8YSaUz+sydTspW4pPKmxjXc1HVefiNJmV?= =?iso-8859-1?Q?O76nAzO70963wklGzN7QHaGvNYLlVEA4GC8TkKf9bVKV7NEiCytlo2oF+6?= =?iso-8859-1?Q?5JMMiPVe4FhTYB24jC0OjdiLoVR72J4N8bI8EGwoRjLgwkLYg0ZZaih8VO?= =?iso-8859-1?Q?j2FTTQwjBxxP8mhvItJp7NbrvfB1A36pOluq6eo5ZKPVl+oiSKvZGGnira?= =?iso-8859-1?Q?wUqNBODT+Q/M2eI6WvNOCrKWVtmQSg9oDzBzW7zmZf9JFzko8FFcF3hOBa?= =?iso-8859-1?Q?ZRFdY+JUXgLk1jiOEJMjNAAkAZd3vL6kfTgrKCJmutens/xCQFQl19SEpY?= =?iso-8859-1?Q?xfcGXqgqpsgVQIMB1rIGSZwiM3irnD6fHXuh6iMenGCmqwvsY/Svs/T65u?= =?iso-8859-1?Q?MmPsqfIPvFLoYxKwe4r6Ot6Km9/d5PRyhESAdvrwlql7vLMCrfxQc7379b?= =?iso-8859-1?Q?ollcBsoDEqY5NX0wbBfUZsNOaaAlarwNqXYthfwpLUnxm6DuF4kYiV2NEG?= =?iso-8859-1?Q?m9ZNW5rLyjNlH9a/olH1YKklKQd4ZCwO5CFk8Ta9TLQ3qF+tVLA/ojlJzo?= =?iso-8859-1?Q?cvHm/FdnK3cgpDTHjhzGH20zqS6KnOD67ZtA8yieuvPBmco2nb6M3Xg0lO?= =?iso-8859-1?Q?nTRoEspaCN+EnFurtpYlYKyW3kwEI/U9Fvc6ziL5i36CkZPvOAhrYO0TPj?= =?iso-8859-1?Q?nO7/s/twbo/DrUbhw0DsOtAQk4cAsG5BAIoE/77P/xvJ03otxovXnee4H/?= =?iso-8859-1?Q?xXyqrcFusiyRTDbN+h8=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4227.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87ac296a-8a9f-46bf-5154-08d9b577237e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 09:35:54.9915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Pdf2/6is08h5k4Or9af3QtoSujDWE/wMbmtFm0glhlSSNRzvT8EdA+H3b9OkSrRinmVqOnV03C0QF+xfDi0kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3987 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote: > > Substituting options with NOOP might cause rte_ipv4_fragment_packet to = produce more fragments than necessary, since options with copied flag unset= will still occupy space in IPv4 header. > --The "ip_options_fragment" just make a replacement and doesn't change th= e length of the IPv4 header.So I don't quite understand why it leads to pro= duce more fragments. If options with copied flag unset are not copied, then IPv4 headers in the = fragments (despite 1st fragment) will be shorter. This leaves more byte spa= ce for the payload and in effect fragmentation might produce less fragments= . Best regards, Dariusz Sosnowski =A0