From: Pier Damouny <pdamouny@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v4 0/2] Fix testpmd interrupt regression
Date: Thu, 16 Mar 2023 08:16:23 +0000 [thread overview]
Message-ID: <BY5PR12MB43237164A72247C39D97CFB3BDBC9@BY5PR12MB4323.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230315173132.4044-1-stephen@networkplumber.org>
> External email: Use caution opening links or attachments
>
>
> Resolve issues from using control-C in testpmd.
> Fixes regression from recent change to use cmdline_poll().
>
> v4 - drop sig_atomic_t. Not required requires changes on
> some platforms.
>
> Stephen Hemminger (2):
> testpmd: go back to using cmdline_interact
> testpmd: enable interrupt in interactive mode
>
> app/test-pmd/cmdline.c | 27 ++++++++++++++-------------
> app/test-pmd/testpmd.c | 11 +++++++++++
> lib/cmdline/cmdline.h | 10 ++++++++++
> lib/cmdline/cmdline_os_unix.c | 8 +++++++-
> lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++--
> lib/cmdline/cmdline_private.h | 2 +-
> lib/cmdline/version.map | 3 +++
> 7 files changed, 62 insertions(+), 17 deletions(-)
>
> --
> 2.39.2
Confirming that this patch fixes Bug: 1180 over Windows.
And CTRL-C works as expected.
Tested-by: Pier Damouny <pdamouny@nvidia.com>
next prev parent reply other threads:[~2023-03-16 8:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 17:19 [RFT] test-pmd: go back to using cmdline_interact Stephen Hemminger
2023-03-13 21:38 ` [RFT v2] " Stephen Hemminger
2023-03-14 7:06 ` Ling, WeiX
[not found] ` <MW4PR12MB56684FA660218F925D64BE09A4BE9@MW4PR12MB5668.namprd12.prod.outlook.com>
2023-03-14 12:07 ` Pier Damouny
2023-03-14 17:36 ` [PATCH v3 0/3] testpmd control C fixes Stephen Hemminger
2023-03-14 17:36 ` [PATCH v3 1/3] testpmd: go back to using cmdline_interact Stephen Hemminger
2023-03-14 17:36 ` [PATCH v3 2/3] testpmd: use sig_atomic_t for flag Stephen Hemminger
2023-03-15 16:31 ` Stephen Hemminger
2023-03-14 17:36 ` [PATCH v3 3/3] testpmd: enable interrupt in interactive mode Stephen Hemminger
2023-03-14 22:40 ` [PATCH v3 0/3] testpmd control C fixes Stephen Hemminger
2023-03-15 9:46 ` David Marchand
2023-03-15 17:31 ` [PATCH v4 0/2] Fix testpmd interrupt regression Stephen Hemminger
2023-03-15 17:31 ` [PATCH v4 1/2] testpmd: go back to using cmdline_interact Stephen Hemminger
2023-03-17 16:20 ` Olivier Matz
2023-03-17 16:38 ` Stephen Hemminger
2023-03-15 17:31 ` [PATCH v4 2/2] testpmd: enable interrupt in interactive mode Stephen Hemminger
2023-03-17 16:20 ` Olivier Matz
2023-03-17 16:25 ` Stephen Hemminger
2023-03-16 8:16 ` Pier Damouny [this message]
2023-03-16 12:20 ` [PATCH v4 0/2] Fix testpmd interrupt regression Ferruh Yigit
2023-03-16 15:31 ` Stephen Hemminger
2023-03-16 17:01 ` Ferruh Yigit
2023-03-16 17:05 ` Thomas Monjalon
2023-03-16 17:36 ` Ferruh Yigit
2023-03-16 17:27 ` [PATCH] app/testpmd: revert cleanup cleanly from signal Ferruh Yigit
2023-03-17 16:59 ` [PATCH v5] testpmd: go back to using cmdline_interact Stephen Hemminger
2023-03-17 21:12 ` Olivier Matz
2023-03-19 23:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB43237164A72247C39D97CFB3BDBC9@BY5PR12MB4323.namprd12.prod.outlook.com \
--to=pdamouny@nvidia.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).