From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A01DCA04DE; Fri, 30 Oct 2020 17:12:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF5EA4C73; Fri, 30 Oct 2020 17:12:37 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 73DA41D9E for ; Fri, 30 Oct 2020 17:12:35 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 31 Oct 2020 00:12:33 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 30 Oct 2020 16:12:29 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.57) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 30 Oct 2020 16:12:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjDxvBR6/lNT8TIOILk+sfGJ+Ac9jX9+xu9XyI13ItFVwGLBl2bJV7i8hw1BomxNlx3kpcpv2+HwFOqzTNjbD1oiNh653sf3sB+QtslDb8kw2wnGjW7c5vBHi+L0tE2rqxaqay7+wSxd5K55Ni22mg76ckBcyCbMpEtM7OToKFlaaKCqee0oHSSnqAqj1EZ/lP20X6s/K9TK1h18FDJcwFF6Pd1gn35WnjKFgDagcFHEquG4VMdDs0c4aAANPz16AvylYaoLhHhFcABp4rJAj2xnN8QiKoft4fBkaNQ2Y78L3+l7P79+WiElHHaBKsBDav05LVK9t59/bkCtr4BfxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTKc0ZpFyOAwHyzjN81Rci95dV3N5vpDTfPxlYOw5R0=; b=SzMKoQe9ZpH4ptKiEBLVuPpM0R8pwtZPYVzFMZBeAc8KVrbpPww666oxRA/5JgN2PHN0CAAJnP87/pwRs2oteVhHb8s6fdYPu/kGtfvqLDuRgmol9O4yH9LQp33QgqhWrKaMyAQay8eG9jlhrAKgqMRkV3eGRvU5fZ/EAEq5J+NC954Y5xvl76A4xqzSesGk8KcW0p2iF/Vm5ujxJCtNfJ9budDJ8loFeyMzlN+5xRkQndEF8YC9yKtnDcN31mGVv8bKr6TvN75RnwAAishn3zrCwQb2eYU8cyWJ0DkBVNZJL/olArqSzScldRivj1wsM+S7D4rOF+myewSDIspEOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BY5PR12MB4145.namprd12.prod.outlook.com (2603:10b6:a03:212::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Fri, 30 Oct 2020 16:12:26 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::3420:8913:2256:fa6f]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::3420:8913:2256:fa6f%2]) with mapi id 15.20.3499.029; Fri, 30 Oct 2020 16:12:26 +0000 From: "Xueming(Steven) Li" To: Andrew Rybchenko , "dev@dpdk.org" CC: Andrey Vesnovaty , NBU-Contact-Thomas Monjalon , Ferruh Yigit , Ray Kinsella , Neil Horman , Ori Kam , Andrew Rybchenko Thread-Topic: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute Thread-Index: AQHWrdEOiFSGnL8SoEK5wu5AK7IEXamwUerA Date: Fri, 30 Oct 2020 16:12:26 +0000 Message-ID: References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: solarflare.com; dkim=none (message not signed) header.d=none;solarflare.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [180.162.54.29] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90e21b1a-7a9d-4870-3105-08d87cee9809 x-ms-traffictypediagnostic: BY5PR12MB4145: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: exlN9sbq9lKIKaxeujU/GOoUuohI/Qdeyut5GY0NJoJpz7lvKYj4thZdPCoVv1/X4lMEk+RtkyRiTTGZB5xMBvmLASm7XvQPgoD4eK1pqN0oFKF3WQIipDPdBFphFks8w0QAMj0eBJ113ommAitFOqoGX+OYwp1asOfJDQllj3+8m++9y88eTVXB9Cin2ruSXyXCX0TM+52NJQgkXXAkYHcb4COTDSGreUqSjkQU0fz356COLkd4+DmtjSHBcJJJRFeq9g3ZeorcDuJ19l8brxnT7b5dXgB74JkVHLLG9WuIkSXFr4PVQOpdDXJecd37jgGDegnWSC9za3nXfPHd8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(186003)(6506007)(53546011)(52536014)(26005)(9686003)(5660300002)(55016002)(478600001)(4326008)(316002)(7696005)(66446008)(64756008)(86362001)(76116006)(8936002)(66556008)(2906002)(66946007)(66476007)(110136005)(71200400001)(83380400001)(54906003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lFfd2aK3xIRiJh+I6OgTF79hwmau56dLcD/YX2RPujX6sk6//okltb4cTbFMRX/k3Y8/vEdHoW/JkzyRq7Estw0yKWaRwAnw/1M678U/JfPuSOU8Tf9aeiFqnGeDRHnzVvEmooPkEDVuefGIfGwgHPOOGmAX4MyJ6qpzKkgt1SX5kuf6tSK+tcY7orgQwKdo69pu5biuTj2ugD0qftzWNIzyeJvgra/Ia2qlrd0ygvdcFywr6LUB8Kbkb4l+/nqcg+/9sCk3O52oEUEotXpdgw4YLgNIYFAPoeSfKkxJvfcMD3uFYXriTyrBTT5wpypmqfX6IGQl4YYFsIaYErQttFIlQWIc+3W/JvQnnUIAJ0NOExEaJZ0JLPUQ+Wzmai7te5VNrMqoGb1IFmNkeL4WtLFWU+O/V/LXJjdPlhBlVjbDOpB3L43aI9iUrIwYeWa8azrLSpsPyoPoOvzeRwg+PwVabXWAZKti3vOFakHrRBr5RmMj9vHdYXD5BWxp5mOz0KOG0iWneNu8GW7UcY0aOvUe4OMLqPcmv7bp0Z36WgZW157XeEEch//1wIPvdyilNJh5lYwzAIakP+MP9Fj2IwONcdLZBS1fZroVrD1ZBnjs1dAy/opYryJzn7naNs7k2z4g4yMHVo05IrKMi5VocA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90e21b1a-7a9d-4870-3105-08d87cee9809 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 16:12:26.6430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PCKjGv6PsTu9i8tvzVDXHXItR1ZyFDEWeMTogXgpQrdFpce0XTvZFA9BqNeoicH5+yuK3mu7Hd2LDwJGEO1u7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4145 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604074353; bh=wTKc0ZpFyOAwHyzjN81Rci95dV3N5vpDTfPxlYOw5R0=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=R3BNlUyQ8Ijwq/95qgtz/oWHj/DuTMlmiex2uMyFHEkqmVWcl5+rnlO+avXe7Fo1O HE9DtDanNY2V9XcxvVpvwRrR96MjHhuxFP0IWQHaEn8gDZYyCTEx0rYJWlbjq0uGEc OJdfOyXKqEMdBFb1/Jrz2vnzVbNOftFiueEwzONg1LwCWNmqOj0dmlpljRi65ZVKdX acelkb+xwh1VzuyKEc3IlVOCtf4pasqQAjw771TMQRDbwqrotA5DrVDoUn/vl7ZBUk Jtao1r8TvizplEfXdtb6uD+EeRfI6aS7Cli+XQbBVTAHJYCHNeYue+gYr0LPA49+K1 NAVjnT+Iie7aA== Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, > -----Original Message----- > From: dev On Behalf Of Andrew Rybchenko > Sent: Thursday, October 29, 2020 4:53 PM > To: dev@dpdk.org > Cc: Andrey Vesnovaty ; NBU-Contact-Thomas > Monjalon ; Ferruh Yigit ; > Ray Kinsella ; Neil Horman ; > Ori Kam ; Andrew Rybchenko > > Subject: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using actio= n > attribute >=20 > A new generic shared actions API may be used to create shared counter. > There is no point to keep duplicate COUNT action specific capability to c= reate > shared counters. >=20 > Signed-off-by: Andrew Rybchenko > --- > In fact, it looks like the next logical step is to remove struct > rte_flow_action_count completely since counter ID makes sense for shared > counters only. I think it will just make it easiser to use COUNT action. > Comments are welcome. >=20 > doc/guides/rel_notes/deprecation.rst | 4 ++++ > lib/librte_ethdev/rte_flow.h | 6 +++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 2e082499b8..4f3bac1a6d 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -138,6 +138,10 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be > removed. >=20 > +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` > + is deprecated and will be removed in DPDK 21.11. Shared counters > +should > + be managed using shared actions API (``rte_flow_shared_action_create`` > etc). > + > * cryptodev: support for using IV with all sizes is added, J0 still can > be used but only when IV length in following structs > ``rte_crypto_auth_xform``, > ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or= equal > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h = index > a8eac4deb8..2bb93d237a 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -2287,6 +2287,9 @@ struct rte_flow_query_age { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > + * @deprecated Shared attribute is deprecated, use generic > + * RTE_FLOW_ACTION_TYPE_SHARED action. > + * > * The shared flag indicates whether the counter is unique to the flow r= ule > the > * action is specified with, or whether it is a shared counter. > * > @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { > * to all ports within that switch domain. > */ > struct rte_flow_action_count { > - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > + /** @deprecated Share counter ID with other flow rules. */ > + uint32_t shared:1; > uint32_t reserved:31; /**< Reserved, must be zero. */ > uint32_t id; /**< Counter ID. */ Do you think id could be removed as well? neither non-shared flow counter q= uery, nor shared action query. > }; > -- > 2.17.1