From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAD54A0A03; Tue, 19 Jan 2021 00:24:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DE50140D2C; Tue, 19 Jan 2021 00:24:06 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 5544E140D2B for ; Tue, 19 Jan 2021 00:24:04 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 18 Jan 2021 15:24:03 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 18 Jan 2021 15:24:03 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 18 Jan 2021 15:24:03 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 18 Jan 2021 23:24:03 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 18 Jan 2021 23:24:01 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 18 Jan 2021 23:24:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODDq+7Vqk8bIFMns0yTf1EAoBD6KuwES7pZwAE289AsoYWMnSDFcu9yxDHJVCVU0SNhR9gc1UTMVCG6jMAkxVKjzjklDTRHtsykLWPRLzben523361JUYh1tCj7ksMoi60udKUmW2rw9GseV0Ri7A3cdDXIrEam0WLc4u5NWS6D6B436iFp6yolTiWROvLJ0aQ5+V8yqV8FqxvoXmwc8+zxLMCFhCy4Q4lfS2hzfC1g5lougKBb+6wM3qd/DbI0gI+W/dYdcnAp6VFF5IqIzB7fP9Rmlgk9NHII9LzJnqudqeeFg8AGag5+IFzC+OJENHKaWZHWU6vH+4Eny93n5UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=emFfeyHZjk0tM6SwBuZVKxenRciAiBpHc8MIkAfTqs0=; b=TW7h6IHvOyqOs9m/zb6w2WgpGSEjOleh1s3D+keWc0fo97jRXheBrGQl+ZRhm5JAv96vKea07NeDSTOLEPFHKD3dJX/O0AB7lPMZ03guAXmUgXnLxK/2KWnZqO3iFQLy2140wZpUxcG4uv8v8uNwUX2fDMRmmHVNRHIJEtTzuBlUxJJn5RkoFSEMH6nk6RhX6VHBW86Nqm1kQsceu1vbX4jzCkmhnp0ADFCRujdkDUcHLE60pCItZKP+QhprhwfoORvrNzqgkpIEQ1Mx/IXcE6im336Fg/TY4tnTPIpA3OqRul9Hqiq9/YxNuOhnssG4VB2B4ahowp2IUbkIXY7l1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BYAPR12MB3365.namprd12.prod.outlook.com (2603:10b6:a03:a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12; Mon, 18 Jan 2021 23:23:59 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::8d03:2ada:5add:965d]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::8d03:2ada:5add:965d%3]) with mapi id 15.20.3763.014; Mon, 18 Jan 2021 23:23:59 +0000 From: "Xueming(Steven) Li" To: NBU-Contact-Thomas Monjalon CC: Ferruh Yigit , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , Slava Ovsiienko , Asaf Penso Thread-Topic: [dpdk-dev] [PATCH v4 2/9] ethdev: support representor port list Thread-Index: AQHW7YuHwO+5uGJXRECGt26RhJ/AEqotj/sAgAB2sqA= Date: Mon, 18 Jan 2021 23:23:59 +0000 Message-ID: References: <1610968623-31345-1-git-send-email-xuemingl@nvidia.com> <1610968623-31345-3-git-send-email-xuemingl@nvidia.com> <6719978.oSDc5pInoS@thomas> In-Reply-To: <6719978.oSDc5pInoS@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [180.162.33.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c695323-e7f4-4d45-d4b5-08d8bc082286 x-ms-traffictypediagnostic: BYAPR12MB3365: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CXLqRq/IzouPw8IPyGG0r5+fhbRKmmpSbUUWoz81I3jK2BjnDMbzP9K5+oxuLM6VDgYRFYxQr68aG4eDsYablBwnEADZiKJaRe/OVWpTxrmVEU+nNMvJZ0iO62JRzxkAOaw5VgMWalErKvDuEP1szkWiRnEXp8M1o40k4aWmuO15ty9t10Bbznzu0zwbKxkDn9dHb4qjqd8CsjNDChoOHgR762l2ngaI2tG0wklWu3zgiarfkFu9g2Tv0iz9WFDzIISmZVo/J8B8aoD9XRAwjWVegfkV1aTkoR9Qq4IPlKa7vlYH0FV5sUFeKKCwWn/jwCGuzgBYvKwRlcPksfPs1mr3OJzY08Hr1e6ojosnzD150zooF4y57PFHK3JBtsayl91h97UWf93w9kiG7crZKg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(4326008)(9686003)(7696005)(55016002)(6506007)(54906003)(316002)(66446008)(26005)(2906002)(64756008)(5660300002)(66556008)(66476007)(86362001)(478600001)(52536014)(107886003)(186003)(76116006)(83380400001)(33656002)(8936002)(71200400001)(6916009)(8676002)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?L5Fe+dsvRN80ePSYwoUFIj4w4DUy6ZndE5sGpvIE8JTdpRjtFPD2EFkWiBi+?= =?us-ascii?Q?Jyh6CO31v6eqHBJjx4Suzcy3lDZDTth2D8YTk5SmmwY9c5Qa0rqKZ7pBRWnb?= =?us-ascii?Q?/PJfRw9kbgUYekEP9DGCQ6a5LQBj85EXuDweS+MS4CXmlZsyQs1T9XC2N75w?= =?us-ascii?Q?FSnv0TuW9DP4jPtEzq9/AEUrAB2S7X+XayAh3s64dJzjuaBGf7nfls/GVeLO?= =?us-ascii?Q?PG8gpmkFWTf2RFdm1mbrbkZYbsDiShIMnVx2DqyNxtOAoPRPC75UCnrq0MSC?= =?us-ascii?Q?fGOji+GzzdBZ92+Y2PQmQwApRU3j/oQ08vHynNcfHjnxnR3NoULlQLEWrU9q?= =?us-ascii?Q?Dhs/BZeSugpwLNN2k2jQxTv8zweT3BE9/I60LdCcRhXBnI0pxUwksTxdB/sP?= =?us-ascii?Q?wmJ7Ri+0qYEi8atvpKdVX5nr9gg1gcxqIigIt1uGKN3LgX02wNgLNci6aO94?= =?us-ascii?Q?gOTJ3vQLOfOlfgGoY+V5glsi4qq4iD9VIGjxfvyIsDxHMnmrliDn31Ih9Jeu?= =?us-ascii?Q?fAbGGerEd66mbkVdGhYMSc3auReJmnLxt6e+bZ6csUbNBEH3Sy4ge0jTmn2y?= =?us-ascii?Q?XK8BSfUgPrIHWMLniWnIfvYBqNLWmXuE4xQYcwrZ6rSks5PZzB82/8cy9x7n?= =?us-ascii?Q?5P6qbpko0p90t/QcPz63VnyRq7RgFQbdNbponiipYA1WcykQZ9Sw64pZ7wHp?= =?us-ascii?Q?N0JGpNJQ6ZLQIpyxXe3NmQccTvoBYKXNGSmOTBZoEB1t8lDqu7mfD/ykz6+y?= =?us-ascii?Q?bzmsdkb0npue1Q8QdySolmAtxzXu/dvlpmFZRFnRXuVwMX/Tq14b7SqGeQnQ?= =?us-ascii?Q?A7PAB1aigdWnhObj0YVjh/BKxISaD85gsaolqOF/zolPhqKDzQrdgn4hmLQp?= =?us-ascii?Q?tKsaanQlwCSghvGdR8ceVCCnrwnAf7hPCIWwqRl08nYM/F7bRD3/YtlotA1W?= =?us-ascii?Q?7ttkYOmHFVwMq7WgmjXkDjMdwjDFgMU3V4sI0KZqo6E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c695323-e7f4-4d45-d4b5-08d8bc082286 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2021 23:23:59.6672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mcnOZC9x1TV8BJ0epaBH08dZRpVDzpg4oDRyq+ngSbc1na6qxMoS5NM7fbo7NXfsgZvFAkyz2vH0RUEwvYEBTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3365 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611012243; bh=emFfeyHZjk0tM6SwBuZVKxenRciAiBpHc8MIkAfTqs0=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=c49XCDFdvlQ5G9YggbKROwgG3nxpq2Oxsv7f3KR1X/hJgJA9GczOpfYjuf4CnLs3v sVa3sEP7pIgVhtLYeyC2YgwZqEfWuOgALPC1P0SkeW2RdHB52uJ/ISzj1C0Ty/GaK/ kIs+GB32Jjq+/UjLmysmxoKpbXjaOmPB43uSoGT56vkN42t1rpK3gBZ3b78yTAiQZd h5Xjthp/ktN9t9LrWY1+v3ZIiZIuPa8HQm7AsaHBOZrT6kMg+rCx/7HLyts0+hkXGG n6//SGyfenDcaP7FNoh9jzKXC8pYSMsMePBcGKIPhyVUIFXEF3BKZfaeKZ6q+yUzJd l7+1QLydtU3BQ== Subject: Re: [dpdk-dev] [PATCH v4 2/9] ethdev: support representor port list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, >-----Original Message----- >From: Thomas Monjalon >Sent: Tuesday, January 19, 2021 12:18 AM >To: Xueming(Steven) Li >Cc: Ferruh Yigit ; Andrew Rybchenko >; Olivier Matz ; >dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: Re: [dpdk-dev] [PATCH v4 2/9] ethdev: support representor port li= st > >18/01/2021 12:16, Xueming Li: >> To support extended representor syntax, this patch extends the >> representor list parsing to support for representor port range in >> devargs, examples: >> representor=3D[1,2,3] - single list >> representor=3D[1,3-5,7,9-11] - list with singles and ranges >> >> Signed-off-by: Xueming Li >> Acked-by: Viacheslav Ovsiienko > >Parsing functions are usually difficult to read. >If you need to do another version, I would recommend adding an oneline >comment on top of parsing functions to give a hint about what it is really >doing. > >Here, > >> +static int >> +rte_eth_devargs_enlist(uint16_t *list, uint16_t *len_list, >> + const uint16_t max_list, uint16_t val) > >here, > >> +static char * >> rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_= list, >> const uint16_t max_list) > >here, > >> +static char * >> +rte_eth_devargs_process_list(char *str, uint16_t *list, uint16_t *len_l= ist, >> + const uint16_t max_list) > >and also for this old one: > >> @@ -121,6 +115,9 @@ rte_eth_devargs_parse_representor_ports(char *str, >> void *data) > > Will add them in next version, thanks.