From: Gregory Etelson <getelson@nvidia.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>,
Ray Kinsella <mdr@ashroe.eu>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header
Date: Fri, 6 Aug 2021 13:56:56 +0000 [thread overview]
Message-ID: <BY5PR12MB48346E44F6EC6099C5E59CF2A5F39@BY5PR12MB4834.namprd12.prod.outlook.com> (raw)
In-Reply-To: <17b1ab37630.281a.45678ef996719ac36a921b5e5b2e03f7@oktetlabs.ru>
Hello,
The TCP flags bitfield patch complements similar changes
proposed to IPv4 header in net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/20210802103834.14263-1-getelson@nvidia.com/>
Regards,
Gregory
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Sent: Friday, August 6, 2021 12:03
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>; ajit.khaparde@broadcom.com; jerinj@marvell.com; akhil.goyal@nxp.com; cristian.dumitrescu@intel.com; ferruh.yigit@intel.com; konstantin.ananyev@intel.com; olivier.matz@6wind.com; maxime.coquelin@redhat.com; david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header
External email: Use caution opening links or attachments
The patch lacks motivation. Why is the change required? Why is it useful?
On August 5, 2021 18:28:31 Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:
Nobody rejected this change but there is not enough ack
to make it an accepted announce of change.
02/08/2021 12:42, Gregory Etelson:
Announce change to add a union that will provide byte and bitfield
access to TCP flags.
Signed-off-by: Gregory Etelson <getelson@nvidia.com<mailto:getelson@nvidia.com>>
---
+* net: structure ``rte_tcp_hdr`` will have a union that will provide
+ byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
next prev parent reply other threads:[~2021-08-06 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 10:42 Gregory Etelson
2021-08-02 12:09 ` Slava Ovsiienko
2021-08-05 15:28 ` Thomas Monjalon
2021-08-06 9:02 ` Andrew Rybchenko
2021-08-06 13:56 ` Gregory Etelson [this message]
2023-06-29 16:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB48346E44F6EC6099C5E59CF2A5F39@BY5PR12MB4834.namprd12.prod.outlook.com \
--to=getelson@nvidia.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akhil.goyal@nxp.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).