Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

[Sunil Kumar Kori <skori@marvell.com>]

Overall, it looks okay but I think "args" will be more relevant as each API says XXX_args_save().
What do you say ?

Regards
Sunil Kumar Kori

>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Monday, May 4, 2020 2:02 AM
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
>Sunil Kumar Kori <skori@marvell.com>
>Subject: [EXT] [PATCH 4/8] trace: avoid confusion on optarg
>
>External Email
>
>----------------------------------------------------------------------
>Prefer a local name to optarg which is a global symbol from the C library.
>
>Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter")
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
> .../common/eal_common_trace_utils.c           | 32 +++++++++----------
> lib/librte_eal/common/eal_trace.h             |  8 ++---
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
>diff --git a/lib/librte_eal/common/eal_common_trace_utils.c
>b/lib/librte_eal/common/eal_common_trace_utils.c
>index fce8892c38..a7c5893b00 100644
>--- a/lib/librte_eal/common/eal_common_trace_utils.c
>+++ b/lib/librte_eal/common/eal_common_trace_utils.c
>@@ -135,7 +135,7 @@ trace_dir_update(const char *str)  }
>
> int
>-eal_trace_args_save(const char *optarg)
>+eal_trace_args_save(const char *val)
> {
> 	struct trace *trace = trace_obj_get();
> 	char *trace_args;
>@@ -144,17 +144,17 @@ eal_trace_args_save(const char *optarg)
> 	nb_args = trace->args.nb_args;
>
> 	if (nb_args >= TRACE_MAX_ARGS) {
>-		trace_err("ignoring trace %s as limit exceeds", optarg);
>+		trace_err("ignoring trace %s as limit exceeds", val);
> 		return 0;
> 	}
>
>-	trace_args = calloc(1, (strlen(optarg) + 1));
>+	trace_args = calloc(1, (strlen(val) + 1));
> 	if (trace_args == NULL) {
>-		trace_err("fail to allocate memory for %s", optarg);
>+		trace_err("fail to allocate memory for %s", val);
> 		return -ENOMEM;
> 	}
>
>-	memcpy(trace_args, optarg, strlen(optarg));
>+	memcpy(trace_args, val, strlen(val));
> 	trace->args.args[nb_args++] = trace_args;
> 	trace->args.nb_args = nb_args;
> 	return 0;
[snip]
>2.23.0