From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0DC1A04AF; Mon, 4 May 2020 10:16:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C17C1D404; Mon, 4 May 2020 10:16:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4DD4A1D152 for ; Mon, 4 May 2020 10:16:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0448FmEM027579; Mon, 4 May 2020 01:16:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=724pKu1kvMWsqLHair7qABAiTJ+b1rZEMxtXEWAdMI8=; b=b9Eb1D336eyCh6JHC3MVAoWKSgnk1ptjvmx7GhgCtykvQd2BdEz3w5HsSt7Ozxk/13r4 vHIDIg8bcfP/fEaJMe071hYjceEbNHGXqdNCg8140id9cXMpB8KMXHkSKaQVXKny3Yls dFbmE2TwyI6EcOB17zC2mijlko1eRmJZIYnNqEs5GpPYaGj+XaL5QknLJYIDoar8uZNe oyQAQCy02malDHgu9qh9cWOBcf8YSSSHgsUidtXVevyl2g/U3N4RHbeWtq9MX4LTNdpo pYZ4wtPv/TWhqXDeXa9+6I70h0V27gewGdsmxs8cjazkWDOPyUcHyYiYGxix5gpLhFMW AA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 30s67q61qf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 04 May 2020 01:16:30 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 May 2020 01:16:28 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 May 2020 01:16:28 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 4 May 2020 01:16:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NhI1wfyPAevJwnSIf1320akJccz8x8DvFcnAsZ28soYmarifDQA8PAjgMh1L8ompzPKIHvsvdZOK6iofydlPzYRNzx0OpJcZ2cjPj5K8VFYPWf5st27qzeCiy/OjgHDFli/zymX0+MALDowPlMHh/e4jxaHY1WQR55sw3n2c2HMwGuuDi5C0ZI3u71mj32TIBYNu7q/4BvOLqjrPOzMoWyWba2BfKLK5XhLJuJiji39E7fy5OpVd2emAocsLlazDEMidhE9HR5iYkwdWdWmsWMVvNwim5UHrEGNEZmqrBzQZU+nfZDBnkQF9KoqdAW1vf7e6WmwCPu7qodnuUnc7+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=724pKu1kvMWsqLHair7qABAiTJ+b1rZEMxtXEWAdMI8=; b=isfz3ZXCmXx8BaL/6J0mL2k9o0zWhDot1Hm83Lx0SDmpeT1ERDwj2lip4KQLPaHPpsBvVM0FU4AAS/6N/ABvHfUnUC2LSjhKB4SxzDGona/MqlPEB8pn/RGkZIuvsfq9AYSyCOXXTBvRmjPLglo6QkD2dryi11oJqGLSRQcqVwzBas3moQusbYPpn934rmqDGSl4nztdGuSYOMMY1qZpkpW/ozTf/3L6dnP2S4V2TiOiLlfpD4aK4wtPz8hpfr1OBlup9GyH33Eu/xSc06WGNpxAAXTXrXADgHWmCKVXX5t1/EcM4Q1rUW8BE58CJROLCjMy2TrrDCjgaDcTRDzHaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=724pKu1kvMWsqLHair7qABAiTJ+b1rZEMxtXEWAdMI8=; b=V46pd7jEAA9T7OUWtfoLPk26Q4wThBuCWmCF6ZiRUegty+g775UrlYefetB9ldbOKZ3lHu6Jprzpx8tBWPo1iyLsomth+cQk6UNKadvyjLN4bnKX7dsFJ9VnJwxT4V8nBJNuprprf1rL+dDj16SpOblGiIj91idsClkGpp3/HnE= Received: from BY5PR18MB3105.namprd18.prod.outlook.com (10.255.136.94) by BY5PR18MB3171.namprd18.prod.outlook.com (10.255.137.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Mon, 4 May 2020 08:16:26 +0000 Received: from BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc6:c7ae:dc40:7ddf]) by BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc6:c7ae:dc40:7ddf%7]) with mapi id 15.20.2958.030; Mon, 4 May 2020 08:16:26 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , Jerin Jacob Kollanukkaran Thread-Topic: [EXT] [PATCH 5/8] trace: remove unneeded checks in internal API Thread-Index: AQHWIYn7Dwm0XzgORkWhO3afg+TNA6iXlETw Date: Mon, 4 May 2020 08:16:26 +0000 Message-ID: References: <20200503203135.6493-1-david.marchand@redhat.com> <20200503203135.6493-6-david.marchand@redhat.com> In-Reply-To: <20200503203135.6493-6-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2401:4900:1699:86aa:a1b6:3b55:e266:80e3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60430b7d-1b37-4cf2-dbfb-08d7f0037110 x-ms-traffictypediagnostic: BY5PR18MB3171: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:972; x-forefront-prvs: 03932714EB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MbH3YpzeDT2r3HGZZBf5YVz5g8I7yV9q0r6Fy7Fdh7rNXAww6vrl4yDSN4rTkx/+u7bIGo1Vo1RED+G58NGqVHcaHuDWl4mVrVzoTxnfGTCSDL9Dpb98niWYOZSBOzZF2t+tb8YSBWi0R+KMWox2YDk0acvtI2mJquR/xjnp5LKSuA/oeY72h+BJvwE6qn1V07bd+Ho/jgPClv9wqTtVHqdCnA+ZHqwlrWYaajZfGgghvtE4vZHIm/85J/WqoyZlgBpMn9JeTeW/GR+lCMIkGbJzS4JOwKpQ2mMrQToOxDlzmjyxZ5TkR7P5+O8ZhUBjMR/UT+H6J3hqmvlMsbWte9zxFFg3cqaPVoy3SSjZ+wFIR5La4vbMOauOchXBNA3w5+Q2G1cqsU+mZpaTeKxsyHDku5mrp1AtFyoPKgrcpS8kcejwbqui5pGn3aXhIX2j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR18MB3105.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(346002)(376002)(396003)(136003)(2906002)(71200400001)(8936002)(8676002)(9686003)(55016002)(478600001)(66476007)(66556008)(66946007)(76116006)(66446008)(64756008)(7696005)(33656002)(6506007)(186003)(316002)(107886003)(110136005)(5660300002)(54906003)(86362001)(4326008)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Yqjx79oTrxzoY5MONGVfolWSKTaPAY2VgQ/4Yohwy21uJkUNy60SWC0s8MH07zbZpltxPf4b6nxiHgs9IOxmMkf7Ral7wH7Ghfig6PvY1LIjyjTEibTfdiR4WcBZfOthD3Sww4gNqOOMMJRG+rysYxqukLaHPZL0MnhvlaggQC+OF6jxXC8OYEiIqQ/CWvpeJwSDhrGnMvag84/FSZXMvVPzZhSdk/Tsk/sxMh8IpwPZUBwRb6ub0dbrqmps2C/48xTSx/UUY+ZW05PdVdpsi/j3AccNS4KwdbWH1ZucAuBsCEfnWLDffxeAgrDgW33/L2BNQD2Jf9NO1kDg4iSbRcerCufKkc1G+lXk/Aulj1xV3Vp3RJPy1+twNdcaNCY9QIqJCmEMCcOORGg6OtzrVYpXuEgCIDobmA5zKc4sMq3i+IH/yX2R00S4eFBNCh64tLMFgYMSms27WWj80JxfrV0GfEfGndInTwI9heqCqO6+BagUKsM58HY+GXyVSbIKpHs9KuscF3D8FAZRz74jIijdHgcJH7109jwfZoYx+HGFnfCsZAd0V15z4OSsGq9x2ZoOLnrXPiaRzWvBggJbnmbc1YqQeVl2uMMmHHakv7bcpI30Y5yNyglp7k0GQBeBW9GiHt498nANKr+zZS63PG133IiJ33ssY37FplN0hz/h6W2qLsXvf/RS+GkHgqOxTT/1myD7UDEmtc8WXUZ9+3DyBQOC6wejuT2Rl9DDU4BSGF4UUXELgmt5BNBAGnPriswQPJTZ37FzLYZjhg+ohd4g/Lp1xe/oh9OD/sAcoFN4xSq+EaI51+lOfpBSydT2kYzXBYFsxv0VTcV2D/w/segBP1I2L97rJI+C5fp+MnbN0SR+K1x9n/UuAXo6v7dQ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 60430b7d-1b37-4cf2-dbfb-08d7f0037110 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2020 08:16:26.7733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: le16iNldNekL1TVnrxy5WdosN2qkEeA0tH2AM3F5C3hMdXwjhNZwd1rJnTH7xMJzvrTuvKh6ouXTzJXjXrVaQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3171 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-04_04:2020-05-01, 2020-05-04 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 5/8] trace: remove unneeded checks in internal API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; >Sunil Kumar Kori >Subject: [EXT] [PATCH 5/8] trace: remove unneeded checks in internal API > >External Email > >---------------------------------------------------------------------- >The trace framework can be configured via 4 EAL options: >- --trace which calls eal_trace_args_save, >- --trace-dir which calls eal_trace_dir_args_save, >- --trace-bufsz which calls eal_trace_bufsz_args_save, >- --trace-mode which calls eal_trace_mode_args_save. > >Those 4 internal callbacks are getting passed a non NULL value: >optarg won't be NULL since those options are declared with >required_argument (man getopt_long). > >eal_trace_bufsz_args_save() already trusted passed value, align the other >3 internal callbacks. > >Coverity issue: 357768 >Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter") > >Signed-off-by: David Marchand >--- Acked-by: Sunil Kumar Kori [snip]