Re: [dpdk-dev] [EXT] [PATCH 7/8] trace: remove string duplication

[Sunil Kumar Kori <skori@marvell.com>]

>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Monday, May 4, 2020 2:02 AM
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
>Sunil Kumar Kori <skori@marvell.com>
>Subject: [EXT] [PATCH 7/8] trace: remove string duplication
>
>External Email
>
>----------------------------------------------------------------------
>No need to duplicate an untouched string.
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
> lib/librte_eal/common/eal_common_trace_utils.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
>diff --git a/lib/librte_eal/common/eal_common_trace_utils.c
>b/lib/librte_eal/common/eal_common_trace_utils.c
>index 15384ce4f1..49cc8d7b1d 100644
>--- a/lib/librte_eal/common/eal_common_trace_utils.c
>+++ b/lib/librte_eal/common/eal_common_trace_utils.c
>@@ -172,19 +172,11 @@ eal_trace_args_free(void)  int
>trace_args_apply(const char *arg)  {
>-	char *str;
>-
>-	str = strdup(arg);
>-	if (str == NULL)
>-		return -1;
>-
>-	if (rte_trace_regexp(str, true) < 0) {
>-		trace_err("cannot enable trace for %s", str);
>-		free(str);
>+	if (rte_trace_regexp(arg, true) < 0) {
>+		trace_err("cannot enable trace for %s", arg);
> 		return -1;
> 	}
>
>-	free(str);
> 	return 0;
> }
>
>--
Acked-by: Sunil Kumar Kori <skori@mavell.com>

>2.23.0