From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A1BFA04AC; Fri, 1 May 2020 14:40:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CE991D9D1; Fri, 1 May 2020 14:40:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id ADB851D6D3 for ; Fri, 1 May 2020 14:40:44 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 041Ce3mm019202; Fri, 1 May 2020 05:40:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Cat9oSVyTiu8irCRkiALhPVHr62EcVygkVEYfA0aIcA=; b=dBTH7sJG0WUH0ZFQbhdOkTMbH512NZZnO3QFh9BPFBhTi/Q1TPDaIEaF3FDDA3irbRo9 v5WH1WpIANPSi/l1TKK2WIPDUI/skvp0g3dqEa6r0uKR/4MqPGrMltLPGNNOZTLKhnaL nJKJgWAag/MBgU3mceNc9OcBrCucGdA/nyzpm9J/h/f6nm+PIsKz4uDgDs+fXXWGKW4b BdS6alxyuv6l2/8J30laAGLI/X1KBfAYRMTbDF7gYiBSFFAuo9Fs9dOA0tDaBkgo+qWE czJ8UejVtw9YAvwHnnb7xDfOm+NbcP8bRMI119+4u4N3gCcESI5/sa6IfBjoPp3MaO0U Jw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 30r7em2gvr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 May 2020 05:40:43 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 1 May 2020 05:40:42 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 1 May 2020 05:40:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E26jLOyLCpYf3GMPqoWTpFeigbBkRa6nK8op0B0kV28PQ39s8iY3pWNK3BJW1Kf1oV9VIL9uSXmHKnlMdo9p9Ooc4ymAYjT4wVtcPaIdyQZ0Reahyo543tgEu7DPZRsoJwJlwrLU92SvgM4SBA4Y8IFJeY1s8dhxVZWWrH65jJmFUY8YG1lVYPQyz3moXqkgSzdxukeZkL7iQYo8LIBORt2LEBv2qtwqGbJvrjNhlMM9ApMyu5Zb+xvMvSbgcnufXvaKH6XMXJz7Snyn6mq6dxs6ZIpi27kv3YFCk/+553ijswar2ZE+beXbK4B/0pY1Vg8/C6xuMRVYAOWILPGEXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cat9oSVyTiu8irCRkiALhPVHr62EcVygkVEYfA0aIcA=; b=l2y0JVYqZl1QGAx9FdD1Y3w/rNgRmpIYroafiT5G74YK7nA+wTKg8bgH4CX8yBd0twDSPs5/oMalSmZYuqhTivwVMURtiC1dAZK3pOQ1VUrryMT9xhyn0PvSFHzHM36T2YNc1yvz+M2wWk045+xj4vwmVY7bfBuLKyR0IMAAa4YkHBcAMUaiFFM8tRpbsjzCaN1rIeK7xNhm3w59V75QTjDd+DY4gRdwNhUoYoT2zx3HkuVIVkbXgA/YxmsCrfZBHXDmQRdrvjwWZ3MLWB1v0OZieqSdMpHA87zX2nj4ciZ1ZYiZ6yPj6I3gabS4qeXg33utvvQHWt33+oyGEF69Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cat9oSVyTiu8irCRkiALhPVHr62EcVygkVEYfA0aIcA=; b=f+glrH4Q+bTLAt75JENiNX6CA+1HlfyRyBJjV3ajgN+l/QTCWvoSJ506GJXo1E/Y5Dadrx8bx/5p8DDNTK3X2WEi0gAvs20JvwpXcNhaTaOnsMGiMYyyMvo7wlEPZnp/gCkZVALucHz6TjU2D/pVgfkuOtvoywc2JPtZ3RoS7w0= Received: from BY5PR18MB3105.namprd18.prod.outlook.com (10.255.136.94) by BY5PR18MB3154.namprd18.prod.outlook.com (10.255.137.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Fri, 1 May 2020 12:40:40 +0000 Received: from BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc6:c7ae:dc40:7ddf]) by BY5PR18MB3105.namprd18.prod.outlook.com ([fe80::cc6:c7ae:dc40:7ddf%7]) with mapi id 15.20.2958.027; Fri, 1 May 2020 12:40:40 +0000 From: Sunil Kumar Kori To: Sunil Kumar Kori , "stephen@networkplumber.org" , "david.marchand@redhat.com" , Jerin Jacob Kollanukkaran , "grive@u256.net" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 1/1] bus/pci: optimise scanning with whitelist/blacklist Thread-Index: AQHWH60omhEuboyrCUS2WGMzBXc5aqiTK0lA Date: Fri, 1 May 2020 12:40:40 +0000 Message-ID: References: <20200420065554.20138-1-skori@marvell.com> <20200501113909.26355-1-skori@marvell.com> In-Reply-To: <20200501113909.26355-1-skori@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.76.146.166] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c7f0cd0b-de9e-4716-4fd9-08d7edccdb72 x-ms-traffictypediagnostic: BY5PR18MB3154: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0390DB4BDA x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PYtQ4VQkw3MdhF7ymh0QWx07Xf8CMrMD+36taxD9gUOPKJ1l1rUQw0lLTjmsOh4Ofw4YoKQ0L/fSvspLE3PGdNi8UrX1upfn/zKJy1KJPUlOWFQb7qena9sdWAWXOrAZa6oZvmixAIiVJWE29OVAmXKVtPlhloveIhyw6zFXRG1ss/frt52Ep7JUQjbTnNDo/CkP4RhtQzRUOgCQui9k5XH8k07UGb11nO+2uhW36WY4+z5PmHIZp6/8E7svH/7wnUYV3XRAh3WuQhGbnVePjq3SeQfEjta5fXey0RaragU6qgTmDSjgIWk0pgImeAQyiWhrG3nah9RwEM264gl75P5iGONxj/yjpPkSTsLWaCMS/CzvtNuXMKxWahRGPLSJcx4J8rG/lfMgHuq9E+4yNXFeb39sCi0CAGaHyAR7caPKy9r0MRxjILJcjBbNqdbl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR18MB3105.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39850400004)(136003)(376002)(396003)(366004)(55016002)(64756008)(66446008)(76116006)(33656002)(66476007)(66556008)(5660300002)(66946007)(26005)(110136005)(8676002)(2906002)(186003)(4326008)(7696005)(86362001)(6506007)(8936002)(478600001)(71200400001)(9686003)(316002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: J6jQyp72j8C6uz1zF4ma3aUPoOs23pdcFUNksiLR3KH97rcvIZJSHdfWGabpDeI5QKzKp8R4nUbIYB5DOLalwO4DhN6yQaEaLQWBLq2BQa7p/pA+MAPoq5rwSFI3Vwdpd5CxftznMn7kRjq+LA4EyTziRSnXpGaxwj+vEEt9lkzqK0YLEQ5onK3Wo48P8VEJ9SvFtsWBkgVaB+bJDNau4meFbhUvbBs9e3hNG1E9dDXl7aQab+IZd8K0rICp74iu/CKU7XFA0jWVO8I8QpW8H0wMi1aJuRCdOey/AFV7gAVNRyOJi1SgxGfItp9NTsVmrFVjfTqxf+PLPKmVGwElZglHxV9IwQ8SVxgGfjaBlNR2p2DDH+IZoABiJfKDagqbbB913qKqNhvP1Q0n1EPX8k4HdiNMtZPu4aKozmOV7qFlK04QBHUhOJIUwCa6mqDx7tCLAWP6XbpT9V490ZDg9/TAmLpAL7RvBD9mq3xdSGBNO9jBdYTxVBmQH0lJi0i7rlRJGc6++Gk2gRL8Rxt8CJY1b9OhHUc2nz5wx2ACF93GPzHbDohi60dJ81YbYGiX5BQjs40ER2TjNKMkGTsMUQKa/0gvl9aXPTefgRtaUHHlx9VMqqdYuUik1/zh331PnP88Co8/hGUQAsqylBibTWqSi7kih8kKU9W5EFPMS9KVYCet1UG5fsBTtSbx7JybFPzu71M49bIyscZFHjUACVn2XyDNAKX25d5tOmZep2u8zEkRrj+4GNK5XGvb0txH3Ya1unc6EICttGDddQTjDocjFgp7m7ePvHdrwZBpjMM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c7f0cd0b-de9e-4716-4fd9-08d7edccdb72 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2020 12:40:40.3789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VbJJVO0+HLnuo1L4owdRWC1D3RAy5JAzoX70WRno28NEDb62BnatAhj1apw2oSe40NiBa7jQfgYLiAviqA81kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3154 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-01_06:2020-04-30, 2020-05-01 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 1/1] bus/pci: optimise scanning with whitelist/blacklist X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Gaeten, I have validated hotplug functionality using multi process hotplug applicat= ion. Devices are being attached and detached at runtime properly. Regards Sunil Kumar Kori >-----Original Message----- >From: Sunil Kumar Kori >Sent: Friday, May 1, 2020 5:09 PM >To: stephen@networkplumber.org; david.marchand@redhat.com; Jerin Jacob >Kollanukkaran ; grive@u256.net >Cc: dev@dpdk.org; Sunil Kumar Kori >Subject: [PATCH v4 1/1] bus/pci: optimise scanning with whitelist/blacklis= t > >rte_bus_scan API scans all the available PCI devices irrespective of white >or black listing parameters then further devices are probed based on white >or black listing parameters. So unnecessary CPU cycles are wasted during >rte_pci_scan. > >For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_scan consumes >around 26ms to scan around 90 PCI devices but all may not be used by the >application. So for the application which uses 2 NICs, rte_bus_scan >consumes few microseconds and rest time is saved with this patch. > >Patch restricts devices to be scanned as per below mentioned conditions: > - All devices will be scanned if no parameters are passed. > - Only white listed devices will be scanned if white list is available. > - All devices, except black listed, will be scanned if black list is > available. > >Signed-off-by: Sunil Kumar Kori >--- >v4: > - Review comments incorporated (Gaeten and David). > - Rebased on top of tree. >v3: > - Remove __rte_experimental from private function. > - Remove entry from map file too. >v2: > - Added function to validate ignorance of device based on PCI address. > - Marked device validation function as experimental. > > drivers/bus/pci/bsd/pci.c | 12 +++++++++++- > drivers/bus/pci/linux/pci.c | 3 +++ > drivers/bus/pci/pci_common.c | 33 ++++++++++++--------------------- > drivers/bus/pci/private.h | 11 +++++++++++ > 4 files changed, 37 insertions(+), 22 deletions(-) > [snip]