From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BC88A04BB; Sat, 26 Sep 2020 03:23:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E9121E9F6; Sat, 26 Sep 2020 03:23:51 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2105.outbound.protection.outlook.com [40.107.223.105]) by dpdk.org (Postfix) with ESMTP id ACCE11E9F5; Sat, 26 Sep 2020 03:23:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dWGwEPIKDtYZ/js7ZUg2VvthGt/mKpLk0IL7/YfTW4luAJYmJJ6UOBMT28glJgrSC+HZBvRSpay8c1nSQE04sUBp3K3nGmqxa/JxmaN8G4C0vROYLpqXbcCkDfCRsTBs1WFpaScglx8ISfFAT03Xg0yQcqDNrs0sedj97EADjqKvwOJpORsMXeB8o2ld91iNqXDpLoLacUk0AE8LeQHDjcAVtkcYgFyKrarIAL54nX27GqLhkBkeHbBt9jecEbUW0DQJXmQuEi6Sb47F/xqQUayThjbNDaw6pEkbP9aqdOc72iQbEAXEAWCUnM/dL9djYe2LKMQfyo3rtFfwp/HxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZnTk4Yc4djKpuSZlOlGVoEtcB5rSR7GaoVNstDEpdqw=; b=PmqiaziScs+iLnaOtRzhXBL9N0r0Lfm2UMpo4wRV6Agr8ZQauiA7q1XUGl1KwvWMXbHYTJSIx5o7utCkEf5ezrtqHIwT+SzXAv6D4/i/JR3SysM+Es8BpLCbixGUxHpuAx767ddS3HWowTQfPf0iFC3o7hrWv4l9mEX4IbM2rUf6lpcSEkmvtqZhq7YK2uij5Xxcqgkr8doMS+IDpRgGYBIppvSnRFAfSeTGaJPWMuigWMdm4swfdPbLjHoD+J6EMFIHlQ4+Q8gKXJ+yfn7PQcU7v5YPRdA75PMtb3Wu3WVmcUDl8pWMWWY+lGyD6vo37+ChR9oAqIZhYXZfcSGwwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZnTk4Yc4djKpuSZlOlGVoEtcB5rSR7GaoVNstDEpdqw=; b=LbwiY1sXYrrIBa/gigrKsQa7LV/U1mrNjlL4NT+u07fl4MdLPU8RpFGLkSUsrUXmgk90dwYnjY2JlpZxUsk0OL/LjkLQWf7d6Hy5N2pC0rMv1ux4cPzUHL63CuWCFHJ9ELaHDiz5PA7QeyX5GD+s4/D82opKHijD4FHRnjrt9n8= Received: from BY5PR21MB1380.namprd21.prod.outlook.com (2603:10b6:a03:23b::19) by BY5PR21MB1444.namprd21.prod.outlook.com (2603:10b6:a03:233::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.8; Sat, 26 Sep 2020 01:23:45 +0000 Received: from BY5PR21MB1380.namprd21.prod.outlook.com ([fe80::8836:b7ce:beb3:91ae]) by BY5PR21MB1380.namprd21.prod.outlook.com ([fe80::8836:b7ce:beb3:91ae%4]) with mapi id 15.20.3433.007; Sat, 26 Sep 2020 01:23:45 +0000 From: Khoa To To: Dmitry Kozlyuk , "dev@dpdk.org" CC: "stable@dpdk.org" , Tal Shnaiderman , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , Pallavi Kadam Thread-Topic: [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW Thread-Index: AQHWksj0ztjcpEHSTUq3YjoCbc4iYql6IQNA Date: Sat, 26 Sep 2020 01:23:45 +0000 Message-ID: References: <20200924231707.23554-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20200924231707.23554-1-dmitry.kozliuk@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=d38fc009-dac3-46a7-b48c-65788999666f; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-09-26T01:21:00Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [67.170.72.207] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b52c6b43-c91b-4bfb-df19-08d861bad025 x-ms-traffictypediagnostic: BY5PR21MB1444: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +VFPK2rSFuKjOMD8xTdw+JNuA5gXcyf/98v0K0nAM/SqU9/Vinptd0i5nFRzVmvFihwuTSGlXe8XmXnce9jCq8UHXFf326ej7ScIsbrkG9S1f9TRT0VVAay/lQE1zgZ7a124BuHxq7o2sD+/5n20hu0VyE+exE5gJVlPd2+vBporApiHeLpAj+GgHbtRDt7ZAniOLKvm8F3YSBUlkMeiIqTC6U8/JDTlyUrvReBTGIKLWqVNHK49mx8EjtgVVKwOTT8c40AgD+4hJUpDNJ/j62CaIqoJP82W7zPR56v41+ggXN9aHjj4JYzOttlHK/8tonJ5tG+MCvcRJ/0modNzZksSDUuqiCGVbPCboCK0MIXLxEs14H3WUtVurFc7wbBOJlVd3Nf/W80GlbcVgGTwYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR21MB1380.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(2906002)(55016002)(66946007)(478600001)(7696005)(26005)(110136005)(76116006)(10290500003)(33656002)(66476007)(5660300002)(8990500004)(66446008)(53546011)(66556008)(71200400001)(54906003)(8676002)(6506007)(64756008)(8936002)(9686003)(966005)(86362001)(316002)(52536014)(83380400001)(4326008)(82950400001)(82960400001)(186003)(83080400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: H49m8lfjYglm58iq7gZIl8DyT3SponcwE0BuHjB0lMwTlZ8Hb9/vadocX4DEO5ohzng3CPZU7TTdnt9bAJsFU4ajDffwli1bIOGvKLiJBu6ZPnEJK6CtE+NdV2WM8xtVjZv2lrEbx1EQJmpRurSA3B7wuuJSokxwG9XEH01wNZ1SbLghkQqK7XxuUaP12wuDEBlxZetpPHtHv2TwQucAvSUh2Y/P9MFvrGDmK2vuup1XMS/xFIDZEPj0XQTjGpLOrZfiq48vD6WiQ7oN3VEzrk4lFsIEjuOSF7bfuvGAeMr5Mb5vMg63XVjgQBWMssT4g6XqJp39cjQWHZLx7cfuhSf0aCyNjZ1OJ8HApLbWwVbrX0WCS1fBRp10RB9kjCRmL+XQpeuGx8Sunw+pj+2WD8lKPss7ZX8zxvlLBQXFwizgsCrW7+s813uuEg9rJCwPeJcXw6w7XFjceNSL12BctiXvSHJtrPHjSy1GV4yAhgTaJ492Oj0/SiCNp55wpfrmPh+7E+J06jqbNZBZS0rQMf+ehrB6Ade+tvXG1ywFsGBW9RK8w2vCU7ubJ8l0ORo0o7XYTg5+Bd8K6AOb/4vkrrZaV0UgRn+EIRB3TCwN5aRglOizmOTOAt5KhbFOcRpUrGSWF2bZKEM80z34DIT/WQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR21MB1380.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b52c6b43-c91b-4bfb-df19-08d861bad025 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2020 01:23:45.5963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tHhqDsxyorGkcGcA3w8MlQGuidabeDYUZFPXzBkADncD8spiwPlaPtRLEPvISmnC6sX+SragRRT9kUtn4mOh/Q/SRfJj7wcG7UIM8nZ3Ky8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR21MB1444 Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Thursday, September 24, 2020 4:17 PM > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; stable@dpdk.org; Khoa To > ; Tal Shnaiderman ; Narcisa Ana > Maria Vasile ; Dmitry Malloy > (MESHCHANINOV) ; Pallavi Kadam > > Subject: [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW >=20 > Clang builds use getopt.c in librte_eal while MinGW provides > implementation as part of the toolchain. Statically linking librte_eal > to an application that depends on getopt results in undefined reference > errors with MinGW. There are no such errors with Clang, because with > Clang librte_eal actually defines getopt functions. >=20 > Use getopt.c in EAL with Clang and MinGW to get identical behavior. > Adjust code for MinGW. Incidentally, this removes a bug when free() is > called on uninitialized memory. >=20 > Fixes: 5e373e456e6 ("eal/windows: add getopt implementation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk > Reported-by: Khoa To > Reported-by: Tal Shnaiderman > --- >=20 > This patch probably supesedes > https://nam06.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > work.dpdk.org%2Fpatch%2F78574%2F&data=3D02%7C01%7Ckhot%40micr > osoft.com%7C7f6e47a7db0945b2c93708d860dffaa3%7C72f988bf86f141af91a > b2d7cd011db47%7C1%7C0%7C637365862839491238&sdata=3D%2BQPJ2US > hknxQLV97rQRVc0sT55TpTNjNTq1m9oj9eFs%3D&reserved=3D0. >=20 Acked-by: Khoa To