From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5343A0C52; Wed, 13 Oct 2021 19:42:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A713B4111A; Wed, 13 Oct 2021 19:42:30 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-oln040093003012.outbound.protection.outlook.com [40.93.3.12]) by mails.dpdk.org (Postfix) with ESMTP id 3BEA3410E4; Wed, 13 Oct 2021 19:42:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kEKrU0rSODMRZ7kl4/DTTHrVpz6t4mWZDsMskqfGpbEfyUiZK4bbw/lbX7KEdsBVlcJXsas84zpgXhyQwL6AZw4xH8m0F6ziLJ/e2yUzyDCoIqnLqs91hVh3qb/XRN4qXO1LVr9OjSm5HTOSAKeV25Ym3DN64h8/kOCOL3sJ0ZNM0Ll+iEwBpjwe4bqWR6NSSO2eEj6IPRZei34Dvvh4mAFAGE/GyBb4E+vdeZ5NgXIioftHwPPb8zmlfleFae1mE0IGugPGmlJWAOfQoDzhubzQJ0Fp9ifpjV0Thn9uGARMzqJqLBjaF9eC9V9oNYK0qjNvX3cxh7C3wNRDAqnlww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z69FUCss0vJh+kbdFnunavYsmqb4CMxhq1YPeMt7FII=; b=O4YFqe+xo6Sz/OlocWtRhbAPyMDnTEcHPDADEf5qqb5lzbIyF0zRYdywYMU25TxKaVsA/sPtM/BHIIhMVyCQDlTJuWcRDaOJnGK26bfXTRpJIY8BSfhApWYQx+5bqsUTp7PiP+3pl/Yzjy0+mZQRhTm6Iu3RGjjXmcA6xOZpjwTYPUpwqCoTrnA2b9cazIK/yAr257bBq5t4GnIw3YeMKcmGzvLbqsFQdvWBEIaIpIqPc8IaHrnoKFjXP8vK1UumN1DpIuofDOhiR3rUF7QhVKnoFz4JDKSEFxfE0QrCfEAbZK3GgzsT7PPf7D9LeusJh5DLOS3inPGPNxBKx4/q1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z69FUCss0vJh+kbdFnunavYsmqb4CMxhq1YPeMt7FII=; b=IOsPoObwIwgkq/7lYJUhW+o/hgqzjDO41HITHALfeCrzFSNMd4R2B4yFKN/VfJvRJj7KwZWgK09UWa/eslxSDtUU9CSoaeQd97SDP+HopAYInliRm+yp5wgJV8qmDErDWyLCGFtL7DEqGPs5BMJYsxnGrV1WPLLP1HcrIECO1Dg= Received: from BY5PR21MB1506.namprd21.prod.outlook.com (2603:10b6:a03:23d::12) by BYAPR21MB1734.namprd21.prod.outlook.com (2603:10b6:a02:ce::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.3; Wed, 13 Oct 2021 17:42:26 +0000 Received: from BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::6472:67ea:9a66:38a4]) by BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::6472:67ea:9a66:38a4%3]) with mapi id 15.20.4628.008; Wed, 13 Oct 2021 17:42:26 +0000 From: Long Li To: thomas CC: "dev@dpdk.org" , Stephen Hemminger , Jonathan Erb , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring buffer addresses for the secondary process Thread-Index: AQHXtXMNcimTSvRfxEa2W1TwMdAcR6vQ54aAgABgeAA= Date: Wed, 13 Oct 2021 17:42:26 +0000 Message-ID: References: <1632948370-25668-1-git-send-email-longli@linuxonhyperv.com> <1973433.8l5BURKI8a@thomas> In-Reply-To: <1973433.8l5BURKI8a@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=ce4a4b2d-c9fb-4caa-b476-6320d5a5b993; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-10-13T17:40:43Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3e73969-1f4b-4d23-c5fd-08d98e70d234 x-ms-traffictypediagnostic: BYAPR21MB1734: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IhEtxJOqpTlxYjkgp+v9Z7L3BofnzNMObJCerMC7vK98Bkr6Y8NP4xsAI+LfrBtzYSuh5NeWr6j4Eo9aZmVtZnhSDyc137QvbAKaSG57MNjzFR/PhOb4nb7EzdLgLmQPNh5kL8X/MR9hfZSY2icQNTIrBDsXaybIvI4UftkIST3WOukF3Wjn62NjhT0iM5CvF3DCA4qBMFZWjZ8qbKF0Hi2wvFlz8DDzaNRBHBzc1G2nJ5gk2UQKH2nWZ6PGFSTfKKKAan+YjxoOi1Yjv+I8fA+xbcKGJlE/LQ9hqCfEPYOPI4BAnRP+0N0rmrahIBL0FejOGTY5jUqf4hZvRVhbxlw2GuJ8dmo9/KBjQAjXFpJ8coRhrbdNB+JQHPwTqoxgxZVu9EYrcvgsxIOp23LSs8WtcK6gESqwkX6WQZmJ2OAD+1Ny70WOthx8eHgAFPmzuax7aUOunFPC9cJenQ4ilKW7tLqCaZzM16XZ85jEqYX+w09YG+mII+IImY9HFgWCg4Ax4ZfVbm3pJ0aq2hoWK+g7auzCkqzVM4fXiYjK5Jz4wxWvrMMgzQZXp7reRKhyglsp24jWV9pnJAOOwHNEAM6ID7P1H8DTp/457V5DENJ1M0E46B3yYxMSSZRcjlFQeeLYopvj4NCybJKXV53c5NDt01I8ykxU3Cyi51KaL5cIVpvJDVBMAhmGTKXqVeFTawZ3DffdPdz9CPenYFE2qw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR21MB1506.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(76116006)(8936002)(82960400001)(316002)(6916009)(2906002)(66946007)(66476007)(82950400001)(66556008)(38070700005)(4744005)(9686003)(64756008)(54906003)(66446008)(10290500003)(4326008)(6506007)(55016002)(508600001)(8676002)(8990500004)(33656002)(26005)(86362001)(52536014)(5660300002)(186003)(122000001)(38100700002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0C37s0znlu+Nzfbthxt+bbd51EUz5MthEGxlBOV2P9M+MOlCfsr8TA9doeAu?= =?us-ascii?Q?65SlQxEPAqNcvvfmamLUmUTsnfcTGuiuLx39u77tgAbM2T0hxHZ8dvS2pogW?= =?us-ascii?Q?9SKIffyFOvyi1MdcgZmabVlURvuqAneEsybcbhCRZA5j3hI93maWNoxwpOnp?= =?us-ascii?Q?qQa+qFGd4rQ+lOOLrbRxBIKqlOG9koUvzAKkf1/Fun9V3M3BUiqw6XJMaLf1?= =?us-ascii?Q?GtDz8jTvUvQpVCL5PViq7jIUY4ajoN7phguAb1eRPiq+WU+izKZlX7K71Bdb?= =?us-ascii?Q?0SF+yXRR64u8b7amJnftwd+Tmc8h446w/oiHEL/8tY837F+6eBqu3BLBsfS0?= =?us-ascii?Q?BYYju46LV0wSjy3w5pMBqE+dugy1SXwVt/V0tEjdY9KR0IzNowPfppZcuCTA?= =?us-ascii?Q?RQ0NwWGsoSR8DHDo16rgU7fnRzabAgoCifJv8PdOyV3t1VhlPSc6P1vUgPzM?= =?us-ascii?Q?7Q/YAf0Kf4V5Bqkyn1Ex+xPaC3kqMd79CrAo7QIb4bZckiYGc1X4ND8PJA+b?= =?us-ascii?Q?7cBAzzclKXxFHup8Xjnpse22o0CD0JR1Vb6kWu5ONC5Mce7Q/zgG9H28cweM?= =?us-ascii?Q?gWWr6nvX0DC0z3aMU1a9sOqYVQMbwTR92olxHFl+6HlfVCl33rWxyjptLaUp?= =?us-ascii?Q?1sXj3shzfvtxsmlAkZ0FimnIOcvolUQwZtM86/A1geg/sYaISl+pLvbBMrDM?= =?us-ascii?Q?BdP1h7q7MKoSQRgAqgQRjIYoRJY+cgSbqwSAuY4QUQ2sc+fyQUsfAOnop5gb?= =?us-ascii?Q?8q4caW85ezqdFBQ0gxj5nHFo8tk0xEWuwv0yOYLUj7A8vV0o96iD4vKew2Wf?= =?us-ascii?Q?fn/ZSd7Ei6jOlEqeS+P0baxkh2zWit2+nsVAz33YZP4YX8dRUxD+EQgyt4ey?= =?us-ascii?Q?twOsAgEpHBwUFXXe3BlG5zGJVqmtdt1IVg9/kkUa4Wkp9GGrEX7iXJKsM+BU?= =?us-ascii?Q?cmyHajhnZ8c3anSJbW6kJ+20VqLB9rfCIGCT95hUQf/8/DO+/7JannO/BBwA?= =?us-ascii?Q?pSXbdQqeMzHATyjpVsfJFwwKd394haHn0PkZssaJLo0JUUTjgqPNugJOjIVC?= =?us-ascii?Q?BU9XEcVl9a8gS4dUHqZKaufjKl30IheebP0eA52Etgq/gMb5iQuOHUWhgIIA?= =?us-ascii?Q?Rr6TKe91TDlL+k/NVCDzXqjcBIDjlUAUnMtPhb5lzsnU1+JJ9PPGDoShk3Y/?= =?us-ascii?Q?z1NnMj5Y/NoUtXce1ijmLJxcjA+DsRXOHXzCnx8bDzxaRjKdF/1lDq/3QtsM?= =?us-ascii?Q?hBcVYYtD5B5O3NriwaLI8s1SR+H2Lgb8HldPG1UX0dY5RFPyRVkNE4PIiyz0?= =?us-ascii?Q?FrI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR21MB1506.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3e73969-1f4b-4d23-c5fd-08d98e70d234 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 17:42:26.2685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aWtNBDMg6oLs0SfQvchmU5ueS/eBZe8kqskoDneM/n5GMYeETv5h456kxCKsp55yN6Yj4vJJDfCMkgZqe2kCQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR21MB1734 Subject: Re: [dpdk-dev] [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring buffer addresses for the secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring = buffer > addresses for the secondary process >=20 > 29/09/2021 22:46, longli@linuxonhyperv.com: > > From: Long Li > > > > The driver code had wrong assumption that all the addresses to ring > > buffers in the secondary process are the same as those in the primary > > process. This is not always correct as the channels could be mapped to > > different addresses in the secondary process. > > > > Fix this by keeping track of all the mapped addresses from the primary > > process in the shared uio_res, and have second process map to the same > > addresses. > > > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > > > > Reported-by: Jonathan Erb > > Cc: stable@dpdk.org > > Signed-off-by: Long Li >=20 > You forgot this ack from v1: > Acked-by: Stephen Hemminger Sorry, my bad. Thank you! >=20 > Applied, thanks >=20