From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D9E8A0C43; Fri, 1 Oct 2021 01:19:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D26A04067A; Fri, 1 Oct 2021 01:19:39 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-oln040093003009.outbound.protection.outlook.com [40.93.3.9]) by mails.dpdk.org (Postfix) with ESMTP id 3100A40040 for ; Fri, 1 Oct 2021 01:19:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxz16wC5q3ZeNv/MBewwmS0SmYf2CM+LtvHMmgxqqJ+d5PI+tuxJSf8eMUCQVIB1UUgsGCpxAQlaJwcG9+M6BLSm5L4SdtFhh7NJHhBjKXe6nx9HX8ujRqxsDGDtRRSnhDu2OBGzY9JyiyZSlts6hqrrDfwRQSvvRZKl0loFxatQXHwJht/oEabLX3qz2shQN/N3o7qEYABh35lKpYWqo4t2bvZ3G5zNt+KSa2Lln+5gEBsDwgEaAAePpEG2n+fDKYavlxPE0T0ZkxJU1XVCGxICFUVg75MH21IxNcfH9JiM5bj3+UchQNuC0QNs8ITwutKjf1kg6MvzTNt4vbxjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=33rMdyZ2zGGY+XFyds1qPYiNnEa/1gS6x0KmHv/scKE=; b=VFG+P1M0pj1xnyzgsfnujWnoYrFGIKw9j4gefIz4n+9fG801tvEf+BPwtqraIw0b7ziHrRMn79Cj1etUlTAE+ISpTxaf+svf8ANIDd0tyevZUH6exQJMXfib+1ST8xCoLKkWEjgH71jMEdoygYpQLnVuHBKI6GmM9h2IpjDsaj6S2MWTtIhCHixJxIhGz1nMK98r9TiDLBGNANoChxNI15NFjarxNO1ICLY83XHSAZmbTzHqzKnuSSKJ0CcewxyMaq08ThuOYEJY7BflUo++uAA5bnW8+/oCJyxpURw4wPNSKvbxSxuevRGbkeJxrZ3TPUhN0SJEuHIIqn8dfITBLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=33rMdyZ2zGGY+XFyds1qPYiNnEa/1gS6x0KmHv/scKE=; b=B4EwuFW2mm7vvakVOwViRUBPvYuJAWklXnZDkzzGd/91Q++BPcXSK3O94DoaxBE4wXkFLuGKZEYMq8pFo5LrS106jnaJ0rWE5fnAf2xN18mmeW5W3tey13bFkbiUb2RhM8jUWKKTmfs7HXfFAM+eHamTe1pQbUcRClVll9xtFtk= Received: from BY5PR21MB1506.namprd21.prod.outlook.com (2603:10b6:a03:23d::12) by BYAPR21MB1190.namprd21.prod.outlook.com (2603:10b6:a03:105::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.3; Thu, 30 Sep 2021 23:19:35 +0000 Received: from BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::c5e9:9018:e64f:c330]) by BY5PR21MB1506.namprd21.prod.outlook.com ([fe80::c5e9:9018:e64f:c330%7]) with mapi id 15.20.4587.011; Thu, 30 Sep 2021 23:19:35 +0000 From: Long Li To: Srikanth Kaka , Stephen Hemminger CC: "dev@dpdk.org" , Vag Singh , Anand Thulasiram Thread-Topic: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels Thread-Index: AQHXs6WgHZmoFGKBK0iFsHzKX9ES96u9O6Xw Date: Thu, 30 Sep 2021 23:19:35 +0000 Message-ID: References: <20210927134231.11177-1-srikanth.k@oneconvergence.com> <20210927134231.11177-7-srikanth.k@oneconvergence.com> In-Reply-To: <20210927134231.11177-7-srikanth.k@oneconvergence.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=70720d87-ca89-493c-a071-773cf9b5bfc1; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-09-30T23:18:25Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20502ccd-cfa3-4bed-a8ed-08d98468c45a x-ms-traffictypediagnostic: BYAPR21MB1190: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wJS9kfCGcrSDzaVM8I8bQZvlttl4wYu1hL8RHTZj9eiKR58kvR/Y5OC7igEyt9kpLzYHEs0eUXWaWEmTLEMhX4OIg1a/5V5w0zEPN+gUOKMZmX3GZJy4zrtUe/ROkNfe6S5QvfwFHUCds42hXPiBJ72VR0ziWPIlcOd+MTvFuExwnKDbt8+Ya4Vwf55F4AILteXAjJJPLWTQhM9Rjf9motnvWI3cpF8QQr52ALfA/wdBajDbaIqZkOLNHo7HqbTHy1dJ5pMp5PjdGnGjPrQNhd5+hhHg5GfuACpoQmE+OAnPInM8zeQi+7ZekHQcQ+c++SsYWspdN77HByRd3ZCjFIkKXGIfk82GV3yfEeS5enwE7R6eAulvTpe/uWP2ILtC37VW31GQ11Bm1EuWdI2vsSp+MfWLK9OOQlBSd0H14dGwYR8tbJH03bYO6L/isoAEEgYfjThl8O2tTChJ9sX8vFtzgjBJ2aB8lfIX30i7NdAAftUCqrLquKNplQxVJYeZkKlOr1drRTYbYLLaNGoaDGHg/RyjMTRdDHv/5z6/d4Njmp+OKBnQEzXffGM+fIcMVZWGzn4dIMbcPmGLu4mkM+0ySe/aCp3YPD4CF3+FHHIziMlyRvvOZJJFqyRUj3hsAqqUlx7qXSsdU0Si3FEvCFx6WNDHcTvJEWtwmLpter/JfbrMkBARgBqU2mD/+mnmRIJ4gGA+mikjyNu9MR5+R7rzp5zajbazSswbDsXH46eTYUWMm9KrP2TmpzWPEKYm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR21MB1506.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(122000001)(66556008)(8676002)(83380400001)(5660300002)(26005)(82960400001)(82950400001)(6636002)(8936002)(38100700002)(6506007)(38070700005)(66476007)(66946007)(8990500004)(66446008)(7696005)(10290500003)(71200400001)(316002)(186003)(2906002)(55016002)(110136005)(33656002)(54906003)(52536014)(966005)(508600001)(64756008)(76116006)(9686003)(4326008)(10090945008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5hqlNKZ+D/Aq+GG1EnI9972VQoWT13yWvTV1XuQFtpOm8EZQv95QxFCNZpqY?= =?us-ascii?Q?AZb7Ujsz1pVnnBwFht8N1o64unND7/b6AFtzrhHD408CnGsn8FVAIO8D8/Z6?= =?us-ascii?Q?Yu0nWRhEvBCCjkc9Nz6OESpak2tyUivcJdabhuYslQ0puyaaKoIxYaUz1FDg?= =?us-ascii?Q?uGVLrcTTWs76P5LvuxTw3UHRm0/W/gxarrRmTswyP6u3eEoTX+1NUJBDq+vx?= =?us-ascii?Q?HwwTf5+9TWKcnITpuiP7jwkdiuq5o0Dt00h692erXubB6ElByPJxIPsZy0Gm?= =?us-ascii?Q?voumQAaOZm2zBOq9LP+gy1Q6N/TESalFd94ss6BG2Op7YCGmQ+CTeXPJ5wcN?= =?us-ascii?Q?KBU7GfMUMlHy8yBbdGatJ1SgK3cSk+bA7jZp9UBnORjB/8plb3SBNi7Zs9NQ?= =?us-ascii?Q?0rYqDFk1/9ikWnuC0ryF4sfNW84lCNKP8b5nje+jXPq0H9TJKLmHykqNPgWa?= =?us-ascii?Q?QaBYvQl28DWcBp0FPnlCLHv6GE4yiTabzfuxayWNLtCOEjNOihdepYXwTgyt?= =?us-ascii?Q?nMYFYtKoO8lHJFg49xx/JYSiNWXbAoyA/a+UMVN4lfnWXMW5SRvYxhSbrsa/?= =?us-ascii?Q?cZJH4eE0JAYu5K+IwRf05mK71i3FClWid0ZOD9hYwjvZopCbeNhE6WUNzsJ4?= =?us-ascii?Q?49ObBK6RdSWYlcmCfqPdzQmp7r4LWF38jz9yrdLWnD8ETuZD0wk82B9g57vG?= =?us-ascii?Q?D8MJtQC0ztNM67wGh9Z3Bx4NQhsVZBmE6tfCdf+PxlrDlZUwZNpuSGmARZiw?= =?us-ascii?Q?/WMPd/qjHp42QzJY1VhbNch7f+4NaozGEoJXbH+RkcJqO3pmkVKDK2Xediyz?= =?us-ascii?Q?OlFt8+KXTjg3zLrudtS+VFB4p9PSvDtC+Tva+A719qfoP8Pv6WFbnXNxbuky?= =?us-ascii?Q?Jqlu0hJzL8LOQyvMk08tfJH4mMXKbJiYM5vvztnTZ7edsbq+pnFhV2RExOpZ?= =?us-ascii?Q?w6n/MvkYR16i6k9TJaWZiEBWfWllNl/niXCJzxvoDA67MxThVoa71ccWOCAX?= =?us-ascii?Q?bCEKbGKHuFjUclQyBkoM0oWIXOWjTsy+LGXJCo5wUyDMA9AF2/YWzFKulxY5?= =?us-ascii?Q?eN1PQMMrdKEwduycXWZSDQQSAhjN/LwTYtPEEMdsIRKoZ9FtI8XHYzSeDreO?= =?us-ascii?Q?f/l/8xBykDcxpTB/C+/JF+DafjrIUa75rZXMpj95xz4Alb45AxBmokSuB8S8?= =?us-ascii?Q?xhlg+6gL9Lodx+m5fCRqc9Bbg2SFhXNSKZ2waHSqqTBG7+XR36vKQg/fbpL6?= =?us-ascii?Q?7UfgJbuN4C75aQssuCiLaMhPzqud50PxfyAJ0QbHWBs65eMGsrDNf8M5jxso?= =?us-ascii?Q?wTxA8QSSV9tWfAT0mOqOdT3C?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR21MB1506.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20502ccd-cfa3-4bed-a8ed-08d98468c45a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 23:19:35.3953 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iuMSYb3c2qMHGNoou+vPEesnSJdGUQgsGdT2IH8Ct8AzCNm6xnOYHWp3Bol155f6UNoXqn/SzORge5nLktZHnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR21MB1190 Subject: Re: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels >=20 > [You don't often get email from srikanth.k@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] >=20 > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel > driver receives the request and opens the subchannels on PMDs behalf. >=20 > Signed-off-by: Srikanth Kaka > Signed-off-by: Vag Singh > Signed-off-by: Anand Thulasiram > --- > drivers/net/netvsc/hn_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/netvsc/hn_ethdev.c > b/drivers/net/netvsc/hn_ethdev.c index 9e2a405973..6f9053c4d5 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -515,6 +515,10 @@ static int hn_subchan_configure(struct hn_data *hv, > if (err) > return err; >=20 > + err =3D rte_vmbus_ioctl(hv->vmbus, subchan); > + if (err) > + return err; > + Now I see why you return 0 for Linux. Can you add a comment to say this fun= ction is not used and should always succeed in Linux? > while (subchan > 0) { > struct vmbus_channel *new_sc; > uint16_t chn_index; > -- > 2.30.2