From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-eopbgr740043.outbound.protection.outlook.com [40.107.74.43]) by dpdk.org (Postfix) with ESMTP id 652A949E0 for ; Thu, 8 Nov 2018 23:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hnOzMU1oIdjp/DUAkP5J1Cxr8vPuAeOTGGuHHcf8YE=; b=RK55vJUsL1AzsyqnDnkx0swVWh90pMRbuzYBDRGPlOtwLCKQ2FuHVS8pEYPr5qQbF90Xs41IXWGSp2tx29YNbsdUoYj/9Qk6SsnAQ+4cq3vmAIbs8rfpPjg7ih4byy9N2fb6pNCknuQLRzYwSaeB2MDOEsq/ic3CQUhyu9Fbwvg= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB5702.namprd07.prod.outlook.com (20.178.0.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.20; Thu, 8 Nov 2018 22:57:37 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::4012:e217:427e:320b]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::4012:e217:427e:320b%3]) with mapi id 15.20.1294.034; Thu, 8 Nov 2018 22:57:37 +0000 From: "Mody, Rasesh" To: Stephen Hemminger CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Dept-Eng DPDK Dev Thread-Topic: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log Thread-Index: AQHUd6i6XRY7Uow45kKutvMPXQ+446VGZ4QAgAAI1/A= Date: Thu, 8 Nov 2018 22:57:37 +0000 Message-ID: References: <1541711947-3714-1-git-send-email-rasesh.mody@cavium.com> <20181108133842.63548c39@shemminger-XPS-13-9360> In-Reply-To: <20181108133842.63548c39@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8081:2d00:67:8392:87b7:3b9f] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5702; 6:jcvyFnj3gpbUFAzIWg06ezntdpNbDNm09bzIAPqtIoBsmCZ99gVvBbAGjU8TMzAummbSwXYWKDw2XsOlqc8WioDC+bdLXgUL9qRwar2x1DSoSTolrpVbrpA81XBOHdWsBVPFvnQ+G53knYnCQDgjD06bs/3xKJBWTrUbevBPRY3ANlF2bbtqc6Fova+OooV7hdX6eHe1yosKwwZmTNRXGBfoCzOapsS2M1G6jyp1LADTw0Zd2xzyg33v15+QE4E8YaEy/E6MeaV1iaz1Zj1uoEVSmhI8BIi8Nt1mOMCKTDo1GuOiTq34zQO0cl1VabO59wchV2wHlyoA4wwA8CYGB40k6w8QdD3XbUcXCrUokg4xV8MRhhumKCVCpeYnEAn+F9AAuwLxcxRj3lj6BNSRypfXgN/eCt3qcNm9QzS7DIT5lIffXTcv/AQG4OCAboc884OZr71ddwAzfabVNWoy7A==; 5:dMtPJIvo5dWl1XgebeBB8MnTimH2gpgGHWwvh7aPZV6atQimzcfVgbdCx+dZTqBDFvFGecPEMmSyZ0sMuATJ+uaXp7F5SDCkQQB5t9rKTU9+t8pW3pBx1G4ZlZ0HP0iqXIN+4f7cD/peAB7W6eUZlzB05bRLWAhEd4q6ptaLSGM=; 7:j6NOl162Rg6f7Hggxk5uItj7T5BTrf7fA8xFiGr4WNvihu4GGABYngRFEWyyKuiLj2eHc4XazmlgUMZXecg1+tJZadx8emgCsOWRGZzhUCEbq84XiWGYVrfzVQxoq8JS8DtZG4anTBLAY1Jw3mIFzw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 588b70b4-e449-4d76-ed69-08d645cd943f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5702; x-ms-traffictypediagnostic: BYAPR07MB5702: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302103)(3231382)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5702; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5702; x-forefront-prvs: 0850800A29 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39860400002)(376002)(346002)(136003)(199004)(189003)(7736002)(2900100001)(316002)(14454004)(256004)(54906003)(6436002)(6506007)(5660300001)(9686003)(55016002)(97736004)(6116002)(6246003)(86362001)(11346002)(478600001)(2906002)(186003)(53936002)(99286004)(107886003)(33656002)(8676002)(81166006)(76176011)(8936002)(102836004)(25786009)(4326008)(81156014)(68736007)(72206003)(74316002)(46003)(476003)(229853002)(105586002)(446003)(486006)(6916009)(7696005)(71190400001)(106356001)(71200400001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5702; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: oOQdss3FHe9TE/VEH0t5i1gzedodrkusJhrUgBue+nvPNqP9sYpR6glqudnlpQW+umYsjYsqFMrSM0eYBeVb3IysRycmTC+w1M6eAoi0HEz+afI75kfWxnZY8ufXYjosYSsmPyD4pPPpxDXB/QTvhMUaYCH+7IPnwX6HZtG1SJwPcMdf0ui6YiAfFMFBB+kFCFuXXN0mZO52N5JzfWoiprPZD9NRdI9tfdcrO/eL7F0ZAKzaXpp6fJAJlhnUbOldpY1KRnBeMrlXoq/v+uAiwy30tZQeaceVGuOmCWwN1+3hNCORrir9yeMM9tonWQfjLHWJLql4Rg8MK13XtWf62M9Fvans+P59/73WTiI64P4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 588b70b4-e449-4d76-ed69-08d645cd943f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2018 22:57:37.6252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5702 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 22:57:39 -0000 >From: Stephen Hemminger >Sent: Thursday, November 08, 2018 1:39 PM > >On Thu, 8 Nov 2018 21:19:26 +0000 >"Mody, Rasesh" wrote: > >> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange >> dynamic log types to the top and configurable log types to bottom. >> Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE >> >> Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") >> >> Signed-off-by: Rasesh Mody > > >Looks good to me. > >You might also want to address the excessive number of INFO messages in >bnx2x.c. There are things like debug messages at INFO level, extra new lin= es >and banner bars. I'll send follow up patch addressing above. Thanks! -Rasesh > >Acked-by: Stephen Hemminger