DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Timothy Redaelli <tredaelli@redhat.com>,
	"Patil, Harish" <Harish.Patil@cavium.com>,
	"Shaikh, Shahed" <Shahed.Shaikh@cavium.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/qede: fix crash when configure fails
Date: Sat, 10 Nov 2018 00:39:05 +0000	[thread overview]
Message-ID: <BYAPR07MB5365E3DDF8BDADE9EF8339BD9FC70@BYAPR07MB5365.namprd07.prod.outlook.com> (raw)
In-Reply-To: <37a7ac2b3c1522fd72e86bf11660f6c65880a8d6.1541777958.git.tredaelli@redhat.com>

>From: Timothy Redaelli <tredaelli@redhat.com>
>Sent: Friday, November 09, 2018 7:46 AM
>
>Currently, if configuration fails (for example if a 100G card is used with an odd
>number of RX/TX queues) QEDE crashes due to a null pointer dereference.
>
>This commit fixes it by checking that the pointer is not NULL before using it.
>
>Fixes: 7105b24f4bb8 ("net/qede: fix memory alloc for multiple port reconfig")
>Cc: stable@dpdk.org
>
>Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>

Fix looks good to me.

Acked-by: Rasesh Mody <rasesh.mody@cavium.com>

Thanks!
-Rasesh

  reply	other threads:[~2018-11-10  0:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 15:45 Timothy Redaelli
2018-11-10  0:39 ` Mody, Rasesh [this message]
2018-11-12 12:09   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR07MB5365E3DDF8BDADE9EF8339BD9FC70@BYAPR07MB5365.namprd07.prod.outlook.com \
    --to=rasesh.mody@cavium.com \
    --cc=Harish.Patil@cavium.com \
    --cc=Shahed.Shaikh@cavium.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).