From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-BY2-obe.outbound.protection.outlook.com (mail-eopbgr710049.outbound.protection.outlook.com [40.107.71.49]) by dpdk.org (Postfix) with ESMTP id 2180528FD; Sat, 10 Nov 2018 01:39:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEPo+A+6Qbb+p+gop2+dPoK4jQV4RIO3pKvpQDQKRnI=; b=UpwJTqTelyLVk4dQG9+VuPMasJ3I5i0Xm/8v55UMwCE7kZ9WGJjCAcRTLhR1aorC3PVLcdqOjBT00LPLzZl45q9R83UDazW0LbWiD3OQ8yExnphc5T2pRx/yH1pRl/bcZSZUIOCXZBiQpwgdaO4vClVcyhwV592dyvhxVaLZ8h8= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB4840.namprd07.prod.outlook.com (52.135.204.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Sat, 10 Nov 2018 00:39:07 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::4012:e217:427e:320b]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::4012:e217:427e:320b%3]) with mapi id 15.20.1294.034; Sat, 10 Nov 2018 00:39:06 +0000 From: "Mody, Rasesh" To: Timothy Redaelli , "Patil, Harish" , "Shaikh, Shahed" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/qede: fix crash when configure fails Thread-Index: AQHUeENL9pwS2TF6NEus4OIX3nbFkKVII2gg Date: Sat, 10 Nov 2018 00:39:05 +0000 Message-ID: References: <37a7ac2b3c1522fd72e86bf11660f6c65880a8d6.1541777958.git.tredaelli@redhat.com> In-Reply-To: <37a7ac2b3c1522fd72e86bf11660f6c65880a8d6.1541777958.git.tredaelli@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [198.186.1.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4840; 6:LNvN9wjBz037lSvGJDihRqNXXN1TmipiCDUJzGWc5Q2gxLF6tzGioy/uvkGfvJ07h4ttkFPqbk0HaExc6POyauInVxKzHSe6h39Yb6zRd5dgRCqbT9pzv0RRb1Ukg0YRKUyMAYzGugOdL15MHwvWKVnkcW6S3uK0QzByJtsTzGaCLzZd/3LCXAuhbwPIv2dDffZ0Rh6SGWM3QFvtcEVzq2irFUVdsFdxbBkSqX8LJGI9K7yDP90FKpG64Ae6wk+tC8W1AtF7a+g0O4UYR9PVO04NE6yDVvd1R+Vd2dfn561O7lMfCwhioeEiisixBSBSbPvqyrGXh4UrenDmmXz2KpXh8RK/HnK8dDbnvfTsl5HBcNdX0+WBc12bx8255jC2XPIpkQ2r31cFaQvEzbXLszT1EQUn33a+V8fite47P19390IqyU/Xtdi9dCMnLkztKVtqrudGGezPs2AtkuI7ng==; 5:vugCdmn4TM+0iX5H3XgrmbypCspPeb0/8aqUu2+IRj0NStyHMbceEFISOTC8KppWY6voYDlrUoGEQc5cQgdyOEf95U5G/h4XhNxxR81PTq3ZkoOpnjSs01pHn0mvQ2G+MYo6lLmh8yI4QmhaZevUwXGH4yiC/lVZLurx08pSAgg=; 7:C1OCoxXOLTAEqz2l7t5qpyr441feO3VXQazebGmOTGDUlZbEBgXyeXZD+FOeXBTab/KMkZeXlJMMQNSoMzYkJCx4R3dmtreOeNiqRDLVnXA25tsq4jSsaHT15jM585VSAuX/f55lbtOO9bLJePm93g== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(136003)(39860400002)(376002)(346002)(396003)(366004)(189003)(199004)(14454004)(186003)(2906002)(229853002)(54906003)(110136005)(74316002)(256004)(486006)(305945005)(7736002)(68736007)(8676002)(8936002)(6636002)(81156014)(81166006)(316002)(3846002)(6116002)(6436002)(99286004)(5660300001)(55016002)(33656002)(53936002)(478600001)(26005)(4326008)(102836004)(66066001)(6506007)(25786009)(6246003)(11346002)(446003)(476003)(105586002)(106356001)(97736004)(86362001)(76176011)(9686003)(2900100001)(7696005)(72206003)(71200400001)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4840; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: bf271ed7-5697-4fcd-d64b-08d646a4ebbe x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4840; x-ms-traffictypediagnostic: BYAPR07MB4840: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231382)(944501410)(52105095)(3002001)(10201501046)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB4840; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4840; x-forefront-prvs: 0852EB6797 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NaGVXfKaPLXZc77iRSgC5bjP+fymVnlfcelSMkhBywXw+xvvndWfziUitObfEHHmGZoXOVl1GadFWxERrAOU5yuqBldjxRiL2JU8RInPh1bcRQiR2oYomfSLTZfyDruFOXZ7AiwvJl5IhFDGpYIMtivjSG/OVCUfOX0K/3YmMn+SIVTbs8xLpnKLFNsVvFNSg0roer6wTP+LfILQtbybiUwF96jV53wZG1UPnzjsUlbgVWhaa8SHYrRtj+V0iumGSGPgeHgwqR/lWYKb6HltAnPu+QtdqGRHUOC7GqfvR+kPMH9YfHasfCaEMR0WU68haXgDhakeK88ZfYvPi5Q0FSEVbuSFSipOMrI0cJ8V+GQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf271ed7-5697-4fcd-d64b-08d646a4ebbe X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2018 00:39:06.1666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4840 Subject: Re: [dpdk-dev] [PATCH] net/qede: fix crash when configure fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 00:39:09 -0000 >From: Timothy Redaelli >Sent: Friday, November 09, 2018 7:46 AM > >Currently, if configuration fails (for example if a 100G card is used with= an odd >number of RX/TX queues) QEDE crashes due to a null pointer dereference. > >This commit fixes it by checking that the pointer is not NULL before using= it. > >Fixes: 7105b24f4bb8 ("net/qede: fix memory alloc for multiple port reconfi= g") >Cc: stable@dpdk.org > >Signed-off-by: Timothy Redaelli Fix looks good to me. Acked-by: Rasesh Mody Thanks! -Rasesh